)]}'
{"etc/neutron/plugins/cisco/cisco_plugins.ini":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1b6785f95c0a84072e73de5b39b2ac7a5ded1ce","unresolved":false,"context_lines":[{"line_number":137,"context_line":"# policy profiles."},{"line_number":138,"context_line":"# Default value: False, indicating all tenants can access all policy profiles."},{"line_number":139,"context_line":"#"},{"line_number":140,"context_line":"# restrict_policy_profiles \u003d"},{"line_number":141,"context_line":"# Example: restrict_policy_profiles \u003d False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# (IntOpt) Number of threads to use to make HTTP requests to the VSM."}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ac7a964_bd2c274c","line":140,"updated":"2014-08-14 13:38:16.000000000","message":"nit: restrict_policy_profile_visibility?","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"b2a34820c83e5b13553649a01bbd5fac7cfd2c08","unresolved":false,"context_lines":[{"line_number":137,"context_line":"# policy profiles."},{"line_number":138,"context_line":"# Default value: False, indicating all tenants can access all policy profiles."},{"line_number":139,"context_line":"#"},{"line_number":140,"context_line":"# restrict_policy_profiles \u003d"},{"line_number":141,"context_line":"# Example: restrict_policy_profiles \u003d False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# (IntOpt) Number of threads to use to make HTTP requests to the VSM."}],"source_content_type":"text/x-properties","patch_set":3,"id":"7ac7a964_3054b153","line":140,"in_reply_to":"7ac7a964_bd2c274c","updated":"2014-08-14 18:22:38.000000000","message":"Hi Paul,\n\nThanks for the comment. I\u0027d argue that even though technically we are only restricting the visibility, tenants won\u0027t be able to use profiles they can\u0027t see. So effectively we are restricting the policy profiles completely, not just the visibility.","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"114cd79125b2c339f5c229eb646f3e754e4cf56d","unresolved":false,"context_lines":[{"line_number":138,"context_line":"# Default value: False, indicating all tenants can access all policy profiles."},{"line_number":139,"context_line":"#"},{"line_number":140,"context_line":"# restrict_policy_profiles \u003d"},{"line_number":141,"context_line":"# Example: restrict_policy_profiles \u003d False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# (IntOpt) Number of threads to use to make HTTP requests to the VSM."},{"line_number":144,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1abeadc6_a1db071a","line":141,"updated":"2014-08-19 05:14:33.000000000","message":"i believe L41 is redundant, in L40 just say\n\n  restrict_policy_profiles \u003d False","commit_id":"45368ed5a3cfb4f310df4a44e2ce201b0fbc8e79"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"fa94aebc843798b0c5bdaf1ed801e33f1c029d19","unresolved":false,"context_lines":[{"line_number":138,"context_line":"# Default value: False, indicating all tenants can access all policy profiles."},{"line_number":139,"context_line":"#"},{"line_number":140,"context_line":"# restrict_policy_profiles \u003d"},{"line_number":141,"context_line":"# Example: restrict_policy_profiles \u003d False"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"# (IntOpt) Number of threads to use to make HTTP requests to the VSM."},{"line_number":144,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":4,"id":"1abeadc6_793a5b37","line":141,"in_reply_to":"1abeadc6_a1db071a","updated":"2014-08-19 21:17:26.000000000","message":"Done","commit_id":"45368ed5a3cfb4f310df4a44e2ce201b0fbc8e79"}],"neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74bace179b630be6750a27bba8497b828aa73e64","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        policy profile extension manager."},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        super(TestN1kvPolicyProfiles, self).setUp("},{"line_number":711,"context_line":"                    ext_mgr \u003d PolicyProfileTestExtensionManager())"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    def test_populate_policy_profile(self):"},{"line_number":714,"context_line":"        client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2399866d","line":711,"updated":"2014-08-08 02:38:57.000000000","message":"No spaces around \u0027\u003d\u0027","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"47df65dc5faf54a5758ad115124c7ed815782b0e","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        policy profile extension manager."},{"line_number":709,"context_line":"        \"\"\""},{"line_number":710,"context_line":"        super(TestN1kvPolicyProfiles, self).setUp("},{"line_number":711,"context_line":"                    ext_mgr \u003d PolicyProfileTestExtensionManager())"},{"line_number":712,"context_line":""},{"line_number":713,"context_line":"    def test_populate_policy_profile(self):"},{"line_number":714,"context_line":"        client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_4fad9f31","line":711,"in_reply_to":"baada198_2399866d","updated":"2014-08-08 19:21:31.000000000","message":"Done","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74bace179b630be6750a27bba8497b828aa73e64","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        # Get the profiles"},{"line_number":767,"context_line":"        client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","},{"line_number":768,"context_line":"                                  new\u003dfake_client.TestClient)"},{"line_number":769,"context_line":"        client_patch.start()"},{"line_number":770,"context_line":"        instance \u003d n1kv_neutron_plugin.N1kvNeutronPluginV2()"},{"line_number":771,"context_line":"        instance._populate_policy_profiles()"},{"line_number":772,"context_line":"        db_session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_4847791e","line":769,"updated":"2014-08-08 02:38:57.000000000","message":"Instead of lines 767-769 you can just do:\n\n        mock.patch.object(n1kv_client, \"Client\",\n                          new\u003dfake_client.TestClient).start()","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"47df65dc5faf54a5758ad115124c7ed815782b0e","unresolved":false,"context_lines":[{"line_number":766,"context_line":"        # Get the profiles"},{"line_number":767,"context_line":"        client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","},{"line_number":768,"context_line":"                                  new\u003dfake_client.TestClient)"},{"line_number":769,"context_line":"        client_patch.start()"},{"line_number":770,"context_line":"        instance \u003d n1kv_neutron_plugin.N1kvNeutronPluginV2()"},{"line_number":771,"context_line":"        instance._populate_policy_profiles()"},{"line_number":772,"context_line":"        db_session \u003d db.get_session()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6faa631b","line":769,"in_reply_to":"baada198_4847791e","updated":"2014-08-08 19:21:31.000000000","message":"Done","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74bace179b630be6750a27bba8497b828aa73e64","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        profiles.append(n1kv_db_v2.get_policy_profile("},{"line_number":776,"context_line":"            db_session, \u002700000000-0000-0000-0000-000000000001\u0027))"},{"line_number":777,"context_line":"        profiles.append(n1kv_db_v2.get_policy_profile("},{"line_number":778,"context_line":"            db_session, \u002700000000-0000-0000-0000-000000000002\u0027))"},{"line_number":779,"context_line":"        # Set the restriction flag"},{"line_number":780,"context_line":"        c_conf.CISCO_N1K.restrict_policy_profiles \u003d False"},{"line_number":781,"context_line":"        # Request the list using non-admin and verify it returns"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e38eae25","line":778,"updated":"2014-08-08 02:38:57.000000000","message":"No need to use append to create this list. Just initialize the whole thing like:\n\n    profiles \u003d [\n        f(1),\n        f(2)\n    ]","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"47df65dc5faf54a5758ad115124c7ed815782b0e","unresolved":false,"context_lines":[{"line_number":775,"context_line":"        profiles.append(n1kv_db_v2.get_policy_profile("},{"line_number":776,"context_line":"            db_session, \u002700000000-0000-0000-0000-000000000001\u0027))"},{"line_number":777,"context_line":"        profiles.append(n1kv_db_v2.get_policy_profile("},{"line_number":778,"context_line":"            db_session, \u002700000000-0000-0000-0000-000000000002\u0027))"},{"line_number":779,"context_line":"        # Set the restriction flag"},{"line_number":780,"context_line":"        c_conf.CISCO_N1K.restrict_policy_profiles \u003d False"},{"line_number":781,"context_line":"        # Request the list using non-admin and verify it returns"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_8fa33743","line":778,"in_reply_to":"baada198_e38eae25","updated":"2014-08-08 19:21:31.000000000","message":"Done","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74bace179b630be6750a27bba8497b828aa73e64","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        for i in range(0, len(res[resource])):"},{"line_number":797,"context_line":"            self.assertEqual(profiles[i].id, res[resource][i][\u0027id\u0027])"},{"line_number":798,"context_line":"            self.assertEqual(profiles[i].name, res[resource][i][\u0027name\u0027])"},{"line_number":799,"context_line":"        client_patch.stop()"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def test_get_profiles_restricted(self):"},{"line_number":802,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_68427d0e","line":799,"updated":"2014-08-08 02:38:57.000000000","message":"Not needed. The BaseTestCase class stops all object patches on tear down.","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"47df65dc5faf54a5758ad115124c7ed815782b0e","unresolved":false,"context_lines":[{"line_number":796,"context_line":"        for i in range(0, len(res[resource])):"},{"line_number":797,"context_line":"            self.assertEqual(profiles[i].id, res[resource][i][\u0027id\u0027])"},{"line_number":798,"context_line":"            self.assertEqual(profiles[i].name, res[resource][i][\u0027name\u0027])"},{"line_number":799,"context_line":"        client_patch.stop()"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def test_get_profiles_restricted(self):"},{"line_number":802,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_afa0fb36","line":799,"in_reply_to":"baada198_68427d0e","updated":"2014-08-08 19:21:31.000000000","message":"Done","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74bace179b630be6750a27bba8497b828aa73e64","unresolved":false,"context_lines":[{"line_number":798,"context_line":"            self.assertEqual(profiles[i].name, res[resource][i][\u0027name\u0027])"},{"line_number":799,"context_line":"        client_patch.stop()"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def test_get_profiles_restricted(self):"},{"line_number":802,"context_line":"        \"\"\""},{"line_number":803,"context_line":"        Test getting policy profiles using the restricted behavior."},{"line_number":804,"context_line":"        We set the flag and attempt to retrieve the port profiles. It"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_03fba27b","line":801,"updated":"2014-08-08 02:38:57.000000000","message":"A lot of the code in this test case is common to the previous one. Consider creating a helper function to improve code re-use.","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"47df65dc5faf54a5758ad115124c7ed815782b0e","unresolved":false,"context_lines":[{"line_number":798,"context_line":"            self.assertEqual(profiles[i].name, res[resource][i][\u0027name\u0027])"},{"line_number":799,"context_line":"        client_patch.stop()"},{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def test_get_profiles_restricted(self):"},{"line_number":802,"context_line":"        \"\"\""},{"line_number":803,"context_line":"        Test getting policy profiles using the restricted behavior."},{"line_number":804,"context_line":"        We set the flag and attempt to retrieve the port profiles. It"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0f672725","line":801,"in_reply_to":"baada198_03fba27b","updated":"2014-08-08 19:21:31.000000000","message":"Done","commit_id":"abdcd6d2e15e22fe3b84a712cb74c0f50373b1f6"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b930a7505bd4b319d884b6e15e826df21467036f","unresolved":false,"context_lines":[{"line_number":770,"context_line":"            n1kv_db_v2.get_policy_profile("},{"line_number":771,"context_line":"                    db_session, \u002700000000-0000-0000-0000-000000000002\u0027)"},{"line_number":772,"context_line":"        ]"},{"line_number":773,"context_line":"        return profiles"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def _test_get_policy_profiles(self, expected_profiles, admin):"},{"line_number":776,"context_line":"        resource \u003d \u0027policy_profiles\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_412f33f5","line":773,"updated":"2014-08-08 20:49:53.000000000","message":"Nit: You don\u0027t really need the profiles variable, you can just return the list directly.","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"1dcacf843ef1e01049479ca6cb89574a2a56315e","unresolved":false,"context_lines":[{"line_number":770,"context_line":"            n1kv_db_v2.get_policy_profile("},{"line_number":771,"context_line":"                    db_session, \u002700000000-0000-0000-0000-000000000002\u0027)"},{"line_number":772,"context_line":"        ]"},{"line_number":773,"context_line":"        return profiles"},{"line_number":774,"context_line":""},{"line_number":775,"context_line":"    def _test_get_policy_profiles(self, expected_profiles, admin):"},{"line_number":776,"context_line":"        resource \u003d \u0027policy_profiles\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_1a34c0f9","line":773,"in_reply_to":"baada198_412f33f5","updated":"2014-08-08 21:31:31.000000000","message":"Done","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b930a7505bd4b319d884b6e15e826df21467036f","unresolved":false,"context_lines":[{"line_number":784,"context_line":"                                  is_admin\u003dFalse)"},{"line_number":785,"context_line":"        res \u003d self._list(resource, neutron_context\u003dctx)"},{"line_number":786,"context_line":"        self.assertEqual(len(expected_profiles), len(res[resource]))"},{"line_number":787,"context_line":"        for i in range(0, len(res[resource])):"},{"line_number":788,"context_line":"            self.assertEqual(expected_profiles[i].id,"},{"line_number":789,"context_line":"                             res[resource][i][\u0027id\u0027])"},{"line_number":790,"context_line":"            self.assertEqual(expected_profiles[i].name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_373b5d9c","line":787,"updated":"2014-08-08 20:49:53.000000000","message":"Nit: if the range starts at 0 you don\u0027t have to specify it.","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"1dcacf843ef1e01049479ca6cb89574a2a56315e","unresolved":false,"context_lines":[{"line_number":784,"context_line":"                                  is_admin\u003dFalse)"},{"line_number":785,"context_line":"        res \u003d self._list(resource, neutron_context\u003dctx)"},{"line_number":786,"context_line":"        self.assertEqual(len(expected_profiles), len(res[resource]))"},{"line_number":787,"context_line":"        for i in range(0, len(res[resource])):"},{"line_number":788,"context_line":"            self.assertEqual(expected_profiles[i].id,"},{"line_number":789,"context_line":"                             res[resource][i][\u0027id\u0027])"},{"line_number":790,"context_line":"            self.assertEqual(expected_profiles[i].name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_7a221cbb","line":787,"in_reply_to":"baada198_373b5d9c","updated":"2014-08-08 21:31:31.000000000","message":"Done","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"b930a7505bd4b319d884b6e15e826df21467036f","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            self.assertEqual(expected_profiles[i].id,"},{"line_number":789,"context_line":"                             res[resource][i][\u0027id\u0027])"},{"line_number":790,"context_line":"            self.assertEqual(expected_profiles[i].name,"},{"line_number":791,"context_line":"                             res[resource][i][\u0027name\u0027])"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def test_get_profiles_unrestricted(self):"},{"line_number":794,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b7984d77","line":791,"updated":"2014-08-08 20:49:53.000000000","message":"It looks like res[\u0027policy_profiles\u0027] is a list of dictionaries deserialized from a json response. This list can be in any order. Check out this etherpad[1] and try testing with hashseed 1654147778 to see what I mean. The solution here seems to be to sort res[resource] before entering the for loop.\n\n[1] https://etherpad.openstack.org/p/neutron-random-hashseed","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"1dcacf843ef1e01049479ca6cb89574a2a56315e","unresolved":false,"context_lines":[{"line_number":788,"context_line":"            self.assertEqual(expected_profiles[i].id,"},{"line_number":789,"context_line":"                             res[resource][i][\u0027id\u0027])"},{"line_number":790,"context_line":"            self.assertEqual(expected_profiles[i].name,"},{"line_number":791,"context_line":"                             res[resource][i][\u0027name\u0027])"},{"line_number":792,"context_line":""},{"line_number":793,"context_line":"    def test_get_profiles_unrestricted(self):"},{"line_number":794,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_fa154c4c","line":791,"in_reply_to":"baada198_b7984d77","updated":"2014-08-08 21:31:31.000000000","message":"Done","commit_id":"1b42defdc8d8af7cec35994dcbd19d259ba5ab11"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1b6785f95c0a84072e73de5b39b2ac7a5ded1ce","unresolved":false,"context_lines":[{"line_number":703,"context_line":"class TestN1kvPolicyProfiles(N1kvPluginTestCase):"},{"line_number":704,"context_line":"    def setUp(self):"},{"line_number":705,"context_line":"        \"\"\""},{"line_number":706,"context_line":"        We need to use the policy profile extension manager for these"},{"line_number":707,"context_line":"        test cases, so call the super class setup, but pass in the"},{"line_number":708,"context_line":"        policy profile extension manager."},{"line_number":709,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_dd656346","line":706,"updated":"2014-08-14 13:38:16.000000000","message":"Nit: PEP257 multiline docstrings should have a summary line, period, blank line, and then rest of docstring.\n\nSame for others in this file.","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"b2a34820c83e5b13553649a01bbd5fac7cfd2c08","unresolved":false,"context_lines":[{"line_number":703,"context_line":"class TestN1kvPolicyProfiles(N1kvPluginTestCase):"},{"line_number":704,"context_line":"    def setUp(self):"},{"line_number":705,"context_line":"        \"\"\""},{"line_number":706,"context_line":"        We need to use the policy profile extension manager for these"},{"line_number":707,"context_line":"        test cases, so call the super class setup, but pass in the"},{"line_number":708,"context_line":"        policy profile extension manager."},{"line_number":709,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_d5a60fc1","line":706,"in_reply_to":"7ac7a964_dd656346","updated":"2014-08-14 18:22:38.000000000","message":"Done","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c1b6785f95c0a84072e73de5b39b2ac7a5ded1ce","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        # Get the profiles"},{"line_number":800,"context_line":"        profiles \u003d self._init_get_policy_profiles()"},{"line_number":801,"context_line":"        # Set the restriction flag"},{"line_number":802,"context_line":"        c_conf.CISCO_N1K.restrict_policy_profiles \u003d False"},{"line_number":803,"context_line":"        # Request the list using non-admin and verify it returns"},{"line_number":804,"context_line":"        self._test_get_policy_profiles(expected_profiles\u003dprofiles, admin\u003dFalse)"},{"line_number":805,"context_line":"        # Request the list using admin and verify it returns"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_9df92b50","line":802,"updated":"2014-08-14 13:38:16.000000000","message":"I haven\u0027t really tried this, but is there any side effect of altering the config, versus using cfg.CONF.set_override(), which restores after the test?\n\nSame on L817.","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"},{"author":{"_account_id":11757,"name":"Steven Hillman","email":"sthillma@cisco.com","username":"sthillma"},"change_message_id":"b2a34820c83e5b13553649a01bbd5fac7cfd2c08","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        # Get the profiles"},{"line_number":800,"context_line":"        profiles \u003d self._init_get_policy_profiles()"},{"line_number":801,"context_line":"        # Set the restriction flag"},{"line_number":802,"context_line":"        c_conf.CISCO_N1K.restrict_policy_profiles \u003d False"},{"line_number":803,"context_line":"        # Request the list using non-admin and verify it returns"},{"line_number":804,"context_line":"        self._test_get_policy_profiles(expected_profiles\u003dprofiles, admin\u003dFalse)"},{"line_number":805,"context_line":"        # Request the list using admin and verify it returns"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac7a964_b59513e6","line":802,"in_reply_to":"7ac7a964_9df92b50","updated":"2014-08-14 18:22:38.000000000","message":"Not sure, but its a fair point- changed them to use set_override().","commit_id":"9b14ffe2badf628911b021c21fc549a5bc9cf96f"}]}