)]}'
{"neutron/hacking/checks.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3ab8d2d0be4d3286a9c35639ab9e87dcab60d03a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def use_jsonutils(logical_line, filename):"},{"line_number":50,"context_line":"    msg \u003d \"N321: jsonutils.%(fun)s must be used instead of json.%(fun)s\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if \"neutron/plugins/openvswitch/agent/xenapi\" in filename:"},{"line_number":53,"context_line":"        return"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    json_funcs \u003d [\u0027dumps\u0027, \u0027dump\u0027, \u0027loads\u0027, \u0027load\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0823c158","line":52,"updated":"2014-08-08 01:27:54.000000000","message":"Can you add a comment to explain this special case?\n\nIt seems that the specific file affected is \"neutron/plugins/openvswitch/agent/xenapi/etc/xapi.d/plugins/netwrap\"? Wouldn\u0027t it be better to specify the full path? In case someone adds some real neutron source files somewhere else under xenapi/...","commit_id":"94119362cc47886870f654a44199479e5c906f03"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9b364c5e8ee07789435226cb38d0c7953428eb3d","unresolved":false,"context_lines":[{"line_number":49,"context_line":"def use_jsonutils(logical_line, filename):"},{"line_number":50,"context_line":"    msg \u003d \"N321: jsonutils.%(fun)s must be used instead of json.%(fun)s\""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    if \"neutron/plugins/openvswitch/agent/xenapi\" in filename:"},{"line_number":53,"context_line":"        return"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    json_funcs \u003d [\u0027dumps\u0027, \u0027dump\u0027, \u0027loads\u0027, \u0027load\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_cf629e3c","line":52,"in_reply_to":"baada198_0823c158","updated":"2014-08-08 12:51:56.000000000","message":"Done","commit_id":"94119362cc47886870f654a44199479e5c906f03"}],"neutron/tests/unit/test_hacking.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"38164478dfe4f1a03edf407c6588a14d8a2cb2b5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    0, len(list(checks.validate_log_translations(ok,"},{"line_number":43,"context_line":"                                                                 ok, \u0027f\u0027))))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_use_jsonutils(self):"},{"line_number":46,"context_line":"        def __get_msg(fun):"},{"line_number":47,"context_line":"            msg \u003d (\"N321: jsonutils.%(fun)s must be used instead of \""},{"line_number":48,"context_line":"                   \"json.%(fun)s\" % {\u0027fun\u0027: fun})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_1e11225c","line":45,"updated":"2014-08-08 14:55:41.000000000","message":"looks like this test is failing","commit_id":"2c99e207a35aa13fe90714bfb1eefb82bc01e641"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"48ee378103f4aabb15830d11c49a771e209b5487","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                    0, len(list(checks.validate_log_translations(ok,"},{"line_number":43,"context_line":"                                                                 ok, \u0027f\u0027))))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def test_use_jsonutils(self):"},{"line_number":46,"context_line":"        def __get_msg(fun):"},{"line_number":47,"context_line":"            msg \u003d (\"N321: jsonutils.%(fun)s must be used instead of \""},{"line_number":48,"context_line":"                   \"json.%(fun)s\" % {\u0027fun\u0027: fun})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cd8e0d32","line":45,"in_reply_to":"baada198_1e11225c","updated":"2014-08-09 07:05:38.000000000","message":"Yeah, the rule #0: don\u0027t update your patches from Flock... Fixed.","commit_id":"2c99e207a35aa13fe90714bfb1eefb82bc01e641"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1d5668bb06253f724b8a3b67c49b20f27de915de","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            self.assertIsNone("},{"line_number":58,"context_line":"                checks.use_jsonutils(\"json.%s\" % method,"},{"line_number":59,"context_line":"                                     \"./neutron/plugins/openvswitch/agent/\""},{"line_number":60,"context_line":"                                     \"xenapi/test.py\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_fdb8f1c8","line":60,"updated":"2014-08-08 16:04:19.000000000","message":"This path should now be:\n\n  \"neutron/plugins/openvswitch/agent/xenapi/etc/xapi.d/plugins/netwrap\"","commit_id":"2c99e207a35aa13fe90714bfb1eefb82bc01e641"}]}
