)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49e527b024b7e594864e36f38304757f42ec6254","unresolved":false,"context_lines":[{"line_number":10,"context_line":"But router should have other status such as PENDING_UPDATE and ERROR."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When ERROR occurs in l3agent process, neutron set \"ERROR\" to router status of DB."},{"line_number":13,"context_line":"This code is modified for l3agent(non DVR)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I44f03ea66d8e5ddb974963ecfa994b6af75c72c8"},{"line_number":16,"context_line":"Closes-Bug: 1341290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_86c4f941","line":13,"updated":"2014-08-09 00:15:50.000000000","message":"not sure I agree here. An agent in error state does not depend on the type of router it manages.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c23d6d50ad98bf75885bd0811c1aaadc64631fc8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"But router should have other status such as PENDING_UPDATE and ERROR."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When ERROR occurs in l3agent process, neutron set \"ERROR\" to router status of DB."},{"line_number":13,"context_line":"This code is modified for l3agent(non DVR)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I44f03ea66d8e5ddb974963ecfa994b6af75c72c8"},{"line_number":16,"context_line":"Closes-Bug: 1341290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7ac7a964_1e77b53b","line":13,"in_reply_to":"baada198_864eb9c0","updated":"2014-08-15 05:15:24.000000000","message":"+1","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"7b88f58eb89ce2d6758fc663bfe2719a52e437b0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"But router should have other status such as PENDING_UPDATE and ERROR."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"When ERROR occurs in l3agent process, neutron set \"ERROR\" to router status of DB."},{"line_number":13,"context_line":"This code is modified for l3agent(non DVR)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I44f03ea66d8e5ddb974963ecfa994b6af75c72c8"},{"line_number":16,"context_line":"Closes-Bug: 1341290"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_864eb9c0","line":13,"in_reply_to":"baada198_86c4f941","updated":"2014-08-09 00:24:03.000000000","message":"I agree with Armando - I don\u0027t we should limit to only legacy routers to start with.  Perhaps all the error cases of DVR can\u0027t be handled at first, but we shouldn\u0027t avoid them as a whole.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49e527b024b7e594864e36f38304757f42ec6254","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                                       router_id\u003drouter_id,"},{"line_number":118,"context_line":"                                       status\u003dstatus),"},{"line_number":119,"context_line":"                         topic\u003dself.topic,"},{"line_number":120,"context_line":"                         version\u003d\u00271.1\u0027)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def update_floatingip_statuses(self, context, router_id, fip_statuses):"},{"line_number":123,"context_line":"        \"\"\"Call the plugin update floating IPs\u0027s operational status.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_262fadf6","line":120,"updated":"2014-08-09 00:15:50.000000000","message":"this would need a bump in the RPC API as far as I can tell. Existing Servers won\u0027t have this method.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"7b88f58eb89ce2d6758fc663bfe2719a52e437b0","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"                # Update router status on the neutron server"},{"line_number":1577,"context_line":"                self.plugin_rpc.update_router_status("},{"line_number":1578,"context_line":"                    self.context, update.id,"},{"line_number":1579,"context_line":"                    status\u003dl3_constants.L3_STATUS_PENDING_UPDATE)"},{"line_number":1580,"context_line":"            router \u003d update.router"},{"line_number":1581,"context_line":"            if update.action !\u003d DELETE_ROUTER and not router:"},{"line_number":1582,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_666a851c","line":1579,"updated":"2014-08-09 00:24:03.000000000","message":"Why limit this to only legacy routers?","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49e527b024b7e594864e36f38304757f42ec6254","unresolved":false,"context_lines":[{"line_number":1576,"context_line":"                # Update router status on the neutron server"},{"line_number":1577,"context_line":"                self.plugin_rpc.update_router_status("},{"line_number":1578,"context_line":"                    self.context, update.id,"},{"line_number":1579,"context_line":"                    status\u003dl3_constants.L3_STATUS_PENDING_UPDATE)"},{"line_number":1580,"context_line":"            router \u003d update.router"},{"line_number":1581,"context_line":"            if update.action !\u003d DELETE_ROUTER and not router:"},{"line_number":1582,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_06070982","line":1579,"updated":"2014-08-09 00:15:50.000000000","message":"these new states would need coordination server/agent: what I mean is that you may want to introduce a STATUS_PENDING_UPDATE_BEGIN in the SERVER, STATUS_PENDING_UPDATE_PROGRESS and STATUS_PENDING_UPDATE_END. That said, this I think goes beyond a simple bug fix. This has impact all the way down the API.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"49e527b024b7e594864e36f38304757f42ec6254","unresolved":false,"context_lines":[{"line_number":1598,"context_line":""},{"line_number":1599,"context_line":"            try:"},{"line_number":1600,"context_line":"                self._process_routers([router])"},{"line_number":1601,"context_line":"            except Exception, msg:"},{"line_number":1602,"context_line":"                if self.conf.agent_mode \u003d\u003d \u0027legacy\u0027:"},{"line_number":1603,"context_line":"                    # Update router status on the neutron server"},{"line_number":1604,"context_line":"                    self.plugin_rpc.update_router_status("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_468101f9","line":1601,"updated":"2014-08-09 00:15:50.000000000","message":"this is not the right syntax do Except as msg.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c23d6d50ad98bf75885bd0811c1aaadc64631fc8","unresolved":false,"context_lines":[{"line_number":1604,"context_line":"                    self.plugin_rpc.update_router_status("},{"line_number":1605,"context_line":"                        self.context, update.id,"},{"line_number":1606,"context_line":"                        status\u003dl3_constants.L3_STATUS_ERROR)"},{"line_number":1607,"context_line":"                raise Exception(msg)"},{"line_number":1608,"context_line":"            LOG.debug(\"Finished a router update for %s\", update.id)"},{"line_number":1609,"context_line":"            if self.conf.agent_mode \u003d\u003d \u0027legacy\u0027:"},{"line_number":1610,"context_line":"                # Update router status on the neutron server"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_be86c111","line":1607,"updated":"2014-08-15 05:15:24.000000000","message":"Exception is too generic.\n\ni guess you should use save_and_reraise_exception.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"}],"neutron/db/l3_rpc_base.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c23d6d50ad98bf75885bd0811c1aaadc64631fc8","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":136,"context_line":"            LOG.debug(_(\"New status for router %(router_id)s: \""},{"line_number":137,"context_line":"                        \"%(status)s\"), {\u0027router_id\u0027: router_id,"},{"line_number":138,"context_line":"                                        \u0027status\u0027: status})"},{"line_number":139,"context_line":"            try:"},{"line_number":140,"context_line":"                l3_plugin.update_router_status(context,"},{"line_number":141,"context_line":"                                               router_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_de20dd4b","line":138,"updated":"2014-08-15 05:15:24.000000000","message":"don\u0027t localize new debug logs.","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c23d6d50ad98bf75885bd0811c1aaadc64631fc8","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                               status)"},{"line_number":143,"context_line":"            except l3.RouterNotFound:"},{"line_number":144,"context_line":"                LOG.debug(_(\"Router: %s no longer present.\"),"},{"line_number":145,"context_line":"                          router_id)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def update_floatingip_statuses(self, context, router_id, fip_statuses):"},{"line_number":148,"context_line":"        \"\"\"Update operational status for a floating IP.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_bee16100","line":145,"updated":"2014-08-15 05:15:24.000000000","message":"ditto","commit_id":"912128221b7816e0bfa3956bb4ef9cc1b222c779"}]}
