)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2pop: Allow network types overridable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currenly \"tunnel_types\" is used for two different purposes; l2pop and"},{"line_number":10,"context_line":"check_segment_for_agent.  This commit introduces a new agent"},{"line_number":11,"context_line":"configuration \"l2pop_network_types\" to allow overriding the former."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_f02a9d2d","line":9,"updated":"2014-08-11 15:48:33.000000000","message":"*Currently","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"l2pop: Allow network types overridable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currenly \"tunnel_types\" is used for two different purposes; l2pop and"},{"line_number":10,"context_line":"check_segment_for_agent.  This commit introduces a new agent"},{"line_number":11,"context_line":"configuration \"l2pop_network_types\" to allow overriding the former."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_0181854c","line":9,"in_reply_to":"baada198_f02a9d2d","updated":"2014-08-11 17:35:26.000000000","message":"Done","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2pop: Allow network types overridable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currenly \"tunnel_types\" is used for two different purposes; l2pop and"},{"line_number":10,"context_line":"check_segment_for_agent.  This commit introduces a new agent"},{"line_number":11,"context_line":"configuration \"l2pop_network_types\" to allow overriding the former."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will be used by ofagent, which wants l2pop info for TYPE_VLAN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_b0fd85b4","line":10,"updated":"2014-08-11 15:48:33.000000000","message":"there are 2 spaces between \"check_segment_for_agent.\" and \"This\"","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":7,"context_line":"l2pop: Allow network types overridable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currenly \"tunnel_types\" is used for two different purposes; l2pop and"},{"line_number":10,"context_line":"check_segment_for_agent.  This commit introduces a new agent"},{"line_number":11,"context_line":"configuration \"l2pop_network_types\" to allow overriding the former."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This will be used by ofagent, which wants l2pop info for TYPE_VLAN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_c15ced1c","line":10,"in_reply_to":"baada198_b0fd85b4","updated":"2014-08-11 17:35:26.000000000","message":"it\u0027s intentional.  is it a problem?","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"}],"neutron/plugins/ml2/drivers/l2pop/db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"df0883b39ce51f716caa9b3849fceb1f11fc0ed3","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":50,"context_line":"        if network_types is not None:"},{"line_number":51,"context_line":"            return network_types"},{"line_number":52,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":55,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e4585527","line":52,"updated":"2014-08-08 20:00:09.000000000","message":"this doesn\u0027t sound right; if l2pop_network_types is None, this still returns tunnel_types. At least this change grants the need of a docstring to explain what\u0027s going on.","commit_id":"87e0940a9768ff83cc1464e2956c211492b0d595"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"4bd96e1bd861edd3d73dabb45eea99fd211f9fb5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":50,"context_line":"        if network_types is not None:"},{"line_number":51,"context_line":"            return network_types"},{"line_number":52,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":55,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_eac0057f","line":52,"in_reply_to":"baada198_b6983a1b","updated":"2014-08-11 03:58:25.000000000","message":"Done","commit_id":"87e0940a9768ff83cc1464e2956c211492b0d595"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c195d6e747b0539fe672910d0ba32c3c892cb9ca","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":50,"context_line":"        if network_types is not None:"},{"line_number":51,"context_line":"            return network_types"},{"line_number":52,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":55,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b6983a1b","line":52,"in_reply_to":"baada198_e4585527","updated":"2014-08-10 23:01:44.000000000","message":"i\u0027ll add docstring to make my intent clear.","commit_id":"87e0940a9768ff83cc1464e2956c211492b0d595"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                       agent.heartbeat_timestamp)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_agent_l2pop_network_types(self, agent):"},{"line_number":48,"context_line":"        \"\"\"Return a list of network types for which the agent requested"},{"line_number":49,"context_line":"        l2population."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        Use \u0027l2pop_network_types\u0027 if specified.  Otherwise fallback to"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d00f59d2","line":48,"updated":"2014-08-11 15:48:33.000000000","message":"*Returns","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                                       agent.heartbeat_timestamp)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def get_agent_l2pop_network_types(self, agent):"},{"line_number":48,"context_line":"        \"\"\"Return a list of network types for which the agent requested"},{"line_number":49,"context_line":"        l2population."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        Use \u0027l2pop_network_types\u0027 if specified.  Otherwise fallback to"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c1b86d14","line":48,"in_reply_to":"baada198_d00f59d2","updated":"2014-08-11 17:35:26.000000000","message":"Done","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Return a list of network types for which the agent requested"},{"line_number":49,"context_line":"        l2population."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        Use \u0027l2pop_network_types\u0027 if specified.  Otherwise fallback to"},{"line_number":52,"context_line":"        \u0027tunnel_types\u0027."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d0bd99d2","line":51,"updated":"2014-08-11 15:48:33.000000000","message":"there are 2 spaces \"specified.\" and \"Otherwise\"","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \"\"\"Return a list of network types for which the agent requested"},{"line_number":49,"context_line":"        l2population."},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        Use \u0027l2pop_network_types\u0027 if specified.  Otherwise fallback to"},{"line_number":52,"context_line":"        \u0027tunnel_types\u0027."},{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a1d61951","line":51,"in_reply_to":"baada198_d0bd99d2","updated":"2014-08-11 17:35:26.000000000","message":"It\u0027s intentional.","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":55,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":56,"context_line":"        if network_types is not None:"},{"line_number":57,"context_line":"            return network_types"},{"line_number":58,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_70cf6d57","line":56,"updated":"2014-08-11 15:48:33.000000000","message":"i assume network_types should be an array. What if network_types is an empty array? Is it ok to return an empty array?","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":55,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":56,"context_line":"        if network_types is not None:"},{"line_number":57,"context_line":"            return network_types"},{"line_number":58,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_81491534","line":56,"in_reply_to":"baada198_70cf6d57","updated":"2014-08-11 17:35:26.000000000","message":"yes.  an empty array is a valid setting.","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"15b13b3fcdf01dad28aadfc73802e4ca6c4c581f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":55,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":56,"context_line":"        if network_types is not None:"},{"line_number":57,"context_line":"            return network_types"},{"line_number":58,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_b22f34f4","line":56,"updated":"2014-08-12 04:55:58.000000000","message":"It is better to have two explicit methods.  One to get l2pop_network_types and get_tunnel_types.  When the former returns values the caller should use that.  If the former returns no values, the latter which is get_tunnel_type should be invoked by the caller.\r\n\r\nLumping tunnel_types into l2pop_network_types hides things.","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"37ebb56012d8577adae1a910f5bdc82dd9be6ecb","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        \"\"\""},{"line_number":54,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":55,"context_line":"        network_types \u003d configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":56,"context_line":"        if network_types is not None:"},{"line_number":57,"context_line":"            return network_types"},{"line_number":58,"context_line":"        return configuration.get(\u0027tunnel_types\u0027)"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_40f6025f","line":56,"in_reply_to":"baada198_b22f34f4","updated":"2014-08-12 06:15:40.000000000","message":"Done","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"818ef1520d1c6815db23174f5b6fa34aecd75e2f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_agent_l2pop_network_types(self, agent):"},{"line_number":52,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":53,"context_line":"        return configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":56,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_9b9c0bc1","line":53,"updated":"2014-08-12 06:34:40.000000000","message":"I donot see either ml2_conf.ini (or) ovs_neutron_plugin.ini as enclosed file.\r\n\r\nYou may want to add this entry as example in ovs_neutron_plugin.ini (or) ml2_conf.ini under the [AGENT] section. \r\n\r\nThis will allow users to know that such an option exists and can be used in lieu of tunnel_types.","commit_id":"57a204583ac5920c033627769e9dd13c1f59451b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f67584e02f8a3f1c1d7510a3a137c664e45e9f3d","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_agent_l2pop_network_types(self, agent):"},{"line_number":52,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":53,"context_line":"        return configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":56,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a6de160e","line":53,"in_reply_to":"baada198_664a3e25","updated":"2014-08-12 07:15:36.000000000","message":"OK, looks like this config can be dynamically sent by agents by clobbering existing tunnel_types and other supported l2 network types as in your ofagent link.","commit_id":"57a204583ac5920c033627769e9dd13c1f59451b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9a3a03248841d886d9dd24ba62c217710d92bc8f","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def get_agent_l2pop_network_types(self, agent):"},{"line_number":52,"context_line":"        configuration \u003d jsonutils.loads(agent.configurations)"},{"line_number":53,"context_line":"        return configuration.get(\u0027l2pop_network_types\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def get_agent_by_host(self, session, agent_host):"},{"line_number":56,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_664a3e25","line":53,"in_reply_to":"baada198_9b9c0bc1","updated":"2014-08-12 07:07:37.000000000","message":"this is not an ini file item.\nit\u0027s a part of agent configuration reported by agent.\nsee https://review.openstack.org/#/c/112949/ for an example usage.","commit_id":"57a204583ac5920c033627769e9dd13c1f59451b"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"df0883b39ce51f716caa9b3849fceb1f11fc0ed3","unresolved":false,"context_lines":[{"line_number":178,"context_line":"            return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        network_types \u003d self.get_agent_l2pop_network_types(agent)"},{"line_number":181,"context_line":"        if segment[\u0027network_type\u0027] not in network_types:"},{"line_number":182,"context_line":"            return"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        fdb_entries \u003d self._get_port_fdb_entries(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_64a44507","line":181,"updated":"2014-08-08 20:00:09.000000000","message":"I find this name change odd, because we are still returning tunnel types if l2pop_network_types is None","commit_id":"87e0940a9768ff83cc1464e2956c211492b0d595"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"15b13b3fcdf01dad28aadfc73802e4ca6c4c581f","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        network_types \u003d self.get_agent_l2pop_network_types(agent)"},{"line_number":181,"context_line":"        if segment[\u0027network_type\u0027] not in network_types:"},{"line_number":182,"context_line":"            return"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        fdb_entries \u003d self._get_port_fdb_entries(port)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_d2090884","line":182,"updated":"2014-08-12 04:55:58.000000000","message":"Better would be:\r\nnetwork_types \u003d get_agent_l2poop_network_types()\r\n\r\nIf not l2pop_network_types:\r\n    network_types \u003d get_tunnel_type\r\n\r\nwork with netwrok_types here...","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"37ebb56012d8577adae1a910f5bdc82dd9be6ecb","unresolved":false,"context_lines":[{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        network_types \u003d self.get_agent_l2pop_network_types(agent)"},{"line_number":181,"context_line":"        if segment[\u0027network_type\u0027] not in network_types:"},{"line_number":182,"context_line":"            return"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        fdb_entries \u003d self._get_port_fdb_entries(port)"},{"line_number":185,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_60f14663","line":182,"in_reply_to":"baada198_d2090884","updated":"2014-08-12 06:15:40.000000000","message":"Done","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"20ed350717b70c6a8f02b11cc39aad60157fbc03","unresolved":false,"context_lines":[{"line_number":177,"context_line":"                        {\u0027port\u0027: port[\u0027id\u0027], \u0027agent\u0027: agent})"},{"line_number":178,"context_line":"            return"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        network_types \u003d self.get_agent_l2pop_network_types(agent)"},{"line_number":181,"context_line":"        if network_types is None:"},{"line_number":182,"context_line":"            network_types \u003d self.get_agent_tunnel_types(agent)"},{"line_number":183,"context_line":"        if segment[\u0027network_type\u0027] not in network_types:"}],"source_content_type":"text/x-python","patch_set":7,"id":"baada198_389f7af7","line":180,"updated":"2014-08-12 12:08:18.000000000","message":"nit:\n network_types \u003d (self.get_agent_l2pop_network_types(agent) or \n                  self.get_agent_tunnel_types(agent))","commit_id":"2e5d06e13b1dcce838dd3a268f5fca25caa133c6"}],"neutron/tests/unit/ml2/drivers/test_l2population.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"6c93ac5afe3f105d884fa90047318f7f6a8bec1c","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                           **host_arg) as port1:"},{"line_number":238,"context_line":"                with self.port(subnet\u003dsubnet,"},{"line_number":239,"context_line":"                               arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":240,"context_line":"                               **host_arg):"},{"line_number":241,"context_line":"                    p1 \u003d port1[\u0027port\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"                    device \u003d (\u0027tap\u0027 + p1[\u0027id\u0027])[:14]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b08d85d6","line":240,"updated":"2014-08-11 15:48:33.000000000","message":"just a thought: maybe you\u0027d like to use contextlib.nested with the with self.port(...), it will save you an identation. But I\u0027m ok either way.","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2aa83d2c5a6c8b6437d7a4ec474efb9227c69baf","unresolved":false,"context_lines":[{"line_number":237,"context_line":"                           **host_arg) as port1:"},{"line_number":238,"context_line":"                with self.port(subnet\u003dsubnet,"},{"line_number":239,"context_line":"                               arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":240,"context_line":"                               **host_arg):"},{"line_number":241,"context_line":"                    p1 \u003d port1[\u0027port\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"                    device \u003d (\u0027tap\u0027 + p1[\u0027id\u0027])[:14]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_010425c4","line":240,"in_reply_to":"baada198_b08d85d6","updated":"2014-08-11 17:35:26.000000000","message":"i followed the style of the existing code in this module.","commit_id":"96d99d80d3817e86f68b42065ba70a6fd6ce6c0d"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"15b13b3fcdf01dad28aadfc73802e4ca6c4c581f","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                                    agent_id\u003dHOST,"},{"line_number":248,"context_line":"                                                    device\u003ddevice)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"                    self.assertFalse(self.mock_fanout.called)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_fdb_add_two_agents(self):"},{"line_number":253,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f251ac63","line":250,"updated":"2014-08-12 04:55:58.000000000","message":"You may watn to ensure that for VLAN case in l2-pop-network types fdb_add is invoked for the downstream agents.\r\n\r\nSo, this has to be changed to \r\n\r\n self.mock_fanout.assert_called_with(\r\n  \r\n                         mock.ANY, expected, topic\u003dself.fanout_topic)\r\n                         mock.ANY, expected, topic\u003dself.fanout_topic)","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"37ebb56012d8577adae1a910f5bdc82dd9be6ecb","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                                                    agent_id\u003dHOST,"},{"line_number":248,"context_line":"                                                    device\u003ddevice)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"                    self.assertFalse(self.mock_fanout.called)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_fdb_add_two_agents(self):"},{"line_number":253,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_20fbce48","line":250,"in_reply_to":"baada198_f251ac63","updated":"2014-08-12 06:15:40.000000000","message":"Done","commit_id":"d9a83a51a0c83d869016dab8a5e86d1504d48d2b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"818ef1520d1c6815db23174f5b6fa34aecd75e2f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.orig_supported_agents \u003d l2_consts.SUPPORTED_AGENT_TYPES"},{"line_number":106,"context_line":"        l2_consts.SUPPORTED_AGENT_TYPES \u003d [constants.AGENT_TYPE_OVS]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        net_arg \u003d {pnet.NETWORK_TYPE: \u0027vxlan\u0027,"},{"line_number":109,"context_line":"                   pnet.SEGMENTATION_ID: \u00271\u0027}"},{"line_number":110,"context_line":"        self._network \u003d self._make_network(self.fmt, \u0027net1\u0027, True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_1b447b17","side":"PARENT","line":107,"updated":"2014-08-12 06:34:40.000000000","message":"Since am not sure of effects of removing this, advise that add both OFA and OVS in this list here and then leave the tearDown() as is.","commit_id":"c90f1c46356e056e0ddc18cf4bf7be0d0a088880"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"9a3a03248841d886d9dd24ba62c217710d92bc8f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.orig_supported_agents \u003d l2_consts.SUPPORTED_AGENT_TYPES"},{"line_number":106,"context_line":"        l2_consts.SUPPORTED_AGENT_TYPES \u003d [constants.AGENT_TYPE_OVS]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        net_arg \u003d {pnet.NETWORK_TYPE: \u0027vxlan\u0027,"},{"line_number":109,"context_line":"                   pnet.SEGMENTATION_ID: \u00271\u0027}"},{"line_number":110,"context_line":"        self._network \u003d self._make_network(self.fmt, \u0027net1\u0027, True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_46c29a54","side":"PARENT","line":107,"in_reply_to":"baada198_1b447b17","updated":"2014-08-12 07:07:37.000000000","message":"i removed this as i made L2_AGENT_5 an ofagent.\n\nthis seems like a leftover hack from the day when SUPPORTED_AGENT_TYPES was empty.","commit_id":"c90f1c46356e056e0ddc18cf4bf7be0d0a088880"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f67584e02f8a3f1c1d7510a3a137c664e45e9f3d","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        self.orig_supported_agents \u003d l2_consts.SUPPORTED_AGENT_TYPES"},{"line_number":106,"context_line":"        l2_consts.SUPPORTED_AGENT_TYPES \u003d [constants.AGENT_TYPE_OVS]"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        net_arg \u003d {pnet.NETWORK_TYPE: \u0027vxlan\u0027,"},{"line_number":109,"context_line":"                   pnet.SEGMENTATION_ID: \u00271\u0027}"},{"line_number":110,"context_line":"        self._network \u003d self._make_network(self.fmt, \u0027net1\u0027, True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_a6b7f6d5","side":"PARENT","line":107,"in_reply_to":"baada198_46c29a54","updated":"2014-08-12 07:15:36.000000000","message":"OK.  \r\n\r\nA linuxbridge example would also help, but that we can do later.  I see only OFA, OVS and LB are supported agents for l2pop as of today.","commit_id":"c90f1c46356e056e0ddc18cf4bf7be0d0a088880"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"d58d167206be0f66cb3dc70cc9dbd8df76983f60","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                \u0027namespace\u0027: None,"},{"line_number":269,"context_line":"                                \u0027method\u0027: \u0027add_fdb_entries\u0027}"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                    self.mock_fanout.assert_called_with("},{"line_number":272,"context_line":"                        mock.ANY, expected, topic\u003dself.fanout_topic)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_fdb_add_two_agents(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_b6f001fd","line":271,"updated":"2014-08-12 08:39:35.000000000","message":"wouldn\u0027t assert_called_once_with be more appropriate ?","commit_id":"57a204583ac5920c033627769e9dd13c1f59451b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"b6c91877fbb72ffef0e8a7870ae491ef4d647a1b","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                                \u0027namespace\u0027: None,"},{"line_number":269,"context_line":"                                \u0027method\u0027: \u0027add_fdb_entries\u0027}"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"                    self.mock_fanout.assert_called_with("},{"line_number":272,"context_line":"                        mock.ANY, expected, topic\u003dself.fanout_topic)"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    def test_fdb_add_two_agents(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ac799482","line":271,"in_reply_to":"baada198_b6f001fd","updated":"2014-08-12 09:38:40.000000000","message":"Let\u0027s leave it at assert_called_with() as all other testcase\u0027s in tis file use that pattern.","commit_id":"57a204583ac5920c033627769e9dd13c1f59451b"}]}
