)]}'
{"neutron/plugins/ml2/rpc.py":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"bf66925b7af12652a954461947f66c9c97e89918","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          \"bound, vif_type: %(vif_type)s\"),"},{"line_number":109,"context_line":"                        {\u0027device\u0027: device,"},{"line_number":110,"context_line":"                         \u0027agent_id\u0027: agent_id,"},{"line_number":111,"context_line":"                         \u0027network_id\u0027: port[\u0027network_id\u0027],"},{"line_number":112,"context_line":"                         \u0027vif_type\u0027: port[portbindings.VIF_TYPE]})"},{"line_number":113,"context_line":"            return {\u0027device\u0027: device}"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_504b5e27","line":111,"updated":"2014-08-11 05:58:11.000000000","message":"you may want to use _LW for warning messages.\n\nuse \u003d\u003e from neutron.openstack.common.gettextutils import _LW","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"210b7e406e9ba907edb716229023146f5ca050b0","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          \"bound, vif_type: %(vif_type)s\"),"},{"line_number":109,"context_line":"                        {\u0027device\u0027: device,"},{"line_number":110,"context_line":"                         \u0027agent_id\u0027: agent_id,"},{"line_number":111,"context_line":"                         \u0027network_id\u0027: port[\u0027network_id\u0027],"},{"line_number":112,"context_line":"                         \u0027vif_type\u0027: port[portbindings.VIF_TYPE]})"},{"line_number":113,"context_line":"            return {\u0027device\u0027: device}"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_50e7de0e","line":111,"in_reply_to":"baada198_504b5e27","updated":"2014-08-11 06:00:56.000000000","message":"this commit does not touch it.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9936bdd55d43a4f36dc62f9ebd4c4be106fa6959","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                          \"bound, vif_type: %(vif_type)s\"),"},{"line_number":109,"context_line":"                        {\u0027device\u0027: device,"},{"line_number":110,"context_line":"                         \u0027agent_id\u0027: agent_id,"},{"line_number":111,"context_line":"                         \u0027network_id\u0027: port[\u0027network_id\u0027],"},{"line_number":112,"context_line":"                         \u0027vif_type\u0027: port[portbindings.VIF_TYPE]})"},{"line_number":113,"context_line":"            return {\u0027device\u0027: device}"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_10580656","line":111,"in_reply_to":"baada198_50e7de0e","updated":"2014-08-11 06:18:11.000000000","message":"okay","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"bf66925b7af12652a954461947f66c9c97e89918","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b0511ad7","line":134,"updated":"2014-08-11 05:58:11.000000000","message":"debug messages can be simple. LOG.debug() .. Like in L202","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"98e1800dd97883ea3118c46459e0eae9131a6bd6","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_eb6487e7","line":134,"in_reply_to":"baada198_504efe90","updated":"2014-08-11 06:24:25.000000000","message":"this commit doesn\u0027t modify neither of L202 and L134.\ni don\u0027t think it\u0027s a good idea to perform unrelated changes within this commit.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"9936bdd55d43a4f36dc62f9ebd4c4be106fa6959","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_504efe90","line":134,"in_reply_to":"baada198_70b782f8","updated":"2014-08-11 06:18:11.000000000","message":"But L202 is modified that way and here L134 is written this way. You may follow one standard for all the messages.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"d43eb9a0378d49d0822d3320b11801a3627c2a99","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_cb242361","line":134,"in_reply_to":"baada198_8b394ba5","updated":"2014-08-11 06:33:58.000000000","message":"Okay. Is there any issue when you make the log debug messages consistent in this file","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"eafd449ec33c96ee18282e989a2e45e524167256","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0c19ced1","line":134,"in_reply_to":"baada198_8bc94b27","updated":"2014-08-11 12:15:54.000000000","message":"+1 to Yamamoto here. I think such changes like logging fix could be incorporated into a change like that, but it\u0027s better to fix logging in whole file, and it for sure not a reason to -1 this patch for not having logging fix.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"210b7e406e9ba907edb716229023146f5ca050b0","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_70b782f8","line":134,"in_reply_to":"baada198_b0511ad7","updated":"2014-08-11 06:00:56.000000000","message":"ditto.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"84ed79304e52a1b1ae4f27a5457d9aef7b636d9d","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8bc94b27","line":134,"in_reply_to":"baada198_cb242361","updated":"2014-08-11 06:58:23.000000000","message":"Trinath,\n\ni agree your suggested changes are good.\nhowever, i don\u0027t think it\u0027s a good idea to make unrelated changes in a single commit especially when the \"main\" change is very small like this.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"b245644a95cbfeeb65d2e8944454fb0b29a7ce30","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_eb92c79e","line":134,"in_reply_to":"baada198_eb6487e7","updated":"2014-08-11 06:27:16.000000000","message":"Okay. I mean to say maintain consistency. In L134 its LOG.deug(_()) and in L202 its LOG.debug().\n\nUse any one version rather two types.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"d329a0d947e3444658910832eeb4f1905e38b51c","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                 \u0027fixed_ips\u0027: port[\u0027fixed_ips\u0027],"},{"line_number":132,"context_line":"                 \u0027device_owner\u0027: port[\u0027device_owner\u0027],"},{"line_number":133,"context_line":"                 \u0027profile\u0027: port[portbindings.PROFILE]}"},{"line_number":134,"context_line":"        LOG.debug(_(\"Returning: %s\"), entry)"},{"line_number":135,"context_line":"        return entry"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def get_devices_details_list(self, rpc_context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8b394ba5","line":134,"in_reply_to":"baada198_eb92c79e","updated":"2014-08-11 06:30:14.000000000","message":"i agree consistency is good.\nbut this commit is not what introduced inconsistency.\ni don\u0027t understand why you put -1 on this commit for the inconsistency.","commit_id":"e5b67ff04f1a90a37b3ddc94dc1b3366883153f9"}]}
