)]}'
{"neutron/plugins/bigswitch/l3_router_plugin.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"49d40edd5966321ced9bcf3e2c994a269bce4ea9","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @put_context_in_serverpool"},{"line_number":65,"context_line":"    def create_router(self, context, router):"},{"line_number":66,"context_line":"        LOG.debug(_(\"NeutronRestProxyV2: create_router() called\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self._warn_on_state_status(router[\u0027router\u0027])"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_50bf94d0","line":66,"range":{"start_line":66,"start_character":21,"end_line":66,"end_character":39},"updated":"2014-08-14 00:21:36.000000000","message":"it seems you need to update the message.\nand remove _().\n\nprobably it\u0027s better to use @logging.log.","commit_id":"7c398c90e91c715513c24a10d3751e6ed354a3b8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b0330aa40ddb1a611ced992a263dc9f68a8a4806","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @put_context_in_serverpool"},{"line_number":65,"context_line":"    def create_router(self, context, router):"},{"line_number":66,"context_line":"        LOG.debug(_(\"NeutronRestProxyV2: create_router() called\"))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        self._warn_on_state_status(router[\u0027router\u0027])"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7ac7a964_87e729e4","line":66,"in_reply_to":"7ac7a964_50bf94d0","updated":"2014-08-14 05:59:19.000000000","message":"Sure.","commit_id":"7c398c90e91c715513c24a10d3751e6ed354a3b8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9ff842b4dbfb3d8ceba6cb42d3226711655964c7","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # return created router"},{"line_number":83,"context_line":"            return new"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_759109f0","line":80,"updated":"2014-08-29 14:29:25.000000000","message":"Isn\u0027t it a common antipattern to call yielding method under transaction?\nIs it necessary to call it in a transaction?\n\nHowever, parent class routerrule_db.RouterRule_db_mixin has the same issue.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f025aa372e747c955dd8fd55ddfef1e517dde53a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # return created router"},{"line_number":83,"context_line":"            return new"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_8c8db233","line":80,"in_reply_to":"1abeadc6_759109f0","updated":"2014-08-29 21:16:56.000000000","message":"The entire point of having a transaction in a context manager is that you can have potentially failing calls inside that will raise an exception and the DB state will be rolled back automatically. \n\nIt only became a risk when with our SQL library not yielding on blocking calls when something else had a lock on the DB record in question. This is a safe operation because there isn\u0027t a lock involved.\n\nCan you explain what you mean about the router rule DB having this issue? It doesn\u0027t make rest calls.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"6afde3230fdf504e92061053e42208353dc7cedb","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # return created router"},{"line_number":83,"context_line":"            return new"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_70ca896f","line":80,"in_reply_to":"1abeadc6_8c8db233","updated":"2014-09-02 13:11:45.000000000","message":"I think lock is implied when you create db records. Anyway, port creation is a complex operation that involves record locking. Just wrapping create_port with transaction (or methods that call create_port)  can cause potential problems.\n\nBut as I said, apparently existing code has the issue already and this patch doesn\u0027t make it worse.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"14bbeda95726a0d6e416ee1de7119c2be237b995","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"            # return created router"},{"line_number":83,"context_line":"            return new"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_afd71c22","line":80,"in_reply_to":"fa98f980_70ca896f","updated":"2014-09-02 21:05:52.000000000","message":"The create_router case could probably be handled by catching the exception from rest call and deleting the router.\n\nHowever, what do you do when it happens after a router deletion has been committed to the database or after an update operation has occurred? After that point it\u0027s too late to go back safely and restore the records because another ongoing operation could have used those unique resources (e.g. IP addresses). At this point there will be failures in consistency between the backend and the front-end and these operations will fail.\n\nLong story short, it\u0027s not a risk-free operation to remove it from the transaction. The deadlock avoided from moving outside is caused by lock_mode update on rows, which are slowly being eliminated anyway. I\u0027m not aware of an eventlet yielding problem with the other operations.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9ff842b4dbfb3d8ceba6cb42d3226711655964c7","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            router \u003d self._map_state_and_status(new_router)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # update router on network controller"},{"line_number":98,"context_line":"            self.servers.rest_update_router(tenant_id, router, router_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            # return updated router"},{"line_number":101,"context_line":"            return new_router"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_15a1b545","line":98,"updated":"2014-08-29 14:29:25.000000000","message":"same","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f025aa372e747c955dd8fd55ddfef1e517dde53a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            router \u003d self._map_state_and_status(new_router)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"            # update router on network controller"},{"line_number":98,"context_line":"            self.servers.rest_update_router(tenant_id, router, router_id)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"            # return updated router"},{"line_number":101,"context_line":"            return new_router"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_eca466a7","line":98,"in_reply_to":"1abeadc6_15a1b545","updated":"2014-08-29 21:16:56.000000000","message":"No DB locks in router update. This is also safe.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"9ff842b4dbfb3d8ceba6cb42d3226711655964c7","unresolved":false,"context_lines":[{"line_number":128,"context_line":"                            self).delete_router(context, router_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # delete from network ctrl"},{"line_number":131,"context_line":"            self.servers.rest_delete_router(tenant_id, router_id)"},{"line_number":132,"context_line":"            return ret_val"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    @put_context_in_serverpool"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_b5be4163","line":131,"updated":"2014-08-29 14:29:25.000000000","message":"same.\n\nJust not to repeat the comment, the code below has the same issue.","commit_id":"b1274be2ed0921472ba270e362b45a8d0b0a52e8"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_7bdd5a14","line":78,"updated":"2014-09-01 09:08:21.000000000","message":"nit: new_router","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":77,"context_line":"            # create router in DB"},{"line_number":78,"context_line":"            new \u003d super(L3RestProxy, self).create_router(context, router)"},{"line_number":79,"context_line":"            mapped_router \u003d self._map_state_and_status(new)"},{"line_number":80,"context_line":"            self.servers.rest_create_router(tenant_id, mapped_router)"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_11889470","line":78,"in_reply_to":"fa98f980_7bdd5a14","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                         filters\u003ddevice_filter)"},{"line_number":125,"context_line":"            if ports:"},{"line_number":126,"context_line":"                raise l3.RouterInUse(router_id\u003drouter_id)"},{"line_number":127,"context_line":"            ret_val \u003d super(L3RestProxy,"},{"line_number":128,"context_line":"                            self).delete_router(context, router_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # delete from network ctrl"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_db11e6ad","line":127,"updated":"2014-09-01 09:08:21.000000000","message":"delete_router don\u0027t return anything","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                                         filters\u003ddevice_filter)"},{"line_number":125,"context_line":"            if ports:"},{"line_number":126,"context_line":"                raise l3.RouterInUse(router_id\u003drouter_id)"},{"line_number":127,"context_line":"            ret_val \u003d super(L3RestProxy,"},{"line_number":128,"context_line":"                            self).delete_router(context, router_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # delete from network ctrl"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_31f4b8f1","line":127,"in_reply_to":"fa98f980_db11e6ad","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            ret_val \u003d super(L3RestProxy,"},{"line_number":128,"context_line":"                            self).delete_router(context, router_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # delete from network ctrl"},{"line_number":131,"context_line":"            self.servers.rest_delete_router(tenant_id, router_id)"},{"line_number":132,"context_line":"            return ret_val"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_3bf2f29a","line":130,"updated":"2014-09-01 09:08:21.000000000","message":"nit: controller","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            ret_val \u003d super(L3RestProxy,"},{"line_number":128,"context_line":"                            self).delete_router(context, router_id)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"            # delete from network ctrl"},{"line_number":131,"context_line":"            self.servers.rest_delete_router(tenant_id, router_id)"},{"line_number":132,"context_line":"            return ret_val"},{"line_number":133,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_11d6d44f","line":130,"in_reply_to":"fa98f980_3bf2f29a","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        defaultset \u003d []"},{"line_number":286,"context_line":"        tenantset \u003d []"},{"line_number":287,"context_line":"        for rule in rules:"},{"line_number":288,"context_line":"            items \u003d rule.split(\u0027:\u0027)"},{"line_number":289,"context_line":"            if len(items) \u003d\u003d 5:"},{"line_number":290,"context_line":"                (tenantid, source, destination, action, nexthops) \u003d items"},{"line_number":291,"context_line":"            elif len(items) \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_3bfcb23e","line":288,"updated":"2014-09-01 09:08:21.000000000","message":"How about this?\n\nitems.append(None)\nif len(items) \u003c\u003d TUPLE_NUM:\n   continue \n\n(tenant_id, source, destination, action, nexthops_string) \u003d items\n\nif nexthops_string:\n    nexthops \u003d nexthops_string.split(\u0027,\u0027)\nelse:\n    nexthops \u003d []\n\nparsed_rule \u003d {\u0027source\u0027: source,\n                          \u0027destination\u0027: destination, \u0027action\u0027: action,\n                          \u0027nexthops\u0027:  nexthops}","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":285,"context_line":"        defaultset \u003d []"},{"line_number":286,"context_line":"        tenantset \u003d []"},{"line_number":287,"context_line":"        for rule in rules:"},{"line_number":288,"context_line":"            items \u003d rule.split(\u0027:\u0027)"},{"line_number":289,"context_line":"            if len(items) \u003d\u003d 5:"},{"line_number":290,"context_line":"                (tenantid, source, destination, action, nexthops) \u003d items"},{"line_number":291,"context_line":"            elif len(items) \u003d\u003d 4:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_111ed470","line":288,"in_reply_to":"fa98f980_3bfcb23e","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        tenantset \u003d []"},{"line_number":287,"context_line":"        for rule in rules:"},{"line_number":288,"context_line":"            items \u003d rule.split(\u0027:\u0027)"},{"line_number":289,"context_line":"            if len(items) \u003d\u003d 5:"},{"line_number":290,"context_line":"                (tenantid, source, destination, action, nexthops) \u003d items"},{"line_number":291,"context_line":"            elif len(items) \u003d\u003d 4:"},{"line_number":292,"context_line":"                (tenantid, source, destination, action) \u003d items"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_9b9afe12","line":289,"updated":"2014-09-01 09:08:21.000000000","message":"5 is a magic number","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        tenantset \u003d []"},{"line_number":287,"context_line":"        for rule in rules:"},{"line_number":288,"context_line":"            items \u003d rule.split(\u0027:\u0027)"},{"line_number":289,"context_line":"            if len(items) \u003d\u003d 5:"},{"line_number":290,"context_line":"                (tenantid, source, destination, action, nexthops) \u003d items"},{"line_number":291,"context_line":"            elif len(items) \u003d\u003d 4:"},{"line_number":292,"context_line":"                (tenantid, source, destination, action) \u003d items"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_51185c81","line":289,"in_reply_to":"fa98f980_9b9afe12","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                nexthops \u003d \u0027\u0027"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                continue"},{"line_number":296,"context_line":"            parsedrule \u003d {\u0027source\u0027: source,"},{"line_number":297,"context_line":"                          \u0027destination\u0027: destination, \u0027action\u0027: action,"},{"line_number":298,"context_line":"                          \u0027nexthops\u0027: nexthops.split(\u0027,\u0027)}"},{"line_number":299,"context_line":"            if parsedrule[\u0027nexthops\u0027][0] \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_364be75a","line":296,"updated":"2014-09-01 09:08:21.000000000","message":"nit: parsed_rule","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":293,"context_line":"                nexthops \u003d \u0027\u0027"},{"line_number":294,"context_line":"            else:"},{"line_number":295,"context_line":"                continue"},{"line_number":296,"context_line":"            parsedrule \u003d {\u0027source\u0027: source,"},{"line_number":297,"context_line":"                          \u0027destination\u0027: destination, \u0027action\u0027: action,"},{"line_number":298,"context_line":"                          \u0027nexthops\u0027: nexthops.split(\u0027,\u0027)}"},{"line_number":299,"context_line":"            if parsedrule[\u0027nexthops\u0027][0] \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_9109e433","line":296,"in_reply_to":"fa98f980_364be75a","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"53ff20188054abddaead037b114ceaaa397db400","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                          \u0027nexthops\u0027: nexthops.split(\u0027,\u0027)}"},{"line_number":299,"context_line":"            if parsedrule[\u0027nexthops\u0027][0] \u003d\u003d \u0027\u0027:"},{"line_number":300,"context_line":"                parsedrule[\u0027nexthops\u0027] \u003d []"},{"line_number":301,"context_line":"            if tenantid \u003d\u003d \u0027*\u0027:"},{"line_number":302,"context_line":"                defaultset.append(parsedrule)"},{"line_number":303,"context_line":"            if tenantid \u003d\u003d tenant:"},{"line_number":304,"context_line":"                tenantset.append(parsedrule)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_db72c6e4","line":301,"updated":"2014-09-01 09:08:21.000000000","message":"nit: tenant_id","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"275879cd3ea3d3570e49c28ba1c3cbc16f3f8737","unresolved":false,"context_lines":[{"line_number":298,"context_line":"                          \u0027nexthops\u0027: nexthops.split(\u0027,\u0027)}"},{"line_number":299,"context_line":"            if parsedrule[\u0027nexthops\u0027][0] \u003d\u003d \u0027\u0027:"},{"line_number":300,"context_line":"                parsedrule[\u0027nexthops\u0027] \u003d []"},{"line_number":301,"context_line":"            if tenantid \u003d\u003d \u0027*\u0027:"},{"line_number":302,"context_line":"                defaultset.append(parsedrule)"},{"line_number":303,"context_line":"            if tenantid \u003d\u003d tenant:"},{"line_number":304,"context_line":"                tenantset.append(parsedrule)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_b106e81e","line":301,"in_reply_to":"fa98f980_db72c6e4","updated":"2014-09-01 17:53:25.000000000","message":"Done","commit_id":"c8476dc95baa1309b0343381f915fa202339906c"}]}
