)]}'
{"quantum/agent/linux/interface.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"71f790a89efc078cf5078b542473d4ad3f67d05b","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from quantum.agent.linux import ip_lib"},{"line_number":24,"context_line":"from quantum.agent.linux import ovs_lib"},{"line_number":25,"context_line":"from quantum.agent.linux import utils"},{"line_number":26,"context_line":"from quantum.common.exceptions import ClassNotFound"},{"line_number":27,"context_line":"from quantum.openstack.common import cfg"},{"line_number":28,"context_line":"from quantum.openstack.common import importutils"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FuuA%3D","line":26,"updated":"2012-08-15 19:42:51.000000000","message":"This is unnecessary since the exception is not really applicable to the code in this file.","commit_id":"7a1e2570ec7841e2dfc9b988506e3563b144c36f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"71f790a89efc078cf5078b542473d4ad3f67d05b","unresolved":false,"context_lines":[{"line_number":271,"context_line":"        try:"},{"line_number":272,"context_line":"            LOG.info(\"Loading Driver: %s\" % driver_provider)"},{"line_number":273,"context_line":"            plugin_klass \u003d importutils.import_class(driver_provider)"},{"line_number":274,"context_line":"        except ClassNotFound:"},{"line_number":275,"context_line":"            LOG.exception(\"Error loading driver\")"},{"line_number":276,"context_line":"            raise Exception(\"driver_provider not found.  You can install a \""},{"line_number":277,"context_line":"                            \"Driver with: pip install \u003cplugin-name\u003e\\n\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fut8%3D","line":274,"updated":"2012-08-15 19:42:51.000000000","message":"This except statement will never execute.  import_class() will only throw python\u0027s ImportError class not any one of the Quantum specific exceptions.  The default ImportError message should suffice, so consider removing the try/except.","commit_id":"7a1e2570ec7841e2dfc9b988506e3563b144c36f"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"71f790a89efc078cf5078b542473d4ad3f67d05b","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        except ClassNotFound:"},{"line_number":275,"context_line":"            LOG.exception(\"Error loading driver\")"},{"line_number":276,"context_line":"            raise Exception(\"driver_provider not found.  You can install a \""},{"line_number":277,"context_line":"                            \"Driver with: pip install \u003cplugin-name\u003e\\n\""},{"line_number":278,"context_line":"                            \"Example: pip install quantum-sample-driver\")"},{"line_number":279,"context_line":"        return plugin_klass(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FutE%3D","line":277,"updated":"2012-08-15 19:42:51.000000000","message":"I believe there are no plans to put drivers separately in PyPI. This could actually make troubleshooting more difficult as the implementer goes to look for a non-existent driver package.","commit_id":"7a1e2570ec7841e2dfc9b988506e3563b144c36f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":236,"context_line":"                for driver_set in"},{"line_number":237,"context_line":"                self.conf.meta_flavor_driver_mappings.split(\u0027,\u0027)]:"},{"line_number":238,"context_line":"            self.flavor_driver_map[flavor] \u003d\\"},{"line_number":239,"context_line":"                self._load_driver(driver_name)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def _get_driver_by_network_id(self, network_id):"},{"line_number":242,"context_line":"        network \u003d self.quantum.show_network(network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FsQ8%3D","line":239,"updated":"2012-08-20 05:52:54.000000000","message":"This sentence does not need to be fold. (In addition breaking a line with backslash is avoided in the community.)","commit_id":"49de7c1df5a0a68e4238109d2fb6f2819b521679"}]}