)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6694,"name":"rcurran","email":"rcurran@cisco.com","username":"rcurran"},"change_message_id":"e81dabb59c2f257841701361baa2d1ecaacec6b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit moves segment management from the ML2 plugin to"},{"line_number":10,"context_line":"the type manager in preparation for dynamic segment support."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: Blueprint ml2-type-driver-refactor"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I068b82369250d115ef91680f19e733ed9aa4659b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_e0ab191c","line":11,"updated":"2014-08-19 17:58:33.000000000","message":"Hi Arvind - since this patch moves a bunch of code from one module to another and not anything else can you just add another sentence or two on why this is required. (I know it\u0027s needed for dynamic segments but why the move.) Thanks.","commit_id":"9757504a18e98b7f41b64020574ddef8321e6e1f"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"214d131f528f25c287687c0910db1bc6deba6fcb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This commit moves segment management from the ML2 plugin to"},{"line_number":10,"context_line":"the type manager in preparation for dynamic segment support."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Partially implements: Blueprint ml2-type-driver-refactor"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I068b82369250d115ef91680f19e733ed9aa4659b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1abeadc6_d3aef084","line":11,"in_reply_to":"1abeadc6_e0ab191c","updated":"2014-08-19 20:14:36.000000000","message":"Done","commit_id":"9757504a18e98b7f41b64020574ddef8321e6e1f"}],"neutron/plugins/ml2/managers.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3bda96e577316394e93769b4d7c6ca47803f1d3f","unresolved":false,"context_lines":[{"line_number":120,"context_line":"            value \u003d None"},{"line_number":121,"context_line":"        return value"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def _extend_network_dict_provider(self, context, network):"},{"line_number":124,"context_line":"        id \u003d network[\u0027id\u0027]"},{"line_number":125,"context_line":"        segments \u003d db.get_network_segments(context.session, id)"},{"line_number":126,"context_line":"        if not segments:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_aa7964c9","line":123,"updated":"2014-08-23 20:01:26.000000000","message":"(suggestion only) This method is called outside from TypeManager, so it is better to remove the underscore at the beginning of the method name. It can be done in a later patch.","commit_id":"169f88d38a2ca86ab43c567cf80c8ab6d60d7280"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"3f44a60d83049d9434eae4545b08f9f21c306fe2","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        id \u003d network[\u0027id\u0027]"},{"line_number":125,"context_line":"        segments \u003d db.get_network_segments(context.session, id)"},{"line_number":126,"context_line":"        if not segments:"},{"line_number":127,"context_line":"            LOG.error(_(\"Network %s has no segments\"), id)"},{"line_number":128,"context_line":"            network[provider.NETWORK_TYPE] \u003d None"},{"line_number":129,"context_line":"            network[provider.PHYSICAL_NETWORK] \u003d None"},{"line_number":130,"context_line":"            network[provider.SEGMENTATION_ID] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_2f647eb7","line":127,"updated":"2014-08-24 14:31:06.000000000","message":"Please use _LE to log error","commit_id":"169f88d38a2ca86ab43c567cf80c8ab6d60d7280"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"58000aee2e619922748b59a4b47472728056aa7d","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        id \u003d network[\u0027id\u0027]"},{"line_number":125,"context_line":"        segments \u003d db.get_network_segments(context.session, id)"},{"line_number":126,"context_line":"        if not segments:"},{"line_number":127,"context_line":"            LOG.error(_(\"Network %s has no segments\"), id)"},{"line_number":128,"context_line":"            network[provider.NETWORK_TYPE] \u003d None"},{"line_number":129,"context_line":"            network[provider.PHYSICAL_NETWORK] \u003d None"},{"line_number":130,"context_line":"            network[provider.SEGMENTATION_ID] \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_2f1e3e70","line":127,"in_reply_to":"1abeadc6_2f647eb7","updated":"2014-08-25 03:18:14.000000000","message":"Irena, I think the intent of this patch is to just move the existing code, without making any changes to it. It might be best to update all of ML2 logging to use _LE, etc., via a separate patch.","commit_id":"169f88d38a2ca86ab43c567cf80c8ab6d60d7280"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"4387a6289493a3c09b3f44d632400cd44a41c717","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                  fanout\u003dFalse)"},{"line_number":143,"context_line":"        return self.conn.consume_in_threads()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _extend_network_dict_provider(self, context, network):"},{"line_number":146,"context_line":"        id \u003d network[\u0027id\u0027]"},{"line_number":147,"context_line":"        segments \u003d db.get_network_segments(context.session, id)"},{"line_number":148,"context_line":"        if not segments:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_ffd1f357","line":145,"updated":"2014-08-19 18:34:04.000000000","message":"Would it make sense to have this function call a function on the TypeManager, or just move this function to the TypeManager? I think doing so would eliminate the need to import providernet and multiprovidernet in this module.","commit_id":"9757504a18e98b7f41b64020574ddef8321e6e1f"},{"author":{"_account_id":107,"name":"Arvind Somya","email":"arvind.somya@gmail.com","username":"asomya"},"change_message_id":"214d131f528f25c287687c0910db1bc6deba6fcb","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                  fanout\u003dFalse)"},{"line_number":143,"context_line":"        return self.conn.consume_in_threads()"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def _extend_network_dict_provider(self, context, network):"},{"line_number":146,"context_line":"        id \u003d network[\u0027id\u0027]"},{"line_number":147,"context_line":"        segments \u003d db.get_network_segments(context.session, id)"},{"line_number":148,"context_line":"        if not segments:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_b3917454","line":145,"in_reply_to":"1abeadc6_ffd1f357","updated":"2014-08-19 20:14:36.000000000","message":"I\u0027ll move it to the type manager.","commit_id":"9757504a18e98b7f41b64020574ddef8321e6e1f"}]}
