)]}'
{"neutron/plugins/common/constants.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"400de570735995399e80b03aa5635d0f0aa4c68c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Special return value for an invalid OVS ofport"},{"line_number":86,"context_line":"INVALID_OFPORT \u003d \u0027-1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_99dcd21a","line":86,"updated":"2014-08-26 00:07:07.000000000","message":"I\u0027m not sure why we are letting this OVS specific detail leak out.  Seems that the constant should be local ovs_lib module.","commit_id":"3b5ea01d5d42b500f027181ecae1ab1b3dae8ed7"},{"author":{"_account_id":5164,"name":"jsimms","email":"justin.simms@gmail.com","username":"jsimms"},"change_message_id":"92d18dd7ca1186302198e19081c146c04d3456de","unresolved":false,"context_lines":[{"line_number":83,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Special return value for an invalid OVS ofport"},{"line_number":86,"context_line":"INVALID_OFPORT \u003d \u0027-1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_c4b3ace7","line":86,"in_reply_to":"1abeadc6_0a49428b","updated":"2014-08-26 13:15:18.000000000","message":"OVS specific constants should live in the ovs_lib. Network constants which can apply to any lib should live in the neutron constants module. \n\nWhat I was asking for originally was that neutron be able to have an agent run when sub-modules were not available (like OVS).","commit_id":"3b5ea01d5d42b500f027181ecae1ab1b3dae8ed7"},{"author":{"_account_id":12857,"name":"Prasoon Telang","email":"prasoontelang@gmail.com","username":"prasoon"},"change_message_id":"3e78e458d448bc59d61206c2af068e118115f6e1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"# Special return value for an invalid OVS ofport"},{"line_number":86,"context_line":"INVALID_OFPORT \u003d \u0027-1\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_0a49428b","line":86,"in_reply_to":"1abeadc6_99dcd21a","updated":"2014-08-26 02:32:04.000000000","message":"Hi, so shall I move them to ovs_lib.py and change the import in the rest of the code for these constants from ovs_lib?\nI had thought about that but I was not sure if it was ok to do so.","commit_id":"3b5ea01d5d42b500f027181ecae1ab1b3dae8ed7"}],"neutron/plugins/openvswitch/common/constants.py":[{"author":{"_account_id":5164,"name":"jsimms","email":"justin.simms@gmail.com","username":"jsimms"},"change_message_id":"9ed9933363c22c2f8519066f46df89522f956b43","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TUNNEL \u003d \u0027tunnel\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Values for network_type"},{"line_number":26,"context_line":"VXLAN_UDP_PORT \u003d p_const.VXLAN_UDP_PORT"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Name prefixes for veth device or patch port pair linking the integration"},{"line_number":29,"context_line":"# bridge with the physical bridge for a physical network"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_e6d35536","line":26,"updated":"2014-08-19 03:20:29.000000000","message":"Was this a constant that was specific to openvswitch? If so, does moving it into neutrino\u0027s constants really solve the problem of coupling between the two namespaces?","commit_id":"d81a1ac23425bfe4c580de56271f17e3cb7443d6"},{"author":{"_account_id":5164,"name":"jsimms","email":"justin.simms@gmail.com","username":"jsimms"},"change_message_id":"9ed9933363c22c2f8519066f46df89522f956b43","unresolved":false,"context_lines":[{"line_number":64,"context_line":"DEFAULT_OVSDBMON_RESPAWN \u003d 30"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"# Special return value for an invalid OVS ofport"},{"line_number":67,"context_line":"INVALID_OFPORT \u003d p_const.INVALID_OFPORT"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Represent invalid OF Port"},{"line_number":70,"context_line":"OFPORT_INVALID \u003d -1"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_26de2d40","line":67,"updated":"2014-08-19 03:20:29.000000000","message":"Was this a constant that was specific to openvswitch? If so, does moving it into neutrino\u0027s constants really solve the problem of coupling between the two namespaces?","commit_id":"d81a1ac23425bfe4c580de56271f17e3cb7443d6"}]}