)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"62936b40d54e0c940fbb025cc51f66deec72eac9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In Mixin callback class approach, RPC versioning depends on"},{"line_number":12,"context_line":"each plugin implementation and it makes harder to maintain"},{"line_number":13,"context_line":"RPC version appropriately. This patch series replaces mixin"},{"line_number":14,"context_line":"PRC callback of server side with a separate class."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit handles dhcp-agent RPC callback."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_dca873dd","line":14,"updated":"2014-08-21 14:51:47.000000000","message":"nit: RPC instead of PRC","commit_id":"a983d55983b23a61909ea29b0f2cfdac9c5bef6b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d782a2f3bf6789f8081ddf3ee93da845124cf4ad","unresolved":false,"context_lines":[{"line_number":11,"context_line":"In Mixin callback class approach, RPC versioning depends on"},{"line_number":12,"context_line":"each plugin implementation and it makes harder to maintain"},{"line_number":13,"context_line":"RPC version appropriately. This patch series replaces mixin"},{"line_number":14,"context_line":"PRC callback of server side with a separate class."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit handles dhcp-agent RPC callback."},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_e9370afd","line":14,"in_reply_to":"1abeadc6_dca873dd","updated":"2014-08-22 14:11:32.000000000","message":"Done. I sometimes misspell RPC this way :-(","commit_id":"a983d55983b23a61909ea29b0f2cfdac9c5bef6b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"62936b40d54e0c940fbb025cc51f66deec72eac9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RPC version appropriately. This patch series replaces mixin"},{"line_number":14,"context_line":"PRC callback of server side with a separate class."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit handles dhcp-agent RPC callback."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1359416"},{"line_number":19,"context_line":"Change-Id: Ifb2a1bc0b7971995aae2856c9d4cd88c6dbc22d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_9c3efb8a","line":16,"updated":"2014-08-21 14:51:47.000000000","message":"I think \u0027dhcp-agent\u0027 here is confusing since this is the server side callback. Maybe just:\n\nThis commit handles DHCP RPC callback.","commit_id":"a983d55983b23a61909ea29b0f2cfdac9c5bef6b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d782a2f3bf6789f8081ddf3ee93da845124cf4ad","unresolved":false,"context_lines":[{"line_number":13,"context_line":"RPC version appropriately. This patch series replaces mixin"},{"line_number":14,"context_line":"PRC callback of server side with a separate class."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This commit handles dhcp-agent RPC callback."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Partial-Bug: #1359416"},{"line_number":19,"context_line":"Change-Id: Ifb2a1bc0b7971995aae2856c9d4cd88c6dbc22d6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_89769604","line":16,"in_reply_to":"1abeadc6_9c3efb8a","updated":"2014-08-22 14:11:32.000000000","message":"This is the interface related to dhcp-agent not to DHCP itself. I will reword it to \"server-side callback of dhcp-agent RPC interface\".","commit_id":"a983d55983b23a61909ea29b0f2cfdac9c5bef6b"}],"neutron/db/dhcp_rpc_base.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"595110c4c418474f2b44d5fafcad69727c9f3499","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class DhcpRpcCallback(n_rpc.RpcCallback):"},{"line_number":34,"context_line":"    \"\"\"DHCP agent RPC callback in plugin implementations.\"\"\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    # API version history:"},{"line_number":37,"context_line":"    #     1.0 - Initial version."}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_923d7fbe","line":34,"updated":"2014-08-26 08:34:51.000000000","message":"It would be great to see this module in neutron.rpc.server_callbacks!\n\nwhat do you reckon?","commit_id":"3e23072c621e38bb937e6d1a0d8c8633179b1d9e"}],"neutron/tests/unit/test_dhcp_rpc.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"eb35eef432e2c9188720a2f882008f540e3dc9fc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.plugin \u003d mock.MagicMock()"},{"line_number":32,"context_line":"        get_plugin.return_value \u003d self.plugin"},{"line_number":33,"context_line":"        self.callbacks \u003d dhcp_rpc.DhcpRpcCallback()"},{"line_number":34,"context_line":"        self.log_p \u003d mock.patch(\u0027neutron.db.dhcp_rpc.LOG\u0027)"},{"line_number":35,"context_line":"        self.log \u003d self.log_p.start()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_get_active_networks(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_4e9a3764","line":34,"updated":"2014-08-27 05:47:26.000000000","message":"Woops! It should be \"neutron.api.rpc.handlers.dhcp_rpc\"","commit_id":"f4ea5ae6597dc99d6bdd9e6f2993468958a69e4c"}]}