)]}'
{"neutron/db/firewall/firewall_db.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"60a8ac9409bca605a5e29f57fa7d60312cf043d5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            firewall_rule_id\u003dfwrule_id,"},{"line_number":194,"context_line":"                            firewall_policy_id\u003dfwp_db[\u0027id\u0027])"},{"line_number":195,"context_line":"                elif fwp_db[\u0027shared\u0027] and not rules_dict[fwrule_id][\u0027shared\u0027]:"},{"line_number":196,"context_line":"                    raise firewall.FirewallPolicySharedConflict("},{"line_number":197,"context_line":"                        firewall_rule_id\u003dfwrule_id,"},{"line_number":198,"context_line":"                        firewall_policy_id\u003dfwp_db[\u0027id\u0027])"},{"line_number":199,"context_line":"            # New list of rules is valid so we will first reset the existing"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_9deda7f2","line":196,"updated":"2014-08-25 19:23:09.000000000","message":"Would prefer 192 and 196 to be a different exception, maybe:\n\n  FirewallRuleSharingException","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"8cb71e27b1a6e79d8ba4e18234acac9dfca43996","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                            firewall_rule_id\u003dfwrule_id,"},{"line_number":194,"context_line":"                            firewall_policy_id\u003dfwp_db[\u0027id\u0027])"},{"line_number":195,"context_line":"                elif fwp_db[\u0027shared\u0027] and not rules_dict[fwrule_id][\u0027shared\u0027]:"},{"line_number":196,"context_line":"                    raise firewall.FirewallPolicySharedConflict("},{"line_number":197,"context_line":"                        firewall_rule_id\u003dfwrule_id,"},{"line_number":198,"context_line":"                        firewall_policy_id\u003dfwp_db[\u0027id\u0027])"},{"line_number":199,"context_line":"            # New list of rules is valid so we will first reset the existing"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_98692328","line":196,"in_reply_to":"1abeadc6_9deda7f2","updated":"2014-08-26 07:36:21.000000000","message":"Done","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"60a8ac9409bca605a5e29f57fa7d60312cf043d5","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    rules_in_db \u003d fwp_db[\u0027firewall_rules\u0027]"},{"line_number":324,"context_line":"                    for fwr_db in rules_in_db:"},{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_007cd071","line":326,"updated":"2014-08-25 19:23:09.000000000","message":"I would recommend creating a different exception and calling it:\n\n  FirewallPolicySharingException","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"8cb71e27b1a6e79d8ba4e18234acac9dfca43996","unresolved":false,"context_lines":[{"line_number":323,"context_line":"                    rules_in_db \u003d fwp_db[\u0027firewall_rules\u0027]"},{"line_number":324,"context_line":"                    for fwr_db in rules_in_db:"},{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_83e61815","line":326,"in_reply_to":"1abeadc6_007cd071","updated":"2014-08-26 07:36:21.000000000","message":"Done","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"60a8ac9409bca605a5e29f57fa7d60312cf043d5","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":330,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"},{"line_number":331,"context_line":"                del fwp[\u0027firewall_rules\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c0e81819","line":328,"updated":"2014-08-25 19:23:09.000000000","message":"Suggest refactoring 320 to 328 in a separate method.","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"7cc9ea85cb2993c15db257c20c7819fcfd4b04f6","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":330,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"},{"line_number":331,"context_line":"                del fwp[\u0027firewall_rules\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_6424460d","line":328,"in_reply_to":"1abeadc6_61af01e4","updated":"2014-08-28 07:04:03.000000000","message":"Done","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"62fbc6525269284e2a720b874b219f6ca6c32a9f","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":330,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"},{"line_number":331,"context_line":"                del fwp[\u0027firewall_rules\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_61af01e4","line":328,"in_reply_to":"1abeadc6_639e5c58","updated":"2014-08-27 08:52:25.000000000","message":"Though it is used once here, in future there may a need for separate method. Kindly go for another method.\n\n+1 sumit.","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"8cb71e27b1a6e79d8ba4e18234acac9dfca43996","unresolved":false,"context_lines":[{"line_number":325,"context_line":"                        if not fwr_db[\u0027shared\u0027]:"},{"line_number":326,"context_line":"                            raise firewall.FirewallPolicySharedConflict("},{"line_number":327,"context_line":"                                firewall_rule_id\u003dfwr_db[\u0027id\u0027],"},{"line_number":328,"context_line":"                                firewall_policy_id\u003did)"},{"line_number":329,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":330,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"},{"line_number":331,"context_line":"                del fwp[\u0027firewall_rules\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_639e5c58","line":328,"in_reply_to":"1abeadc6_c0e81819","updated":"2014-08-26 07:36:21.000000000","message":"this logic is used only once here. if it is used again, we can move this to a function.","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"961ee9e82aaf38e7122d6ead714e1bb107b92514","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            fwp_db.firewall_rules.reorder()"},{"line_number":207,"context_line":"            fwp_db.audited \u003d False"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _check_unshared_rules_for_policy(fwp_db, fwp):"},{"line_number":210,"context_line":"        if fwp[\u0027shared\u0027]:"},{"line_number":211,"context_line":"            rules_in_db \u003d fwp_db[\u0027firewall_rules\u0027]"},{"line_number":212,"context_line":"            for fwr_db in rules_in_db:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_6e095730","line":209,"updated":"2014-08-29 03:24:22.000000000","message":"def _check_unshared_rules_for_policy(self, fwp_db, fwp):","commit_id":"a6e076c8674070d4bfcbf7fc2dd7bfc14f258cda"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"e97dad4806edf62895327e94a45894c47bec232a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            fwp_db.firewall_rules.reorder()"},{"line_number":207,"context_line":"            fwp_db.audited \u003d False"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def _check_unshared_rules_for_policy(fwp_db, fwp):"},{"line_number":210,"context_line":"        if fwp[\u0027shared\u0027]:"},{"line_number":211,"context_line":"            rules_in_db \u003d fwp_db[\u0027firewall_rules\u0027]"},{"line_number":212,"context_line":"            for fwr_db in rules_in_db:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_4f9537e3","line":209,"in_reply_to":"1abeadc6_6e095730","updated":"2014-09-01 05:10:09.000000000","message":"Done","commit_id":"a6e076c8674070d4bfcbf7fc2dd7bfc14f258cda"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"92835a9a3ce8181f28e8aaf730fb4702c902ce11","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":334,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":335,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":336,"context_line":"            #check any existing rules are not shared"},{"line_number":337,"context_line":"            if (\u0027shared\u0027 in fwp) and (\u0027firewall_rules\u0027 not in fwp):"},{"line_number":338,"context_line":"                self._check_unshared_rules_for_policy(fwp_db, fwp)"},{"line_number":339,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_fae30b03","line":336,"updated":"2014-09-01 05:46:38.000000000","message":"put a space after #","commit_id":"8810161f221ffd2b9daa5d9a93dfa284c731ba19"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"13fef360f810c482f14633b3138b517a6c96b44e","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        fwp \u003d firewall_policy[\u0027firewall_policy\u0027]"},{"line_number":334,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":335,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":336,"context_line":"            #check any existing rules are not shared"},{"line_number":337,"context_line":"            if (\u0027shared\u0027 in fwp) and (\u0027firewall_rules\u0027 not in fwp):"},{"line_number":338,"context_line":"                self._check_unshared_rules_for_policy(fwp_db, fwp)"},{"line_number":339,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_9a359f48","line":336,"in_reply_to":"fa98f980_fae30b03","updated":"2014-09-01 06:01:01.000000000","message":"Done","commit_id":"8810161f221ffd2b9daa5d9a93dfa284c731ba19"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e769d77852f965890c495199831b9ea53e7ec7c","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":335,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":336,"context_line":"            # check any existing rules are not shared"},{"line_number":337,"context_line":"            if (\u0027shared\u0027 in fwp) and (\u0027firewall_rules\u0027 not in fwp):"},{"line_number":338,"context_line":"                self._check_unshared_rules_for_policy(fwp_db, fwp)"},{"line_number":339,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":340,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_d275f598","line":337,"updated":"2014-09-02 15:28:40.000000000","message":"both () are not required in the if condition","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"aa4f42673bb2553337a6066b6b278a14517f1f4a","unresolved":false,"context_lines":[{"line_number":334,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":335,"context_line":"            fwp_db \u003d self._get_firewall_policy(context, id)"},{"line_number":336,"context_line":"            # check any existing rules are not shared"},{"line_number":337,"context_line":"            if (\u0027shared\u0027 in fwp) and (\u0027firewall_rules\u0027 not in fwp):"},{"line_number":338,"context_line":"                self._check_unshared_rules_for_policy(fwp_db, fwp)"},{"line_number":339,"context_line":"            elif \u0027firewall_rules\u0027 in fwp:"},{"line_number":340,"context_line":"                self._set_rules_for_policy(context, fwp_db, fwp)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_7398acc0","line":337,"in_reply_to":"fa98f980_d275f598","updated":"2014-09-03 09:35:33.000000000","message":"Done","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"}],"neutron/extensions/firewall.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"9b6e5b42116217087d347bf3d8be0e2c7b312cba","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    \"\"\"FWaaS exception for firewall rules"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    When shared policy is careated or updated with unshared rules,"},{"line_number":62,"context_line":"    this exception will be raised."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    message \u003d _(\"Operation cannot be performed since Firewall Policy \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_f9d2bd5a","line":61,"updated":"2014-09-03 10:24:41.000000000","message":"nit: created spelling.","commit_id":"555e4282fabf410ed7d37b65e7addd8d70628291"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"b8a105fdbad6ce99661e759930210b933c65acf8","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    \"\"\"FWaaS exception for firewall rules"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    When shared policy is careated or updated with unshared rules,"},{"line_number":62,"context_line":"    this exception will be raised."},{"line_number":63,"context_line":"    \"\"\""},{"line_number":64,"context_line":"    message \u003d _(\"Operation cannot be performed since Firewall Policy \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_9b67c54c","line":61,"in_reply_to":"fa98f980_f9d2bd5a","updated":"2014-09-04 05:46:04.000000000","message":"Done","commit_id":"555e4282fabf410ed7d37b65e7addd8d70628291"}],"neutron/tests/unit/db/firewall/test_db_firewall.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"60a8ac9409bca605a5e29f57fa7d60312cf043d5","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":550,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def test_update_firewall_policy_with_shared_attr(self):"},{"line_number":553,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"},{"line_number":554,"context_line":"            fw_rule_ids \u003d [fr[\u0027firewall_rule\u0027][\u0027id\u0027]]"},{"line_number":555,"context_line":"            with self.firewall_policy(shared\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_c0b9f8ed","line":552,"updated":"2014-08-25 19:23:09.000000000","message":"test_update_firewall_policy_with_shared_attr_existing_unshared_rule","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"8cb71e27b1a6e79d8ba4e18234acac9dfca43996","unresolved":false,"context_lines":[{"line_number":549,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":550,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":551,"context_line":""},{"line_number":552,"context_line":"    def test_update_firewall_policy_with_shared_attr(self):"},{"line_number":553,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"},{"line_number":554,"context_line":"            fw_rule_ids \u003d [fr[\u0027firewall_rule\u0027][\u0027id\u0027]]"},{"line_number":555,"context_line":"            with self.firewall_policy(shared\u003dFalse,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_833e1828","line":552,"in_reply_to":"1abeadc6_c0b9f8ed","updated":"2014-08-26 07:36:21.000000000","message":"Done","commit_id":"0f1654cae7cc48678ba6a4a4d85918e4dccb476d"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e769d77852f965890c495199831b9ea53e7ec7c","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            res \u003d self._create_firewall_policy("},{"line_number":354,"context_line":"                None, \u0027firewall_policy1\u0027, description\u003dDESCRIPTION, shared\u003dTrue,"},{"line_number":355,"context_line":"                firewall_rules\u003dfw_rule_ids, audited\u003dAUDITED)"},{"line_number":356,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def test_show_firewall_policy(self):"},{"line_number":359,"context_line":"        name \u003d \"firewall_policy1\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_12f5bded","line":356,"updated":"2014-09-02 15:28:40.000000000","message":"the correct pattern is: self.assertEqual(expected, observed), you should reverse both arguments","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"aa4f42673bb2553337a6066b6b278a14517f1f4a","unresolved":false,"context_lines":[{"line_number":353,"context_line":"            res \u003d self._create_firewall_policy("},{"line_number":354,"context_line":"                None, \u0027firewall_policy1\u0027, description\u003dDESCRIPTION, shared\u003dTrue,"},{"line_number":355,"context_line":"                firewall_rules\u003dfw_rule_ids, audited\u003dAUDITED)"},{"line_number":356,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"    def test_show_firewall_policy(self):"},{"line_number":359,"context_line":"        name \u003d \"firewall_policy1\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_b33214f0","line":356,"in_reply_to":"fa98f980_12f5bded","updated":"2014-09-03 09:35:33.000000000","message":"Done","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e769d77852f965890c495199831b9ea53e7ec7c","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":539,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":540,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":541,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def test_update_firewall_policy_with_shared_attr_unshared_rule(self):"},{"line_number":544,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_72d9a982","line":541,"updated":"2014-09-02 15:28:40.000000000","message":"itto","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"aa4f42673bb2553337a6066b6b278a14517f1f4a","unresolved":false,"context_lines":[{"line_number":538,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":539,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":540,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":541,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    def test_update_firewall_policy_with_shared_attr_unshared_rule(self):"},{"line_number":544,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_73434c42","line":541,"in_reply_to":"fa98f980_72d9a982","updated":"2014-09-03 09:35:33.000000000","message":"Done","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e769d77852f965890c495199831b9ea53e7ec7c","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":551,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":552,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":553,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def test_update_firewall_policy_with_shared_attr_exist_unshare_rule(self):"},{"line_number":556,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_b2e31132","line":553,"updated":"2014-09-02 15:28:40.000000000","message":"ditto","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"aa4f42673bb2553337a6066b6b278a14517f1f4a","unresolved":false,"context_lines":[{"line_number":550,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":551,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":552,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":553,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"    def test_update_firewall_policy_with_shared_attr_exist_unshare_rule(self):"},{"line_number":556,"context_line":"        with self.firewall_rule(name\u003d\u0027fwr1\u0027, shared\u003dFalse) as fr:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f3765ca3","line":553,"in_reply_to":"fa98f980_b2e31132","updated":"2014-09-03 09:35:33.000000000","message":"Done","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"0e769d77852f965890c495199831b9ea53e7ec7c","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":563,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":564,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":565,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_delete_firewall_policy(self):"},{"line_number":568,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_52c5858c","line":565,"updated":"2014-09-02 15:28:40.000000000","message":"...","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"},{"author":{"_account_id":11614,"name":"Koteswara Rao Kelam","email":"koteswara.kelam@hp.com","username":"koteswar"},"change_message_id":"aa4f42673bb2553337a6066b6b278a14517f1f4a","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                req \u003d self.new_update_request(\u0027firewall_policies\u0027, data,"},{"line_number":563,"context_line":"                                              fwp[\u0027firewall_policy\u0027][\u0027id\u0027])"},{"line_number":564,"context_line":"                res \u003d req.get_response(self.ext_api)"},{"line_number":565,"context_line":"                self.assertEqual(res.status_int, 409)"},{"line_number":566,"context_line":""},{"line_number":567,"context_line":"    def test_delete_firewall_policy(self):"},{"line_number":568,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_137cc082","line":565,"in_reply_to":"fa98f980_52c5858c","updated":"2014-09-03 09:35:33.000000000","message":"Done","commit_id":"c333d64b7b6af58f5d3216fe5b0e4f2251f110ce"}]}