)]}'
{"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":940,"context_line":"            try:"},{"line_number":941,"context_line":"                # TODO(salv-orlando): Provide bulk API for retrieving"},{"line_number":942,"context_line":"                # details for all devices in one call"},{"line_number":943,"context_line":"                devices_details_list.append("},{"line_number":944,"context_line":"                    self.plugin_rpc.get_device_details("},{"line_number":945,"context_line":"                        self.context, device, self.agent_id))"},{"line_number":946,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_bd2fafa6","line":943,"updated":"2014-09-17 11:58:51.000000000","message":"Could use list comprehension vs for loop.\n    device_details_list \u003d [self.plugin_rpc.get_device_details(\n        self.context, d, self.agent_id) for d in devices]","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":951,"context_line":""},{"line_number":952,"context_line":"        for details in devices_details_list:"},{"line_number":953,"context_line":"            device \u003d details[\u0027device\u0027]"},{"line_number":954,"context_line":"            LOG.debug(_(\"Processing port %s\"), device)"},{"line_number":955,"context_line":"            port \u003d self.int_br.get_vif_port_by_id(device)"},{"line_number":956,"context_line":"            if not port:"},{"line_number":957,"context_line":"                # The port disappeared and cannot be processed"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_fd3937f3","line":954,"updated":"2014-09-17 11:58:51.000000000","message":"No i18n translation on debug logs.","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":955,"context_line":"            port \u003d self.int_br.get_vif_port_by_id(device)"},{"line_number":956,"context_line":"            if not port:"},{"line_number":957,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":958,"context_line":"                LOG.info(_(\"Port %s was not found on the integration bridge \""},{"line_number":959,"context_line":"                           \"and will therefore not be processed\"), device)"},{"line_number":960,"context_line":"                skipped_devices.append(device)"},{"line_number":961,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_7d2d47a8","line":958,"updated":"2014-09-17 11:58:51.000000000","message":"Can use _LI() hint here.","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":994,"context_line":"            try:"},{"line_number":995,"context_line":"                # TODO(salv-orlando): Provide bulk API for retrieving"},{"line_number":996,"context_line":"                # details for all devices in one call"},{"line_number":997,"context_line":"                devices_details_list.append("},{"line_number":998,"context_line":"                    self.plugin_rpc.get_device_details("},{"line_number":999,"context_line":"                        self.context, device, self.agent_id))"},{"line_number":1000,"context_line":"            except Exception as e:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_48119f52","line":997,"updated":"2014-09-17 11:58:51.000000000","message":"Same here on using list comprehension. Also, can the duplication here and L939-950 be extracted to function and removed?","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":1005,"context_line":""},{"line_number":1006,"context_line":"        for details in devices_details_list:"},{"line_number":1007,"context_line":"            device \u003d details[\u0027device\u0027]"},{"line_number":1008,"context_line":"            LOG.info(_(\"Ancillary Port %s added\"), device)"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":"            # update plugin about port status"},{"line_number":1011,"context_line":"            self.plugin_rpc.update_device_up(self.context,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_680e6334","line":1008,"updated":"2014-09-17 11:58:51.000000000","message":"_LI() hint.","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"            try:"},{"line_number":1080,"context_line":"                skipped_devices \u003d self.treat_devices_added_or_updated("},{"line_number":1081,"context_line":"                    devices_added_updated)"},{"line_number":1082,"context_line":"                LOG.debug(_(\"process_network_ports - \""},{"line_number":1083,"context_line":"                            \"treat_devices_added_or_updated completed. \""},{"line_number":1084,"context_line":"                            \"Skipped %(num_skipped)d devices of \""},{"line_number":1085,"context_line":"                            \"%(num_current)d devices currently available. \""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_a8184b76","line":1082,"updated":"2014-09-17 11:58:51.000000000","message":"remove i18n for debug log.","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"89270d62b5c5e471023af985566a7f595c199444","unresolved":false,"context_lines":[{"line_number":1110,"context_line":"            start \u003d time.time()"},{"line_number":1111,"context_line":"            try:"},{"line_number":1112,"context_line":"                self.treat_ancillary_devices_added(port_info[\u0027added\u0027])"},{"line_number":1113,"context_line":"                LOG.debug(_(\"process_ancillary_network_ports - \""},{"line_number":1114,"context_line":"                            \"treat_ancillary_devices_added \""},{"line_number":1115,"context_line":"                            \"completed in %(elapsed).3f\"),"},{"line_number":1116,"context_line":"                          {\u0027elapsed\u0027: time.time() - start})"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_285b7b2f","line":1113,"updated":"2014-09-17 11:58:51.000000000","message":"remove i18n","commit_id":"3c44da1a968d157eeea7677b39d5d9f9d84365c7"}]}