)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"32c499bc2716be553c6e918b7618ac7f0df676a8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    - Automatic topology discovery"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Implements blueprint: apic-driver-enhancements"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I4264afe5c140c3576951c1a5a28a8d7666481147"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_f57fc2a8","line":13,"updated":"2014-08-23 15:04:21.000000000","message":"There are multiple authors in the files, you add them here rather than in the files.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"}],"etc/neutron/plugins/ml2/ml2_conf_cisco.ini":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"32c499bc2716be553c6e918b7618ac7f0df676a8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# apic_function_profile\u003dopenstack_function"},{"line_number":75,"context_line":"# apic_app_profile_name\u003dopenstack_app"},{"line_number":76,"context_line":"# Agent timers for State reporting and topology discovery"},{"line_number":77,"context_line":"# apic_agent_report_interval\u003d30"},{"line_number":78,"context_line":"# apic_agent_poll_interval\u003d2"},{"line_number":79,"context_line":"# apic_sync_interval \u003d 30"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"1abeadc6_f5fa6241","line":77,"updated":"2014-08-23 15:04:21.000000000","message":"can you give some space between key and values.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"# apic_function_profile\u003dopenstack_function"},{"line_number":75,"context_line":"# apic_app_profile_name\u003dopenstack_app"},{"line_number":76,"context_line":"# Agent timers for State reporting and topology discovery"},{"line_number":77,"context_line":"# apic_agent_report_interval\u003d30"},{"line_number":78,"context_line":"# apic_agent_poll_interval\u003d2"},{"line_number":79,"context_line":"# apic_sync_interval \u003d 30"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"1abeadc6_732561ad","line":77,"in_reply_to":"1abeadc6_f5fa6241","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e0eb2994a53828408b4bdc0815fd30f2961f16b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fa98f980_f8ba4909","updated":"2014-08-30 21:19:58.000000000","message":"i guess nothing has changed here except formatting (note to other reviewers)","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"}],"neutron/plugins/ml2/drivers/cisco/apic/apic_sync.py":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"32c499bc2716be553c6e918b7618ac7f0df676a8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.driver.create_network_postcommit(mech_context)"},{"line_number":66,"context_line":"            except Exception:"},{"line_number":67,"context_line":"                LOG.warn((\"Create network postcommit failed for\""},{"line_number":68,"context_line":"                          \" network %s\"), network[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Sync Subnets"},{"line_number":71,"context_line":"        for subnet in self.core_plugin.get_subnets(ctx):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_759e5208","line":68,"updated":"2014-08-23 15:04:21.000000000","message":"you can use LOG.warn(_LW()). Can you check this once.\nditto for all Warns.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.driver.create_network_postcommit(mech_context)"},{"line_number":66,"context_line":"            except Exception:"},{"line_number":67,"context_line":"                LOG.warn((\"Create network postcommit failed for\""},{"line_number":68,"context_line":"                          \" network %s\"), network[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Sync Subnets"},{"line_number":71,"context_line":"        for subnet in self.core_plugin.get_subnets(ctx):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_98be9ad3","line":68,"in_reply_to":"1abeadc6_23d65f28","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"                self.driver.create_network_postcommit(mech_context)"},{"line_number":66,"context_line":"            except Exception:"},{"line_number":67,"context_line":"                LOG.warn((\"Create network postcommit failed for\""},{"line_number":68,"context_line":"                          \" network %s\"), network[\u0027id\u0027])"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        # Sync Subnets"},{"line_number":71,"context_line":"        for subnet in self.core_plugin.get_subnets(ctx):"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_23d65f28","line":68,"in_reply_to":"1abeadc6_759e5208","updated":"2014-08-24 02:57:42.000000000","message":"+1.Need i18n for all log levels, except debug.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"f0979baa584391caa8f4e3d628cd654c317d4130","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def sync(self, f, *args, **kwargs):"},{"line_number":38,"context_line":"        \"\"\"Fire synchronization based on interval."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        Interval can be 0 for \u0027sync once\u0027 \u003e0 for \u0027sync periodically\u0027 and"},{"line_number":41,"context_line":"        \u003c0 for \u0027no sync\u0027"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        if self.interval:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_c5254f0b","line":40,"updated":"2014-08-27 01:09:15.000000000","message":"See my comment in the config.py file - it applies here as well.","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"68d8073e09da9bb2d006f0f137196bcdf90c6ace","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def sync(self, f, *args, **kwargs):"},{"line_number":38,"context_line":"        \"\"\"Fire synchronization based on interval."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        Interval can be 0 for \u0027sync once\u0027 \u003e0 for \u0027sync periodically\u0027 and"},{"line_number":41,"context_line":"        \u003c0 for \u0027no sync\u0027"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        if self.interval:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_405e8dea","line":40,"in_reply_to":"1abeadc6_c5254f0b","updated":"2014-08-27 01:22:40.000000000","message":"See answer to your comment in config.py","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"},{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"f0979baa584391caa8f4e3d628cd654c317d4130","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def _sync_base(self):"},{"line_number":60,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":61,"context_line":"        # Sync Networks"},{"line_number":62,"context_line":"        for network in self.core_plugin.get_networks(ctx):"},{"line_number":63,"context_line":"            mech_context \u003d driver_context.NetworkContext(self.core_plugin, ctx,"},{"line_number":64,"context_line":"                                                         network)"},{"line_number":65,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_25bfe3ab","line":62,"updated":"2014-08-27 01:09:15.000000000","message":"Looks like this is one way sync. \nWhat happens if the resources (e.g. networks) are in backend (apic), but, not in the core DB? How do you remove those? \nI would have thought you will get the resources from back-end and compare them with the ones in the DB and push which is missing and delete which is not needed.","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"68d8073e09da9bb2d006f0f137196bcdf90c6ace","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def _sync_base(self):"},{"line_number":60,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":61,"context_line":"        # Sync Networks"},{"line_number":62,"context_line":"        for network in self.core_plugin.get_networks(ctx):"},{"line_number":63,"context_line":"            mech_context \u003d driver_context.NetworkContext(self.core_plugin, ctx,"},{"line_number":64,"context_line":"                                                         network)"},{"line_number":65,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_a515b34a","line":62,"in_reply_to":"1abeadc6_25bfe3ab","updated":"2014-08-27 01:22:40.000000000","message":"You are right, this sync is only meant to be one way for now.\nThe \"way back\" synchronization will be handled in a different changeset or in the backend library itself if possible.","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e0eb2994a53828408b4bdc0815fd30f2961f16b2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        Interval can be 0 for \u0027sync once\u0027 \u003e0 for \u0027sync periodically\u0027 and"},{"line_number":41,"context_line":"        \u003c0 for \u0027no sync\u0027"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        if self.interval:"},{"line_number":44,"context_line":"            if self.interval \u003e 0:"},{"line_number":45,"context_line":"                loop_call \u003d loopingcall.FixedIntervalLoopingCall(f, *args,"},{"line_number":46,"context_line":"                                                                 **kwargs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_d8f025cc","line":43,"updated":"2014-08-30 21:19:58.000000000","message":"why not just:\n\n    if self.interval \u003e 0:","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"5c5e12bfe510788d71413e3f531749195d1fcf86","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        Interval can be 0 for \u0027sync once\u0027 \u003e0 for \u0027sync periodically\u0027 and"},{"line_number":41,"context_line":"        \u003c0 for \u0027no sync\u0027"},{"line_number":42,"context_line":"        \"\"\""},{"line_number":43,"context_line":"        if self.interval:"},{"line_number":44,"context_line":"            if self.interval \u003e 0:"},{"line_number":45,"context_line":"                loop_call \u003d loopingcall.FixedIntervalLoopingCall(f, *args,"},{"line_number":46,"context_line":"                                                                 **kwargs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_9b405737","line":43,"in_reply_to":"fa98f980_d8f025cc","updated":"2014-08-30 22:36:12.000000000","message":"Done","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e0eb2994a53828408b4bdc0815fd30f2961f16b2","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            except Exception:"},{"line_number":91,"context_line":"                LOG.warn(_LW(\"Create port postcommit failed for\""},{"line_number":92,"context_line":"                             \" port %s\"), port[\u0027id\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class ApicRouterSynchronizer(SynchronizerBase):"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_78b019f5","line":93,"updated":"2014-08-30 21:19:58.000000000","message":"in all these cases its okay to just warn? is it the assumption that a subsequent sync will resolve any inconsistencies?","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"5c5e12bfe510788d71413e3f531749195d1fcf86","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            except Exception:"},{"line_number":91,"context_line":"                LOG.warn(_LW(\"Create port postcommit failed for\""},{"line_number":92,"context_line":"                             \" port %s\"), port[\u0027id\u0027])"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class ApicRouterSynchronizer(SynchronizerBase):"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_fb47a349","line":93,"in_reply_to":"fa98f980_78b019f5","updated":"2014-08-30 22:36:12.000000000","message":"yes. Being these existing (and therefore validated) objects on the Neutron side, the reason for having an exception (bugs aside) is that the APIC controller is momentarily not reachable","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"}],"neutron/plugins/ml2/drivers/cisco/apic/apic_topology.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.apic_manager \u003d ma.APICMechanismDriver.get_apic_manager(False)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def init_host(self):"},{"line_number":79,"context_line":"        LOG.info(_(\"APIC service agent starting ...\"))"},{"line_number":80,"context_line":"        self.state \u003d {"},{"line_number":81,"context_line":"            \u0027binary\u0027: BINARY_APIC_SERVICE_AGENT,"},{"line_number":82,"context_line":"            \u0027host\u0027: self.host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_83df3339","line":79,"updated":"2014-08-24 02:57:42.000000000","message":"So you can use _LI() for info logs, _LE for error, _LW for warn.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.apic_manager \u003d ma.APICMechanismDriver.get_apic_manager(False)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def init_host(self):"},{"line_number":79,"context_line":"        LOG.info(_(\"APIC service agent starting ...\"))"},{"line_number":80,"context_line":"        self.state \u003d {"},{"line_number":81,"context_line":"            \u0027binary\u0027: BINARY_APIC_SERVICE_AGENT,"},{"line_number":82,"context_line":"            \u0027host\u0027: self.host,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_58f88249","line":79,"in_reply_to":"1abeadc6_83df3339","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def report_send(self, context):"},{"line_number":99,"context_line":"        if not self.state_agent:"},{"line_number":100,"context_line":"            return"},{"line_number":101,"context_line":"        LOG.debug(_(\"APIC service agent: sending report state\"))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            self.state_agent.report_state(context, self.state)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a3e98fe7","line":101,"updated":"2014-08-24 02:57:42.000000000","message":"No i18n on debug logs though.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    def report_send(self, context):"},{"line_number":99,"context_line":"        if not self.state_agent:"},{"line_number":100,"context_line":"            return"},{"line_number":101,"context_line":"        LOG.debug(_(\"APIC service agent: sending report state\"))"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            self.state_agent.report_state(context, self.state)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_f8006e37","line":101,"in_reply_to":"1abeadc6_a3e98fe7","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # ignore it"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        except Exception:"},{"line_number":111,"context_line":"            LOG.exception(_(\"APIC service agent: failed in reporting state\"))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @lockutils.synchronized(\u0027apic_service\u0027)"},{"line_number":114,"context_line":"    def update_link(self, context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_23bd7fd8","line":111,"updated":"2014-08-24 02:57:42.000000000","message":"I think this is _LC()","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            # ignore it"},{"line_number":109,"context_line":"            return"},{"line_number":110,"context_line":"        except Exception:"},{"line_number":111,"context_line":"            LOG.exception(_(\"APIC service agent: failed in reporting state\"))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @lockutils.synchronized(\u0027apic_service\u0027)"},{"line_number":114,"context_line":"    def update_link(self, context,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_b8e6f6e6","line":111,"in_reply_to":"1abeadc6_23bd7fd8","updated":"2014-08-25 17:18:12.000000000","message":"Apparently that\u0027s log_critical. I don\u0027t see any specific i18n for log exception","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                    curr_peers.pop(interface)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            # Any interface still in curr_peers need to be deleted"},{"line_number":251,"context_line":"            for interface in curr_peers:"},{"line_number":252,"context_line":"                peer \u003d curr_peers[interface]"},{"line_number":253,"context_line":"                self.service_agent.update_link("},{"line_number":254,"context_line":"                    context, peer[0], peer[1], None, 0, 0, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_a3d0af1f","line":251,"updated":"2014-08-24 02:57:42.000000000","message":"Could do...\n    for peer in curr_peers.values():\nor\n    for peer in curr_peers.itervalues():\n\nSame for L236-237","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                    curr_peers.pop(interface)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"            # Any interface still in curr_peers need to be deleted"},{"line_number":251,"context_line":"            for interface in curr_peers:"},{"line_number":252,"context_line":"                peer \u003d curr_peers[interface]"},{"line_number":253,"context_line":"                self.service_agent.update_link("},{"line_number":254,"context_line":"                    context, peer[0], peer[1], None, 0, 0, 0)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_d88732d6","line":251,"in_reply_to":"1abeadc6_a3d0af1f","updated":"2014-08-25 17:18:12.000000000","message":"Don in this line, in L236-237 I use the key to check curr_peers","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"}],"neutron/plugins/ml2/drivers/cisco/apic/config.py":[{"author":{"_account_id":6558,"name":"Sukhdev Kapur","email":"sukhdevkapur@gmail.com","username":"sukhdev-8"},"change_message_id":"f0979baa584391caa8f4e3d628cd654c317d4130","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027,"},{"line_number":82,"context_line":"               default\u003dDEFAULT_ROOT_HELPER,"},{"line_number":83,"context_line":"               help\u003d_(\"Setup root helper as rootwrap or sudo\")),"},{"line_number":84,"context_line":"    cfg.IntOpt(\u0027apic_sync_interval\u0027,"},{"line_number":85,"context_line":"               default\u003d0,"},{"line_number":86,"context_line":"               help\u003d_(\"Synchronization interval in seconds\")),"},{"line_number":87,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_054907d0","line":84,"updated":"2014-08-27 01:09:15.000000000","message":"Why would you want to sync only once? Is the intent only to sync when neutron restart and never afterwards. \n\nWhat happens if the back-end resets and looses the data? \nThis does not seem to be robust solution - but, I may be missing the intent and reason behind it. If that is the case, feel free to ignore my comment.","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"68d8073e09da9bb2d006f0f137196bcdf90c6ace","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    cfg.StrOpt(\u0027root_helper\u0027,"},{"line_number":82,"context_line":"               default\u003dDEFAULT_ROOT_HELPER,"},{"line_number":83,"context_line":"               help\u003d_(\"Setup root helper as rootwrap or sudo\")),"},{"line_number":84,"context_line":"    cfg.IntOpt(\u0027apic_sync_interval\u0027,"},{"line_number":85,"context_line":"               default\u003d0,"},{"line_number":86,"context_line":"               help\u003d_(\"Synchronization interval in seconds\")),"},{"line_number":87,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_005575c5","line":84,"in_reply_to":"1abeadc6_054907d0","updated":"2014-08-27 01:22:40.000000000","message":"The synchronization may be a very expansive operation for large deployments. Therefore, as you said, I\u0027m giving the admin the freedom to choose whether he wants to sync only when the service starts or periodically.\n\nThe next step would be to enable \"on demand\" synchronization once ML2 extensions get in place.","commit_id":"02b9035db19acf6f0bc7249ef89d50a499b45a00"}],"neutron/plugins/ml2/drivers/cisco/apic/mechanism_apic.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def sync_init(f):"},{"line_number":79,"context_line":"        def inner(inst, *args, **kwargs):"},{"line_number":80,"context_line":"            if not inst.synchronizer:"},{"line_number":81,"context_line":"                inst.synchronizer \u003d \\"},{"line_number":82,"context_line":"                    APICMechanismDriver.get_base_synchronizer(inst)"},{"line_number":83,"context_line":"                inst.synchronizer.sync_base()"},{"line_number":84,"context_line":"            return f(inst, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_43a7dbbc","line":81,"updated":"2014-08-24 02:57:42.000000000","message":"use parens vs backslash for line continuation.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def sync_init(f):"},{"line_number":79,"context_line":"        def inner(inst, *args, **kwargs):"},{"line_number":80,"context_line":"            if not inst.synchronizer:"},{"line_number":81,"context_line":"                inst.synchronizer \u003d \\"},{"line_number":82,"context_line":"                    APICMechanismDriver.get_base_synchronizer(inst)"},{"line_number":83,"context_line":"                inst.synchronizer.sync_base()"},{"line_number":84,"context_line":"            return f(inst, *args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_9864da4a","line":81,"in_reply_to":"1abeadc6_43a7dbbc","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e0eb2994a53828408b4bdc0815fd30f2961f16b2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        apic_config \u003d cfg.CONF.ml2_cisco_apic"},{"line_number":67,"context_line":"        return apic_sync.ApicRouterSynchronizer(inst,"},{"line_number":68,"context_line":"                                                apic_config.apic_sync_interval)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def initialize(self):"},{"line_number":71,"context_line":"        # initialize apic"},{"line_number":72,"context_line":"        self.apic_manager \u003d APICMechanismDriver.get_apic_manager()"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_78b579cc","line":69,"updated":"2014-08-30 21:19:58.000000000","message":"any particular reason this is being done here and not in the l3_apic?","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"5c5e12bfe510788d71413e3f531749195d1fcf86","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        apic_config \u003d cfg.CONF.ml2_cisco_apic"},{"line_number":67,"context_line":"        return apic_sync.ApicRouterSynchronizer(inst,"},{"line_number":68,"context_line":"                                                apic_config.apic_sync_interval)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def initialize(self):"},{"line_number":71,"context_line":"        # initialize apic"},{"line_number":72,"context_line":"        self.apic_manager \u003d APICMechanismDriver.get_apic_manager()"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_5b6eefca","line":69,"in_reply_to":"fa98f980_78b579cc","updated":"2014-08-30 22:36:12.000000000","message":"Just wanted to import this module alone on l3_apic plugin :)","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"}],"neutron/services/l3_router/l3_apic.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"e0eb2994a53828408b4bdc0815fd30f2961f16b2","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    def get_routers(self, *args, **kwargs):"},{"line_number":152,"context_line":"        return super(ApicL3ServicePlugin, self).get_routers(*args, **kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @sync_init"},{"line_number":155,"context_line":"    def get_routers_count(self, *args, **kwargs):"},{"line_number":156,"context_line":"        return super(ApicL3ServicePlugin, self).get_routers_count(*args,"},{"line_number":157,"context_line":"                                                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_d8dae516","line":154,"updated":"2014-08-30 21:19:58.000000000","message":"is this required for the getters?","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"5c5e12bfe510788d71413e3f531749195d1fcf86","unresolved":false,"context_lines":[{"line_number":151,"context_line":"    def get_routers(self, *args, **kwargs):"},{"line_number":152,"context_line":"        return super(ApicL3ServicePlugin, self).get_routers(*args, **kwargs)"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @sync_init"},{"line_number":155,"context_line":"    def get_routers_count(self, *args, **kwargs):"},{"line_number":156,"context_line":"        return super(ApicL3ServicePlugin, self).get_routers_count(*args,"},{"line_number":157,"context_line":"                                                                  **kwargs)"}],"source_content_type":"text/x-python","patch_set":13,"id":"fa98f980_9b6777ea","line":154,"in_reply_to":"fa98f980_d8dae516","updated":"2014-08-30 22:36:12.000000000","message":"it\u0027s nice because you get the synchronization initialized even with a simple GET instead of running a noop update.","commit_id":"95f7a654e9e3e7b153ce84b2df7e54ee4801c198"}],"neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_sync.py":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"d07a9da15c6b66d5b308e7421f852edd4974ba26","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Ivar Lazzaro (ivarlazzaro@gmail.com), Cisco Systems, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sys.modules[\"apicapi\"] \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_e825e4ae","line":18,"updated":"2014-08-26 09:17:58.000000000","message":"nit: mock is not part of stdlib in python2\n http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"cf7f6170fdda0fd8416f85c8e7925751e97bf8ee"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"291fa05eabfb58f223bea296a0a0231df0e4cfed","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: Ivar Lazzaro (ivarlazzaro@gmail.com), Cisco Systems, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sys.modules[\"apicapi\"] \u003d mock.Mock()"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_6e72aa12","line":18,"in_reply_to":"1abeadc6_e825e4ae","updated":"2014-08-26 17:32:42.000000000","message":"will fix here and other tests as well on next rebase","commit_id":"cf7f6170fdda0fd8416f85c8e7925751e97bf8ee"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"268898d68dc7f12abecaa2f15637ce5af2f6fc47","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sys.modules[\"apicapi\"] \u003d mock.Mock()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import apic_sync"},{"line_number":24,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_f675ac32","line":21,"updated":"2014-08-26 19:40:10.000000000","message":"I\u0027m not sure myself will it work after change so I\u0027ll look forward to results.","commit_id":"cf7f6170fdda0fd8416f85c8e7925751e97bf8ee"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"d07a9da15c6b66d5b308e7421f852edd4974ba26","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sys.modules[\"apicapi\"] \u003d mock.Mock()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import apic_sync"},{"line_number":24,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_0804e013","line":21,"updated":"2014-08-26 09:17:58.000000000","message":"nit: Does this need to be in this place instead of under imports ?","commit_id":"cf7f6170fdda0fd8416f85c8e7925751e97bf8ee"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"291fa05eabfb58f223bea296a0a0231df0e4cfed","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"sys.modules[\"apicapi\"] \u003d mock.Mock()"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.plugins.ml2.drivers.cisco.apic import apic_sync"},{"line_number":24,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":5,"id":"1abeadc6_4e4ecec2","line":21,"in_reply_to":"1abeadc6_0804e013","updated":"2014-08-26 17:32:42.000000000","message":"I think I need to mock before apic_sync is imported (and apicapi with it). I\u0027ll try though.","commit_id":"cf7f6170fdda0fd8416f85c8e7925751e97bf8ee"}],"neutron/tests/unit/ml2/drivers/cisco/apic/test_cisco_apic_topology_agent.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"e6fbdf2fab3c92e23ba31adf749458b50734055c","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                mocked.APIC_EXT_MODULE, mocked.APIC_EXT_PORT)"},{"line_number":84,"context_line":"        self.service.update_link(None, *args)"},{"line_number":85,"context_line":"        self.service.apic_manager.add_hostlink.assert_called_once_with(*args)"},{"line_number":86,"context_line":"        self.assertEqual("},{"line_number":87,"context_line":"            self.service.peers["},{"line_number":88,"context_line":"                (mocked.SERVICE_HOST, mocked.SERVICE_HOST_IFACE)], args)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_c3920b56","line":86,"updated":"2014-08-24 02:57:42.000000000","message":"order args expected, actual. Check other places.","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"},{"author":{"_account_id":7987,"name":"Ivar Lazzaro","email":"ivarlazzaro@gmail.com","username":"Ivar"},"change_message_id":"7ad4e7a39ff60c8ff025be2518b210bb9f92f7e6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                mocked.APIC_EXT_MODULE, mocked.APIC_EXT_PORT)"},{"line_number":84,"context_line":"        self.service.update_link(None, *args)"},{"line_number":85,"context_line":"        self.service.apic_manager.add_hostlink.assert_called_once_with(*args)"},{"line_number":86,"context_line":"        self.assertEqual("},{"line_number":87,"context_line":"            self.service.peers["},{"line_number":88,"context_line":"                (mocked.SERVICE_HOST, mocked.SERVICE_HOST_IFACE)], args)"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_38e4a6ab","line":86,"in_reply_to":"1abeadc6_c3920b56","updated":"2014-08-25 17:18:12.000000000","message":"Done","commit_id":"0488fa6b48ce02543501adee5eaa89e07204ffc7"}]}
