)]}'
{"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"050dc761a671506d5bf5b47e671c6d0d2184a80c","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                                         \"set_tunnel:%s,output:%s\" %"},{"line_number":480,"context_line":"                                         (segmentation_id, ofports))"},{"line_number":481,"context_line":"                else:"},{"line_number":482,"context_line":"                    # drop all packets if none destination tunnel is up."},{"line_number":483,"context_line":"                    # this flow will be modified by _setup_tunnel_port when any"},{"line_number":484,"context_line":"                    # new tunnel port is up."},{"line_number":485,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_79e1cdcf","line":482,"updated":"2014-08-25 14:55:27.000000000","message":"nit: none -\u003e no","commit_id":"40a9bc0504907e7f90d6157c497effd6b2a393d0"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"050dc761a671506d5bf5b47e671c6d0d2184a80c","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    # drop all packets if none destination tunnel is up."},{"line_number":483,"context_line":"                    # this flow will be modified by _setup_tunnel_port when any"},{"line_number":484,"context_line":"                    # new tunnel port is up."},{"line_number":485,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":486,"context_line":"                                         priority\u003d1,"},{"line_number":487,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":488,"context_line":"                                         actions\u003d\"drop\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_8e949ce9","line":485,"updated":"2014-08-25 14:55:27.000000000","message":"can you add some detail in the comment to explain why this drop flow is needed","commit_id":"40a9bc0504907e7f90d6157c497effd6b2a393d0"},{"author":{"_account_id":7170,"name":"Zang MingJie","email":"zealot0630@gmail.com","username":"zealot"},"change_message_id":"2141ee479c26495dd3332c8f90b8c4916d2b3eb1","unresolved":false,"context_lines":[{"line_number":482,"context_line":"                    # drop all packets if none destination tunnel is up."},{"line_number":483,"context_line":"                    # this flow will be modified by _setup_tunnel_port when any"},{"line_number":484,"context_line":"                    # new tunnel port is up."},{"line_number":485,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":486,"context_line":"                                         priority\u003d1,"},{"line_number":487,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":488,"context_line":"                                         actions\u003d\"drop\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_e51fd959","line":485,"in_reply_to":"1abeadc6_8e949ce9","updated":"2014-08-26 02:28:32.000000000","message":"I think it is already explained clearly by the comment. the following mod-flow needs an origin flow, which is this one","commit_id":"40a9bc0504907e7f90d6157c497effd6b2a393d0"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"59766a3aa87834a5502ad3c2797a65d74bee222b","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                # outbound broadcast/multicast"},{"line_number":473,"context_line":"                ofports \u003d \u0027,\u0027.join(self.tun_br_ofports[network_type].values())"},{"line_number":474,"context_line":"                if ofports:"},{"line_number":475,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":476,"context_line":"                                         priority\u003d1,"},{"line_number":477,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":478,"context_line":"                                         actions\u003d\"strip_vlan,\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_d7378efd","line":475,"updated":"2014-09-11 08:10:32.000000000","message":"What\u0027s the difference between using add flow and mod-flow.\n\nCould you detail what are the consequences of using mod-flow in the launchpad bug?.\n\nGenerally a bug details the consequences, but we only have detail of the solution.","commit_id":"b32d27f5e821d460d2cce00f97eb91da8114e4db"},{"author":{"_account_id":7170,"name":"Zang MingJie","email":"zealot0630@gmail.com","username":"zealot"},"change_message_id":"3b36414f87aedd99cce2171f501e3faf218b9d5f","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                # outbound broadcast/multicast"},{"line_number":473,"context_line":"                ofports \u003d \u0027,\u0027.join(self.tun_br_ofports[network_type].values())"},{"line_number":474,"context_line":"                if ofports:"},{"line_number":475,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":476,"context_line":"                                         priority\u003d1,"},{"line_number":477,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":478,"context_line":"                                         actions\u003d\"strip_vlan,\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_ec1e846f","line":475,"in_reply_to":"fa98f980_370d3a3f","updated":"2014-09-11 09:17:24.000000000","message":"if from cold start, all flows is deleted inside `setup_tunnel_br`, and `reclaim_local_vlan` also delete the rule @L578","commit_id":"b32d27f5e821d460d2cce00f97eb91da8114e4db"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"04dba82f93db8d6a0b73ec05b9c2dc72415f5bca","unresolved":false,"context_lines":[{"line_number":472,"context_line":"                # outbound broadcast/multicast"},{"line_number":473,"context_line":"                ofports \u003d \u0027,\u0027.join(self.tun_br_ofports[network_type].values())"},{"line_number":474,"context_line":"                if ofports:"},{"line_number":475,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":476,"context_line":"                                         priority\u003d1,"},{"line_number":477,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":478,"context_line":"                                         actions\u003d\"strip_vlan,\""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_370d3a3f","line":475,"in_reply_to":"fa98f980_d7378efd","updated":"2014-09-11 09:08:30.000000000","message":"If we\u0027re using add, don\u0027t we need to check that the rule isn\u0027t already present? I suppose provision_local_vlan is only called once, and the rule gets removed if the vlan is released.","commit_id":"b32d27f5e821d460d2cce00f97eb91da8114e4db"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d04e732ec0dd52ae30a9489720d307749755e52c","unresolved":false,"context_lines":[{"line_number":490,"context_line":"                # outbound broadcast/multicast"},{"line_number":491,"context_line":"                ofports \u003d \u0027,\u0027.join(self.tun_br_ofports[network_type].values())"},{"line_number":492,"context_line":"                if ofports:"},{"line_number":493,"context_line":"                    self.tun_br.add_flow(table\u003dconstants.FLOOD_TO_TUN,"},{"line_number":494,"context_line":"                                         priority\u003d1,"},{"line_number":495,"context_line":"                                         dl_vlan\u003dlvid,"},{"line_number":496,"context_line":"                                         actions\u003d\"strip_vlan,\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_6647bd1d","line":493,"updated":"2015-01-08 08:36:49.000000000","message":"The addition of the priority seems like an unrelated change. Right now I see that flows are added without priority, and the first first (Drop flow) has priority 0. Does it matter if the added flows have a priority of 1, is there any impact whatsoever? Why did you add it?","commit_id":"9e4ff5171b9536cbc46ab92fb3b7588e7a861089"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4fc9d77d2152b7a22719c93f71b66080952ed448","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                         actions\u003d\"strip_vlan,\""},{"line_number":497,"context_line":"                                         \"set_tunnel:%s,output:%s\" %"},{"line_number":498,"context_line":"                                         (segmentation_id, ofports))"},{"line_number":499,"context_line":"                else:"},{"line_number":500,"context_line":"                    # drop all packets if no destination tunnel is up. this"},{"line_number":501,"context_line":"                    # flow will be modified by _setup_tunnel_port when any new"},{"line_number":502,"context_line":"                    # tunnel port is up."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_4342b33e","line":499,"updated":"2015-01-08 07:43:07.000000000","message":"This seems unnecessary. If there is no tunnel setup, aren\u0027t we just dropping the packets anyway?","commit_id":"9e4ff5171b9536cbc46ab92fb3b7588e7a861089"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d04e732ec0dd52ae30a9489720d307749755e52c","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                                         actions\u003d\"strip_vlan,\""},{"line_number":497,"context_line":"                                         \"set_tunnel:%s,output:%s\" %"},{"line_number":498,"context_line":"                                         (segmentation_id, ofports))"},{"line_number":499,"context_line":"                else:"},{"line_number":500,"context_line":"                    # drop all packets if no destination tunnel is up. this"},{"line_number":501,"context_line":"                    # flow will be modified by _setup_tunnel_port when any new"},{"line_number":502,"context_line":"                    # tunnel port is up."}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_06c8b9a6","line":499,"in_reply_to":"3a961159_4342b33e","updated":"2015-01-08 08:36:49.000000000","message":"Please see line 855. Zang MingJie, can you explain what the else clause is for?","commit_id":"9e4ff5171b9536cbc46ab92fb3b7588e7a861089"}]}
