)]}'
{"neutron/plugins/vmware/plugins/base.py":[{"author":{"_account_id":12857,"name":"Prasoon Telang","email":"prasoontelang@gmail.com","username":"prasoon"},"change_message_id":"f086fd5484ddebbfe92242e8e60144e8c710595d","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"        except Exception as e:"},{"line_number":1315,"context_line":"            # This implies that the port does not exist in the NSX database."},{"line_number":1316,"context_line":"            # we can now proceed to try deleting it from Neutron\u0027s database."},{"line_number":1317,"context_line":"            LOG.debug((\"Port %s does not exist on the NSX config. Error: %s\""},{"line_number":1318,"context_line":"                %(id, e)))"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_127441fc","line":1317,"updated":"2014-08-31 16:20:30.000000000","message":"In my opinion, the log message should be of type info instead of debug. I feel the logging for such an event is required during the operations.","commit_id":"a00c324945fe3dbfd9a1fc199f1bc5b5f62149bd"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0e749be11f25dbc8524837b36618288a79f5dca1","unresolved":false,"context_lines":[{"line_number":1311,"context_line":""},{"line_number":1312,"context_line":"        try:"},{"line_number":1313,"context_line":"            port_delete_func(context, neutron_db_port)"},{"line_number":1314,"context_line":"        except Exception as e:"},{"line_number":1315,"context_line":"            # This implies that the port does not exist in the NSX database."},{"line_number":1316,"context_line":"            # we can now proceed to try deleting it from Neutron\u0027s database."},{"line_number":1317,"context_line":"            LOG.debug((\"Port %s does not exist on the NSX config. Error: %s\""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_f0a4554c","line":1314,"updated":"2014-09-04 18:40:15.000000000","message":"Can we catch specific, \"expected\" exceptions, rather than a catch all Exception? This way, if something unexpected happens, we\u0027ll get a T/B.","commit_id":"acc1e303d80357c0986665cd122a89840c3cfd9c"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"ca155f3c01416c5aa1b33df399bb967cdc5ec43c","unresolved":false,"context_lines":[{"line_number":1314,"context_line":"        except Exception as e:"},{"line_number":1315,"context_line":"            # This implies that the port does not exist in the NSX database."},{"line_number":1316,"context_line":"            # we can now proceed to try deleting it from Neutron\u0027s database."},{"line_number":1317,"context_line":"            LOG.debug((\"Port %s does not exist on the NSX config. Error: %s\""},{"line_number":1318,"context_line":"                % (id, e)))"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_060e183b","line":1317,"updated":"2014-09-04 06:31:53.000000000","message":"Is that port deleted before. If so it can be handled there. Why you handle this here?","commit_id":"acc1e303d80357c0986665cd122a89840c3cfd9c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0e749be11f25dbc8524837b36618288a79f5dca1","unresolved":false,"context_lines":[{"line_number":1315,"context_line":"            # This implies that the port does not exist in the NSX database."},{"line_number":1316,"context_line":"            # we can now proceed to try deleting it from Neutron\u0027s database."},{"line_number":1317,"context_line":"            LOG.debug((\"Port %s does not exist on the NSX config. Error: %s\""},{"line_number":1318,"context_line":"                % (id, e)))"},{"line_number":1319,"context_line":""},{"line_number":1320,"context_line":"        self.disassociate_floatingips(context, id)"},{"line_number":1321,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_70478577","line":1318,"updated":"2014-09-04 18:40:15.000000000","message":"Three things... Don\u0027t need extra parens on string. Since multiple args, should use named formatting specifiers and dict. The log message could change context and lose the exception info. Use excutils.save_and_reraise_exception() with reraise\u003dFalse to preserve info.","commit_id":"acc1e303d80357c0986665cd122a89840c3cfd9c"}]}
