)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"8df12c7f24675cfc4432543909cdf2ee3b9f6227","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ext-gw update on dvr router improperly handled by l3-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recenlty added external_gateway method does not check"},{"line_number":10,"context_line":"the agent more or host binding before adding an external"},{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_eb4ed595","line":9,"updated":"2014-08-25 20:08:36.000000000","message":"spelling: recently.","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"bc434d26f3c6534b43787ebfbb5ad02b8cf3eaba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"ext-gw update on dvr router improperly handled by l3-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recenlty added external_gateway method does not check"},{"line_number":10,"context_line":"the agent more or host binding before adding an external"},{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_193e022a","line":9,"in_reply_to":"1abeadc6_eb4ed595","updated":"2014-08-26 00:09:15.000000000","message":"Done","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"8df12c7f24675cfc4432543909cdf2ee3b9f6227","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ext-gw update on dvr router improperly handled by l3-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recenlty added external_gateway method does not check"},{"line_number":10,"context_line":"the agent more or host binding before adding an external"},{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_4b5d0948","line":10,"updated":"2014-08-25 20:08:36.000000000","message":"Should \"more\" actually be \"node\"?","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"689a05f366b5725872d00e029f48da4f44852650","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ext-gw update on dvr router improperly handled by l3-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recenlty added external_gateway method does not check"},{"line_number":10,"context_line":"the agent more or host binding before adding an external"},{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_e651ac0f","line":10,"in_reply_to":"1abeadc6_4b5d0948","updated":"2014-08-25 20:11:29.000000000","message":"Oops, I mean \"mode\", not \"node\".","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"bc434d26f3c6534b43787ebfbb5ad02b8cf3eaba","unresolved":false,"context_lines":[{"line_number":7,"context_line":"ext-gw update on dvr router improperly handled by l3-agent"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The recenlty added external_gateway method does not check"},{"line_number":10,"context_line":"the agent more or host binding before adding an external"},{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_393bbe39","line":10,"in_reply_to":"1abeadc6_e651ac0f","updated":"2014-08-26 00:09:15.000000000","message":"Done","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5561ba3d7e3275b4b64c42ff5de1b3d9f77ac115","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch formerly was part of a larger patch here:"},{"line_number":15,"context_line":"https://review.openstack.org/#/c/114410"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Idbb76eea1faec1c5d6b7615d23d74760cc327bb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_a65174da","line":14,"updated":"2014-08-25 20:15:51.000000000","message":"I don\u0027t think this needs to be mention here.","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"bc434d26f3c6534b43787ebfbb5ad02b8cf3eaba","unresolved":false,"context_lines":[{"line_number":11,"context_line":"gateway to a particular node/agent.  This fix adds the"},{"line_number":12,"context_line":"required checks in the update path."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch formerly was part of a larger patch here:"},{"line_number":15,"context_line":"https://review.openstack.org/#/c/114410"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Idbb76eea1faec1c5d6b7615d23d74760cc327bb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1abeadc6_b92fcef5","line":14,"in_reply_to":"1abeadc6_a65174da","updated":"2014-08-26 00:09:15.000000000","message":"Done","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"}],"neutron/tests/unit/test_l3_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5561ba3d7e3275b4b64c42ff5de1b3d9f77ac115","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                                                    [\u002720.0.0.30/24\u0027],"},{"line_number":531,"context_line":"                                                    **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def test_ext_gw_updated_dvr_agent_mode(self):"},{"line_number":534,"context_line":"        router \u003d prepare_router_data(num_internal_ports\u003d2)"},{"line_number":535,"context_line":"        ri \u003d l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"},{"line_number":536,"context_line":"                                 self.conf.use_namespaces, router\u003drouter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_2673a4b2","line":533,"updated":"2014-08-25 20:15:51.000000000","message":"unless I am overlooking something, in my opinion this can become a util function that takes (host, agent_mode and expected_ext_gw_call_count); then three tests will become only a few lines of code.","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"bc434d26f3c6534b43787ebfbb5ad02b8cf3eaba","unresolved":false,"context_lines":[{"line_number":530,"context_line":"                                                    [\u002720.0.0.30/24\u0027],"},{"line_number":531,"context_line":"                                                    **kwargs)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def test_ext_gw_updated_dvr_agent_mode(self):"},{"line_number":534,"context_line":"        router \u003d prepare_router_data(num_internal_ports\u003d2)"},{"line_number":535,"context_line":"        ri \u003d l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"},{"line_number":536,"context_line":"                                 self.conf.use_namespaces, router\u003drouter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_b9934e4e","line":533,"in_reply_to":"1abeadc6_2673a4b2","updated":"2014-08-26 00:09:15.000000000","message":"Done","commit_id":"44e30a6408993a4a18152ca8e76aec4ffc350fa4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"aa5ce08f881516db8b1aad563b655d24911132da","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                                     \u0027fixed_ip_address\u0027: \u0027192.168.0.1\u0027,"},{"line_number":516,"context_line":"                                     \u0027port_id\u0027: _uuid()}]}"},{"line_number":517,"context_line":"        router[l3_constants.FLOATINGIP_KEY] \u003d fake_fip[\u0027floatingips\u0027]"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        agent.external_gateway_updated(ri, ex_gw_port,"},{"line_number":520,"context_line":"                                     interface_name)"},{"line_number":521,"context_line":"        self.assertEqual(self.mock_driver.plug.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4c41950a","line":518,"updated":"2014-08-26 04:01:37.000000000","message":"boo!  ;)","commit_id":"46f15d9b49e7e1fb56e84b4c4cd281def0ab885c"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"94a506b0721075022b688d10260b835c177a14e9","unresolved":false,"context_lines":[{"line_number":515,"context_line":"                                     \u0027fixed_ip_address\u0027: \u0027192.168.0.1\u0027,"},{"line_number":516,"context_line":"                                     \u0027port_id\u0027: _uuid()}]}"},{"line_number":517,"context_line":"        router[l3_constants.FLOATINGIP_KEY] \u003d fake_fip[\u0027floatingips\u0027]"},{"line_number":518,"context_line":""},{"line_number":519,"context_line":"        agent.external_gateway_updated(ri, ex_gw_port,"},{"line_number":520,"context_line":"                                     interface_name)"},{"line_number":521,"context_line":"        self.assertEqual(self.mock_driver.plug.call_count, 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_87dd3117","line":518,"in_reply_to":"1abeadc6_4c41950a","updated":"2014-08-26 15:30:53.000000000","message":"Thanks for finding and fixing Carl!","commit_id":"46f15d9b49e7e1fb56e84b4c4cd281def0ab885c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"57ef1ff7e3968a8983b6c10183a90703abf67029","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                                       interface_name)"},{"line_number":549,"context_line":"        # no gateway should be added on dvr node"},{"line_number":550,"context_line":"        self.assertEqual(expected_call_count,"},{"line_number":551,"context_line":"                         agent._external_gateway_added.called)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def test_ext_gw_updated_dvr_agent_mode(self):"},{"line_number":554,"context_line":"        # no gateway should be added on dvr node"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_69d643c7","line":551,"updated":"2014-08-26 03:44:23.000000000","message":"called is a bool, you\u0027d want call_count:\n\nhttps://docs.python.org/3/library/unittest.mock.html","commit_id":"46f15d9b49e7e1fb56e84b4c4cd281def0ab885c"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"94a506b0721075022b688d10260b835c177a14e9","unresolved":false,"context_lines":[{"line_number":548,"context_line":"                                       interface_name)"},{"line_number":549,"context_line":"        # no gateway should be added on dvr node"},{"line_number":550,"context_line":"        self.assertEqual(expected_call_count,"},{"line_number":551,"context_line":"                         agent._external_gateway_added.called)"},{"line_number":552,"context_line":""},{"line_number":553,"context_line":"    def test_ext_gw_updated_dvr_agent_mode(self):"},{"line_number":554,"context_line":"        # no gateway should be added on dvr node"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_a7b94dcd","line":551,"in_reply_to":"1abeadc6_69d643c7","updated":"2014-08-26 15:30:53.000000000","message":"blech!  good catch!  Thanks for finding it !","commit_id":"46f15d9b49e7e1fb56e84b4c4cd281def0ab885c"}]}