)]}'
{"neutron/common/ipv6_utils.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c72652a740c20b2e4b0dd4c18c998709b86e603c","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if _IS_IPV6_ENABLED is None:"},{"line_number":50,"context_line":"        disabled_ipv6_path \u003d \"/proc/sys/net/ipv6/conf/default/disable_ipv6\""},{"line_number":51,"context_line":"        if os.path.exists(disabled_ipv6_path):"},{"line_number":52,"context_line":"            with open(disabled_ipv6_path, \u0027r\u0027) as f:"},{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_6a745f9c","line":51,"updated":"2014-08-26 13:57:43.000000000","message":"If the path does not exist, do we want to fail silently or would logging a warning be a good idea to aid in troubleshooting?","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":1446,"name":"Bernhard M.","email":"bmwiedemann@zq1.de","username":"ubuntubmw","status":"dev at SUSE"},"change_message_id":"1f7e352ac4118bf3d8c80351d98493ed7904ca4a","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    if _IS_IPV6_ENABLED is None:"},{"line_number":50,"context_line":"        disabled_ipv6_path \u003d \"/proc/sys/net/ipv6/conf/default/disable_ipv6\""},{"line_number":51,"context_line":"        if os.path.exists(disabled_ipv6_path):"},{"line_number":52,"context_line":"            with open(disabled_ipv6_path, \u0027r\u0027) as f:"},{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_94ca9e4d","line":51,"in_reply_to":"1abeadc6_6a745f9c","updated":"2014-08-27 07:00:56.000000000","message":"It is not failing silently - just disabling some functionality that can not work without IPv6. And I\u0027m pretty sure that people needing this, would first try to add IPv6 addresses to the machine and notice that they can\u0027t - so no extra warning needed here.","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c72652a740c20b2e4b0dd4c18c998709b86e603c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if _IS_IPV6_ENABLED is None:"},{"line_number":50,"context_line":"        disabled_ipv6_path \u003d \"/proc/sys/net/ipv6/conf/default/disable_ipv6\""},{"line_number":51,"context_line":"        if os.path.exists(disabled_ipv6_path):"},{"line_number":52,"context_line":"            with open(disabled_ipv6_path, \u0027r\u0027) as f:"},{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_4a2fa388","line":52,"updated":"2014-08-26 13:57:43.000000000","message":"If this file exists, is it always guaranteed to be readable?  If not (e.g. permission problem), do we want to fail or catch the exception and disable ipv6 with a warning?","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5cfaad1bac6026813b36f7cf2f53e9fe512aa45a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if _IS_IPV6_ENABLED is None:"},{"line_number":50,"context_line":"        disabled_ipv6_path \u003d \"/proc/sys/net/ipv6/conf/default/disable_ipv6\""},{"line_number":51,"context_line":"        if os.path.exists(disabled_ipv6_path):"},{"line_number":52,"context_line":"            with open(disabled_ipv6_path, \u0027r\u0027) as f:"},{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_bc769c3c","line":52,"in_reply_to":"1abeadc6_4a2fa388","updated":"2014-08-27 09:20:39.000000000","message":"I think if we can\u0027t read it and this exists, it should probably just be an uncaught exception. If I can\u0027t tell what the file says, what would I return?","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":1446,"name":"Bernhard M.","email":"bmwiedemann@zq1.de","username":"ubuntubmw","status":"dev at SUSE"},"change_message_id":"1f7e352ac4118bf3d8c80351d98493ed7904ca4a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    if _IS_IPV6_ENABLED is None:"},{"line_number":50,"context_line":"        disabled_ipv6_path \u003d \"/proc/sys/net/ipv6/conf/default/disable_ipv6\""},{"line_number":51,"context_line":"        if os.path.exists(disabled_ipv6_path):"},{"line_number":52,"context_line":"            with open(disabled_ipv6_path, \u0027r\u0027) as f:"},{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""},{"line_number":55,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_74afc294","line":52,"in_reply_to":"1abeadc6_4a2fa388","updated":"2014-08-27 07:00:56.000000000","message":"If it exists, it should be readable and everything else would be (and thus trigger) an exception, so this part is good.","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"c72652a740c20b2e4b0dd4c18c998709b86e603c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":57,"context_line":"    return _IS_IPV6_ENABLED"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_2a6267d8","line":56,"updated":"2014-08-26 13:57:43.000000000","message":"Do we want to log a warning that ipv6 is disabled because of a lack of system support?","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"5cfaad1bac6026813b36f7cf2f53e9fe512aa45a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                disabled \u003d f.read().strip()"},{"line_number":54,"context_line":"            _IS_IPV6_ENABLED \u003d disabled \u003d\u003d \"0\""},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":57,"context_line":"    return _IS_IPV6_ENABLED"}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_fc3734ae","line":56,"in_reply_to":"1abeadc6_2a6267d8","updated":"2014-08-27 09:20:39.000000000","message":"I suppose so. Not really the bug this is addressing but it sounds like a good improvement.","commit_id":"ad113f8391df086a3a89d5cba3f14bd24444a0ca"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"74e700e493b1da3226c75d1415500e5762903dbb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":57,"context_line":"        if not _IS_IPV6_ENABLED:"},{"line_number":58,"context_line":"            LOG.info(_(\"IPv6 is not enabled on this system.\"))"},{"line_number":59,"context_line":"    return _IS_IPV6_ENABLED"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_5372c9e3","line":58,"updated":"2014-08-27 15:21:00.000000000","message":"You are missing an import for logging. And while you are at it, you should translate with _LI().","commit_id":"2c75d5c3cb7e8cc89ee74f673b65f04e3fb80c17"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"277a11bbb63f2f711e1fcf97ebd89708b9942f9f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            _IS_IPV6_ENABLED \u003d False"},{"line_number":57,"context_line":"        if not _IS_IPV6_ENABLED:"},{"line_number":58,"context_line":"            LOG.info(_(\"IPv6 is not enabled on this system.\"))"},{"line_number":59,"context_line":"    return _IS_IPV6_ENABLED"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_ac89f227","line":58,"in_reply_to":"1abeadc6_5372c9e3","updated":"2014-08-27 21:04:31.000000000","message":"Whoops. Forgot to run the full PEP8 job.","commit_id":"2c75d5c3cb7e8cc89ee74f673b65f04e3fb80c17"}]}