)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"a7bf85834bf6c2a2c8dc3abafeabcaa07f875ccf","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-08 11:14:15 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification following port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic2fd872725c1da8e2dc394473b7feb407d21268f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_af3f83d5","line":7,"updated":"2014-09-08 07:54:51.000000000","message":"Any explanation as for why is this change needed ?","commit_id":"1a2ac4f7cb2d7f79fdec2469dc01898bc25c78b2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"8ee6fa1d4740a1a080bd438b0318a63d5dd75995","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-08 11:14:15 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification following port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic2fd872725c1da8e2dc394473b7feb407d21268f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_ac48fcb3","line":7,"in_reply_to":"fa98f980_370e6535","updated":"2014-09-11 09:09:59.000000000","message":"I didn\u0027t actually wrote the code, I modified it. :) So, below is just my brief (mis)understanding.\n\nSo, most plugins are interested in updating L3 agent about port updates. Hence notifications.\n\nBut *some* plugins (like VMWare NSX [1]) do not actually use Neutron L3 agent, so they are not interested in notifications being sent thru MQ (f.e. see [2]).\n\nThat said, I don\u0027t know *anything* about brocade plugin, so I don\u0027t know whether anyone is really listening to those notifications in their setup; not being an expert in any way, and seeing that you\u0027re not either, I would recommend to ask someone from Brocade on the expected behaviour. Random changes like that are for no good for sure.\n\n[1]: http://blog.scottlowe.org/2014/03/12/learning-nsx-part-11-reviewing-openstack-integration-basics/\n[2]: https://review.openstack.org/#/c/101219","commit_id":"1a2ac4f7cb2d7f79fdec2469dc01898bc25c78b2"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"ca02edfff81ee6cd109d4ac30bd7e18028e34ffc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-08 11:14:15 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Send notification following port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic2fd872725c1da8e2dc394473b7feb407d21268f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"fa98f980_370e6535","line":7,"in_reply_to":"fa98f980_af3f83d5","updated":"2014-09-09 05:19:55.000000000","message":"Nope :)\n\nI just noticed that this piece of code didn\u0027t match similar examples elsewhere in neutron - and the bit that was missing was sending the notification.  If the notification expectations are described anywhere, I\u0027d be happy to refer to that in the description here - are they written down anywhere?\n\nI was hoping Ihar (who wrote this and the similar code in other modules) would chime in before now...","commit_id":"1a2ac4f7cb2d7f79fdec2469dc01898bc25c78b2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"116b6eb82c3e058442269cec65d086a15528b2d7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Angus Lees \u003cgus@inodes.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-09-15 13:21:16 +1000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Big Switch: Send notification following port update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ic2fd872725c1da8e2dc394473b7feb407d21268f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa98f980_de3cb495","line":7,"updated":"2014-09-15 08:22:39.000000000","message":"I think you should report a bug for that, and mention it here. Also, please add more details on the change.","commit_id":"2f419e04e28463f95fe7fe75d0dca8b006c69986"}]}
