)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3ec1f063553511472031718bcab8541644cb3d45","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Salvatore Orlando \u003csalv.orlando@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-08-29 12:16:05 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Subnets with prefix length 0 are invalid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the API behaviour to return a 400 error"},{"line_number":10,"context_line":"when a subnet with /0 prefix length is specified."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1abeadc6_bb42a60c","line":7,"updated":"2014-08-29 19:18:33.000000000","message":"Well this commit makes them invalid... :-)","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4995b35ac33e64b043bc3f245d4a9d5ed05fdb51","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Subnets with prefix length 0 are invalid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the API behaviour to return a 400 error"},{"line_number":10,"context_line":"when a subnet with /0 prefix length is specified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This kind of subnet hardly make any sense, and also cannot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_2fa63354","line":9,"updated":"2014-09-08 07:53:25.000000000","message":"Should doc team be notified with DocImpact?","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6b2ba55d39e2e65bf37cf0de34f403d80d313fe4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Subnets with prefix length 0 are invalid"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch changes the API behaviour to return a 400 error"},{"line_number":10,"context_line":"when a subnet with /0 prefix length is specified."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This kind of subnet hardly make any sense, and also cannot"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fa98f980_e2999220","line":9,"in_reply_to":"fa98f980_2fa63354","updated":"2014-09-08 15:19:00.000000000","message":"I don\u0027t think this strictly needed.","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b43ea8858122aa8d97ee6bbc627b8b5c331ba3a0","unresolved":false,"context_lines":[{"line_number":565,"context_line":"        \"\"\""},{"line_number":566,"context_line":"        new_subnet_ipset \u003d netaddr.IPSet([new_subnet_cidr])"},{"line_number":567,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":568,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":569,"context_line":"                err_msg \u003d (\"0 is an invalid CIDR prefix length\")"},{"line_number":570,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":571,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1abeadc6_6e96c1f1","line":568,"updated":"2014-08-28 22:37:52.000000000","message":"# NOTE: This check is here because of dnsmasq failures on /0. Nothing wrong with /0 networks.","commit_id":"60e20366e5378a3c3f510b71ae9417642c12a56a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"0765de59c67acd4f39c33e0c413aad40726b86b4","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d (\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        if cfg.CONF.allow_overlapping_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_9f1964d3","line":574,"updated":"2014-08-29 13:27:05.000000000","message":"(nit) i18n","commit_id":"03e4fc73efc71f165a3c797f7f54908e36fc38c0"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9b1f87d211725cc7e39a4ceee3020584ab3ee77b","unresolved":false,"context_lines":[{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d (\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        if cfg.CONF.allow_overlapping_ips:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_db97628e","line":574,"in_reply_to":"1abeadc6_9f1964d3","updated":"2014-08-29 19:15:08.000000000","message":"cool","commit_id":"03e4fc73efc71f165a3c797f7f54908e36fc38c0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7d0d5fa03600e95b434678b389b2d334ec1fbdbd","unresolved":false,"context_lines":[{"line_number":566,"context_line":"        new_subnet_ipset \u003d netaddr.IPSet([new_subnet_cidr])"},{"line_number":567,"context_line":"        # Disallow subnets with prefix length 0 as they will lead to"},{"line_number":568,"context_line":"        # dnsmasq failures (see bug 1362651)."},{"line_number":569,"context_line":"        # This is not a discrimination against /0 subnets."},{"line_number":570,"context_line":"        # A /0 subnet is conceptually possible but hardly a practical"},{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_c2369350","line":569,"updated":"2014-08-29 22:50:08.000000000","message":"This is a discrimination against the only one /0 subnet ... lonely subnet","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7d0d5fa03600e95b434678b389b2d334ec1fbdbd","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        # This is not a discrimination against /0 subnets."},{"line_number":570,"context_line":"        # A /0 subnet is conceptually possible but hardly a practical"},{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d _(\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1abeadc6_82681bf6","line":572,"updated":"2014-08-29 22:50:08.000000000","message":"iiuc, there is only one iteration (cidr \u003d\u003d IPNetwork(new_subnet_cidr)), using a for loop is to avoid computing IPNetwork(new_subnet_cidr)?","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2abfebd1666a04a7299b71e2bbccd3b30d590041","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        # This is not a discrimination against /0 subnets."},{"line_number":570,"context_line":"        # A /0 subnet is conceptually possible but hardly a practical"},{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d _(\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_2b260769","line":572,"in_reply_to":"1abeadc6_82681bf6","updated":"2014-09-08 23:16:49.000000000","message":"At this point we don\u0027t know only one subnet is specified because it is the logic to validate input subnet CIDRs.","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"b4b37beb01db2eeedac0c0b067a1702063f22bd3","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        # This is not a discrimination against /0 subnets."},{"line_number":570,"context_line":"        # A /0 subnet is conceptually possible but hardly a practical"},{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d _(\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_486c2637","line":572,"in_reply_to":"fa98f980_2b260769","updated":"2014-09-09 08:19:29.000000000","message":"we know it because new_subnet_ipset is a list of one cidr.","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e30397b5218465ea90087a8a383327053518ec17","unresolved":false,"context_lines":[{"line_number":569,"context_line":"        # This is not a discrimination against /0 subnets."},{"line_number":570,"context_line":"        # A /0 subnet is conceptually possible but hardly a practical"},{"line_number":571,"context_line":"        # scenario for neutron\u0027s use cases."},{"line_number":572,"context_line":"        for cidr in new_subnet_ipset.iter_cidrs():"},{"line_number":573,"context_line":"            if cidr.prefixlen \u003d\u003d 0:"},{"line_number":574,"context_line":"                err_msg \u003d _(\"0 is not allowed as CIDR prefix length\")"},{"line_number":575,"context_line":"                raise n_exc.InvalidInput(error_message\u003derr_msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_17c90526","line":572,"in_reply_to":"fa98f980_486c2637","updated":"2014-09-11 17:15:57.000000000","message":"Sorry. I missed it . you are right.","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"46d37a30be43331250d0a4a87b97ad01cee4cf94","unresolved":false,"context_lines":[{"line_number":2366,"context_line":"                    \u0027gateway_ip\u0027: \u00270.0.0.1\u0027}}"},{"line_number":2367,"context_line":"            subnet_req \u003d self.new_create_request(\u0027subnets\u0027, data)"},{"line_number":2368,"context_line":"            res \u003d subnet_req.get_response(self.api)"},{"line_number":2369,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPClientError.code)"},{"line_number":2370,"context_line":""},{"line_number":2371,"context_line":"    def test_create_subnet_bad_V6_cidr(self):"},{"line_number":2372,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_495a7e51","line":2369,"updated":"2014-09-08 18:44:34.000000000","message":"nit: use expected, actual","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2abfebd1666a04a7299b71e2bbccd3b30d590041","unresolved":false,"context_lines":[{"line_number":2366,"context_line":"                    \u0027gateway_ip\u0027: \u00270.0.0.1\u0027}}"},{"line_number":2367,"context_line":"            subnet_req \u003d self.new_create_request(\u0027subnets\u0027, data)"},{"line_number":2368,"context_line":"            res \u003d subnet_req.get_response(self.api)"},{"line_number":2369,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPClientError.code)"},{"line_number":2370,"context_line":""},{"line_number":2371,"context_line":"    def test_create_subnet_bad_V6_cidr(self):"},{"line_number":2372,"context_line":"        with self.network() as network:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_ab191724","line":2369,"in_reply_to":"fa98f980_495a7e51","updated":"2014-09-08 23:16:49.000000000","message":"I think it is okay because this style is used throughout this module (at least the class).","commit_id":"f2aa93767ece248d8efadc9b3507e233044aa316"}]}
