)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4c26e07d2216c179baec5d25ade7d2ff2405c5ab","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Remove logic for conditional migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch removes the logic for handling conditional migrations"},{"line_number":10,"context_line":"and adjusts all the patches were it was used accordingly."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The alembic environment has been update to not send anymore"},{"line_number":13,"context_line":"the active plugins list to migrations."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_c69b8670","line":10,"updated":"2014-09-02 09:37:53.000000000","message":"nit: were - where","commit_id":"51e6abda09caae1795279ca1c498b48fac50483d"}],"neutron/db/migration/alembic_migrations/versions/10cd28e692e9_nuage_extraroute.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4c26e07d2216c179baec5d25ade7d2ff2405c5ab","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027router_id\u0027], [\u0027routers.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    op.create_table("},{"line_number":52,"context_line":"        \u0027routerroutes\u0027,"},{"line_number":53,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":54,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_26b612fb","side":"PARENT","line":51,"updated":"2014-09-02 09:37:53.000000000","message":"why is it deleted (in this patch)?","commit_id":"73160ebc431e5885316396e4d1fbbee57de50c0e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"38fca8f00ceb6bd7ec39abb4234cdcbee5660a65","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027router_id\u0027], [\u0027routers.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    op.create_table("},{"line_number":52,"context_line":"        \u0027routerroutes\u0027,"},{"line_number":53,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":54,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_cf8f19cb","side":"PARENT","line":51,"in_reply_to":"fa98f980_26b612fb","updated":"2014-09-02 10:34:59.000000000","message":"because this is a generic table for the \u0027extra route\u0027 extension.\nSuch table will be created in the appropriate \"init_ops\" module and should not be created again.\n\nPreviously the nuage plugin was not part of those included in the initial extra route migration. For this reason the table was created in this migration exclusively for the nuage plugin.\n\nThis change should however be part of the dependent patch. I\u0027m not sure howe it ended up here.","commit_id":"73160ebc431e5885316396e4d1fbbee57de50c0e"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"4b6b0a614e068f24849a9a5984d358db65db8be9","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        sa.ForeignKeyConstraint([\u0027router_id\u0027], [\u0027routers.id\u0027],"},{"line_number":49,"context_line":"                                ondelete\u003d\u0027CASCADE\u0027),"},{"line_number":50,"context_line":"    )"},{"line_number":51,"context_line":"    op.create_table("},{"line_number":52,"context_line":"        \u0027routerroutes\u0027,"},{"line_number":53,"context_line":"        sa.Column(\u0027destination\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":54,"context_line":"        sa.Column(\u0027nexthop\u0027, sa.String(length\u003d64), nullable\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_fa001d03","side":"PARENT","line":51,"in_reply_to":"fa98f980_cf8f19cb","updated":"2014-09-02 10:36:12.000000000","message":"This is another refuse deriving from incorrectly rebasing after Ann\u0027s patch merged.","commit_id":"73160ebc431e5885316396e4d1fbbee57de50c0e"}],"neutron/db/migration/alembic_migrations/versions/117643811bca_nec_delete_ofc_mapping.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bdc2a292328dd0cf145cd4fd3c80bbad966830ae","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    op.execute(stmt)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # drop old mapping tables"},{"line_number":164,"context_line":"    op.drop_table(\u0027ofctenants\u0027)"},{"line_number":165,"context_line":"    op.drop_table(\u0027ofcnetworks\u0027)"},{"line_number":166,"context_line":"    op.drop_table(\u0027ofcports\u0027)"},{"line_number":167,"context_line":"    op.drop_table(\u0027ofcfilters\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_5e9c810f","line":164,"updated":"2014-09-03 16:28:35.000000000","message":"This is gonna fail when upgrading from Havana deployed without nec plugin.","commit_id":"c41d2a7bf3e0912a040e68a76baef749192487fd"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"792a545ab0c12f47d719b44b599e1e3a00ae5070","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    op.execute(stmt)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    # drop old mapping tables"},{"line_number":164,"context_line":"    op.drop_table(\u0027ofctenants\u0027)"},{"line_number":165,"context_line":"    op.drop_table(\u0027ofcnetworks\u0027)"},{"line_number":166,"context_line":"    op.drop_table(\u0027ofcports\u0027)"},{"line_number":167,"context_line":"    op.drop_table(\u0027ofcfilters\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_3318ce74","line":164,"in_reply_to":"fa98f980_5e9c810f","updated":"2014-09-03 19:09:35.000000000","message":"I think this statement is correct, since we do not have a sort of healing step for the old havana state.","commit_id":"c41d2a7bf3e0912a040e68a76baef749192487fd"}],"neutron/db/migration/alembic_migrations/versions/3d3cb89d84ee_nsx_switch_mappings.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"4c26e07d2216c179baec5d25ade7d2ff2405c5ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":44,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_e6640a24","line":44,"updated":"2014-09-02 09:37:53.000000000","message":"nit: not sure about this kind of changes","commit_id":"51e6abda09caae1795279ca1c498b48fac50483d"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"38fca8f00ceb6bd7ec39abb4234cdcbee5660a65","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":44,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_ef321d0f","line":44,"in_reply_to":"fa98f980_e6640a24","updated":"2014-09-02 10:34:59.000000000","message":"You might refer to several thing:\n1: the change gerrit is showing at line 44. I have no idea what that would be.\n2: removing parameters from upgrade. This is part of the removal of conditional logic.\n3: not removing parameters on downgrading. They should go indeed. I unfortunately made a mistae while rebasing after Anna\u0027s patch merged.","commit_id":"51e6abda09caae1795279ca1c498b48fac50483d"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"a85f46e7375266a05f382fce5dc88b5d784b800f","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def downgrade(active_plugins\u003dNone, options\u003dNone):"},{"line_number":44,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_fb7adfef","line":44,"in_reply_to":"fa98f980_ef321d0f","updated":"2014-09-02 12:26:17.000000000","message":"Yeah, I was referring to the change gerrit is showing at line 44, I guess this is smth related to new line at the end of file. Nevertheless this is what pep8 should take care of, and if it\u0027s happy I\u0027m happy too)","commit_id":"51e6abda09caae1795279ca1c498b48fac50483d"}],"neutron/db/migration/alembic_migrations/versions/5446f2a45467_set_server_default.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f6baea1a049874f53f4b4d273084615060cb47d9","unresolved":false,"context_lines":[{"line_number":60,"context_line":"@migration.skip_if_offline"},{"line_number":61,"context_line":"def run(default\u003dNone):"},{"line_number":62,"context_line":"    set_default_ml2(default)"},{"line_number":63,"context_line":"    set_default_agents(default)"},{"line_number":64,"context_line":"    set_default_mlnx(default)"},{"line_number":65,"context_line":"    set_default_brocade(default)"},{"line_number":66,"context_line":"    set_default_cisco(default)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_6ccc548a","line":63,"updated":"2014-09-11 09:51:39.000000000","message":"Why was the order changed? Just curious. :)","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"d49effddd1bebf051aedd2e2aa149ad4757d0200","unresolved":false,"context_lines":[{"line_number":60,"context_line":"@migration.skip_if_offline"},{"line_number":61,"context_line":"def run(default\u003dNone):"},{"line_number":62,"context_line":"    set_default_ml2(default)"},{"line_number":63,"context_line":"    set_default_agents(default)"},{"line_number":64,"context_line":"    set_default_mlnx(default)"},{"line_number":65,"context_line":"    set_default_brocade(default)"},{"line_number":66,"context_line":"    set_default_cisco(default)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_a8a3689c","line":63,"in_reply_to":"fa98f980_2505e179","updated":"2014-09-12 04:37:32.000000000","message":"Done","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8d146051fe7c8798bc6a64f0eb38749ac9d8557f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"@migration.skip_if_offline"},{"line_number":61,"context_line":"def run(default\u003dNone):"},{"line_number":62,"context_line":"    set_default_ml2(default)"},{"line_number":63,"context_line":"    set_default_agents(default)"},{"line_number":64,"context_line":"    set_default_mlnx(default)"},{"line_number":65,"context_line":"    set_default_brocade(default)"},{"line_number":66,"context_line":"    set_default_cisco(default)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_2505e179","line":63,"in_reply_to":"fa98f980_6ccc548a","updated":"2014-09-12 04:14:31.000000000","message":"Salvatore did that. I reverted it and it seems to still work, but I would like to hear from Salvatore why the order was changed.","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"}],"neutron/db/migration/alembic_migrations/versions/abc88c33f74f_lb_stats_needs_bigint.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f6baea1a049874f53f4b4d273084615060cb47d9","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    if migration.schema_has_table(\u0027poolstatisticss\u0027):"},{"line_number":37,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_in\u0027,"},{"line_number":38,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"},{"line_number":39,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_out\u0027,"},{"line_number":40,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_1f0f6c89","line":37,"updated":"2014-09-11 09:51:39.000000000","message":"There is alter_column_if_exists method.","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8d146051fe7c8798bc6a64f0eb38749ac9d8557f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    if migration.schema_has_table(\u0027poolstatisticss\u0027):"},{"line_number":37,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_in\u0027,"},{"line_number":38,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"},{"line_number":39,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_out\u0027,"},{"line_number":40,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_65e449e0","line":37,"in_reply_to":"fa98f980_1f0f6c89","updated":"2014-09-12 04:14:31.000000000","message":"I thought about this. If I use that then the table existence will be check four times. I think it\u0027s better to check once. Let me know if you disagree.","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"dd4d671dff54bfb56f3eda2ba1e8d8b9200364b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def upgrade():"},{"line_number":36,"context_line":"    if migration.schema_has_table(\u0027poolstatisticss\u0027):"},{"line_number":37,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_in\u0027,"},{"line_number":38,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"},{"line_number":39,"context_line":"        op.alter_column(\u0027poolstatisticss\u0027, \u0027bytes_out\u0027,"},{"line_number":40,"context_line":"                        type_\u003dsa.BigInteger(), existing_type\u003dsa.Integer())"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_4f7afe88","line":37,"in_reply_to":"fa98f980_65e449e0","updated":"2014-09-12 08:20:03.000000000","message":"That is fine. I agree with you.","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"}],"neutron/db/migration/alembic_migrations/versions/e766b19a3bb_nuage_initial.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f6baea1a049874f53f4b4d273084615060cb47d9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    if not migration.schema_has_table(\u0027routers\u0027):"},{"line_number":70,"context_line":"        # In the database we are migrating from, the configured plugin"},{"line_number":71,"context_line":"        # did not create the routers table."},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    op.create_table("},{"line_number":75,"context_line":"        \u0027net_partition_router_mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_1fa20c4b","line":72,"updated":"2014-09-11 09:51:39.000000000","message":"I\u0027ve got some doubts here. If there is no table \u0027routers\u0027 3 tables will be created and 2 skipped. Shouldn\u0027t migration create all table that needed or don\u0027t create them at all?","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"8d146051fe7c8798bc6a64f0eb38749ac9d8557f","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    if not migration.schema_has_table(\u0027routers\u0027):"},{"line_number":70,"context_line":"        # In the database we are migrating from, the configured plugin"},{"line_number":71,"context_line":"        # did not create the routers table."},{"line_number":72,"context_line":"        return"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    op.create_table("},{"line_number":75,"context_line":"        \u0027net_partition_router_mapping\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa98f980_e5ee79b4","line":72,"in_reply_to":"fa98f980_1fa20c4b","updated":"2014-09-12 04:14:31.000000000","message":"Done","commit_id":"9a8724b42edf5f51f1e2238f5cd20f40d5f45791"}]}