)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Wendlandt \u003cdan@nicira.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2012-08-28 14:44:40 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"prevent invalid deletion of ports using by L3 devices"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"bug 1039947"},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAALH%2F%2Flng%3D","line":7,"updated":"2012-08-29 12:50:51.000000000","message":"using \u003d\u003e used","commit_id":"8336e724540edb0a45ca22d4121f1f58d15e0316"}],"quantum/db/l3_db.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":534,"context_line":"        some ports for L3 are not intended to be deleted directly via a"},{"line_number":535,"context_line":"        DELETE to /ports, but rather via other API calls that perform the"},{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpgQ%3D","line":537,"updated":"2012-08-23 09:08:13.000000000","message":"Verify this docstring is compliant with HACKING rules for multi-line docstrings","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":534,"context_line":"        some ports for L3 are not intended to be deleted directly via a"},{"line_number":535,"context_line":"        DELETE to /ports, but rather via other API calls that perform the"},{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fnu8%3D","line":537,"in_reply_to":"AAAALH%2F%2FpgQ%3D","updated":"2012-08-25 04:40:13.000000000","message":"will do.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"},{"line_number":541,"context_line":"                                       DEVICE_OWNER_FLOATINGIP]:"},{"line_number":542,"context_line":"            raise l3.L3PortInUse(port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpiQ%3D","line":539,"updated":"2012-08-23 07:07:37.000000000","message":"Only concern here is that the CLI can update these fields.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"},{"line_number":541,"context_line":"                                       DEVICE_OWNER_FLOATINGIP]:"},{"line_number":542,"context_line":"            raise l3.L3PortInUse(port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmGo%3D","line":539,"in_reply_to":"AAAALH%2F%2FnnM%3D","updated":"2012-08-28 21:44:52.000000000","message":"we have this bug filed, but it would have to have its priority upped: https://bugs.launchpad.net/quantum/+bug/1031473\n\nI mispoke earlier when I said that with L3 the ports could only be deleted by admin.  The issue you ran into could only have been done by admin, since ports associated with floating Ips and external-gateways are owned by an empty tenant, meaning no tenant could modify them, but an admin could.  Ports associated with router interfaces are visible though, and so the user could delete it.  Nothing really bad would happen there though, as there are no foreign key references there.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"},{"line_number":541,"context_line":"                                       DEVICE_OWNER_FLOATINGIP]:"},{"line_number":542,"context_line":"            raise l3.L3PortInUse(port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FnnM%3D","line":539,"in_reply_to":"AAAALH%2F%2Fnu4%3D","updated":"2012-08-26 04:19:34.000000000","message":"The admin only update sounds reasonable regarding these fields. I am atill not 100% on where this is enforced. Will this be done via the policy.json file or hard coded?","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":536,"context_line":"        proper deletion checks."},{"line_number":537,"context_line":"        \"\"\""},{"line_number":538,"context_line":"        port_db \u003d self._get_port(context, port_id)"},{"line_number":539,"context_line":"        if port_db[\u0027device_owner\u0027] in [DEVICE_OWNER_ROUTER_INTF,"},{"line_number":540,"context_line":"                                       DEVICE_OWNER_ROUTER_GW,"},{"line_number":541,"context_line":"                                       DEVICE_OWNER_FLOATINGIP]:"},{"line_number":542,"context_line":"            raise l3.L3PortInUse(port_id\u003dport_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fnu4%3D","line":539,"in_reply_to":"AAAALH%2F%2FpiQ%3D","updated":"2012-08-25 04:40:13.000000000","message":"One option would be to make device_id and device_owner something that can only be set on port-create, but that doesn\u0027t seem to work well with a model where a user can create a port themselves, then pass it to a service like nova, to be used when booting a VM (since Nova would have to update device_owner and device_id).  \n\nSo with that in mind, we could try to make it such that only a \"service\" could update these fields.  But already I believe that in the case of these L3 ports, only an admin user can update the owner of an L3 port (since these ports only have a tenant-id), and generally speaking, an admin user can probably really screw things up in general if they aren\u0027t careful.  \n\nIs there a particular direction you think this should go?","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":524,"context_line":"                                    filters\u003dfilters, fields\u003dfields)"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def prevent_l3_port_deletion(self, context, port_id):"},{"line_number":527,"context_line":"        \"\"\" Checks to make sure a port is allowed to be deleted, raising"},{"line_number":528,"context_line":"        an exception if this is not the case.  This should be called by"},{"line_number":529,"context_line":"        any plugin when the API requests the deletion of a port, since"},{"line_number":530,"context_line":"        some ports for L3 are not intended to be deleted directly via a"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlnU%3D","line":527,"updated":"2012-08-29 12:50:51.000000000","message":"I think that the comment format deviates from the standard. I am not an expert here.","commit_id":"8336e724540edb0a45ca22d4121f1f58d15e0316"}],"quantum/extensions/l3.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Port %(port_id) already has a floating IP associated with it\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class L3PortInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpiY%3D","line":53,"updated":"2012-08-23 07:07:37.000000000","message":"%(port_id)s","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class FloatingIPPortAlreadyAssociated(qexception.InUse):"},{"line_number":53,"context_line":"    message \u003d _(\"Port %(port_id) already has a floating IP associated with it\")"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class L3PortInUse(qexception.InUse):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmGc%3D","line":53,"in_reply_to":"AAAALH%2F%2FpiY%3D","updated":"2012-08-28 21:44:52.000000000","message":"yikes, thanks for catching this.  Done","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class L3PortInUse(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Port %(port_id) has owner %(device_owner)s and therefore\""},{"line_number":58,"context_line":"                \" cannot be deleted directly via the port API.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fpiw%3D","line":57,"updated":"2012-08-23 07:07:37.000000000","message":"%(port_id)s","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class L3PortInUse(qexception.InUse):"},{"line_number":57,"context_line":"    message \u003d _(\"Port %(port_id) has owner %(device_owner)s and therefore\""},{"line_number":58,"context_line":"                \" cannot be deleted directly via the port API.\")"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmEk%3D","line":57,"in_reply_to":"AAAALH%2F%2Fpiw%3D","updated":"2012-08-28 21:44:52.000000000","message":"Done","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                          binding.vlan_id)"},{"line_number":359,"context_line":"        return port"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":362,"context_line":"        if l3_port_check:"},{"line_number":363,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":364,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpiM%3D","line":361,"updated":"2012-08-23 07:07:37.000000000","message":"Maybe a comment would be good here to explain.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                          binding.vlan_id)"},{"line_number":359,"context_line":"        return port"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":362,"context_line":"        if l3_port_check:"},{"line_number":363,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":364,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmEQ%3D","line":361,"in_reply_to":"AAAALH%2F%2Fnsw%3D","updated":"2012-08-28 21:44:52.000000000","message":"Right now, L2/L3 are coupled in the plugin either way as I see it, so this is really more about avoiding code duplication, which I agree with.  In the future, I\u0027d like L2/L3 plugins to be decoupled, but that will require more infrastructure, I suspect.  I see this first implementation as a good learning experience that will flush out the issues we\u0027ll need to tackle.  \n\nAnother patch I\u0027ll be doing will have some more code that needs to be put in the plugin, so perhaps we can better tackle that there.\n\nThe only thing that concerns me is a precedent about putting extension-specific code in the base-db class may set a bad precedent. \n\nbtw, added comment garyk requested.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                          binding.vlan_id)"},{"line_number":359,"context_line":"        return port"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":362,"context_line":"        if l3_port_check:"},{"line_number":363,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":364,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fnsw%3D","line":361,"in_reply_to":"AAAALH%2F%2FnvA%3D","updated":"2012-08-25 09:13:31.000000000","message":"Yes. \nThe only problem with that is that we will tighten the L2 and L3 parts of the plugin. If our architecture should allow for independent plugins, with the L2 plugin in particular unaware of the L3 plugin then we should keep things as they are.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                          binding.vlan_id)"},{"line_number":359,"context_line":"        return port"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":362,"context_line":"        if l3_port_check:"},{"line_number":363,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":364,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FnvA%3D","line":361,"in_reply_to":"AAAALH%2F%2Fpf4%3D","updated":"2012-08-25 04:40:13.000000000","message":"huh, that\u0027s an interesting idea.  I guess we could put this in db_base_plugin_v2 and just guard it with a check that determines whether self is an instance of the L3_NAT_db_mixin.  Is that what you were thinking of?","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":358,"context_line":"                                          binding.vlan_id)"},{"line_number":359,"context_line":"        return port"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":362,"context_line":"        if l3_port_check:"},{"line_number":363,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":364,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fpf4%3D","line":361,"in_reply_to":"AAAALH%2F%2FpiM%3D","updated":"2012-08-23 09:08:13.000000000","message":"Is there a chance the actual check can be performed in db_base_plugin, thus avoiding changes to the plugins?","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"def8773fcd3839bb1bb5361c5148dd278b56dc46","unresolved":false,"context_lines":[{"line_number":363,"context_line":"                self.notifier.port_update(self.context, port, vlan_id)"},{"line_number":364,"context_line":"        return port"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":367,"context_line":"        if l3_port_check:"},{"line_number":368,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":369,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpiI%3D","line":366,"updated":"2012-08-23 07:07:37.000000000","message":"Ditto regarding the comment","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":363,"context_line":"                self.notifier.port_update(self.context, port, vlan_id)"},{"line_number":364,"context_line":"        return port"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    def delete_port(self, context, id, l3_port_check\u003dTrue):"},{"line_number":367,"context_line":"        if l3_port_check:"},{"line_number":368,"context_line":"            self.prevent_l3_port_deletion(context, id)"},{"line_number":369,"context_line":"        self.disassociate_floatingips(context, id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmEM%3D","line":366,"in_reply_to":"AAAALH%2F%2FpiI%3D","updated":"2012-08-28 21:44:52.000000000","message":"Done","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":465,"context_line":"                                                  None,"},{"line_number":466,"context_line":"                                                  p[\u0027port\u0027][\u0027id\u0027])"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def test_router_remove_router_interface_wrong_port_returns_409(self):"},{"line_number":469,"context_line":"        with self.router() as r:"},{"line_number":470,"context_line":"            with self.subnet() as s:"},{"line_number":471,"context_line":"                with self.port(no_delete\u003dTrue) as p:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpfM%3D","line":468,"updated":"2012-08-23 09:08:13.000000000","message":"Fix this test name to:\ntest_router_remove_router_interface_wrong_port_returns_404","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":465,"context_line":"                                                  None,"},{"line_number":466,"context_line":"                                                  p[\u0027port\u0027][\u0027id\u0027])"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def test_router_remove_router_interface_wrong_port_returns_409(self):"},{"line_number":469,"context_line":"        with self.router() as r:"},{"line_number":470,"context_line":"            with self.subnet() as s:"},{"line_number":471,"context_line":"                with self.port(no_delete\u003dTrue) as p:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmEI%3D","line":468,"in_reply_to":"AAAALH%2F%2Fnu0%3D","updated":"2012-08-28 21:44:52.000000000","message":"Done","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":465,"context_line":"                                                  None,"},{"line_number":466,"context_line":"                                                  p[\u0027port\u0027][\u0027id\u0027])"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":"    def test_router_remove_router_interface_wrong_port_returns_409(self):"},{"line_number":469,"context_line":"        with self.router() as r:"},{"line_number":470,"context_line":"            with self.subnet() as s:"},{"line_number":471,"context_line":"                with self.port(no_delete\u003dTrue) as p:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fnu0%3D","line":468,"in_reply_to":"AAAALH%2F%2FpfM%3D","updated":"2012-08-25 04:40:13.000000000","message":"will do.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                         {\u0027port_id\u0027: port_id}},"},{"line_number":633,"context_line":"                                        expected_code\u003dexc.HTTPConflict.code)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_floating_ip_direct_port_delete(self):"},{"line_number":636,"context_line":"        found \u003d False"},{"line_number":637,"context_line":"        with self.floatingip_with_assoc() as fip:"},{"line_number":638,"context_line":"            for p in self._list(\u0027ports\u0027)[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FpfQ%3D","line":635,"updated":"2012-08-23 09:08:13.000000000","message":"It might be worth pointing out the fact that this is a negative test by renaming it to:\ntest_floating_ip_direct_port_delete_returns_409","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                         {\u0027port_id\u0027: port_id}},"},{"line_number":633,"context_line":"                                        expected_code\u003dexc.HTTPConflict.code)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_floating_ip_direct_port_delete(self):"},{"line_number":636,"context_line":"        found \u003d False"},{"line_number":637,"context_line":"        with self.floatingip_with_assoc() as fip:"},{"line_number":638,"context_line":"            for p in self._list(\u0027ports\u0027)[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FmD8%3D","line":635,"in_reply_to":"AAAALH%2F%2Fnuw%3D","updated":"2012-08-28 21:44:52.000000000","message":"Done","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                         {\u0027port_id\u0027: port_id}},"},{"line_number":633,"context_line":"                                        expected_code\u003dexc.HTTPConflict.code)"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"    def test_floating_ip_direct_port_delete(self):"},{"line_number":636,"context_line":"        found \u003d False"},{"line_number":637,"context_line":"        with self.floatingip_with_assoc() as fip:"},{"line_number":638,"context_line":"            for p in self._list(\u0027ports\u0027)[\u0027ports\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fnuw%3D","line":635,"in_reply_to":"AAAALH%2F%2FpfQ%3D","updated":"2012-08-25 04:40:13.000000000","message":"seems like a good idea.","commit_id":"5534e3bc5c04ca444540a7b78b4a274b56886ffa"}]}
