)]}'
{"quantum/plugins/cisco/nexus/cisco_nexus_plugin_v2.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"30286479bd874b1531008bb6a47619a60149166e","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            if key \u003d\u003d const.BASE_PLUGIN_REF:"},{"line_number":107,"context_line":"                base_plugin_ref \u003d kwargs[const.BASE_PLUGIN_REF]"},{"line_number":108,"context_line":"            if key \u003d\u003d \u0027vlan_id\u0027:"},{"line_number":109,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"},{"line_number":110,"context_line":"        if vlan_id is None:"},{"line_number":111,"context_line":"            vlan_id \u003d self._get_vlan_id_for_network(tenant_id, net_id,"},{"line_number":112,"context_line":"                                                    context, base_plugin_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FoRA%3D","line":109,"updated":"2012-08-24 16:54:10.000000000","message":"Consider using \nif condition:\nelif condition:\nelse:","commit_id":"0c01a03ba5599089356a3298b08992650617418d"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":106,"context_line":"            if key \u003d\u003d const.BASE_PLUGIN_REF:"},{"line_number":107,"context_line":"                base_plugin_ref \u003d kwargs[const.BASE_PLUGIN_REF]"},{"line_number":108,"context_line":"            if key \u003d\u003d \u0027vlan_id\u0027:"},{"line_number":109,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"},{"line_number":110,"context_line":"        if vlan_id is None:"},{"line_number":111,"context_line":"            vlan_id \u003d self._get_vlan_id_for_network(tenant_id, net_id,"},{"line_number":112,"context_line":"                                                    context, base_plugin_ref)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FoHo%3D","line":109,"in_reply_to":"AAAALH%2F%2FoRA%3D","updated":"2012-08-24 18:44:55.000000000","message":"I want to check for separate if\u0027s as they all can be passed as arguments to the method.","commit_id":"0c01a03ba5599089356a3298b08992650617418d"}],"quantum/plugins/cisco/tests/unit/v2/test_nexus_plugin.py":[{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"change_message_id":"30286479bd874b1531008bb6a47619a60149166e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.plugins.cisco.nexus import cisco_nexus_plugin_v2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.tests.test_nexus\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestNexusPlugin(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FoQ4%3D","line":28,"updated":"2012-08-24 16:54:10.000000000","message":"Preferable to use __name__ instead of module name.","commit_id":"0c01a03ba5599089356a3298b08992650617418d"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.plugins.cisco.nexus import cisco_nexus_plugin_v2"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.tests.test_nexus\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"class TestNexusPlugin(unittest.TestCase):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FoHk%3D","line":28,"in_reply_to":"AAAALH%2F%2FoQ4%3D","updated":"2012-08-24 18:44:55.000000000","message":"Done","commit_id":"0c01a03ba5599089356a3298b08992650617418d"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"92650c299ae6586312aa813241c22d97dc889aa9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from quantum.common import exceptions as exc"},{"line_number":20,"context_line":"from quantum.plugins.cisco.common import cisco_constants as const"},{"line_number":21,"context_line":"from quantum.plugins.cisco.common import cisco_credentials_v2 as creds"},{"line_number":22,"context_line":"from quantum.db import api as db"},{"line_number":23,"context_line":"from quantum.plugins.cisco.db import network_db_v2 as cdb"},{"line_number":24,"context_line":"from quantum.plugins.cisco.db import network_models_v2"},{"line_number":25,"context_line":"from quantum.plugins.cisco.nexus import cisco_nexus_plugin_v2"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FoBo%3D","line":22,"updated":"2012-08-24 20:21:51.000000000","message":"nit: import abc order","commit_id":"978222a13d0ea749f0525a055a4b7b2c69db4a75"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":19,"context_line":"from quantum.common import exceptions as exc"},{"line_number":20,"context_line":"from quantum.plugins.cisco.common import cisco_constants as const"},{"line_number":21,"context_line":"from quantum.plugins.cisco.common import cisco_credentials_v2 as creds"},{"line_number":22,"context_line":"from quantum.db import api as db"},{"line_number":23,"context_line":"from quantum.plugins.cisco.db import network_db_v2 as cdb"},{"line_number":24,"context_line":"from quantum.plugins.cisco.db import network_models_v2"},{"line_number":25,"context_line":"from quantum.plugins.cisco.nexus import cisco_nexus_plugin_v2"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FoBI%3D","line":22,"in_reply_to":"AAAALH%2F%2FoBo%3D","updated":"2012-08-24 20:27:40.000000000","message":"Done","commit_id":"978222a13d0ea749f0525a055a4b7b2c69db4a75"}]}