)]}'
{"quantum/agent/dhcp_agent.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"            self.disable_dhcp_helper(network_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def network_delete_end(self, payload):"},{"line_number":144,"context_line":"        \"\"\"Handle the network.detete.end notification event.\"\"\""},{"line_number":145,"context_line":"        self.disable_dhcp_helper(payload[\u0027network_id\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def subnet_update_end(self, payload):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FmMM%3D","line":144,"updated":"2012-08-28 22:04:03.000000000","message":"(Suggestion only) detete \u003d\u003e delete","commit_id":"e7efc88009f8298387410c5c9859e305edcdcad0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cfbfaeffab74ab5156b12e7e71bb12994bb5ed6c","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            self.disable_dhcp_helper(network_id)"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    def network_delete_end(self, payload):"},{"line_number":144,"context_line":"        \"\"\"Handle the network.detete.end notification event.\"\"\""},{"line_number":145,"context_line":"        self.disable_dhcp_helper(payload[\u0027network_id\u0027])"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def subnet_update_end(self, payload):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FmAM%3D","line":144,"in_reply_to":"AAAALH%2F%2FmMM%3D","updated":"2012-08-28 22:39:34.000000000","message":"Good catch.  Updated.","commit_id":"e7efc88009f8298387410c5c9859e305edcdcad0"}],"quantum/db/db_base_plugin_v2.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d0f9916627103c035c308b02442c23ba650c2607","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        This method will retry the delete method until the configured"},{"line_number":164,"context_line":"        cumulative wait has been reached.  When the wait has been exceeded, the"},{"line_number":165,"context_line":"        cleanup method will be called with the context and the id of the parent"},{"line_number":166,"context_line":"        resource.  The cleanup method should cleaning up the resources that may"},{"line_number":167,"context_line":"        be preventing the delete method from succeeding.  If the method returns"},{"line_number":168,"context_line":"        True, the delete will be retried.  If False is returned, the original"},{"line_number":169,"context_line":"        exception will be re-raised."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FnOU%3D","line":166,"updated":"2012-08-27 16:14:54.000000000","message":"(Suggestion) cleaning up -\u003e free","commit_id":"7a66d0b45a439a81577c0af511c4a4bc16ca7676"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d0f9916627103c035c308b02442c23ba650c2607","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        filter \u003d {\u0027network_id\u0027: [id]}"},{"line_number":825,"context_line":"        ports \u003d self.get_ports(context, filters\u003dfilter)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        # check to make sure ports are owned solely by Quantum"},{"line_number":828,"context_line":"        for port in ports:"},{"line_number":829,"context_line":"            if not port[\u0027device_owner\u0027].startswith(\u0027network:\u0027):"},{"line_number":830,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FnNQ%3D","line":827,"updated":"2012-08-27 16:14:54.000000000","message":"(Suggestion only) Consider simplifying this line and the 3 that follow with all():\n\nall_quantum_ports \u003d all(x[\u0027device_owner\u0027].startswith(\u0027network:\u0027) for x in ports)\nif not all_quantum_ports:\n  return False\n\nThis comment also applies to lines 1006-1010.","commit_id":"7a66d0b45a439a81577c0af511c4a4bc16ca7676"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cfbfaeffab74ab5156b12e7e71bb12994bb5ed6c","unresolved":false,"context_lines":[{"line_number":824,"context_line":"        filter \u003d {\u0027network_id\u0027: [id]}"},{"line_number":825,"context_line":"        ports \u003d self.get_ports(context, filters\u003dfilter)"},{"line_number":826,"context_line":""},{"line_number":827,"context_line":"        # check to make sure ports are owned solely by Quantum"},{"line_number":828,"context_line":"        for port in ports:"},{"line_number":829,"context_line":"            if not port[\u0027device_owner\u0027].startswith(\u0027network:\u0027):"},{"line_number":830,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmM8%3D","line":827,"in_reply_to":"AAAALH%2F%2FnNQ%3D","updated":"2012-08-28 18:47:37.000000000","message":"Good suggestion.  I\u0027ve incorporated into the new version","commit_id":"7a66d0b45a439a81577c0af511c4a4bc16ca7676"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"d0f9916627103c035c308b02442c23ba650c2607","unresolved":false,"context_lines":[{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"    def delete_port(self, context, id):"},{"line_number":1110,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1111,"context_line":"            self._delete_port(context, id)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1114,"context_line":"        port \u003d self._get_port(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FnM0%3D","line":1111,"updated":"2012-08-27 16:14:54.000000000","message":"If delete_port() isn\u0027t going to be rewritten to use wait_for_resource_cleanup(), is it necessary to change it?","commit_id":"7a66d0b45a439a81577c0af511c4a4bc16ca7676"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cfbfaeffab74ab5156b12e7e71bb12994bb5ed6c","unresolved":false,"context_lines":[{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"    def delete_port(self, context, id):"},{"line_number":1110,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1111,"context_line":"            self._delete_port(context, id)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    def _delete_port(self, context, id):"},{"line_number":1114,"context_line":"        port \u003d self._get_port(context, id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FmMs%3D","line":1111,"in_reply_to":"AAAALH%2F%2FnM0%3D","updated":"2012-08-28 18:47:37.000000000","message":"I did this so that _delete_port would use the came session as the caller since delete_network now calls it to clean-up.","commit_id":"7a66d0b45a439a81577c0af511c4a4bc16ca7676"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":796,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilter)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"            # check if there are any tenant owned ports in-use"},{"line_number":799,"context_line":"            only_svc \u003d all(p[\u0027device_owner\u0027].startswith(\u0027network:\u0027)"},{"line_number":800,"context_line":"                           for p in ports)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"            if not only_svc:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FmMU%3D","line":799,"updated":"2012-08-28 19:05:11.000000000","message":"maybe consider \u0027network:\u0027 to be a define and use this also in the agents.\nthis is not critical","commit_id":"e7efc88009f8298387410c5c9859e305edcdcad0"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"cfbfaeffab74ab5156b12e7e71bb12994bb5ed6c","unresolved":false,"context_lines":[{"line_number":796,"context_line":"            ports \u003d self.get_ports(context, filters\u003dfilter)"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"            # check if there are any tenant owned ports in-use"},{"line_number":799,"context_line":"            only_svc \u003d all(p[\u0027device_owner\u0027].startswith(\u0027network:\u0027)"},{"line_number":800,"context_line":"                           for p in ports)"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"            if not only_svc:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAALH%2F%2FmAE%3D","line":799,"in_reply_to":"AAAALH%2F%2FmMU%3D","updated":"2012-08-28 22:39:34.000000000","message":"I\u0027ve updated it for now and will create a bug to update the other places once this lands.","commit_id":"e7efc88009f8298387410c5c9859e305edcdcad0"}]}