)]}'
{"neutron/tests/functional/agent/linux/bin/ipt_binname.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"476c1fb43e5f4e81f9d5775d4d1c6d20c39d915d","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def print_binary_name():"},{"line_number":26,"context_line":"    # NOTE(yamamoto): Don\u0027t move this import to module-level."},{"line_number":27,"context_line":"    # The aim is to test importing from eventlet non-main thread."},{"line_number":28,"context_line":"    from neutron.agent.linux import iptables_manager"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    print(iptables_manager.binary_name)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_4e8f0224","line":28,"updated":"2014-09-21 00:55:47.000000000","message":"Why not just call the get_binary_name function to guaruntee that it\u0027s called by the eventlet coroutine?","commit_id":"6a7bcabbd43a065c8c83426ee441b3195a758e76"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1b737310c800d1dfde4f28c20e001571a152dd5c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def print_binary_name():"},{"line_number":26,"context_line":"    # NOTE(yamamoto): Don\u0027t move this import to module-level."},{"line_number":27,"context_line":"    # The aim is to test importing from eventlet non-main thread."},{"line_number":28,"context_line":"    from neutron.agent.linux import iptables_manager"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    print(iptables_manager.binary_name)"},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da9df570_a520889c","line":28,"in_reply_to":"da9df570_4e8f0224","updated":"2014-09-21 22:55:17.000000000","message":"because i want to test it in a similar way how it\u0027s actually used as far as possible.","commit_id":"6a7bcabbd43a065c8c83426ee441b3195a758e76"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ccfe40f80e34518b4b89edfda29e77d3a4161b71","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def print_binary_name():"},{"line_number":26,"context_line":"    # NOTE(yamamoto): Don\u0027t move this import to module-level."},{"line_number":27,"context_line":"    # The aim is to test importing from eventlet non-main thread."},{"line_number":28,"context_line":"    from neutron.agent.linux import iptables_manager"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    print(iptables_manager.binary_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_988d982d","line":27,"updated":"2015-02-14 23:20:14.000000000","message":"It is better to refer LP bug here so that developers can know what is actually tested.","commit_id":"035aaa9ee9e86564c0218b9f65e0adafd06eff77"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2ce6401deb0352e196414563226e7d6ece915c01","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def print_binary_name():"},{"line_number":26,"context_line":"    # NOTE(yamamoto): Don\u0027t move this import to module-level."},{"line_number":27,"context_line":"    # The aim is to test importing from eventlet non-main thread."},{"line_number":28,"context_line":"    from neutron.agent.linux import iptables_manager"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    print(iptables_manager.binary_name)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_9a5739ca","line":27,"in_reply_to":"da86d52c_988d982d","updated":"2015-02-16 10:42:40.000000000","message":"Done","commit_id":"035aaa9ee9e86564c0218b9f65e0adafd06eff77"}],"neutron/tests/functional/agent/linux/helpers/ipt_binname.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"93d1f8bf71338e86b279b62bb9f7741c7da9726e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#! /usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":4,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_aaa7f14e","line":1,"updated":"2014-09-11 16:59:25.000000000","message":"putting these files under \u0027helpers\u0027 might be a bit confusing. In the end they are just used by one test, they don\u0027t really contain any helper functions.\nMaybe simply name the folder \u0027bin\u0027 ?","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a9023f4412ae11967e4e2f8389ab7aa2bc14dd73","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#! /usr/bin/env python"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright (C) 2014 VA Linux Systems Japan K.K."},{"line_number":4,"context_line":"# Copyright (C) 2014 YAMAMOTO Takashi \u003cyamamoto at valinux co jp\u003e"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_c55b3552","line":1,"in_reply_to":"fa98f980_aaa7f14e","updated":"2014-09-12 04:22:46.000000000","message":"i meant helper binaries but i can rename.","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"93d1f8bf71338e86b279b62bb9f7741c7da9726e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    print(iptables_manager.binary_name)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":28,"context_line":"    print_binary_name()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_6a26e9cf","line":28,"updated":"2014-09-11 16:59:25.000000000","message":"why not adding a param to determine if the function should be run in the current green thread or in a new one spawn? So we can remove next file. Something like:\n\nif len(sys.argv) \u003e 1:\n    eventlet.spawn(print_binary_name).wait()\nelse:\n    print_binary_name()","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a9023f4412ae11967e4e2f8389ab7aa2bc14dd73","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    print(iptables_manager.binary_name)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":28,"context_line":"    print_binary_name()"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_282778b7","line":28,"in_reply_to":"fa98f980_6a26e9cf","updated":"2014-09-12 04:22:46.000000000","message":"Done","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"}],"neutron/tests/functional/agent/linux/test_iptables.py":[{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"93d1f8bf71338e86b279b62bb9f7741c7da9726e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        observed \u003d utils.execute([modname]).rstrip()"},{"line_number":96,"context_line":"        self.assertEqual(expected, observed)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_binary_name(self):"},{"line_number":99,"context_line":"        self._test_binary_name(ipt_binname)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_binary_name_eventlet(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_e505aa7a","line":98,"updated":"2014-09-11 16:59:25.000000000","message":"If you like my suggestion of having just one fine instead of 2, then you could simplify the test as follows.\nInstead of having 2 tests, you need just one that checks that binary_name function returns the same result even using a non main thread. This would be simpler and more similar to the real case scenario.\n\nSomething like:\n\ndef test_binary_name(self):\n    # I assume the name of the module is ipt_binname and that there\u0027s a param\n    # to use another thread \n    modname \u003d self._normalize_module_name(ipt_binname.__file__)\n    binary_name \u003d utils.execute([modname]).rstrip()\n    binary_name_with_eventlet \u003d utils.execute(modname, \u0027--spawn_thread\u0027).rstrip())\n    self.assertEqual(binary_name, binary_name_with_eventlet)\n\nMaybe you can even hard code modname since it\u0027s just one","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"a9023f4412ae11967e4e2f8389ab7aa2bc14dd73","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        observed \u003d utils.execute([modname]).rstrip()"},{"line_number":96,"context_line":"        self.assertEqual(expected, observed)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_binary_name(self):"},{"line_number":99,"context_line":"        self._test_binary_name(ipt_binname)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_binary_name_eventlet(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_282db846","line":98,"in_reply_to":"fa98f980_e505aa7a","updated":"2014-09-12 04:22:46.000000000","message":"i kept it two tests because it seems simpler to me that way.","commit_id":"cf5421122b47f548afcd7953c71af4cd30802050"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"fbdce06061c584a7ec56f3280ce985791003febb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._test_binary_name(ipt_binname)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_binary_name_eventlet_spawn(self):"},{"line_number":101,"context_line":"        \"\"\"Test for Bug #1367075.\"\"\""},{"line_number":102,"context_line":"        self._test_binary_name(ipt_binname, \u0027spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_0c7801c3","line":101,"updated":"2014-09-12 10:14:08.000000000","message":"Hmm is there some new suggestion to add such comments to tests added in bugfix ?","commit_id":"185ae5850c0f8a8a3490a3360f0aeefce399de87"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"019d0e1ff01550a1528f45a72b9d2242246ec5ae","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self._test_binary_name(ipt_binname)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_binary_name_eventlet_spawn(self):"},{"line_number":101,"context_line":"        \"\"\"Test for Bug #1367075.\"\"\""},{"line_number":102,"context_line":"        self._test_binary_name(ipt_binname, \u0027spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_eff56fed","line":101,"in_reply_to":"fa98f980_0c7801c3","updated":"2014-09-12 10:25:39.000000000","message":"i added the comment because why it should be tested with eventlet is not clear from the code.","commit_id":"185ae5850c0f8a8a3490a3360f0aeefce399de87"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"68e304ee0cd7a8743082b8d315341a73477e571b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self._test_binary_name(ipt_binname)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_binary_name_eventlet_spawn(self):"},{"line_number":64,"context_line":"        \"\"\"Test for Bug #1367075.\"\"\""},{"line_number":65,"context_line":"        self._test_binary_name(ipt_binname, \u0027spawn\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_5edf263a","line":64,"updated":"2014-12-03 05:08:03.000000000","message":"we don\u0027t need this bug number in the docstring. git blame will show us that this change went in related to this bug.","commit_id":"6a7bcabbd43a065c8c83426ee441b3195a758e76"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ccfe40f80e34518b4b89edfda29e77d3a4161b71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import testtools"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os.path"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":20,"context_line":"from neutron.agent.linux import utils"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_187a8825","line":17,"updated":"2015-02-14 23:20:14.000000000","message":"os.path needs to be moved before testtools.","commit_id":"035aaa9ee9e86564c0218b9f65e0adafd06eff77"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2ce6401deb0352e196414563226e7d6ece915c01","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import testtools"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os.path"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.agent.linux import iptables_manager"},{"line_number":20,"context_line":"from neutron.agent.linux import utils"}],"source_content_type":"text/x-python","patch_set":10,"id":"da86d52c_fa191524","line":17,"in_reply_to":"da86d52c_187a8825","updated":"2015-02-16 10:42:40.000000000","message":"Done","commit_id":"035aaa9ee9e86564c0218b9f65e0adafd06eff77"}]}
