)]}'
{"quantum/plugins/cisco/models/network_multi_blade_v2.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def update_network(self, context, id, network):"},{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":"        Perform this operation in the context of the configured device"},{"line_number":162,"context_line":"        plugins."},{"line_number":163,"context_line":"        \"\"\""},{"line_number":164,"context_line":"        n \u003d network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flk8%3D","line":161,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) This generic docstring doesn\u0027t communicate anything useful - consider removing it.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":158,"context_line":""},{"line_number":159,"context_line":"    def update_network(self, context, id, network):"},{"line_number":160,"context_line":"        \"\"\""},{"line_number":161,"context_line":"        Perform this operation in the context of the configured device"},{"line_number":162,"context_line":"        plugins."},{"line_number":163,"context_line":"        \"\"\""},{"line_number":164,"context_line":"        n \u003d network"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flik%3D","line":161,"in_reply_to":"AAAALH%2F%2Flk8%3D","updated":"2012-08-29 15:56:21.000000000","message":"Keeping this there to maintain consistency with other methods doc strings. Have made a note for cleaning this up or making it more descriptive.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        n \u003d network"},{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            vlan \u003d cdb.get_vlan_binding(id)"},{"line_number":167,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":168,"context_line":"            args \u003d [n[\u0027tenant_id\u0027], id, {\u0027vlan_id\u0027:vlan.vlan_id},"},{"line_number":169,"context_line":"                    {\u0027net_admin_state\u0027:n[\u0027admin_state_up\u0027]},"},{"line_number":170,"context_line":"                    {\u0027vlan_ids\u0027:vlanids}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flkk%3D","line":167,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) This definition is only used once, on line 170.  Consider simply using the value inline and skipping the definition of this variable.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"        n \u003d network"},{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            vlan \u003d cdb.get_vlan_binding(id)"},{"line_number":167,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":168,"context_line":"            args \u003d [n[\u0027tenant_id\u0027], id, {\u0027vlan_id\u0027:vlan.vlan_id},"},{"line_number":169,"context_line":"                    {\u0027net_admin_state\u0027:n[\u0027admin_state_up\u0027]},"},{"line_number":170,"context_line":"                    {\u0027vlan_ids\u0027:vlanids}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FliA%3D","line":167,"in_reply_to":"AAAALH%2F%2Flkk%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            vlan \u003d cdb.get_vlan_binding(id)"},{"line_number":167,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":168,"context_line":"            args \u003d [n[\u0027tenant_id\u0027], id, {\u0027vlan_id\u0027:vlan.vlan_id},"},{"line_number":169,"context_line":"                    {\u0027net_admin_state\u0027:n[\u0027admin_state_up\u0027]},"},{"line_number":170,"context_line":"                    {\u0027vlan_ids\u0027:vlanids}]"},{"line_number":171,"context_line":"            nexus_output \u003d self._invoke_plugin_per_device(const.NEXUS_PLUGIN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flko%3D","line":168,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) Consider following PEP8 conventions on spacing:\n\n{\u0027vlan_id\u0027:vlan.vlan_id} \u003d\u003e {\u0027vlan_id\u0027: vlan.vlan_id}\n\nThis comment applies to all dictionaries defined by this change.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":165,"context_line":"        try:"},{"line_number":166,"context_line":"            vlan \u003d cdb.get_vlan_binding(id)"},{"line_number":167,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":168,"context_line":"            args \u003d [n[\u0027tenant_id\u0027], id, {\u0027vlan_id\u0027:vlan.vlan_id},"},{"line_number":169,"context_line":"                    {\u0027net_admin_state\u0027:n[\u0027admin_state_up\u0027]},"},{"line_number":170,"context_line":"                    {\u0027vlan_ids\u0027:vlanids}]"},{"line_number":171,"context_line":"            nexus_output \u003d self._invoke_plugin_per_device(const.NEXUS_PLUGIN,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flh4%3D","line":168,"in_reply_to":"AAAALH%2F%2Flko%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                                          args)"},{"line_number":174,"context_line":"            return nexus_output"},{"line_number":175,"context_line":"        except:"},{"line_number":176,"context_line":"            raise"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def delete_network(self, context, id, kwargs):"},{"line_number":179,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FllE%3D","line":176,"updated":"2012-08-29 14:18:09.000000000","message":"There is no point in having a blanket exception clause and then raising the exception.  Please remove the try/except block.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":173,"context_line":"                                                          args)"},{"line_number":174,"context_line":"            return nexus_output"},{"line_number":175,"context_line":"        except:"},{"line_number":176,"context_line":"            raise"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    def delete_network(self, context, id, kwargs):"},{"line_number":179,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flhs%3D","line":176,"in_reply_to":"AAAALH%2F%2FllE%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"}],"quantum/plugins/cisco/models/virt_phy_sw_v2.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":223,"context_line":"            raise"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def update_network(self, context, id, network):"},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        Perform this operation in the context of the configured device"},{"line_number":228,"context_line":"        plugins."},{"line_number":229,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flk4%3D","line":226,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) This generic docstring doesn\u0027t communicate anything useful - consider removing it.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":223,"context_line":"            raise"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def update_network(self, context, id, network):"},{"line_number":226,"context_line":"        \"\"\""},{"line_number":227,"context_line":"        Perform this operation in the context of the configured device"},{"line_number":228,"context_line":"        plugins."},{"line_number":229,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlhY%3D","line":226,"in_reply_to":"AAAALH%2F%2Flk4%3D","updated":"2012-08-29 15:56:21.000000000","message":"same comment as network_multi_blade_v2.py. made a note for future cleanup.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                                        self._func_name(),"},{"line_number":235,"context_line":"                                                        args)"},{"line_number":236,"context_line":"            vlan_id \u003d odb.get_vlan(ovs_output[0][\u0027id\u0027])"},{"line_number":237,"context_line":"            vlan_ids \u003d odb.get_vlans()"},{"line_number":238,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":239,"context_line":"            for v_id in vlan_ids:"},{"line_number":240,"context_line":"                vlanids \u003d str(v_id[0]) + \u0027,\u0027 + vlanids"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlkU%3D","line":237,"updated":"2012-08-29 14:18:09.000000000","message":"A couple of issues with the code from lines 237-241:\n\n- The variables vlan_ids and vlanids are not sufficiently differentiated, and should likely be vlans and vlan_ids, respectively.\n\n- The code to join the vlan ids together is needlessly complicated - use join() instead.\n\n(Suggestion only) The following line can replace lines 237-241:\n\nvlan_ids \u003d \u0027,\u0027.join(x[0] for x in odb.get_vlans()]","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                                        self._func_name(),"},{"line_number":235,"context_line":"                                                        args)"},{"line_number":236,"context_line":"            vlan_id \u003d odb.get_vlan(ovs_output[0][\u0027id\u0027])"},{"line_number":237,"context_line":"            vlan_ids \u003d odb.get_vlans()"},{"line_number":238,"context_line":"            vlanids \u003d \u0027\u0027"},{"line_number":239,"context_line":"            for v_id in vlan_ids:"},{"line_number":240,"context_line":"                vlanids \u003d str(v_id[0]) + \u0027,\u0027 + vlanids"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlhA%3D","line":237,"in_reply_to":"AAAALH%2F%2FlkU%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                                          self._func_name(),"},{"line_number":247,"context_line":"                                                          args)"},{"line_number":248,"context_line":"            return ovs_output[0]"},{"line_number":249,"context_line":"        except:"},{"line_number":250,"context_line":"            raise"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlkM%3D","line":249,"updated":"2012-08-29 14:18:09.000000000","message":"There is no point in having a blanket exception clause and then raising the exception. Please remove the try/except block.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                                          self._func_name(),"},{"line_number":247,"context_line":"                                                          args)"},{"line_number":248,"context_line":"            return ovs_output[0]"},{"line_number":249,"context_line":"        except:"},{"line_number":250,"context_line":"            raise"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def delete_network(self, context, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flg0%3D","line":249,"in_reply_to":"AAAALH%2F%2FlkM%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"}],"quantum/plugins/cisco/network_plugin.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        Virtual Network."},{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        LOG.debug(\"update_network() called\\n\")"},{"line_number":122,"context_line":"        upd_network \u003d super(PluginV2, self).update_network(context, id,"},{"line_number":123,"context_line":"                                                           network)"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            self._invoke_device_plugins(self._func_name(), [context, id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlkI%3D","line":122,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) Consider naming the return value of update_network() to be more informative.  What does update_network return?","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":119,"context_line":"        Virtual Network."},{"line_number":120,"context_line":"        \"\"\""},{"line_number":121,"context_line":"        LOG.debug(\"update_network() called\\n\")"},{"line_number":122,"context_line":"        upd_network \u003d super(PluginV2, self).update_network(context, id,"},{"line_number":123,"context_line":"                                                           network)"},{"line_number":124,"context_line":"        try:"},{"line_number":125,"context_line":"            self._invoke_device_plugins(self._func_name(), [context, id,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlgU%3D","line":122,"in_reply_to":"AAAALH%2F%2FlkI%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                            network)"},{"line_number":124,"context_line":"        self._invoke_device_plugins(self._func_name(), [context, id,"},{"line_number":125,"context_line":"                                                        upd_net_dict])"},{"line_number":126,"context_line":"        return upd_net_dict"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete_network(self, context, id):"},{"line_number":129,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlPM%3D","line":126,"updated":"2012-08-29 18:58:36.000000000","message":"I know Maru suggested to remove any blank exceptions and I do agree but wouldn\u0027t be possible to add an exception for this case?","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                            network)"},{"line_number":124,"context_line":"        self._invoke_device_plugins(self._func_name(), [context, id,"},{"line_number":125,"context_line":"                                                        upd_net_dict])"},{"line_number":126,"context_line":"        return upd_net_dict"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete_network(self, context, id):"},{"line_number":129,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlEY%3D","line":126,"in_reply_to":"AAAALH%2F%2FlJY%3D","updated":"2012-08-29 20:27:24.000000000","message":"sounds good, maybe in the future we can add one new exception for this case. approving the code!","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                            network)"},{"line_number":124,"context_line":"        self._invoke_device_plugins(self._func_name(), [context, id,"},{"line_number":125,"context_line":"                                                        upd_net_dict])"},{"line_number":126,"context_line":"        return upd_net_dict"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete_network(self, context, id):"},{"line_number":129,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlJY%3D","line":126,"in_reply_to":"AAAALH%2F%2FlLU%3D","updated":"2012-08-29 19:34:44.000000000","message":"thanks for the clarification...yes...the create_network exception handling is different and we cannot use it. Also, i dont see what would be an ideal exception for this case. I referenced others plugins and there isn\u0027t any there either for update_network.","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                            network)"},{"line_number":124,"context_line":"        self._invoke_device_plugins(self._func_name(), [context, id,"},{"line_number":125,"context_line":"                                                        upd_net_dict])"},{"line_number":126,"context_line":"        return upd_net_dict"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete_network(self, context, id):"},{"line_number":129,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlLU%3D","line":126,"in_reply_to":"AAAALH%2F%2FlM8%3D","updated":"2012-08-29 19:21:36.000000000","message":"What I wanted to say is that you cloud add an exception for this call similar to the one existing in create_network, not the same one nor a blank one of course but one for this specific case","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":123,"context_line":"                                                            network)"},{"line_number":124,"context_line":"        self._invoke_device_plugins(self._func_name(), [context, id,"},{"line_number":125,"context_line":"                                                        upd_net_dict])"},{"line_number":126,"context_line":"        return upd_net_dict"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def delete_network(self, context, id):"},{"line_number":129,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlM8%3D","line":126,"in_reply_to":"AAAALH%2F%2FlPM%3D","updated":"2012-08-29 19:12:29.000000000","message":"don\u0027t see any here.","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"}],"quantum/plugins/cisco/nexus/cisco_nexus_network_driver_v2.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":"        with self.nxos_connect(nexus_host, int(nexus_ssh_port), nexus_user,"},{"line_number":158,"context_line":"                               nexus_password) as man:"},{"line_number":159,"context_line":"            if vlan_ids is \u0027\u0027:"},{"line_number":160,"context_line":"                vlan_ids \u003d self.build_vlans_cmd()"},{"line_number":161,"context_line":"            for ports in nexus_ports:"},{"line_number":162,"context_line":"                self.enable_vlan_on_trunk_int(man, ports, vlan_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlkE%3D","line":159,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) Consider using implicit boolean conversion:\n\nif vlan_ids is \u0027\u0027 \u003d\u003e if not vlan_ids","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":156,"context_line":"        \"\"\""},{"line_number":157,"context_line":"        with self.nxos_connect(nexus_host, int(nexus_ssh_port), nexus_user,"},{"line_number":158,"context_line":"                               nexus_password) as man:"},{"line_number":159,"context_line":"            if vlan_ids is \u0027\u0027:"},{"line_number":160,"context_line":"                vlan_ids \u003d self.build_vlans_cmd()"},{"line_number":161,"context_line":"            for ports in nexus_ports:"},{"line_number":162,"context_line":"                self.enable_vlan_on_trunk_int(man, ports, vlan_ids)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlgQ%3D","line":159,"in_reply_to":"AAAALH%2F%2FlkE%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"}],"quantum/plugins/cisco/nexus/cisco_nexus_plugin_v2.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        Virtual Network."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.debug(\"NexusPlugin:update_network() called\\n\")"},{"line_number":139,"context_line":"        vlan_ids \u003d \u0027\u0027"},{"line_number":140,"context_line":"        for key in kwargs:"},{"line_number":141,"context_line":"            if key \u003d\u003d \u0027net_admin_state\u0027:"},{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fljg%3D","line":139,"updated":"2012-08-29 14:18:09.000000000","message":"This definition is unnecessary - the value for vlan_ids is always set on line 143.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":136,"context_line":"        Virtual Network."},{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.debug(\"NexusPlugin:update_network() called\\n\")"},{"line_number":139,"context_line":"        vlan_ids \u003d \u0027\u0027"},{"line_number":140,"context_line":"        for key in kwargs:"},{"line_number":141,"context_line":"            if key \u003d\u003d \u0027net_admin_state\u0027:"},{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlgM%3D","line":139,"in_reply_to":"AAAALH%2F%2Fljg%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.debug(\"NexusPlugin:update_network() called\\n\")"},{"line_number":139,"context_line":"        vlan_ids \u003d \u0027\u0027"},{"line_number":140,"context_line":"        for key in kwargs:"},{"line_number":141,"context_line":"            if key \u003d\u003d \u0027net_admin_state\u0027:"},{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"},{"line_number":143,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fljk%3D","line":140,"updated":"2012-08-29 14:18:09.000000000","message":"Since can only be one \u0027net_admin_state\u0027 in kwargs, this for loop is unnecessary.  Retrieve the value for the key directly:\n\nif kwargs.has_key(\u0027net_admin_state\u0027):\n  net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]\n  ...","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":"        \"\"\""},{"line_number":138,"context_line":"        LOG.debug(\"NexusPlugin:update_network() called\\n\")"},{"line_number":139,"context_line":"        vlan_ids \u003d \u0027\u0027"},{"line_number":140,"context_line":"        for key in kwargs:"},{"line_number":141,"context_line":"            if key \u003d\u003d \u0027net_admin_state\u0027:"},{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"},{"line_number":143,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlgA%3D","line":140,"in_reply_to":"AAAALH%2F%2Fljk%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"},{"line_number":143,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"},{"line_number":144,"context_line":"                vlan_ids \u003d kwargs[\u0027vlan_ids\u0027]"},{"line_number":145,"context_line":"                if net_admin_state is False:"},{"line_number":146,"context_line":"                    self._client.remove_vlan_int("},{"line_number":147,"context_line":"                        str(vlan_id), self._nexus_ip,"},{"line_number":148,"context_line":"                        self._nexus_username, self._nexus_password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fljc%3D","line":145,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) Avoid comparing booleans with a boolean.  Use implicit boolean conversion:\n\nif net_admin_state is False \u003d\u003e if not net_admin_state","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":142,"context_line":"                net_admin_state \u003d kwargs[\u0027net_admin_state\u0027]"},{"line_number":143,"context_line":"                vlan_id \u003d kwargs[\u0027vlan_id\u0027]"},{"line_number":144,"context_line":"                vlan_ids \u003d kwargs[\u0027vlan_ids\u0027]"},{"line_number":145,"context_line":"                if net_admin_state is False:"},{"line_number":146,"context_line":"                    self._client.remove_vlan_int("},{"line_number":147,"context_line":"                        str(vlan_id), self._nexus_ip,"},{"line_number":148,"context_line":"                        self._nexus_username, self._nexus_password,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flf8%3D","line":145,"in_reply_to":"AAAALH%2F%2Fljc%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"}],"quantum/tests/unit/cisco/test_nexus_plugin.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                   \u0027__init__\u0027, new\u003dnew_nexus_init):"},{"line_number":74,"context_line":"                self._cisco_nexus_plugin \u003d cisco_nexus_plugin_v2.NexusPlugin()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_a_create_delete_network(self):"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        Tests creation of two new Virtual Network."},{"line_number":79,"context_line":"        Tests deletion of one Virtual Network."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FljU%3D","line":76,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) Avoid differentiating tests by the use of numeric or alphabetic indexes.  Instead use a descriptive test name, e.g. test_create_two_networks_and_delete_one_network.\n\nThis comment applies to all other test method names modified by this change.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                   \u0027__init__\u0027, new\u003dnew_nexus_init):"},{"line_number":74,"context_line":"                self._cisco_nexus_plugin \u003d cisco_nexus_plugin_v2.NexusPlugin()"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    def test_a_create_delete_network(self):"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        Tests creation of two new Virtual Network."},{"line_number":79,"context_line":"        Tests deletion of one Virtual Network."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Flfw%3D","line":76,"in_reply_to":"AAAALH%2F%2FljU%3D","updated":"2012-08-29 15:56:21.000000000","message":"I wanted these tests to run in an order and as I understood they are run alphabetically by unit.test. Therefore, the prefix of an alphabet in front of the tests","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        test_nexus_clear_vlan after this test to clean"},{"line_number":86,"context_line":"        up the second vlan created by this test."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        LOG.debug(\"test_a_create_delete_network - START\")"},{"line_number":89,"context_line":"        tenant_id \u003d self.tenant_id"},{"line_number":90,"context_line":"        net_name \u003d self.net_name"},{"line_number":91,"context_line":"        net_id \u003d self.net_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FljM%3D","line":88,"updated":"2012-08-29 14:18:09.000000000","message":"(Suggestion only) I know this is a consistent patten, and as opposed to logging method entry and exit in regular code, logging test entry and exit is completely redundant.  All the test runners can be configured to indicate when a test is entered, and always output when a test has completed.  Consider removing this unnecessary logging from the tests.\n\nThis comment applies to all tests in this change.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":85,"context_line":"        test_nexus_clear_vlan after this test to clean"},{"line_number":86,"context_line":"        up the second vlan created by this test."},{"line_number":87,"context_line":"        \"\"\""},{"line_number":88,"context_line":"        LOG.debug(\"test_a_create_delete_network - START\")"},{"line_number":89,"context_line":"        tenant_id \u003d self.tenant_id"},{"line_number":90,"context_line":"        net_name \u003d self.net_name"},{"line_number":91,"context_line":"        net_id \u003d self.net_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FlfU%3D","line":88,"in_reply_to":"AAAALH%2F%2FljM%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"0d8a7ab9029ec4f2fab467c18bdd875a14b51920","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            second_vlan_name, second_vlan_id,"},{"line_number":171,"context_line":"            vlan_ids\u003dvlan_ids)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        netid \u003d self._cisco_nexus_plugin.update_network("},{"line_number":174,"context_line":"            tenant_id, net_id, net_admin_state\u003dFalse,"},{"line_number":175,"context_line":"            vlan_id\u003dvlan_id, vlan_ids\u003dstr(vlan_id))"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fli8%3D","line":173,"updated":"2012-08-29 14:18:09.000000000","message":"Deviating from the pep8 convention of underscore_separated variable names for the sake of differentiating two variables is highly discouaged.  Please provide different names for net_id and netid, e.g. expected_net_id and net_id, respectively.  \n\nThis comment also applies to lines 198 and 223.","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":170,"context_line":"            second_vlan_name, second_vlan_id,"},{"line_number":171,"context_line":"            vlan_ids\u003dvlan_ids)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        netid \u003d self._cisco_nexus_plugin.update_network("},{"line_number":174,"context_line":"            tenant_id, net_id, net_admin_state\u003dFalse,"},{"line_number":175,"context_line":"            vlan_id\u003dvlan_id, vlan_ids\u003dstr(vlan_id))"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fles%3D","line":173,"in_reply_to":"AAAALH%2F%2Fli8%3D","updated":"2012-08-29 15:56:21.000000000","message":"Done","commit_id":"e2425561a2ef3095d4e262f4757e43bc8aecb95a"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"                self._cisco_nexus_plugin \u003d cisco_nexus_plugin_v2.NexusPlugin()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_a_create_delete_network(self):"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        Tests creation of two new Virtual Network."},{"line_number":76,"context_line":"        Tests deletion of one Virtual Network."},{"line_number":77,"context_line":"        This would result the following -"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlOo%3D","line":74,"updated":"2012-08-29 18:58:36.000000000","message":"Would be better to remove the \"a, b, c, etc...\" from the test cases names?","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"                self._cisco_nexus_plugin \u003d cisco_nexus_plugin_v2.NexusPlugin()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_a_create_delete_network(self):"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        Tests creation of two new Virtual Network."},{"line_number":76,"context_line":"        Tests deletion of one Virtual Network."},{"line_number":77,"context_line":"        This would result the following -"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlLQ%3D","line":74,"in_reply_to":"AAAALH%2F%2FlM0%3D","updated":"2012-08-29 19:21:36.000000000","message":"My bad! Didn\u0027t see that comment from Maru\u0027s review!\nThanks","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"},{"author":{"_account_id":141,"name":"Rohit Agarwalla","email":"roagarwa@cisco.com","username":"rohitagarwalla"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"                self._cisco_nexus_plugin \u003d cisco_nexus_plugin_v2.NexusPlugin()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def test_a_create_delete_network(self):"},{"line_number":74,"context_line":"        \"\"\""},{"line_number":75,"context_line":"        Tests creation of two new Virtual Network."},{"line_number":76,"context_line":"        Tests deletion of one Virtual Network."},{"line_number":77,"context_line":"        This would result the following -"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FlM0%3D","line":74,"in_reply_to":"AAAALH%2F%2FlOo%3D","updated":"2012-08-29 19:12:29.000000000","message":"please refer to the discussion with Maru on this one.","commit_id":"f75256f9574955c65b4e64a6701128044fc64278"}]}