)]}'
{"neutron/common/exceptions.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"bdee2272ebe9804b97c943e1425b74642fa2b983","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \"The number of DNS nameservers exceeds the limit %(quota)s.\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InvalidIpForNetwork(BadRequest):"},{"line_number":145,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":146,"context_line":"                \"for the defined subnet.\")"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_0a2be533","line":144,"updated":"2014-12-31 17:50:10.000000000","message":"The error message should include all of the subnet CIDRs on the network, and the network ID.","commit_id":"fa5aad54fad85080383c293a363228815c63b423"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"3d7c1a42adc8775c0a2198a04751f200adc80204","unresolved":false,"context_lines":[{"line_number":141,"context_line":"                \"The number of DNS nameservers exceeds the limit %(quota)s.\")"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InvalidIpForNetwork(BadRequest):"},{"line_number":145,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":146,"context_line":"                \"for the defined subnet.\")"},{"line_number":147,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_52674dea","line":144,"in_reply_to":"3a961159_0a2be533","updated":"2015-01-04 05:30:43.000000000","message":"One tempest case is validating this error message now. I need to think how to make it better.","commit_id":"fa5aad54fad85080383c293a363228815c63b423"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"690378f842348324ffc4a1cedd61b9207c0408a1","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InvalidIpForNetwork(BadRequest):"},{"line_number":145,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":146,"context_line":"                \"for the defined networks subnets.\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_d302beb3","line":146,"updated":"2015-01-27 19:43:22.000000000","message":"\"for any of the subnets on the specified network.\"","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"74752ead2da6b4729d71bccd3498d2c57da511a0","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InvalidIpForNetwork(BadRequest):"},{"line_number":145,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":146,"context_line":"                \"for the defined networks subnets.\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_0d5ef5e9","line":146,"updated":"2015-01-27 19:40:36.000000000","message":"\"given\" or \"specified\" looks better rather than \"defined\".\nI know this word is used now, but it is a good chance to reword.","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"11b9b651e11a8b1a294b32dab5a8881d97ac1a30","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class InvalidIpForNetwork(BadRequest):"},{"line_number":145,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":146,"context_line":"                \"for the defined networks subnets.\")"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_f34a62ab","line":146,"in_reply_to":"fa81d914_0d5ef5e9","updated":"2015-01-27 19:53:59.000000000","message":"Done","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"690378f842348324ffc4a1cedd61b9207c0408a1","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"},{"line_number":150,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":151,"context_line":"                \"for the defined subnet.\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class IpAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_b31c6a15","line":151,"updated":"2015-01-27 19:43:22.000000000","message":"+1 for specified","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"74752ead2da6b4729d71bccd3498d2c57da511a0","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"},{"line_number":150,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":151,"context_line":"                \"for the defined subnet.\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class IpAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_4d58edfa","line":151,"updated":"2015-01-27 19:40:36.000000000","message":"ditto","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"11b9b651e11a8b1a294b32dab5a8881d97ac1a30","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"class InvalidIpForSubnet(BadRequest):"},{"line_number":150,"context_line":"    message \u003d _(\"IP address %(ip_address)s is not a valid IP \""},{"line_number":151,"context_line":"                \"for the defined subnet.\")"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"class IpAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa81d914_13c7f613","line":151,"in_reply_to":"fa81d914_4d58edfa","updated":"2015-01-27 19:53:59.000000000","message":"Done","commit_id":"91f5273d02de15d9575b84528454ba572cb0c387"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"e8be227314b60285e73d3b045ec0aa18db29986c","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        Check that configured subnets are valid prior to allocating any"},{"line_number":358,"context_line":"        IPs. Include the subnet_id in the result if only an IP address is"},{"line_number":359,"context_line":"        configured."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        :raises: InvalidInput, IpAddressInUse"},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":"        fixed_ip_set \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa81d914_1fd37739","line":360,"updated":"2015-01-27 21:23:25.000000000","message":"The two new exceptions should be added here.","commit_id":"d874d3c8e6d400782aa84372979755d7bfee240e"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"dd30b01ec8c79939fcd28c1ecff6cc9367690b3f","unresolved":false,"context_lines":[{"line_number":357,"context_line":"        Check that configured subnets are valid prior to allocating any"},{"line_number":358,"context_line":"        IPs. Include the subnet_id in the result if only an IP address is"},{"line_number":359,"context_line":"        configured."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"        :raises: InvalidInput, IpAddressInUse"},{"line_number":362,"context_line":"        \"\"\""},{"line_number":363,"context_line":"        fixed_ip_set \u003d []"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa81d914_1fda8678","line":360,"in_reply_to":"fa81d914_1fd37739","updated":"2015-01-28 05:53:48.000000000","message":"Done","commit_id":"d874d3c8e6d400782aa84372979755d7bfee240e"}],"neutron/tests/unit/opencontrail/test_contrail_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"51c930f7ac5672a1578cc663ffaa37eed4309e2f","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":259,"context_line":"                          ContrailPluginTestCase):"},{"line_number":260,"context_line":"    def setUp(self):"},{"line_number":261,"context_line":"        super(TestContrailPortsV2, self).setUp()"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_create_port_public_network_with_invalid_ip_no_subnet_id(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba7be1f8_3bd7cc4c","line":260,"updated":"2015-02-25 05:03:50.000000000","message":"This setup method can be removed. Mind removing it as well.","commit_id":"64e0af6bd505d78d053669775ac536b9e4404f93"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"700842dd28f28c978afeda0964520c08833f7ac5","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class TestContrailPortsV2(test_plugin.TestPortsV2,"},{"line_number":259,"context_line":"                          ContrailPluginTestCase):"},{"line_number":260,"context_line":"    def setUp(self):"},{"line_number":261,"context_line":"        super(TestContrailPortsV2, self).setUp()"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def test_create_port_public_network_with_invalid_ip_no_subnet_id(self):"}],"source_content_type":"text/x-python","patch_set":16,"id":"ba7be1f8_1d801cbf","line":260,"in_reply_to":"ba7be1f8_3bd7cc4c","updated":"2015-02-25 18:47:58.000000000","message":"Done","commit_id":"64e0af6bd505d78d053669775ac536b9e4404f93"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1b562d9fe8afd86736a81c9f2be9eaf304951a42","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                                        set_context\u003dTrue)"},{"line_number":850,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":851,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":852,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"    def test_create_ports_bulk_native(self):"},{"line_number":855,"context_line":"        if self._skip_native_bulk:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_b8b3a14b","line":852,"updated":"2014-10-07 12:24:31.000000000","message":"nit: assert args should be (expected, actual). Could name variable, expected vs msg.","commit_id":"293ae636e4190847d1801de6e0b1ce7e3a6367ad"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"7799e87c9f2c416c84c6a7fcdf2ee730f5e39371","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                                        set_context\u003dTrue)"},{"line_number":850,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":851,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":852,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"    def test_create_ports_bulk_native(self):"},{"line_number":855,"context_line":"        if self._skip_native_bulk:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_cf1c876d","line":852,"in_reply_to":"baa201ad_b8b3a14b","updated":"2014-10-13 17:49:50.000000000","message":"Hi Paul, I did not notice that argument order rule. Where is the reference doc? Thanks!","commit_id":"293ae636e4190847d1801de6e0b1ce7e3a6367ad"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"c5e9e3db2b6b7ac057cea0d2a7a5618cbef9a666","unresolved":false,"context_lines":[{"line_number":849,"context_line":"                                        set_context\u003dTrue)"},{"line_number":850,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":851,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":852,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":853,"context_line":""},{"line_number":854,"context_line":"    def test_create_ports_bulk_native(self):"},{"line_number":855,"context_line":"        if self._skip_native_bulk:"}],"source_content_type":"text/x-python","patch_set":4,"id":"baa201ad_012d4695","line":852,"in_reply_to":"baa201ad_cf1c876d","updated":"2014-10-15 11:39:58.000000000","message":"Not a rule, but more of a convention (hence the nit). Python docs just say (first, second). However, depending on the data type, if you have a dict, and there is a mismatch, it will report the first as \"reference\" and second as \"actual\". Just figured that if you are updating the code for other purposes, you can consider this too.","commit_id":"293ae636e4190847d1801de6e0b1ce7e3a6367ad"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"fd40b102316bd680f4d6d0f663fe77702f6d2062","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                self.assertIn(\u0027mac_address\u0027, port[\u0027port\u0027])"},{"line_number":846,"context_line":"                self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def test_create_port_public_network_with_invalid_ip(self):"},{"line_number":849,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":850,"context_line":"            with self.subnet(network\u003dnetwork, cidr\u003d\u002710.0.0.0/24\u0027) as subnet:"},{"line_number":851,"context_line":"                ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_42e96db6","line":848,"updated":"2015-01-20 18:49:00.000000000","message":"In the code, there are two conditions that raise the exception. Is it possible to test both of them?","commit_id":"d135dceec68a4a33a2108d93f2953ecb1d49dbe4"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"886457049c8eafd77b7d03f234080568afd4b67c","unresolved":false,"context_lines":[{"line_number":845,"context_line":"                self.assertIn(\u0027mac_address\u0027, port[\u0027port\u0027])"},{"line_number":846,"context_line":"                self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":847,"context_line":""},{"line_number":848,"context_line":"    def test_create_port_public_network_with_invalid_ip(self):"},{"line_number":849,"context_line":"        with self.network(shared\u003dTrue) as network:"},{"line_number":850,"context_line":"            with self.subnet(network\u003dnetwork, cidr\u003d\u002710.0.0.0/24\u0027) as subnet:"},{"line_number":851,"context_line":"                ips \u003d [{\u0027subnet_id\u0027: subnet[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a930d6b_f4dfc566","line":848,"in_reply_to":"3a961159_42e96db6","updated":"2015-01-27 18:25:45.000000000","message":"Thanks! I add two test cases to address them.","commit_id":"d135dceec68a4a33a2108d93f2953ecb1d49dbe4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1ed1ecbbc9589305f89922319f138cc39e691e0","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_17aa7770","line":859,"updated":"2015-01-31 12:21:48.000000000","message":"It is better to check data[\"NeutronError\u0027][\u0027type\u0027] rather than [\u0027message\u0027].","commit_id":"7b61662c46df74e40e6b21e9ab4457c5c364c66b"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"d8b8fc4006638ed3fecdfdc9551a8d3231b96614","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_c2f6b1f8","line":859,"in_reply_to":"da86d52c_17aa7770","updated":"2015-02-05 04:14:18.000000000","message":"@Akihiro, opencontrail plugin override the error type so that I can not hard code error type here to check it. I did not find other unit test who can handle this case. Do you know how to write this type checking?\n\nMismatchError: u\u0027ContrailBadRequestError\u0027 !\u003d \u0027InvalidIpForSubnet\u0027","commit_id":"7b61662c46df74e40e6b21e9ab4457c5c364c66b"},{"author":{"_account_id":8574,"name":"Qin Zhao","username":"zhaoqin","inactive":true},"change_message_id":"877f324dc60a7a482160b8df6d6865790160cf0b","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_72aec582","line":859,"in_reply_to":"da86d52c_17aa7770","updated":"2015-02-04 20:03:06.000000000","message":"Let me check both...","commit_id":"7b61662c46df74e40e6b21e9ab4457c5c364c66b"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"e3efcf840200492e61d79f1e4ba54f994b2591b9","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_c59cfb5f","line":859,"in_reply_to":"da86d52c_c2f6b1f8","updated":"2015-02-05 05:21:15.000000000","message":"fix contrail, or skip the test for it by overriding TestContrailPortsV2?","commit_id":"7b61662c46df74e40e6b21e9ab4457c5c364c66b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"b1ed1ecbbc9589305f89922319f138cc39e691e0","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                                        set_context\u003dTrue)"},{"line_number":871,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":872,"context_line":"                msg \u003d str(n_exc.InvalidIpForSubnet(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":873,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    def test_create_ports_bulk_native(self):"},{"line_number":876,"context_line":"        if self._skip_native_bulk:"}],"source_content_type":"text/x-python","patch_set":12,"id":"da86d52c_37b69bdd","line":873,"updated":"2015-01-31 12:21:48.000000000","message":"Ditto","commit_id":"7b61662c46df74e40e6b21e9ab4457c5c364c66b"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"47656b7007582ac1c61020f1b973bd668a2af9c9","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_eadffed3","line":859,"updated":"2015-02-05 12:57:56.000000000","message":"Nit: expected value should be first. Here an L873. Also, you could name it \"exected_msg\".","commit_id":"87772089350cff668518460bdd3091dc8b1df3ce"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"060c03358dc722b445da21d4c91dacaf727569c2","unresolved":false,"context_lines":[{"line_number":856,"context_line":"                                        set_context\u003dTrue)"},{"line_number":857,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":858,"context_line":"                msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":859,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    def test_create_port_public_network_with_invalid_ip_and_subnet_id(self):"},{"line_number":862,"context_line":"        with self.network(shared\u003dTrue) as network:"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_3a80648a","line":859,"in_reply_to":"da86d52c_eadffed3","updated":"2015-02-06 06:59:55.000000000","message":"+1\n\nhere the expected value is msg \u003d str(n_exc.InvalidIpForNetwork(ip_address\u003d\u00271.1.1.1\u0027))\n\nand actual value is data \u003d self.deserialize(self.fmt, res)\n\nand according to https://docs.python.org/2/library/unittest.html\nassertEqual should have assertEqual(expected, actual)","commit_id":"87772089350cff668518460bdd3091dc8b1df3ce"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"060c03358dc722b445da21d4c91dacaf727569c2","unresolved":false,"context_lines":[{"line_number":870,"context_line":"                                        set_context\u003dTrue)"},{"line_number":871,"context_line":"                data \u003d self.deserialize(self.fmt, res)"},{"line_number":872,"context_line":"                msg \u003d str(n_exc.InvalidIpForSubnet(ip_address\u003d\u00271.1.1.1\u0027))"},{"line_number":873,"context_line":"                self.assertEqual(data[\u0027NeutronError\u0027][\u0027message\u0027], msg)"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    def test_create_ports_bulk_native(self):"},{"line_number":876,"context_line":"        if self._skip_native_bulk:"}],"source_content_type":"text/x-python","patch_set":14,"id":"da86d52c_ba43746a","line":873,"updated":"2015-02-06 06:59:55.000000000","message":"ditto","commit_id":"87772089350cff668518460bdd3091dc8b1df3ce"}]}
