)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"aaa05ba01601759fcabc761ce3c2ec743289c909","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit sets the port status to \"N/A\" to reflect the fact"},{"line_number":15,"context_line":"that the port associated with a floating IP has no operational"},{"line_number":16,"context_line":"status."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1196851"},{"line_number":19,"context_line":"Change-Id: I2f94afa001b213d61f0e5892aae2e6e6de98fe4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa963961_e23006a1","line":16,"updated":"2015-03-26 13:21:48.000000000","message":"Do we need a DocImpact tag?","commit_id":"022631e3467cc9c5db134e008c27e32351f6338f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"214907dc94c585523fb43706143804ec0ddd9c79","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This commit sets the port status to \"N/A\" to reflect the fact"},{"line_number":15,"context_line":"that the port associated with a floating IP has no operational"},{"line_number":16,"context_line":"status."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1196851"},{"line_number":19,"context_line":"Change-Id: I2f94afa001b213d61f0e5892aae2e6e6de98fe4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"fa963961_4aa1f5a8","line":16,"in_reply_to":"fa963961_e23006a1","updated":"2015-03-26 21:45:11.000000000","message":"Probably.","commit_id":"022631e3467cc9c5db134e008c27e32351f6338f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b63c878a2585e1f9f10499a36d41321d2533fb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"that the port associated with a floating IP has no operational"},{"line_number":16,"context_line":"status."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1196851"},{"line_number":21,"context_line":"Change-Id: I2f94afa001b213d61f0e5892aae2e6e6de98fe4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9b358b_e343616b","line":18,"updated":"2015-03-28 16:51:00.000000000","message":"ApiImpact too.\n\nIt introduces a new value to port status.","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce497cfaab82b002efe4fc744c31b8d032ff6cf0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"that the port associated with a floating IP has no operational"},{"line_number":16,"context_line":"status."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1196851"},{"line_number":21,"context_line":"Change-Id: I2f94afa001b213d61f0e5892aae2e6e6de98fe4c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"da9b358b_4081cc49","line":18,"in_reply_to":"da9b358b_e343616b","updated":"2015-03-30 10:31:04.000000000","message":"Done","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"}],"neutron/common/constants.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"dd7425dd9f04e848b75b24e41c4e5e0a0b2b338b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":35,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6ced46_4f9d9765","line":32,"updated":"2015-03-26 11:50:08.000000000","message":"Would it make sense to have PORT_ prefix on this?","commit_id":"022631e3467cc9c5db134e008c27e32351f6338f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"214907dc94c585523fb43706143804ec0ddd9c79","unresolved":false,"context_lines":[{"line_number":29,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":35,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa963961_8ac81d76","line":32,"in_reply_to":"1a6ced46_4f9d9765","updated":"2015-03-26 21:45:11.000000000","message":"I was looking at Salvatore\u0027s comment at the top of this file and thought there wasn\u0027t anything specific about a port N/A state so I made it more widely usable.","commit_id":"022631e3467cc9c5db134e008c27e32351f6338f"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"70bb7cc4621092ae4e6fd7dfc10ff6a4da7a773e","unresolved":false,"context_lines":[{"line_number":29,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":35,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_07e51808","line":32,"updated":"2015-03-27 08:53:32.000000000","message":"I would call it PORT_STATUS_NOTAPPLICABLE (few lines above)","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"9acecd6e6b5a67761fbe28275a876e632035f2d4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":35,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""}],"source_content_type":"text/x-python","patch_set":9,"id":"da9b358b_8ad82af1","line":32,"in_reply_to":"fa963961_07e51808","updated":"2015-03-28 09:21:53.000000000","message":"Done","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"7820aceaa070b5e47b16ab4da9b1d2ce8cdeaffd","unresolved":false,"context_lines":[{"line_number":29,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"DEVICE_OWNER_ROUTER_HA_INTF \u003d \"network:router_ha_interface\""},{"line_number":35,"context_line":"DEVICE_OWNER_ROUTER_INTF \u003d \"network:router_interface\""}],"source_content_type":"text/x-python","patch_set":9,"id":"da9b358b_c408702b","line":32,"in_reply_to":"fa963961_07e51808","updated":"2015-03-27 23:11:45.000000000","message":"I do agree with the suggestion, otherwise it could be understood as NOT AVAILABLE.. Just make it short: NOT_APPLICABLE","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b63c878a2585e1f9f10499a36d41321d2533fb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PORT_STATUS_BUILD \u003d \u0027BUILD\u0027"},{"line_number":25,"context_line":"PORT_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":26,"context_line":"PORT_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":27,"context_line":"PORT_STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"FLOATINGIP_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_6393d1fb","line":27,"updated":"2015-03-28 16:51:00.000000000","message":"I think N/A usually means \"not available\". Is it different?","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"66b63c878a2585e1f9f10499a36d41321d2533fb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PORT_STATUS_BUILD \u003d \u0027BUILD\u0027"},{"line_number":25,"context_line":"PORT_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":26,"context_line":"PORT_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":27,"context_line":"PORT_STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"FLOATINGIP_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_8386d5b7","line":27,"updated":"2015-03-28 16:51:00.000000000","message":"I think N/A usually means \"not available\". Is it different?","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"ce497cfaab82b002efe4fc744c31b8d032ff6cf0","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PORT_STATUS_BUILD \u003d \u0027BUILD\u0027"},{"line_number":25,"context_line":"PORT_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":26,"context_line":"PORT_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":27,"context_line":"PORT_STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"FLOATINGIP_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_c0b6fc3c","line":27,"in_reply_to":"da9b358b_8386d5b7","updated":"2015-03-30 10:31:04.000000000","message":"It can mean either. http://en.wikipedia.org/wiki/N/a","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"396f95735e7e08b06805e39329d2f62221aab1fd","unresolved":false,"context_lines":[{"line_number":24,"context_line":"PORT_STATUS_BUILD \u003d \u0027BUILD\u0027"},{"line_number":25,"context_line":"PORT_STATUS_DOWN \u003d \u0027DOWN\u0027"},{"line_number":26,"context_line":"PORT_STATUS_ERROR \u003d \u0027ERROR\u0027"},{"line_number":27,"context_line":"PORT_STATUS_NOTAPPLICABLE \u003d \u0027N/A\u0027"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"FLOATINGIP_STATUS_ACTIVE \u003d \u0027ACTIVE\u0027"},{"line_number":30,"context_line":"FLOATINGIP_STATUS_DOWN \u003d \u0027DOWN\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_3cb02cdd","line":27,"in_reply_to":"da9b358b_c0b6fc3c","updated":"2015-03-30 15:05:11.000000000","message":"Thanks. Got it.","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"}],"neutron/db/l3_db.py":[{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"213312c0aa2213f08ce87bb7679f3f12916701f3","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        \"\"\"Update operational status for floating IP in neutron DB.\"\"\""},{"line_number":777,"context_line":"        fip_query \u003d self._model_query(context, FloatingIP).filter("},{"line_number":778,"context_line":"            FloatingIP.id \u003d\u003d floatingip_id)"},{"line_number":779,"context_line":"        port_id \u003d fip_query.first().get(\u0027floating_port_id\u0027)"},{"line_number":780,"context_line":"        # update the corresponding port status for consistency"},{"line_number":781,"context_line":"        if port_id:"},{"line_number":782,"context_line":"            if status \u003d\u003d l3_constants.FLOATINGIP_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa98f980_b7a5f548","line":779,"updated":"2014-09-18 06:23:09.000000000","message":"Can fip_query.first() be None ?","commit_id":"283b981095482c40acfdc8aa69fe0582431dc66c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2c6fd04dbc58a2d9fe31059e32f0959d4664f57e","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        \"\"\"Update operational status for floating IP in neutron DB.\"\"\""},{"line_number":777,"context_line":"        fip_query \u003d self._model_query(context, FloatingIP).filter("},{"line_number":778,"context_line":"            FloatingIP.id \u003d\u003d floatingip_id)"},{"line_number":779,"context_line":"        fip_query.update({\u0027status\u0027: status}, synchronize_session\u003dFalse)"},{"line_number":780,"context_line":"        # update the corresponding port status for consistency"},{"line_number":781,"context_line":"        fip \u003d fip_query.first()"},{"line_number":782,"context_line":"        if fip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_91836155","line":779,"updated":"2015-01-23 17:23:38.000000000","message":"I\u0027m not a SQL guy to say the least, but this \u0027synchronize_session\u003dFalse\u0027 thing is suspicious. As per SQLAlchemy docs, it means: \"Before the expiration, updated objects may still remain in the session with stale values on their attributes, which can lead to confusing results.\"\n\nSince we are going to use fip attributes later, shouldn\u0027t we change the argument? Or am I missing everything?","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"08c8373b472d54107a87b652a8c9635983a66db0","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        \"\"\"Update operational status for floating IP in neutron DB.\"\"\""},{"line_number":777,"context_line":"        fip_query \u003d self._model_query(context, FloatingIP).filter("},{"line_number":778,"context_line":"            FloatingIP.id \u003d\u003d floatingip_id)"},{"line_number":779,"context_line":"        fip_query.update({\u0027status\u0027: status}, synchronize_session\u003dFalse)"},{"line_number":780,"context_line":"        # update the corresponding port status for consistency"},{"line_number":781,"context_line":"        fip \u003d fip_query.first()"},{"line_number":782,"context_line":"        if fip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da86d52c_2dfa55bd","line":779,"in_reply_to":"1a930d6b_719b5572","updated":"2015-02-10 22:00:50.000000000","message":"ACK. I will probably fix this as part of a separate patch because this one might not end up going anywhere.","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":11816,"name":"mike bayer","display_name":"Mike Bayer","email":"mike_mp@zzzcomputing.com","username":"zzzeek","status":"Red Hat"},"change_message_id":"2ab4d1e763c20a2ca811ae526883f7e08e1d795b","unresolved":false,"context_lines":[{"line_number":776,"context_line":"        \"\"\"Update operational status for floating IP in neutron DB.\"\"\""},{"line_number":777,"context_line":"        fip_query \u003d self._model_query(context, FloatingIP).filter("},{"line_number":778,"context_line":"            FloatingIP.id \u003d\u003d floatingip_id)"},{"line_number":779,"context_line":"        fip_query.update({\u0027status\u0027: status}, synchronize_session\u003dFalse)"},{"line_number":780,"context_line":"        # update the corresponding port status for consistency"},{"line_number":781,"context_line":"        fip \u003d fip_query.first()"},{"line_number":782,"context_line":"        if fip:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_719b5572","line":779,"in_reply_to":"1a930d6b_91836155","updated":"2015-01-23 17:43:07.000000000","message":"OK well the first thing that stands out here is the use of query.update(), which is there just to update lots of rows without needing to SELECT them, but this is just one row, which you do in fact want to SELECT.  So this would be a lot simpler if you just used regular ORM patterns:\n\n    fip \u003d self._model_query(...).filter(...).first()\n    if fip:\n        fip.status \u003d status\n        self._set_port_status_to_fip_status(context, fip)\n\nthe change of fip.status will be flushed when the Session next emits a query or when commit() is called.\n\nthe reason we\u0027re starting to use more query.update() elsewhere is to implement so-called \"compare and swap\" updates, but that\u0027s not what\u0027s happening here, and if it were, there\u0027s an oslo_db function I\u0027d prefer people use (once I get it approved :) ). \n\nNow all of that said, if you absolutely need to call query.update() and then you want to do the first(), you can force the first() to definitely populate an existing object like this:\n\n    fip_query.populate_existing().first()\n\nbut from what I see, the need for query.update() is not present here.   the ORM synchronizes the state of loaded objects more or less automatically (e.g. there is an UPDATE statement but it happens automatically).","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"204bc3b1e9b53635bf09513fa86bcef3fa41f196","unresolved":false,"context_lines":[{"line_number":782,"context_line":"        if fip:"},{"line_number":783,"context_line":"            self._set_port_status_to_fip_status(context, fip)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"    def _set_port_status_to_fip_status(self, context, fip):"},{"line_number":786,"context_line":"        if not fip.get(\u0027floating_port_id\u0027):"},{"line_number":787,"context_line":"            return"},{"line_number":788,"context_line":"        if fip.status \u003d\u003d l3_constants.FLOATINGIP_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_41cede84","line":785,"updated":"2014-09-22 16:36:30.000000000","message":"you\u0027re calling this method from update_floatingip_status, which is about updating the operational status for a FIP in Neutron DB, but, the method calls into the backends. I smell inconsistency here.","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"4ae96f66da7fe29a23a93e07c97579cd30bc2538","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":1124,"context_line":"        old_floatingip, floatingip \u003d self._update_floatingip("},{"line_number":1125,"context_line":"            context, id, floatingip)"},{"line_number":1126,"context_line":"        self._set_port_status_to_fip_status(context, floatingip)"},{"line_number":1127,"context_line":"        router_ids \u003d self._floatingips_to_router_ids("},{"line_number":1128,"context_line":"            [old_floatingip, floatingip])"},{"line_number":1129,"context_line":"        super(L3_NAT_db_mixin, self).notify_routers_updated("}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_64d04251","line":1126,"updated":"2014-09-23 01:46:05.000000000","message":"I went back and forth on this. They are really separate objects so it actually makes more sense to me to call update_port method from the core plugin. Thoughts?","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"204bc3b1e9b53635bf09513fa86bcef3fa41f196","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":1124,"context_line":"        old_floatingip, floatingip \u003d self._update_floatingip("},{"line_number":1125,"context_line":"            context, id, floatingip)"},{"line_number":1126,"context_line":"        self._set_port_status_to_fip_status(context, floatingip)"},{"line_number":1127,"context_line":"        router_ids \u003d self._floatingips_to_router_ids("},{"line_number":1128,"context_line":"            [old_floatingip, floatingip])"},{"line_number":1129,"context_line":"        super(L3_NAT_db_mixin, self).notify_routers_updated("}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_a1aa2a6e","line":1126,"updated":"2014-09-22 16:36:30.000000000","message":"this calls into the backends, but _update_floatingip does it too. For instance, the NSX plugin overrides _update_fip_assoc (which is called by _update_floatingip), which takes care of the state propagation already.\n\nSee:\n\nhttps://review.openstack.org/#/c/103214","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"083ee956425857d454325d16a37120e1e1790aff","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":1124,"context_line":"        old_floatingip, floatingip \u003d self._update_floatingip("},{"line_number":1125,"context_line":"            context, id, floatingip)"},{"line_number":1126,"context_line":"        self._set_port_status_to_fip_status(context, floatingip)"},{"line_number":1127,"context_line":"        router_ids \u003d self._floatingips_to_router_ids("},{"line_number":1128,"context_line":"            [old_floatingip, floatingip])"},{"line_number":1129,"context_line":"        super(L3_NAT_db_mixin, self).notify_routers_updated("}],"source_content_type":"text/x-python","patch_set":5,"id":"da9df570_912546c4","line":1126,"in_reply_to":"da9df570_64d04251","updated":"2014-09-23 23:46:54.000000000","message":"good question, let me loop in Salvatore. He might have an opinion too.\n\nupdate_floatingip_status is only affected by plugins that rely on the l3 agent, so for those that don\u0027t this should be ok (so NSX was a poor choice of mine, sorry).\n\nSo might it make sense to remove the update from here and deal with each plugin on a case by base basis? I know it sucks a little bit.","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2f45eee0d12d480b13c25218c0c5ff6a995fb3eb","unresolved":false,"context_lines":[{"line_number":1123,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":1124,"context_line":"        old_floatingip, floatingip \u003d self._update_floatingip("},{"line_number":1125,"context_line":"            context, id, floatingip)"},{"line_number":1126,"context_line":"        self._set_port_status_to_fip_status(context, floatingip)"},{"line_number":1127,"context_line":"        router_ids \u003d self._floatingips_to_router_ids("},{"line_number":1128,"context_line":"            [old_floatingip, floatingip])"},{"line_number":1129,"context_line":"        super(L3_NAT_db_mixin, self).notify_routers_updated("}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_fd144545","line":1126,"in_reply_to":"da9df570_912546c4","updated":"2014-10-07 01:38:29.000000000","message":"Any thoughts from Salvatore?","commit_id":"c726bf1f4e53dc26d2face56200468f650d9ee6b"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4e6a6099abc3b4151cea88862227a9a48b68ab09","unresolved":false,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _create_port_db(self, context, port):"},{"line_number":933,"context_line":"        attrs \u003d port[attributes.PORT]"},{"line_number":934,"context_line":"        if not attrs.get(\u0027status\u0027):"},{"line_number":935,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_e19fc45d","line":934,"updated":"2015-03-27 07:37:06.000000000","message":"you can use directly instead of L934-935:\n\n  attrs.setdefault(\u0027status\u0027, const.PORT_STATUS_DOWN)","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"07bfa8697950effffe68829bd658460a76ebe38e","unresolved":false,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _create_port_db(self, context, port):"},{"line_number":933,"context_line":"        attrs \u003d port[attributes.PORT]"},{"line_number":934,"context_line":"        if not attrs.get(\u0027status\u0027):"},{"line_number":935,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_cd52b1dd","line":934,"in_reply_to":"fa963961_27737c82","updated":"2015-03-27 09:37:43.000000000","message":"ok","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"53488164e3acb5952078877976de9b197c9b2b4e","unresolved":false,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _create_port_db(self, context, port):"},{"line_number":933,"context_line":"        attrs \u003d port[attributes.PORT]"},{"line_number":934,"context_line":"        if not attrs.get(\u0027status\u0027):"},{"line_number":935,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_e790f497","line":934,"in_reply_to":"fa963961_e19fc45d","updated":"2015-03-27 08:35:00.000000000","message":"I always forget about setdefault...","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b5cce79a663d2011befed537f1c12b67243151a2","unresolved":false,"context_lines":[{"line_number":931,"context_line":""},{"line_number":932,"context_line":"    def _create_port_db(self, context, port):"},{"line_number":933,"context_line":"        attrs \u003d port[attributes.PORT]"},{"line_number":934,"context_line":"        if not attrs.get(\u0027status\u0027):"},{"line_number":935,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa963961_27737c82","line":934,"in_reply_to":"fa963961_e790f497","updated":"2015-03-27 08:39:02.000000000","message":"Oh, but that won\u0027t catch if a caller passes in a blank status. I wanted to be pretty defensive here.","commit_id":"387f6f84aebef844b53ba2fbb48dc83bc06ff261"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"396f95735e7e08b06805e39329d2f62221aab1fd","unresolved":false,"context_lines":[{"line_number":932,"context_line":"    def _create_port_db(self, context, port):"},{"line_number":933,"context_line":"        attrs \u003d port[attributes.PORT]"},{"line_number":934,"context_line":"        if not attrs.get(\u0027status\u0027):"},{"line_number":935,"context_line":"            attrs[\u0027status\u0027] \u003d const.PORT_STATUS_DOWN"},{"line_number":936,"context_line":""},{"line_number":937,"context_line":"        session \u003d context.session"},{"line_number":938,"context_line":"        with session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da9b358b_bc49dcd2","line":935,"updated":"2015-03-30 15:05:11.000000000","message":"(just comment) we can use:\n\n  attrs.setdefault(\u0027status\u0027, const.PORT_STATUS_DOWN)","commit_id":"f71febc4e868b0ca790691b6bf7b23322396fbd6"}]}
