)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"f91b0d8306c335f9b1aa097533daa74cd56e5d4e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"with the network or the subnet that cannot be autodeleted,"},{"line_number":13,"context_line":"an exception is raised. The operation will be rolled back."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I29178204b3a220c1c6010f59272981fb1b4099fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aa7fdbe_ec0807dc","line":15,"updated":"2014-10-27 10:12:37.000000000","message":"it seems this change Closes-Bug: #1331564","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2bb219b6a424ba1c2167e13ef4c569a450a816e0","unresolved":false,"context_lines":[{"line_number":12,"context_line":"with the network or the subnet that cannot be autodeleted,"},{"line_number":13,"context_line":"an exception is raised. The operation will be rolled back."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I29178204b3a220c1c6010f59272981fb1b4099fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a961159_588100c2","line":15,"in_reply_to":"9aa7fdbe_ec0807dc","updated":"2014-12-19 14:31:24.000000000","message":"Thanks, I removed the dependencies from the other patch and updated the commit message accordingly","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a8bff589c920990415d0116c3bdbd14e53349eb6","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                                 models_v2.Port.device_owner."},{"line_number":1243,"context_line":"                                 in_(AUTO_DELETE_PORT_OWNERS)"},{"line_number":1244,"context_line":"                             ).all())"},{"line_number":1245,"context_line":"            if network_ports:"},{"line_number":1246,"context_line":"                map(context.session.delete, network_ports)"},{"line_number":1247,"context_line":"            # Check if there are tenant owned ports"},{"line_number":1248,"context_line":"            tenant_ports \u003d (context.session.query(models_v2.IPAllocation)."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_9b39eca5","line":1245,"updated":"2014-09-18 17:08:35.000000000","message":"Agreed, unnecessary conditional","commit_id":"69e0a6f9f0d9a810104a58cd6f10c516eb154e97"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"ede1acc90429c53cf29c5542eb23723f15648aa6","unresolved":false,"context_lines":[{"line_number":1242,"context_line":"                                 models_v2.Port.device_owner."},{"line_number":1243,"context_line":"                                 in_(AUTO_DELETE_PORT_OWNERS)"},{"line_number":1244,"context_line":"                             ).all())"},{"line_number":1245,"context_line":"            if network_ports:"},{"line_number":1246,"context_line":"                map(context.session.delete, network_ports)"},{"line_number":1247,"context_line":"            # Check if there are tenant owned ports"},{"line_number":1248,"context_line":"            tenant_ports \u003d (context.session.query(models_v2.IPAllocation)."}],"source_content_type":"text/x-python","patch_set":1,"id":"fa98f980_4557a126","line":1245,"updated":"2014-09-18 16:21:34.000000000","message":"is this conditional necessary?","commit_id":"69e0a6f9f0d9a810104a58cd6f10c516eb154e97"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f4ed3138c21871fabfad0a60e8f35532061e70a","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"                in_(AUTO_DELETE_PORT_OWNERS)).delete(synchronize_session\u003dFalse)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"            ports_in_use \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":1047,"context_line":"                network_id\u003did).all()"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"            if ports_in_use:"},{"line_number":1050,"context_line":"                raise n_exc.NetworkInUse(net_id\u003did)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_4ccd93b6","line":1047,"updated":"2014-10-27 10:08:10.000000000","message":".count() would be more efficient as it avoid to deserialize remaining ports","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2bb219b6a424ba1c2167e13ef4c569a450a816e0","unresolved":false,"context_lines":[{"line_number":1044,"context_line":"                in_(AUTO_DELETE_PORT_OWNERS)).delete(synchronize_session\u003dFalse)"},{"line_number":1045,"context_line":""},{"line_number":1046,"context_line":"            ports_in_use \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":1047,"context_line":"                network_id\u003did).all()"},{"line_number":1048,"context_line":""},{"line_number":1049,"context_line":"            if ports_in_use:"},{"line_number":1050,"context_line":"                raise n_exc.NetworkInUse(net_id\u003did)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_1862183e","line":1047,"in_reply_to":"9aa7fdbe_4ccd93b6","updated":"2014-12-19 14:31:24.000000000","message":"I use first instead. thanks!","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7f4ed3138c21871fabfad0a60e8f35532061e70a","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"            tenant_ports \u003d (context.session.query(models_v2.IPAllocation)."},{"line_number":1378,"context_line":"                            filter_by(subnet_id\u003dsubnet[\u0027id\u0027])."},{"line_number":1379,"context_line":"                            join(models_v2.Port)."},{"line_number":1380,"context_line":"                            filter_by(network_id\u003dsubnet[\u0027network_id\u0027]).first())"},{"line_number":1381,"context_line":"            if tenant_ports:"},{"line_number":1382,"context_line":"                raise n_exc.SubnetInUse(subnet_id\u003did)"},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9aa7fdbe_6cc7b796","line":1380,"updated":"2014-10-27 10:08:10.000000000","message":"itto","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"2bb219b6a424ba1c2167e13ef4c569a450a816e0","unresolved":false,"context_lines":[{"line_number":1377,"context_line":"            tenant_ports \u003d (context.session.query(models_v2.IPAllocation)."},{"line_number":1378,"context_line":"                            filter_by(subnet_id\u003dsubnet[\u0027id\u0027])."},{"line_number":1379,"context_line":"                            join(models_v2.Port)."},{"line_number":1380,"context_line":"                            filter_by(network_id\u003dsubnet[\u0027network_id\u0027]).first())"},{"line_number":1381,"context_line":"            if tenant_ports:"},{"line_number":1382,"context_line":"                raise n_exc.SubnetInUse(subnet_id\u003did)"},{"line_number":1383,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_785ddc78","line":1380,"in_reply_to":"9aa7fdbe_6cc7b796","updated":"2014-12-19 14:31:24.000000000","message":"the execution time of first is more predictable than count, I prefer leaving it as it is","commit_id":"089694bf955c94d0855ac34baf48284505d1e8db"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"127bb065fae1ed92f4d1a3c322234e00afc24d60","unresolved":false,"context_lines":[{"line_number":941,"context_line":"                models_v2.Port.device_owner."},{"line_number":942,"context_line":"                in_(AUTO_DELETE_PORT_OWNERS)).delete(synchronize_session\u003dFalse)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"            ports_in_use \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":945,"context_line":"                network_id\u003did).first()"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"            if ports_in_use:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_3afdfdb1","line":944,"updated":"2014-12-19 22:52:01.000000000","message":"ports_in_use \u003d\u003d\u003e port_in_use","commit_id":"930ecd343b727abee6d048c118cfc8f0e3c0bc5b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"113a0266d51e7e00463ee48e36461a6c547d0923","unresolved":false,"context_lines":[{"line_number":941,"context_line":"                models_v2.Port.device_owner."},{"line_number":942,"context_line":"                in_(AUTO_DELETE_PORT_OWNERS)).delete(synchronize_session\u003dFalse)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"            ports_in_use \u003d context.session.query(models_v2.Port).filter_by("},{"line_number":945,"context_line":"                network_id\u003did).first()"},{"line_number":946,"context_line":""},{"line_number":947,"context_line":"            if ports_in_use:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a961159_7a78492b","line":944,"in_reply_to":"3a961159_3afdfdb1","updated":"2015-01-07 15:13:10.000000000","message":":)","commit_id":"930ecd343b727abee6d048c118cfc8f0e3c0bc5b"}]}
