)]}'
{"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"61a38e351adaa2ac2e15d02e3e327d37b24c3c24","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        vif_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":124,"context_line":"        if vif_port:"},{"line_number":125,"context_line":"            if port[\u0027admin_state_up\u0027]:"},{"line_number":126,"context_line":"                lvm \u003d self.local_vlan_map[port[\u0027network_id\u0027]]"},{"line_number":127,"context_line":"                # create the networking for the port"},{"line_number":128,"context_line":"                self.int_br.set_db_attribute(\"Port\", vif_port.port_name,"},{"line_number":129,"context_line":"                                             \"tag\", str(lvm.vlan))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FihU%3D","line":126,"updated":"2012-09-03 00:42:58.000000000","message":"similar question to nachi\u0027s review.  Is it possible that the agent and server somehow get out of sync such that the local vlan for this network is not yet populated?  If so, we should handle that.","commit_id":"9580946d3634a0dd1eb02a28add0f5c0dc07043c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce8ef2d74a91c025ef6c1e6ea9ac378393ff9413","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        vif_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":124,"context_line":"        if vif_port:"},{"line_number":125,"context_line":"            if port[\u0027admin_state_up\u0027]:"},{"line_number":126,"context_line":"                lvm \u003d self.local_vlan_map[port[\u0027network_id\u0027]]"},{"line_number":127,"context_line":"                # create the networking for the port"},{"line_number":128,"context_line":"                self.int_br.set_db_attribute(\"Port\", vif_port.port_name,"},{"line_number":129,"context_line":"                                             \"tag\", str(lvm.vlan))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fibc%3D","line":126,"in_reply_to":"AAAALH%2F%2FihU%3D","updated":"2012-09-03 08:14:58.000000000","message":"Done","commit_id":"9580946d3634a0dd1eb02a28add0f5c0dc07043c"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"61a38e351adaa2ac2e15d02e3e327d37b24c3c24","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                                    details[\u0027segmentation_id\u0027])"},{"line_number":641,"context_line":"                    if not details[\u0027admin_state_up\u0027]:"},{"line_number":642,"context_line":"                        self.int_br.clear_db_attribute(\"Port\", port.port_name,"},{"line_number":643,"context_line":"                                                       \"Tag\")"},{"line_number":644,"context_line":"            else:"},{"line_number":645,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":646,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FihQ%3D","line":643,"updated":"2012-09-03 00:42:58.000000000","message":"shouldn\u0027t you be setting this to the dead vlan?  Just clearing the vlan attribute will make this a trunk port, which would be a big security hole, unless I\u0027m misunderstanding what is going on here.\n\nIf this is incorrect, we should probably check to make sure we aren\u0027t doing something similar elsewhere in teh code.","commit_id":"9580946d3634a0dd1eb02a28add0f5c0dc07043c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ce8ef2d74a91c025ef6c1e6ea9ac378393ff9413","unresolved":false,"context_lines":[{"line_number":640,"context_line":"                                    details[\u0027segmentation_id\u0027])"},{"line_number":641,"context_line":"                    if not details[\u0027admin_state_up\u0027]:"},{"line_number":642,"context_line":"                        self.int_br.clear_db_attribute(\"Port\", port.port_name,"},{"line_number":643,"context_line":"                                                       \"Tag\")"},{"line_number":644,"context_line":"            else:"},{"line_number":645,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":646,"context_line":"        return resync"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FibY%3D","line":643,"in_reply_to":"AAAALH%2F%2FihQ%3D","updated":"2012-09-03 08:14:58.000000000","message":"Done","commit_id":"9580946d3634a0dd1eb02a28add0f5c0dc07043c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"000c515a0a51700ddbcf6329c78b962174184f9a","unresolved":false,"context_lines":[{"line_number":636,"context_line":"                                    details[\u0027segmentation_id\u0027],"},{"line_number":637,"context_line":"                                    details[\u0027admin_state_up\u0027])"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":640,"context_line":"        return resync"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def treat_devices_removed(self, devices):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FiE4%3D","line":639,"updated":"2012-09-03 20:38:07.000000000","message":"Dan, you\u0027re connect. After this line, self.port_dead() should be called I believe.","commit_id":"0f9f17212efe130c0d689033bdf10089aba1b45c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":636,"context_line":"                                    details[\u0027segmentation_id\u0027],"},{"line_number":637,"context_line":"                                    details[\u0027admin_state_up\u0027])"},{"line_number":638,"context_line":"            else:"},{"line_number":639,"context_line":"                LOG.debug(\"Device %s not defined on plugin\", device)"},{"line_number":640,"context_line":"        return resync"},{"line_number":641,"context_line":""},{"line_number":642,"context_line":"    def treat_devices_removed(self, devices):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAALH%2F%2FiB4%3D","line":639,"in_reply_to":"AAAALH%2F%2FiE4%3D","updated":"2012-09-03 21:49:11.000000000","message":"ok, i\u0027ll add it.\nthanks","commit_id":"0f9f17212efe130c0d689033bdf10089aba1b45c"}]}