)]}'
{"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"c07eb05221a254cad52d2b10ca2c46dbbc0b8857","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":190,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":191,"context_line":"        LOG.debug(\"Delete %s\", network_id)"},{"line_number":192,"context_line":"        lvm \u003d self.local_vlan_map[network_id]"},{"line_number":193,"context_line":"        self.reclaim_local_vlan(network_id, lvm)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def port_update(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fikc%3D","line":192,"updated":"2012-09-02 15:38:18.000000000","message":"Exception handling is needed for the case there are no network_id yet in local_vlan_map. \nI\u0027m not sure this case will happen, however restarting may cause this.","commit_id":"73284fc6f044d62d93d8f2a7c7eee8f6faf0dde7"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":189,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":190,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":191,"context_line":"        LOG.debug(\"Delete %s\", network_id)"},{"line_number":192,"context_line":"        lvm \u003d self.local_vlan_map[network_id]"},{"line_number":193,"context_line":"        self.reclaim_local_vlan(network_id, lvm)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def port_update(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fiew%3D","line":192,"in_reply_to":"AAAALH%2F%2Fihk%3D","updated":"2012-09-03 06:24:53.000000000","message":"This is a good catch by Nachi. In the RPC when a port is updated or a network deleted a fanout cast message is sent. This is received on all agents. This agents that have the relevant allocated resources should treat them accordingly.","commit_id":"73284fc6f044d62d93d8f2a7c7eee8f6faf0dde7"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":189,"context_line":"        LOG.debug(\"network_delete received\")"},{"line_number":190,"context_line":"        network_id \u003d kwargs.get(\u0027network_id\u0027)"},{"line_number":191,"context_line":"        LOG.debug(\"Delete %s\", network_id)"},{"line_number":192,"context_line":"        lvm \u003d self.local_vlan_map[network_id]"},{"line_number":193,"context_line":"        self.reclaim_local_vlan(network_id, lvm)"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def port_update(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fihk%3D","line":192,"in_reply_to":"AAAALH%2F%2Fikc%3D","updated":"2012-09-03 00:33:46.000000000","message":"seems prudent to do this.  Probably doesn\u0027t happen in common case, but perhaps could happen as a race (not sure, as I\u0027m not very familiar with RPC code).","commit_id":"73284fc6f044d62d93d8f2a7c7eee8f6faf0dde7"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":194,"context_line":"            lvm \u003d self.local_vlan_map[network_id]"},{"line_number":195,"context_line":"            self.reclaim_local_vlan(network_id, lvm)"},{"line_number":196,"context_line":"        except:"},{"line_number":197,"context_line":"            LOG.debug(\"Network %s not used on agent.\", network_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def port_update(self, context, **kwargs):"},{"line_number":200,"context_line":"        LOG.debug(\"port_update received\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FicE%3D","line":197,"updated":"2012-09-03 07:58:49.000000000","message":"Did you put both lines in the same try...except block for any particular reason?\nreclaim_local_vlan can fail for several reasons, including failures running ovs-ofctl and/or retrieving the physical bridge from phys_brs - but catching the exception here in this way would just cancel the error.\n\nI would have done:\n\nlvm \u003d self.local_vlan_map.get(network_id)\nif lvm:\n    self.reclaim_local_vlan(network_id, lvm)\nelse:\n   LOG.debug(\"Network %s not used on agent.\", network_id)","commit_id":"558087cb5c67e8a05b1f4eefc9e7cfe2b1255f0c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":194,"context_line":"            lvm \u003d self.local_vlan_map[network_id]"},{"line_number":195,"context_line":"            self.reclaim_local_vlan(network_id, lvm)"},{"line_number":196,"context_line":"        except:"},{"line_number":197,"context_line":"            LOG.debug(\"Network %s not used on agent.\", network_id)"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def port_update(self, context, **kwargs):"},{"line_number":200,"context_line":"        LOG.debug(\"port_update received\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fia4%3D","line":197,"in_reply_to":"AAAALH%2F%2FicE%3D","updated":"2012-09-03 08:23:29.000000000","message":"Done","commit_id":"558087cb5c67e8a05b1f4eefc9e7cfe2b1255f0c"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"828e7560b33aaa84a580ff5c9abecc6c574770e6","unresolved":false,"context_lines":[{"line_number":200,"context_line":"        LOG.debug(\"port_update received\")"},{"line_number":201,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":202,"context_line":"        vif_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":203,"context_line":"        if vif_port:"},{"line_number":204,"context_line":"            if port[\u0027admin_state_up\u0027]:"},{"line_number":205,"context_line":"                vlan_id \u003d kwargs.get(\u0027vlan_id\u0027)"},{"line_number":206,"context_line":"                # create the networking for the port"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FiTQ%3D","line":203,"updated":"2012-09-03 12:28:45.000000000","message":"(Suggestion only) I\u0027m not sure if this is necessary, but would it make sense to add a debug logging statement indicating if the vif port was not present on the agent?","commit_id":"0ff186758d6cbc4ead3e91ff361b56b5f4ab9575"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":200,"context_line":"        LOG.debug(\"port_update received\")"},{"line_number":201,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"},{"line_number":202,"context_line":"        vif_port \u003d self.int_br.get_vif_port_by_id(port[\u0027id\u0027])"},{"line_number":203,"context_line":"        if vif_port:"},{"line_number":204,"context_line":"            if port[\u0027admin_state_up\u0027]:"},{"line_number":205,"context_line":"                vlan_id \u003d kwargs.get(\u0027vlan_id\u0027)"},{"line_number":206,"context_line":"                # create the networking for the port"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2FiTE%3D","line":203,"in_reply_to":"AAAALH%2F%2FiTQ%3D","updated":"2012-09-03 12:36:53.000000000","message":"There is a sperate patch for the port update (https://review.openstack.org/#/c/12290/). I\u0027ll add that in the pacth. I requires a merge after this one.\nThanks\nGary","commit_id":"0ff186758d6cbc4ead3e91ff361b56b5f4ab9575"}]}