)]}'
{"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f62c4ea1f4eac8eb918343db318f26d66d2d1193","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"                      self.iter_num)"},{"line_number":1352,"context_line":"            if sync:"},{"line_number":1353,"context_line":"                LOG.info(_(\"Agent out of sync with plugin!\"))"},{"line_number":1354,"context_line":"                ports.clear()"},{"line_number":1355,"context_line":"                ancillary_ports.clear()"},{"line_number":1356,"context_line":"                sync \u003d False"},{"line_number":1357,"context_line":"                polling_manager.force_polling()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_443c1ee3","side":"PARENT","line":1354,"updated":"2014-09-23 02:18:34.000000000","message":"why removing this?\n\nMay be sync should be False initially instead?","commit_id":"a76af4ade3c751a4372a427989035cf8c32342b0"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"951dcf43ac8476e7f1552c17d5a9a300d9481a63","unresolved":false,"context_lines":[{"line_number":1351,"context_line":"                      self.iter_num)"},{"line_number":1352,"context_line":"            if sync:"},{"line_number":1353,"context_line":"                LOG.info(_(\"Agent out of sync with plugin!\"))"},{"line_number":1354,"context_line":"                ports.clear()"},{"line_number":1355,"context_line":"                ancillary_ports.clear()"},{"line_number":1356,"context_line":"                sync \u003d False"},{"line_number":1357,"context_line":"                polling_manager.force_polling()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_f8ccce37","side":"PARENT","line":1354,"in_reply_to":"da9df570_443c1ee3","updated":"2014-09-23 09:20:25.000000000","message":"Actually it is the root cause of the issue..\nWhen we clear our known ports we can miss removing event and don\u0027t handle it.\nSo, in this fix we use sync flag for signaling to update all ports and \nresync flag for the cumulating of return values in case we need to sync again for some reason.","commit_id":"a76af4ade3c751a4372a427989035cf8c32342b0"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f62c4ea1f4eac8eb918343db318f26d66d2d1193","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        cur_ports \u003d set()"},{"line_number":990,"context_line":"        for bridge in self.ancillary_brs:"},{"line_number":991,"context_line":"            cur_ports |\u003d bridge.get_vif_port_set()"},{"line_number":992,"context_line":"            port_info \u003d {\u0027current\u0027: cur_ports}"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"        # FIXME(salv-orlando): It\u0027s not really necessary to return early"},{"line_number":995,"context_line":"        # if nothing has changed."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_a4922a55","line":992,"updated":"2014-09-23 02:18:34.000000000","message":"that should be moved outside the loop, or otherwise it would get only the result of the last call to bridge.get_vif_port_set()","commit_id":"7ccb812c621acab6e858865442546362307a6c2a"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"951dcf43ac8476e7f1552c17d5a9a300d9481a63","unresolved":false,"context_lines":[{"line_number":989,"context_line":"        cur_ports \u003d set()"},{"line_number":990,"context_line":"        for bridge in self.ancillary_brs:"},{"line_number":991,"context_line":"            cur_ports |\u003d bridge.get_vif_port_set()"},{"line_number":992,"context_line":"            port_info \u003d {\u0027current\u0027: cur_ports}"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"        # FIXME(salv-orlando): It\u0027s not really necessary to return early"},{"line_number":995,"context_line":"        # if nothing has changed."}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_b89c066b","line":992,"in_reply_to":"da9df570_a4922a55","updated":"2014-09-23 09:20:25.000000000","message":"Sure","commit_id":"7ccb812c621acab6e858865442546362307a6c2a"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f62c4ea1f4eac8eb918343db318f26d66d2d1193","unresolved":false,"context_lines":[{"line_number":991,"context_line":"            cur_ports |\u003d bridge.get_vif_port_set()"},{"line_number":992,"context_line":"            port_info \u003d {\u0027current\u0027: cur_ports}"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"        # FIXME(salv-orlando): It\u0027s not really necessary to return early"},{"line_number":995,"context_line":"        # if nothing has changed."},{"line_number":996,"context_line":"        if not sync and cur_ports \u003d\u003d registered_ports:"},{"line_number":997,"context_line":"            # No added or removed ports to set, just return here"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_24d9da57","line":994,"updated":"2014-09-23 02:18:34.000000000","message":"i think the authorship should be changed and comment should be amended with information that it\u0027s the same logic as in L952","commit_id":"7ccb812c621acab6e858865442546362307a6c2a"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"951dcf43ac8476e7f1552c17d5a9a300d9481a63","unresolved":false,"context_lines":[{"line_number":991,"context_line":"            cur_ports |\u003d bridge.get_vif_port_set()"},{"line_number":992,"context_line":"            port_info \u003d {\u0027current\u0027: cur_ports}"},{"line_number":993,"context_line":""},{"line_number":994,"context_line":"        # FIXME(salv-orlando): It\u0027s not really necessary to return early"},{"line_number":995,"context_line":"        # if nothing has changed."},{"line_number":996,"context_line":"        if not sync and cur_ports \u003d\u003d registered_ports:"},{"line_number":997,"context_line":"            # No added or removed ports to set, just return here"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_d888ea24","line":994,"in_reply_to":"da9df570_24d9da57","updated":"2014-09-23 09:20:25.000000000","message":"Will do","commit_id":"7ccb812c621acab6e858865442546362307a6c2a"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"f62c4ea1f4eac8eb918343db318f26d66d2d1193","unresolved":false,"context_lines":[{"line_number":1345,"context_line":"            polling_manager \u003d polling.AlwaysPoll()"},{"line_number":1346,"context_line":""},{"line_number":1347,"context_line":"        sync \u003d True"},{"line_number":1348,"context_line":"        resync \u003d False"},{"line_number":1349,"context_line":"        ports \u003d set()"},{"line_number":1350,"context_line":"        updated_ports_copy \u003d set()"},{"line_number":1351,"context_line":"        ancillary_ports \u003d set()"}],"source_content_type":"text/x-python","patch_set":2,"id":"da9df570_241e3a71","line":1348,"updated":"2014-09-23 02:18:34.000000000","message":"I think some detailed comments would be useful for those who will review and later read the code.","commit_id":"7ccb812c621acab6e858865442546362307a6c2a"}]}