)]}'
{"etc/l3_agent.ini":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"# value should be set to the UUID of that external network.  If empty,"},{"line_number":27,"context_line":"# the agent will enforce that only a single external networks exists and"},{"line_number":28,"context_line":"# use that external network id"},{"line_number":29,"context_line":"gateway_external_net_id \u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Indicates that this L3 agent should also handle routers that do not have"},{"line_number":32,"context_line":"# an external network gateway configured.  This option should be True only"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FhoM%3D","line":29,"updated":"2012-09-04 13:46:55.000000000","message":"We must prepare l3_agent.ini per external network If we want to run multiple l3-agent instances. In addition network_id changes whenever a network is created.\n\nConsidering the above, it would be better to splitting \"gateway_external_net_id\" to a separate config file. If so we have a common l3_agent.ini and per-network net_id config file. per-network net_id files can be generated automatically by a script.\n\nIMO, this approach is transient for Folsom release. In the future we need to consider better approach to run multiple agent instances including l3-agent, dhcp-agent and so on.","commit_id":"a20bc8e735b9b631ccb1767bedd52b27dab8ac4a"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"# value should be set to the UUID of that external network.  If empty,"},{"line_number":27,"context_line":"# the agent will enforce that only a single external networks exists and"},{"line_number":28,"context_line":"# use that external network id"},{"line_number":29,"context_line":"gateway_external_net_id \u003d"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"# Indicates that this L3 agent should also handle routers that do not have"},{"line_number":32,"context_line":"# an external network gateway configured.  This option should be True only"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2Fe%2B4%3D","line":29,"in_reply_to":"AAAALH%2F%2FhoM%3D","updated":"2012-09-07 01:44:32.000000000","message":"Yes, this is just a simple work around to make multiple external networks possible in Folsom.  The work to have a single agent support multiple gateways was deemed too disruptive.\n\nIn the future, it would probably be better to have such \"per-instance\" config options passed in as command parameters and leave the config file to \u0027general settings\u0027 that are the same across all agents.","commit_id":"a20bc8e735b9b631ccb1767bedd52b27dab8ac4a"}],"quantum/agent/l3_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b40ee618ffdf028600c26b1bb1758c20adf38b7f","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if self.conf.gateway_external_network_id:"},{"line_number":176,"context_line":"            return self.conf.gateway_external_network_id"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        params \u003d {\u0027router:external\u0027: True}"},{"line_number":179,"context_line":"        ex_nets \u003d self.qclient.list_networks(**params)[\u0027networks\u0027]"},{"line_number":180,"context_line":"        if len(ex_nets) \u003e 1:"},{"line_number":181,"context_line":"            raise Exception(\"must configure \u0027external_network_id\u0027 if \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fhpw%3D","line":178,"updated":"2012-09-04 12:10:42.000000000","message":"Maybe it is worthwhile considering using a constant.","commit_id":"a20bc8e735b9b631ccb1767bedd52b27dab8ac4a"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":175,"context_line":"        if self.conf.gateway_external_network_id:"},{"line_number":176,"context_line":"            return self.conf.gateway_external_network_id"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        params \u003d {\u0027router:external\u0027: True}"},{"line_number":179,"context_line":"        ex_nets \u003d self.qclient.list_networks(**params)[\u0027networks\u0027]"},{"line_number":180,"context_line":"        if len(ex_nets) \u003e 1:"},{"line_number":181,"context_line":"            raise Exception(\"must configure \u0027external_network_id\u0027 if \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fe%2B0%3D","line":178,"in_reply_to":"AAAALH%2F%2Fhpw%3D","updated":"2012-09-07 01:44:32.000000000","message":"am waiting to rebase this on top of salvatore\u0027s merged patch.  he may have made that change himself (I know he did in most of the code) otherwise, I will make the change.","commit_id":"a20bc8e735b9b631ccb1767bedd52b27dab8ac4a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"unresolved":false,"context_lines":[{"line_number":90,"context_line":"                    help\u003d\"Allow overlapping IP.\"),"},{"line_number":91,"context_line":"        cfg.StrOpt(\u0027router_id\u0027, default\u003d\u0027\u0027,"},{"line_number":92,"context_line":"                   help\u003d\"If namespaces is disabled, the l3 agent can only\""},{"line_number":93,"context_line":"                        \" confgure a router that has the matching router ID.\")"},{"line_number":94,"context_line":"        cfg.BoolOpt(\u0027handle_internal_only_routers\u0027,"},{"line_number":95,"context_line":"                    default\u003dTrue,"},{"line_number":96,"context_line":"                    help\u003d\"Agent should implement routers with no gateway\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FdYc%3D","line":93,"updated":"2012-09-09 14:55:48.000000000","message":"Looks like there a missing coma at line 93","commit_id":"f2e271b6ffa778fb6199fb1fd7313f476078a91f"}]}