)]}'
{"etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e tuples enumerating ranges"},{"line_number":13,"context_line":"# of VLAN IDs on named physical networks that are available for"},{"line_number":14,"context_line":"# allocation."},{"line_number":15,"context_line":"# Default: network_vlan_ranges \u003d"},{"line_number":16,"context_line":"# Example: network_vlan_ranges \u003d default:1000:2999"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[DATABASE]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Fegw%3D","line":15,"updated":"2012-09-07 16:31:11.000000000","message":"I think we should add comments to explain what it means by network_vlan_ranges \u003d. Does it mean disable?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":12,"context_line":"# \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e tuples enumerating ranges"},{"line_number":13,"context_line":"# of VLAN IDs on named physical networks that are available for"},{"line_number":14,"context_line":"# allocation."},{"line_number":15,"context_line":"# Default: network_vlan_ranges \u003d"},{"line_number":16,"context_line":"# Example: network_vlan_ranges \u003d default:1000:2999"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[DATABASE]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Febw%3D","line":15,"in_reply_to":"AAAALH%2F%2Fegw%3D","updated":"2012-09-07 18:04:43.000000000","message":"Done","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":33,"context_line":"# \u003cphysical_network\u003e:\u003cphysical_interface\u003e tuples mapping physical"},{"line_number":34,"context_line":"# network names to the agent\u0027s node-specific physical network"},{"line_number":35,"context_line":"# interfaces to be used for flat and VLAN networks."},{"line_number":36,"context_line":"# Default: physical_interface_mappings \u003d"},{"line_number":37,"context_line":"# Example: physical_interface_mappings \u003d default:eth1"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Fegs%3D","line":36,"updated":"2012-09-07 16:31:11.000000000","message":"What does it mean by empty value?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":33,"context_line":"# \u003cphysical_network\u003e:\u003cphysical_interface\u003e tuples mapping physical"},{"line_number":34,"context_line":"# network names to the agent\u0027s node-specific physical network"},{"line_number":35,"context_line":"# interfaces to be used for flat and VLAN networks."},{"line_number":36,"context_line":"# Default: physical_interface_mappings \u003d"},{"line_number":37,"context_line":"# Example: physical_interface_mappings \u003d default:eth1"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2FebQ%3D","line":36,"in_reply_to":"AAAALH%2F%2Fegs%3D","updated":"2012-09-07 18:04:43.000000000","message":"Added text: All physical networks listed in network_vlan_ranges on the server should have mappings to appropriate interfaces on each agent.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Only used if tunnel_id_ranges (above) is not empty."},{"line_number":45,"context_line":"# In most cases, the default value should be fine."},{"line_number":46,"context_line":"# Default: tunnel_bridge \u003d br-tun"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# (ListOpt) Comma-separated list of \u003cphysical_network\u003e:\u003cbridge\u003e tuples"},{"line_number":49,"context_line":"# mapping physical network names to agent\u0027s node-specific OVS bridge"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FgrE%3D","line":46,"updated":"2012-09-05 14:16:18.000000000","message":"I\u0027m thinking an empty tunnel_bridge value would indicate to the agent that GRE tunnels are not being used at all, in which case there is no need for it to create the tunnel bridge or patch port. This would eliminate unneeded clutter when tunnels aren\u0027t being used, and would eliminate the error messages on systems that don\u0027t support the patch ports.\n\nIf so, it seems the tunnel_bridge default should be empty, and it should only be set when configuring tenant_network_type \u003d gre. Any comments?\n\nNote that the agent doesn\u0027t currently know or care at all about the distinction between tenant and provider networks. All it cares about is network bindings, which have a network type and any associated data. Therefore, I\u0027d prefer not to have the agent look at tenant_network_type to decide whether to create the tunnel bridge and patch port. Also, in the future, we may allow provider tunnels, so tunnels could be used even with tenant_network_type !\u003d gre. Private clouds (or non-OpenStack Quantum deployments) may even completely disable tenant networks, and configure all networks they use as provider networks.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Only used if tunnel_id_ranges (above) is not empty."},{"line_number":45,"context_line":"# In most cases, the default value should be fine."},{"line_number":46,"context_line":"# Default: tunnel_bridge \u003d br-tun"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# (ListOpt) Comma-separated list of \u003cphysical_network\u003e:\u003cbridge\u003e tuples"},{"line_number":49,"context_line":"# mapping physical network names to agent\u0027s node-specific OVS bridge"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2Fe%2Fc%3D","line":46,"in_reply_to":"AAAALH%2F%2FgrE%3D","updated":"2012-09-07 01:10:47.000000000","message":"sorry, missed this comment.  \n\nis the problem that tunnel-br is always created now, regardless, since we no longer have a \"tunnel-mode\" or \"vlan-mode\"?  \n\nIt seems a bit clunky to \"overload\" the tunnel_bridge setting to mean \"tunneling-enabled\".  Would it be possible to only create the tunnel bridge if/when the agent is told it needs to implement a tunneled network?  That would probably be idea.\n\nI don\u0027t feel really strong here, but to be honest, its probably too late in the cycle for us to be changing non-critical things like this.  We should probably just focus on fixing blocker bugs and leave the rest of Grizzly.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"19762874f26e358cc77e1fdf5427a85a11719aca","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# names. Each bridge must exist, and should have physical network"},{"line_number":51,"context_line":"# interface configured as a port."},{"line_number":52,"context_line":"# Default: bridge_mappings \u003d"},{"line_number":53,"context_line":"# Example: bridge_mappings \u003d default:br-eth1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FhCQ%3D","line":53,"updated":"2012-09-05 00:36:22.000000000","message":"is this option only to be used when using VLANs?  not clear from the comments.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# names. Each bridge must exist, and should have physical network"},{"line_number":51,"context_line":"# interface configured as a port."},{"line_number":52,"context_line":"# Default: bridge_mappings \u003d"},{"line_number":53,"context_line":"# Example: bridge_mappings \u003d default:br-eth1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2Ff4E%3D","line":53,"in_reply_to":"AAAALH%2F%2FgrM%3D","updated":"2012-09-06 01:09:52.000000000","message":"Done","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":50,"context_line":"# names. Each bridge must exist, and should have physical network"},{"line_number":51,"context_line":"# interface configured as a port."},{"line_number":52,"context_line":"# Default: bridge_mappings \u003d"},{"line_number":53,"context_line":"# Example: bridge_mappings \u003d default:br-eth1"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FgrM%3D","line":53,"in_reply_to":"AAAALH%2F%2FhCQ%3D","updated":"2012-09-05 14:16:18.000000000","message":"Its used for VLAN tenant networks, as well as VLAN and flat provider networks. I\u0027ll add this to the comment.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"19762874f26e358cc77e1fdf5427a85a11719aca","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."},{"line_number":57,"context_line":"# Default: local_ip \u003d 10.0.0.3"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[AGENT]"},{"line_number":60,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FhCM%3D","line":57,"updated":"2012-09-05 00:36:22.000000000","message":"(suggestion) maybe group all of the tunnel-specific params together?","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."},{"line_number":57,"context_line":"# Default: local_ip \u003d 10.0.0.3"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[AGENT]"},{"line_number":60,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2Ff4A%3D","line":57,"in_reply_to":"AAAALH%2F%2FgrI%3D","updated":"2012-09-06 01:09:52.000000000","message":"Done","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# Uncomment this line if tunnel_id_ranges (above) is not empty."},{"line_number":56,"context_line":"# Set local-ip to be the local IP address of this hypervisor."},{"line_number":57,"context_line":"# Default: local_ip \u003d 10.0.0.3"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"[AGENT]"},{"line_number":60,"context_line":"# Agent\u0027s polling interval in seconds"}],"source_content_type":"text/x-properties","patch_set":1,"id":"AAAALH%2F%2FgrI%3D","line":57,"in_reply_to":"AAAALH%2F%2FhCM%3D","updated":"2012-09-05 14:16:18.000000000","message":"I considered that, but didn\u0027t want this patch to look like it was changing things that it wasn\u0027t. I\u0027ll move it up.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"# \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e tuples enumerating ranges"},{"line_number":27,"context_line":"# of VLAN IDs on named physical networks that are available for"},{"line_number":28,"context_line":"# allocation."},{"line_number":29,"context_line":"# Default: network_vlan_ranges \u003d"},{"line_number":30,"context_line":"# Example: network_vlan_ranges \u003d default:1000:2999"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# (ListOpt) Comma-separated list of \u003ctun_min\u003e:\u003ctun_max\u003e tuples"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Fego%3D","line":29,"updated":"2012-09-07 16:31:11.000000000","message":"What does it mean by empty value?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"# \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e tuples enumerating ranges"},{"line_number":27,"context_line":"# of VLAN IDs on named physical networks that are available for"},{"line_number":28,"context_line":"# allocation."},{"line_number":29,"context_line":"# Default: network_vlan_ranges \u003d"},{"line_number":30,"context_line":"# Example: network_vlan_ranges \u003d default:1000:2999"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"# (ListOpt) Comma-separated list of \u003ctun_min\u003e:\u003ctun_max\u003e tuples"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2FebM%3D","line":29,"in_reply_to":"AAAALH%2F%2Fego%3D","updated":"2012-09-07 18:04:43.000000000","message":"Done","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# (ListOpt) Comma-separated list of \u003ctun_min\u003e:\u003ctun_max\u003e tuples"},{"line_number":33,"context_line":"# enumerating ranges of GRE tunnel IDs that are available for"},{"line_number":34,"context_line":"# allocation."},{"line_number":35,"context_line":"# Default: tunnel_id_ranges \u003d"},{"line_number":36,"context_line":"# Example: tunnel_id_ranges \u003d 1:1000"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Do not change this parameter unless you have a good reason to."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Fegk%3D","line":35,"updated":"2012-09-07 16:31:11.000000000","message":"What does it mean by empty value?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"# (ListOpt) Comma-separated list of \u003ctun_min\u003e:\u003ctun_max\u003e tuples"},{"line_number":33,"context_line":"# enumerating ranges of GRE tunnel IDs that are available for"},{"line_number":34,"context_line":"# allocation."},{"line_number":35,"context_line":"# Default: tunnel_id_ranges \u003d"},{"line_number":36,"context_line":"# Example: tunnel_id_ranges \u003d 1:1000"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Do not change this parameter unless you have a good reason to."}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2FebI%3D","line":35,"in_reply_to":"AAAALH%2F%2Fegk%3D","updated":"2012-09-07 18:04:43.000000000","message":"Updated text to clarify when it applies.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"# bridge names to be used for flat and VLAN networks. Each bridge must"},{"line_number":57,"context_line":"# exist, and should have a physical network interface configured as a"},{"line_number":58,"context_line":"# port."},{"line_number":59,"context_line":"# Default: bridge_mappings \u003d"},{"line_number":60,"context_line":"# Example: bridge_mappings \u003d default:br-eth1"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2Fegc%3D","line":59,"updated":"2012-09-07 16:31:11.000000000","message":"what does it mean by empty value?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":56,"context_line":"# bridge names to be used for flat and VLAN networks. Each bridge must"},{"line_number":57,"context_line":"# exist, and should have a physical network interface configured as a"},{"line_number":58,"context_line":"# port."},{"line_number":59,"context_line":"# Default: bridge_mappings \u003d"},{"line_number":60,"context_line":"# Example: bridge_mappings \u003d default:br-eth1"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"[AGENT]"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAALH%2F%2FebE%3D","line":59,"in_reply_to":"AAAALH%2F%2Fegc%3D","updated":"2012-09-07 18:04:43.000000000","message":"Done","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"quantum/extensions/providernet.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027networks\u0027: {"},{"line_number":24,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":25,"context_line":"                       \u0027validate\u0027: {\u0027type:values\u0027: [\u0027flat\u0027,"},{"line_number":26,"context_line":"                                                    \u0027local\u0027,"},{"line_number":27,"context_line":"                                                    \u0027vlan\u0027]},"},{"line_number":28,"context_line":"                       \u0027default\u0027: attributes.ATTR_NOT_SPECIFIED,"},{"line_number":29,"context_line":"                       \u0027is_visible\u0027: True},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Felk%3D","line":26,"updated":"2012-09-07 14:51:35.000000000","message":"Note that local networks can be created as provider networks. I would like to also add \u0027gre\u0027 here so that GRE provider networks would be supported as well. A couple lines of code would be needed in ovs_quantum_plugin.py as well.\n\nIn previous discussions, use cases for provider GRE networks were not identified. In adding the local network type, I realized that there are use cases where only provider networks would be used, and I don\u0027t see any reason to exclude creating either provider local or GRE networks. These use cases include non-OpenStack applications of Quantum, and private OpenStack clouds where administrators want to maintain explicit control over all physical network resources and identifiers, including the assignment of tunnel segmentation_id values.\n\nAre there any objections to adding support for GRE provider networks in this patch? No change at all would be needed in the openvswitch agent, and the support in the plugin would be very similar to the existing code for the other allowable types. This would introduce practically no new risk, would make things more consistent, and I think it would address some valid use cases we hadn\u0027t considered previously.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"quantum/plugins/linuxbridge/agent/linuxbridge_quantum_agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self.setup_rpc(interface_mappings.values())"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_rpc(self, physical_interfaces):"},{"line_number":632,"context_line":"        for interface in physical_interfaces + [\u0027eth0\u0027, \u0027em1\u0027, \u0027p1p1\u0027]:"},{"line_number":633,"context_line":"            try:"},{"line_number":634,"context_line":"                mac \u003d utils.get_interface_mac(interface)"},{"line_number":635,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fe2M%3D","line":632,"updated":"2012-09-07 08:34:11.000000000","message":"why not use the stuff in agent/linux/ip_lib.py?  I believe this has a method to list devices.  Seems like it would be cleaner.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        self.setup_rpc(interface_mappings.values())"},{"line_number":630,"context_line":""},{"line_number":631,"context_line":"    def setup_rpc(self, physical_interfaces):"},{"line_number":632,"context_line":"        for interface in physical_interfaces + [\u0027eth0\u0027, \u0027em1\u0027, \u0027p1p1\u0027]:"},{"line_number":633,"context_line":"            try:"},{"line_number":634,"context_line":"                mac \u003d utils.get_interface_mac(interface)"},{"line_number":635,"context_line":"                break"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Feoc%3D","line":632,"in_reply_to":"AAAALH%2F%2Fe2M%3D","updated":"2012-09-07 14:51:35.000000000","message":"It looks like I should be able to use IPWrapper.get_devices(True) to find all the devices, excluding loopback. The explicitly-named interfaces should still be tried first. Are there any other device types in addition to loopback that \"ip link\" would list but that would not have sufficiently random mac addresses?\n\nAlso, I\u0027m wondering if IPDevice.link.address should be used instead of utils.get_interface_mac() both below and in ovs_quantum_agent.py? The get_interface_mac() function could then be eliminated from utils.py.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"quantum/plugins/linuxbridge/common/config.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":26,"context_line":"vlan_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027tenant_network_type\u0027, default\u003d\u0027local\u0027,"},{"line_number":28,"context_line":"               help\u003d\"Network type for tenant networks \""},{"line_number":29,"context_line":"               \"(local, vlan, or none)\"),"},{"line_number":30,"context_line":"    cfg.ListOpt(\u0027network_vlan_ranges\u0027,"},{"line_number":31,"context_line":"                default\u003dDEFAULT_VLAN_RANGES,"},{"line_number":32,"context_line":"                help\u003d\"List of \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fe2I%3D","line":29,"updated":"2012-09-07 08:34:11.000000000","message":"missing \u0027flat\u0027?\n\nUpdate: this may be cleared up now that i\u0027ve read more code.  see my question later in review.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"vlan_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027tenant_network_type\u0027, default\u003d\u0027local\u0027,"},{"line_number":28,"context_line":"               help\u003d\"Network type for tenant networks \""},{"line_number":29,"context_line":"               \"(local, vlan, or none)\"),"},{"line_number":30,"context_line":"    cfg.ListOpt(\u0027network_vlan_ranges\u0027,"},{"line_number":31,"context_line":"                default\u003dDEFAULT_VLAN_RANGES,"},{"line_number":32,"context_line":"                help\u003d\"List of \u003cphysical_network\u003e:\u003cvlan_min\u003e:\u003cvlan_max\u003e \""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FenA%3D","line":29,"in_reply_to":"AAAALH%2F%2Fe2I%3D","updated":"2012-09-07 14:51:35.000000000","message":"Excerpt from my response to the other question:\n\nTYPE_FLAT isn\u0027t in this list because normal tenant networks cannot be flat networks. There is no pool of them from which tenant networks could be allocated. Flat networks are only available as provider networks.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"quantum/plugins/linuxbridge/db/l2network_models_v2.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":46,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":47,"context_line":"                           primary_key\u003dTrue)"},{"line_number":48,"context_line":"    physical_network \u003d sa.Column(sa.String(64))"},{"line_number":49,"context_line":"    vlan_id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self, network_id, physical_network, vlan_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fdew%3D","line":48,"updated":"2012-09-09 08:56:35.000000000","message":"why can the physical_network be null?","commit_id":"88cd4f85047cb8844fd192f3c8d4b087b4085a1a"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":45,"context_line":"    network_id \u003d sa.Column(sa.String(36),"},{"line_number":46,"context_line":"                           sa.ForeignKey(\u0027networks.id\u0027, ondelete\u003d\"CASCADE\"),"},{"line_number":47,"context_line":"                           primary_key\u003dTrue)"},{"line_number":48,"context_line":"    physical_network \u003d sa.Column(sa.String(64))"},{"line_number":49,"context_line":"    vlan_id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def __init__(self, network_id, physical_network, vlan_id):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fdd8%3D","line":48,"in_reply_to":"AAAALH%2F%2Fdew%3D","updated":"2012-09-09 09:50:07.000000000","message":"I think that the reason for this is that in certain cases one may just want to deploy this in a setup with no external network connectivity. This is for a single box configuration. Hence the option for NULL is allowed.","commit_id":"88cd4f85047cb8844fd192f3c8d4b087b4085a1a"}],"quantum/plugins/linuxbridge/lb_quantum_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":"from quantum.openstack.common import rpc"},{"line_number":32,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":33,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":34,"context_line":"from quantum.plugins.linuxbridge.common import constants"},{"line_number":35,"context_line":"from quantum.plugins.linuxbridge.db import l2network_db_v2 as db"},{"line_number":36,"context_line":"from quantum import policy"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fe2E%3D","line":34,"updated":"2012-09-07 08:34:11.000000000","message":"(suggestion) maybe make this \"as lb_constants\" to avoid confusion with other constants.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from quantum.openstack.common import rpc"},{"line_number":32,"context_line":"from quantum.openstack.common.rpc import dispatcher"},{"line_number":33,"context_line":"from quantum.openstack.common.rpc import proxy"},{"line_number":34,"context_line":"from quantum.plugins.linuxbridge.common import constants"},{"line_number":35,"context_line":"from quantum.plugins.linuxbridge.db import l2network_db_v2 as db"},{"line_number":36,"context_line":"from quantum import policy"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fel8%3D","line":34,"in_reply_to":"AAAALH%2F%2Fe2E%3D","updated":"2012-09-07 14:51:35.000000000","message":"I\u0027d probably pick a shorter name to reduce pep8 complaints. In the recent FlatNetworkInUse exception patch, I changed additional plugin code to use \"constants\" the same way as this file, and I think ovs_quantum_plugin.py and the agents also are consistent with this. I think keeping the import [re]naming consistent across the files is important, and updating them all might be a bit out of scope right now. But I\u0027ll update them all (to lb_const and ovs_const) in this patch if you\u0027d like.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.tenant_network_type \u003d cfg.CONF.VLANS.tenant_network_type"},{"line_number":163,"context_line":"        if self.tenant_network_type not in [constants.TYPE_LOCAL,"},{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s\" %"},{"line_number":167,"context_line":"                      self.tenant_network_type)"},{"line_number":168,"context_line":"            sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fe18%3D","line":165,"updated":"2012-09-07 08:34:11.000000000","message":"so I was expecting to see TYPE_FLAT in here, but looking below, I guess type flat is just an internal type, not exposed to customers, who would instead do type\u003dVLAN?","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.tenant_network_type \u003d cfg.CONF.VLANS.tenant_network_type"},{"line_number":163,"context_line":"        if self.tenant_network_type not in [constants.TYPE_LOCAL,"},{"line_number":164,"context_line":"                                            constants.TYPE_VLAN,"},{"line_number":165,"context_line":"                                            constants.TYPE_NONE]:"},{"line_number":166,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s\" %"},{"line_number":167,"context_line":"                      self.tenant_network_type)"},{"line_number":168,"context_line":"            sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Feng%3D","line":165,"in_reply_to":"AAAALH%2F%2Fe18%3D","updated":"2012-09-07 14:51:35.000000000","message":"No, TYPE_FLAT is exposed to admins via the provider API - they can do \"quantum net-create ... --provider:network_type flat ...\" to create a flat provider network. The use of FLAT_VLAN_ID for the segmentation_id of a flat network is an internal detail that is not exposed to clients.\n\nTYPE_FLAT isn\u0027t in this list because normal tenant networks cannot be flat networks. There is no pool of them from which tenant networks could be allocated. Flat networks are only available as provider networks.\n\nIt might make sense to eventually support a pool of tenant subnets on top of a single provider flat network, but that\u0027s out of scope for this patch.","commit_id":"be0c2e4ef22fe9bf5369fe0106f822b8f0d95f73"}],"quantum/plugins/openvswitch/common/constants.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"19762874f26e358cc77e1fdf5427a85a11719aca","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TYPE_FLAT \u003d \u0027flat\u0027"},{"line_number":24,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":25,"context_line":"TYPE_GRE \u003d \u0027gre\u0027"},{"line_number":26,"context_line":"TYPE_LOCAL \u003d \u0027local\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Name prefixes for veth device pair linking the integration bridge"},{"line_number":29,"context_line":"# with the physical bridge for a physical network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FhBY%3D","line":26,"updated":"2012-09-05 00:36:22.000000000","message":"if you have these defined as constats, we should make sure we use those constants (i remember seeing these as text strings elsewhere).","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TYPE_FLAT \u003d \u0027flat\u0027"},{"line_number":24,"context_line":"TYPE_VLAN \u003d \u0027vlan\u0027"},{"line_number":25,"context_line":"TYPE_GRE \u003d \u0027gre\u0027"},{"line_number":26,"context_line":"TYPE_LOCAL \u003d \u0027local\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# Name prefixes for veth device pair linking the integration bridge"},{"line_number":29,"context_line":"# with the physical bridge for a physical network"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FgrA%3D","line":26,"in_reply_to":"AAAALH%2F%2FhBY%3D","updated":"2012-09-05 14:16:18.000000000","message":"You may have seen the text strings in a couple of comments in the openvswitch code. The only place constants are not used is in providernet.py. This is because I didn\u0027t want the agents to pull in the purely server-side providernet.py, and I didn\u0027t want to add the extension\u0027s constants to any core files. We could add a new provider.py file somewhere with the constants in it, to be shared by providernet.py, the plugins, and the agents. Is this worth bothering with at this point?","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"}],"quantum/plugins/openvswitch/ovs_models_v2.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"fce4ab15ddb4c2ae7bf28d854a2f69e847e324a6","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                        primary_key\u003dTrue)"},{"line_number":67,"context_line":"    # \u0027gre\u0027, \u0027vlan\u0027, \u0027flat\u0027, \u0027local\u0027"},{"line_number":68,"context_line":"    network_type \u003d Column(String(32), nullable\u003dFalse)"},{"line_number":69,"context_line":"    physical_network \u003d Column(String(64))"},{"line_number":70,"context_line":"    segmentation_id \u003d Column(Integer)  # tunnel_id or vlan_id"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def __init__(self, network_id, network_type, physical_network,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAALH%2F%2Fdes%3D","line":69,"updated":"2012-09-09 08:56:35.000000000","message":"why can the physical_network be null?","commit_id":"88cd4f85047cb8844fd192f3c8d4b087b4085a1a"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"19762874f26e358cc77e1fdf5427a85a11719aca","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    (physical_network,"},{"line_number":389,"context_line":"                     segmentation_id) \u003d ovs_db_v2.reserve_vlan(session)"},{"line_number":390,"context_line":"                elif network_type \u003d\u003d constants.TYPE_GRE:"},{"line_number":391,"context_line":"                    segmentation_id \u003d ovs_db_v2.reserve_tunnel(session)"},{"line_number":392,"context_line":"            else:"},{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FhBM%3D","line":391,"updated":"2012-09-05 00:36:22.000000000","message":"might be useful to have comment that TYPE_LOCAL if fall through.. kind of hard to parse otherwise.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    (physical_network,"},{"line_number":389,"context_line":"                     segmentation_id) \u003d ovs_db_v2.reserve_vlan(session)"},{"line_number":390,"context_line":"                elif network_type \u003d\u003d constants.TYPE_GRE:"},{"line_number":391,"context_line":"                    segmentation_id \u003d ovs_db_v2.reserve_tunnel(session)"},{"line_number":392,"context_line":"            else:"},{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Ff3Q%3D","line":391,"in_reply_to":"AAAALH%2F%2Fgq4%3D","updated":"2012-09-06 01:09:52.000000000","message":"Done","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                    (physical_network,"},{"line_number":389,"context_line":"                     segmentation_id) \u003d ovs_db_v2.reserve_vlan(session)"},{"line_number":390,"context_line":"                elif network_type \u003d\u003d constants.TYPE_GRE:"},{"line_number":391,"context_line":"                    segmentation_id \u003d ovs_db_v2.reserve_tunnel(session)"},{"line_number":392,"context_line":"            else:"},{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fgq4%3D","line":391,"in_reply_to":"AAAALH%2F%2FhBM%3D","updated":"2012-09-05 14:16:18.000000000","message":"I\u0027ll add a comment.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"19762874f26e358cc77e1fdf5427a85a11719aca","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":395,"context_line":"                    ovs_db_v2.reserve_specific_vlan(session, physical_network,"},{"line_number":396,"context_line":"                                                    segmentation_id)"},{"line_number":397,"context_line":"            net \u003d super(OVSQuantumPluginV2, self).create_network(context,"},{"line_number":398,"context_line":"                                                                 network)"},{"line_number":399,"context_line":"            ovs_db_v2.add_network_binding(session, net[\u0027id\u0027], network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FhBI%3D","line":396,"updated":"2012-09-05 00:36:22.000000000","message":"if network_type \u003d\u003d local, is this the right thing to do?","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":395,"context_line":"                    ovs_db_v2.reserve_specific_vlan(session, physical_network,"},{"line_number":396,"context_line":"                                                    segmentation_id)"},{"line_number":397,"context_line":"            net \u003d super(OVSQuantumPluginV2, self).create_network(context,"},{"line_number":398,"context_line":"                                                                 network)"},{"line_number":399,"context_line":"            ovs_db_v2.add_network_binding(session, net[\u0027id\u0027], network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Ff3M%3D","line":396,"in_reply_to":"AAAALH%2F%2Fgq8%3D","updated":"2012-09-06 01:09:52.000000000","message":"Done","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"ded64f43513158a71573d8eeb3dcff2e7da5edf8","unresolved":false,"context_lines":[{"line_number":393,"context_line":"                # provider network"},{"line_number":394,"context_line":"                if network_type in [constants.TYPE_VLAN, constants.TYPE_FLAT]:"},{"line_number":395,"context_line":"                    ovs_db_v2.reserve_specific_vlan(session, physical_network,"},{"line_number":396,"context_line":"                                                    segmentation_id)"},{"line_number":397,"context_line":"            net \u003d super(OVSQuantumPluginV2, self).create_network(context,"},{"line_number":398,"context_line":"                                                                 network)"},{"line_number":399,"context_line":"            ovs_db_v2.add_network_binding(session, net[\u0027id\u0027], network_type,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fgq8%3D","line":396,"in_reply_to":"AAAALH%2F%2FhBI%3D","updated":"2012-09-05 14:16:18.000000000","message":"The above code only calls reserve_specific_vlan() for TYPE_VLAN and TYPE_FLAT. I\u0027ll add a comment that nothing needs to be done for TYPE_LOCAL.","commit_id":"c5575c789723a18f1af04180a3059cc6823539fe"}]}
