)]}'
{"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"8075f6ef4fd358a3578872741d534526bbd9abea","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                    if (subnet.ip_version \u003d\u003d 4 and self.conf.use_namespaces"},{"line_number":233,"context_line":"                        and enable_metadata):"},{"line_number":234,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":235,"context_line":"                        enable_metadata \u003d False  # Don\u0027t trigger twice"},{"line_number":236,"context_line":"                    self.cache.put(network)"},{"line_number":237,"context_line":"                break"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_59b057f4","line":235,"updated":"2014-09-24 12:47:01.000000000","message":"Not related to the problem addressed by this patch, but can the above statement be removed due to the \u0027break\u0027 statement in below? The comments is misleading as well.\n\nAnother issue is related to metadata service in the case of ipv6 only network. With the above ip_version check, metadata service won\u0027t be available in that  case. But again this is not related to the issue.","commit_id":"1b66e11b5d8c0b3de0610ca02c3e10b6f64ae375"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"ad1e9cb24a264464b106c47430d8875d8a909edd","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                    if (subnet.ip_version \u003d\u003d 4 and self.conf.use_namespaces"},{"line_number":233,"context_line":"                        and enable_metadata):"},{"line_number":234,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":235,"context_line":"                        enable_metadata \u003d False  # Don\u0027t trigger twice"},{"line_number":236,"context_line":"                    self.cache.put(network)"},{"line_number":237,"context_line":"                break"},{"line_number":238,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da9df570_9261a33b","line":235,"in_reply_to":"da9df570_59b057f4","updated":"2014-09-25 02:41:27.000000000","message":"I think we can remove this line since the loop gets broken anyway. \n\nmetadata service only works for IPv4 right now because the current default service address is 169.254.169.254. And IPv6 metadata address is not supported by cloud init yet.","commit_id":"1b66e11b5d8c0b3de0610ca02c3e10b6f64ae375"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"a5ece9443384b64502d8ad3972ebbb835a807e2f","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":235,"context_line":"                        enable_metadata \u003d False  # Don\u0027t trigger twice"},{"line_number":236,"context_line":"                    self.cache.put(network)"},{"line_number":237,"context_line":"                break"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def disable_dhcp_helper(self, network_id):"},{"line_number":240,"context_line":"        \"\"\"Disable DHCP for a network known to the agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_63f2afd3","line":237,"updated":"2014-11-13 15:17:35.000000000","message":"I believe this loop is still broken (metadata start)\n\nA second loop may be required only to make sure isolated metadata starts properly where needed ( ipv4 + enable_metadata), otherwise, if first subnet is IPv6(dhcp enabled), and second subnet is IPv4, the code will break, and isolated metadata won\u0027t be started.\n\nWhat do you think?\nThat corner case didn\u0027t happen in previous code), but it may happen now.","commit_id":"1b66e11b5d8c0b3de0610ca02c3e10b6f64ae375"},{"author":{"_account_id":6685,"name":"Baodong (Robert) Li","email":"baoli@cisco.com","username":"baoli"},"change_message_id":"5289a992faf079a35bb78343ac1449d00d85694a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                        self.enable_isolated_metadata_proxy(network)"},{"line_number":235,"context_line":"                        enable_metadata \u003d False  # Don\u0027t trigger twice"},{"line_number":236,"context_line":"                    self.cache.put(network)"},{"line_number":237,"context_line":"                break"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def disable_dhcp_helper(self, network_id):"},{"line_number":240,"context_line":"        \"\"\"Disable DHCP for a network known to the agent.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_768fcfcc","line":237,"in_reply_to":"5a890539_63f2afd3","updated":"2014-11-13 15:43:20.000000000","message":"+1. nice catch.\n\nSuggested to take the logic that enables the metadata proxy outside this existing loop. \n\nAlternatively, I think that enabling the proxy doesn\u0027t have to depend on the ip_version to be v4 on KVM/linux hypervisors. The v4 stack will always be on, and the metadata just uses link local v4 address.","commit_id":"1b66e11b5d8c0b3de0610ca02c3e10b6f64ae375"}]}
