)]}'
{"etc/quantum/rootwrap.d/dhcp.filters":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"528e79f6d261aaf0a786888d10d738d632f299bd","unresolved":false,"context_lines":[{"line_number":25,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":26,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":27,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":28,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2FhAs%3D","line":28,"updated":"2012-09-05 00:50:09.000000000","message":"ip_exec_usr?","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":26,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":27,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":28,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2Fg%2BE%3D","line":28,"in_reply_to":"AAAALH%2F%2FhAs%3D","updated":"2012-09-05 02:26:30.000000000","message":"good catch. done","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"}],"etc/quantum/rootwrap.d/l3.filters":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"528e79f6d261aaf0a786888d10d738d632f299bd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":16,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":17,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":18,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# ovs_lib (if OVSInterfaceDriver is used)"},{"line_number":21,"context_line":"ovs-vsctl: CommandFilter, /bin/ovs-vsctl, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2FhA0%3D","line":18,"updated":"2012-09-05 00:50:09.000000000","message":"I think this name should be ip_exec_usr, right?","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":16,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":17,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":18,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# ovs_lib (if OVSInterfaceDriver is used)"},{"line_number":21,"context_line":"ovs-vsctl: CommandFilter, /bin/ovs-vsctl, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2Fg%2BA%3D","line":18,"in_reply_to":"AAAALH%2F%2FhA0%3D","updated":"2012-09-05 02:26:30.000000000","message":"Done","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"}],"etc/quantum/rootwrap.d/linuxbridge-plugin.filters":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"528e79f6d261aaf0a786888d10d738d632f299bd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":19,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":20,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":21,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2FhAo%3D","line":21,"updated":"2012-09-05 00:50:09.000000000","message":"ip_exec_usr?","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"ip: IpFilter, /sbin/ip, root"},{"line_number":19,"context_line":"ip_usr: IpFilter, /usr/sbin/ip, root"},{"line_number":20,"context_line":"ip_exec: IpNetnsExecFilter, /sbin/ip, root"},{"line_number":21,"context_line":"ip_usr: IpNetnsExecFilter, /usr/sbin/ip, root"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAALH%2F%2Fg98%3D","line":21,"in_reply_to":"AAAALH%2F%2FhAo%3D","updated":"2012-09-05 02:26:30.000000000","message":"Done","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"}],"quantum/rootwrap/filters.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"528e79f6d261aaf0a786888d10d738d632f299bd","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class ExecCommandFilter(CommandFilter):"},{"line_number":48,"context_line":"    def exec_args(self, userargs):"},{"line_number":49,"context_line":"        return []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class RegExpFilter(CommandFilter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FhBg%3D","line":49,"updated":"2012-09-05 00:50:09.000000000","message":"Why do we need this Filter class since we have only one IPNetnsExecFilter to derive from it? I prefer not to predict something in the future. (just a suggestion)","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class ExecCommandFilter(CommandFilter):"},{"line_number":48,"context_line":"    def exec_args(self, userargs):"},{"line_number":49,"context_line":"        return []"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"class RegExpFilter(CommandFilter):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fg%2Bc%3D","line":49,"in_reply_to":"AAAALH%2F%2FhBg%3D","updated":"2012-09-05 02:26:30.000000000","message":"I wrote a base class because it\u0027s still possible we could need to provide alternate support for distros that don\u0027t have the correct version of iproute.","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":193,"context_line":"            return False"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def exec_args(self, userargs):"},{"line_number":196,"context_line":"        return userargs[4:]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fg9s%3D","line":196,"updated":"2012-09-05 02:33:46.000000000","message":"(suggestion) might be worth a comment that we\u0027re intentionally excluding the namespace name.  Otherwise, looks like an off-by-one bug.","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"}],"quantum/rootwrap/wrapper.py":[{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"528e79f6d261aaf0a786888d10d738d632f299bd","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                if not isinstance(fltr,"},{"line_number":72,"context_line":"                                                  filters.ExecCommandFilter)]"},{"line_number":73,"context_line":"                args \u003d f.exec_args(userargs)"},{"line_number":74,"context_line":"                if not args or not match_filter(leaf_filters, args):"},{"line_number":75,"context_line":"                    continue"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # Try other filters if executable is absent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FhAc%3D","line":74,"updated":"2012-09-05 00:50:09.000000000","message":"Does this mean all other commands which are not ip netns exec in filter files can be run by  ip netns exec? Can we do more strict check? For example, we can check what commands we need to run by ip netns exec.","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                if not isinstance(fltr,"},{"line_number":72,"context_line":"                                                  filters.ExecCommandFilter)]"},{"line_number":73,"context_line":"                args \u003d f.exec_args(userargs)"},{"line_number":74,"context_line":"                if not args or not match_filter(leaf_filters, args):"},{"line_number":75,"context_line":"                    continue"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # Try other filters if executable is absent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fg9o%3D","line":74,"in_reply_to":"AAAALH%2F%2Fg%2FA%3D","updated":"2012-09-05 02:33:46.000000000","message":"that\u0027s clever.  Since we can run with namespaces disabled, all namespace commands must also be able to be run directly.  I suppose there may be some commands that are only currently run outside of a namespace, but in general I agree it doesn\u0027t make much sense to keep a separate list.","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                if not isinstance(fltr,"},{"line_number":72,"context_line":"                                                  filters.ExecCommandFilter)]"},{"line_number":73,"context_line":"                args \u003d f.exec_args(userargs)"},{"line_number":74,"context_line":"                if not args or not match_filter(leaf_filters, args):"},{"line_number":75,"context_line":"                    continue"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            # Try other filters if executable is absent"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fg%2FA%3D","line":74,"in_reply_to":"AAAALH%2F%2FhAc%3D","updated":"2012-09-05 02:26:30.000000000","message":"The commands that run inside a namespace are the exact same set as the commands that run outside of one.  It made more sense to leverage the existing set than duplicate it.","commit_id":"4f19c72b21778297e776e38739cd42dcbe4087b4"}]}
