)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"d45b05e22f576c4643f75465e3ebfcf4e3b9ae6d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"},{"line_number":14,"context_line":"Change-Id: Ide995810d6fe0481d3add206bf0674cbbde7f05f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da9df570_a02388a5","line":11,"updated":"2014-09-26 07:55:11.000000000","message":"Can you rephrase the above 3 lines for more readability.","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"46f4730f3de1222555471d684367755f5873c1b8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"},{"line_number":14,"context_line":"Change-Id: Ide995810d6fe0481d3add206bf0674cbbde7f05f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9aa7fdbe_f55170d9","line":11,"in_reply_to":"da9df570_40073cca","updated":"2014-10-17 23:55:27.000000000","message":"Wei Wang, since you\u0027ve written this explanation, could you add it to the commit message as Trinath requested?","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"31c4264f179e4b170cd7a456f4aa4ff3bea85ae6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"},{"line_number":14,"context_line":"Change-Id: Ide995810d6fe0481d3add206bf0674cbbde7f05f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da9df570_40073cca","line":11,"in_reply_to":"da9df570_a02388a5","updated":"2014-10-08 03:34:26.000000000","message":"Allowed address pair have an unique check in extensions.allowedaddresspairs._validate_allowed_address_pairs, but it can\u0027t handle a sistuation like this: [{\u0027ip_address\u0027: \u002710.0.0.1\u0027, \u0027mac_address\u0027: \u002712:34:56:78:aa:bb\u0027}, {\u0027ip_address\u0027: \u002710.0.0.1\u0027}]","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":12215,"name":"Alexey Miroshkin","email":"alexey.miroshkin@ru.ibm.com","username":"amirosh"},"change_message_id":"a5bed718c35e6ee3eee5075d19cd63785ae37116","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wei Wang \u003cwangwei@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-11-09 13:33:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP, like this example: [{\u0027ip_address\u0027: \u002710.0.0.1\u0027, \u0027mac_address\u0027:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_e29c226c","line":7,"updated":"2014-11-11 15:00:41.000000000","message":"Perhaps I\u0027m missing something, but it looks confusing to me. As I understood your code the goal is to raise a more meaningful (application) exception instead of a general (database) one. However it\u0027s not clear from the title and the text below.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ce10efb7cedea24ea773c6cb37af3557f8ef1269","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wei Wang \u003cwangwei@unitedstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-11-09 13:33:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP, like this example: [{\u0027ip_address\u0027: \u002710.0.0.1\u0027, \u0027mac_address\u0027:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a890539_c12fe986","line":7,"in_reply_to":"5a890539_e29c226c","updated":"2014-11-21 05:30:36.000000000","message":"-1 @Alexey.  I don\u0027t think you have fully captured the intent of the code.  There are some cases that should fail that don\u0027t with just the database.  This commit message could use some clearer language but I\u0027m not too concerned.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"05f744d42b46ae16cd9238558fa1d8ab5e648803","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da9b358b_45d2a3d3","line":10,"updated":"2015-04-01 08:47:32.000000000","message":"I\u0027m not understanding how the fix helps in this case. It\u0027s converting one exception type to another. Please explain how that stops the unique check from passing in a condition it did before.","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f778b678a7a391e4ca9e979e408743894ba25a4f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a930d6b_f80e7d31","line":10,"updated":"2015-01-22 14:06:19.000000000","message":"This long sentence is hard to read. Consider rewording. Also, it doesn\u0027t describe the solution taken (checking for duplicate at create for database).","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"db3861122d385a2aa3d42970b6a35e7aa1ba4e4e","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"1a930d6b_4f8c2880","line":10,"in_reply_to":"1a930d6b_f80e7d31","updated":"2015-01-22 14:48:54.000000000","message":"+1","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4a009d87ca83e008707425e6ceec9a49a96a9238","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension sometimes not work for extension can\u0027t get port\u0027s"},{"line_number":10,"context_line":"IP so None and real mac for allowed address pair to one IP address"},{"line_number":11,"context_line":"will pass in allowed address pair\u0027s unique check."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a016987_07ce4db4","line":9,"updated":"2015-05-26 19:51:10.000000000","message":"This sentence isn\u0027t clear.","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"536e7ae1a20443f15ec58e258c78d4502ed3461f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix duplicate entry catch for allowed address pairs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension not work for it can\u0027t get port\u0027s IP"},{"line_number":10,"context_line":"so if None and real mac both submited in allowed address pair"},{"line_number":11,"context_line":"with one IP address will survived in unique check."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7a016987_41100659","line":9,"updated":"2015-06-01 11:56:06.000000000","message":"This still doesn\u0027t really explain what is being fixed. Is the intent here only to provide more info in the exception?","commit_id":"c8f4ec83867a76acd30a857486f911feb6095a1e"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e5df5708190801be1ab6889d790b239b26c735c3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension not work for it can\u0027t get port\u0027s IP"},{"line_number":10,"context_line":"so if None and real mac both submited in allowed address pair"},{"line_number":11,"context_line":"with one IP address will survived in unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"},{"line_number":14,"context_line":"Change-Id: Ide995810d6fe0481d3add206bf0674cbbde7f05f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa32b979_2be1622a","line":11,"updated":"2015-06-24 08:02:30.000000000","message":"Change this to:\n\nIf None is submitted as a MAC address in an allowed_address_pair,\nthe port MAC will be used. So if two entries are submitted with the\nsame IP and one\u0027s MAC is None while the others is the port\u0027s MAC,\nthey will pass the API duplication check and fail to insert into\nthe DB due to a unique constraint violation.\n\nThis patch catches the db error and turns it into the same exception\nthe API uses on duplicate entries.","commit_id":"c8f4ec83867a76acd30a857486f911feb6095a1e"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"572ffc3731b97fd2682affc65e3db5a305e93ee2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Check in extension not work for it can\u0027t get port\u0027s IP"},{"line_number":10,"context_line":"so if None and real mac both submited in allowed address pair"},{"line_number":11,"context_line":"with one IP address will survived in unique check."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-bug: #1373756"},{"line_number":14,"context_line":"Change-Id: Ide995810d6fe0481d3add206bf0674cbbde7f05f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"ba3cc151_c607241c","line":11,"in_reply_to":"fa32b979_2be1622a","updated":"2015-07-10 10:57:14.000000000","message":"really thanks!","commit_id":"c8f4ec83867a76acd30a857486f911feb6095a1e"}],"neutron/db/allowedaddresspairs_db.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"f8400d7fe8ce2e9352f4ff864da66b41605b4919","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_d91b63c8","line":58,"updated":"2014-10-14 07:10:16.000000000","message":"As we may successfully add some address_pairs when we get this exception, does it make sense to remove the pairs added here or mark them in the message.","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"d866f23e75cb354cdf2462036c2ee854d097cb9c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_620a1bd4","line":58,"in_reply_to":"9aa7fdbe_d5546ccc","updated":"2014-10-20 03:32:47.000000000","message":"Thank you for the clarification!","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"46f4730f3de1222555471d684367755f5873c1b8","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_d5546ccc","line":58,"in_reply_to":"baa201ad_57c297e9","updated":"2014-10-17 23:55:27.000000000","message":"Wei Wang, fair enough.  It is probably better not to go to the DB if not necessary.\n\nTo Zhenguo\u0027s comment, Wei Wang is correct.  The transaction will be rolled back and there is nothing to remove.","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"4f6bfe9491243c4096e94751c6872226686c8e54","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_17a48f49","line":58,"in_reply_to":"baa201ad_96635319","updated":"2014-10-16 03:29:40.000000000","message":"Eh, yes, but check in extension is quicker than check in db, right? I think check in extension worth to exist.","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"c7e9ad87386e320ce897ace584d7e2bc0a97b16b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_96635319","line":58,"in_reply_to":"baa201ad_d91b63c8","updated":"2014-10-14 17:10:03.000000000","message":"Does this effectively obsolete the unique check in neutron/extensions/allowedaddresspairs.py?  At first glance, it seems we could remove that code if this is all we need?","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"4f6bfe9491243c4096e94751c6872226686c8e54","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":56,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":57,"context_line":"                    context.session.add(db_pair)"},{"line_number":58,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":59,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":60,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":61,"context_line":"                ip_address\u003daddress_pair[\u0027ip_address\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_57c297e9","line":58,"in_reply_to":"baa201ad_d91b63c8","updated":"2014-10-16 03:29:40.000000000","message":"In fact, \"context.session.add(db_pair)\" won\u0027t get successfully for db has constraint on it,  and  a db exception will be returned.","commit_id":"d78d728c208fc33ea5de7b09b72954c69a523571"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"65e2f32b4732d00f0a5c60d78b2dbdc141e18e7a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import model_base"},{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":24,"context_line":"from oslo.db import exception as db_exc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddressPair(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_1188b01e","line":24,"updated":"2014-11-10 22:08:12.000000000","message":"nit: please move this line before line 16, as suggested in http://docs.openstack.org/developer/hacking/#real-world-import-order-examples","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"7621e38732139003912745c009af6b98fba804f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import model_base"},{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":24,"context_line":"from oslo.db import exception as db_exc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddressPair(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_8576163d","line":24,"in_reply_to":"5a890539_1188b01e","updated":"2014-11-11 03:09:41.000000000","message":"nice catch!","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"3339ff6b048ca3ba5173f42be137c52fe6651356","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import model_base"},{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":24,"context_line":"from oslo.db import exception as db_exc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddressPair(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_306f50c7","line":24,"updated":"2015-01-22 03:39:02.000000000","message":"you still have this import in the wrong place.  Please seen the comments people left on patch set 5.","commit_id":"169ad85d2e635adf36640ab43264909de87be2f8"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"84fb5bf234926403ecb3efe4e06c41976d8c4e52","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import model_base"},{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":"from neutron.extensions import allowedaddresspairs as addr_pair"},{"line_number":24,"context_line":"from oslo.db import exception as db_exc"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class AllowedAddressPair(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a930d6b_f65ea0e8","line":24,"in_reply_to":"1a930d6b_306f50c7","updated":"2015-01-22 05:55:40.000000000","message":"I\u0027m sorry for forgot that, plz check whether the newest patch is right, thx!","commit_id":"169ad85d2e635adf36640ab43264909de87be2f8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"653efcb8b7a755e6665fc9794d04fd62ef9f08cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.db import exception as db_exc"},{"line_number":19,"context_line":"from sqlalchemy import orm"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.api.v2 import attributes as attr"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_86fb8d78","line":18,"updated":"2015-05-25 12:34:51.000000000","message":"oslo_db","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"780097cfd1fb89c0d0d2f0c5a6e1f6349e7bebee","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import sqlalchemy as sa"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from oslo.db import exception as db_exc"},{"line_number":19,"context_line":"from sqlalchemy import orm"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.api.v2 import attributes as attr"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_a53fd585","line":18,"in_reply_to":"7a016987_86fb8d78","updated":"2015-05-31 10:51:10.000000000","message":"Done","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"653efcb8b7a755e6665fc9794d04fd62ef9f08cb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        port_id\u003dport[\u0027id\u0027],"},{"line_number":56,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":57,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":58,"context_line":"                    context.session.add(db_pair)"},{"line_number":59,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":60,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":61,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_26a739a8","line":58,"updated":"2015-05-25 12:34:51.000000000","message":"don\u0027t you need to flush each add in order to use the correct address_pair for L60-62?","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"780097cfd1fb89c0d0d2f0c5a6e1f6349e7bebee","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                        port_id\u003dport[\u0027id\u0027],"},{"line_number":56,"context_line":"                        mac_address\u003daddress_pair[\u0027mac_address\u0027],"},{"line_number":57,"context_line":"                        ip_address\u003daddress_pair[\u0027ip_address\u0027])"},{"line_number":58,"context_line":"                    context.session.add(db_pair)"},{"line_number":59,"context_line":"        except db_exc.DBDuplicateEntry:"},{"line_number":60,"context_line":"            raise addr_pair.DuplicateAddressPairInRequest("},{"line_number":61,"context_line":"                mac_address\u003daddress_pair[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_857df96e","line":58,"in_reply_to":"7a016987_26a739a8","updated":"2015-05-31 10:51:10.000000000","message":"Eh... You mean we should eliminate the duplicate entry and submit?","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"}],"neutron/tests/unit/db/test_allowedaddresspairs_db.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4a009d87ca83e008707425e6ceec9a49a96a9238","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":281,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":282,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":283,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":284,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_a79e5961","line":283,"updated":"2015-05-26 19:51:10.000000000","message":"While it isn\u0027t a huge deal, the mis-ordering of arguments has been pointed out multiple times.  Please swap it in the next patch.","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"780097cfd1fb89c0d0d2f0c5a6e1f6349e7bebee","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":281,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":282,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":283,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":284,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_c5a091f6","line":283,"in_reply_to":"7a016987_a79e5961","updated":"2015-05-31 10:51:10.000000000","message":"Done","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"4a009d87ca83e008707425e6ceec9a49a96a9238","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":282,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":283,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":284,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":287,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_478c4535","line":284,"updated":"2015-05-26 19:51:10.000000000","message":"This has been pointed out multiple times.  Please remove it.","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"780097cfd1fb89c0d0d2f0c5a6e1f6349e7bebee","unresolved":false,"context_lines":[{"line_number":281,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":282,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":283,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":284,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":287,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a016987_a5a355ff","line":284,"in_reply_to":"7a016987_478c4535","updated":"2015-05-31 10:51:10.000000000","message":"Done","commit_id":"b09d4a942242512b7135151c2c2b02e4535c3a9a"}],"neutron/tests/unit/test_extension_allowedaddresspairs.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"3de5f58ef816751c3998a2fcca6c15e8f356111d","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_fe369fe6","line":284,"updated":"2014-11-10 11:07:18.000000000","message":"It is expected that the arguments that are passed to self.assertEqual have the following order:\n\n    self.assertEqual(expected, observed)\n\nThis rule is not followed everywhere, but if you will have to upload a new patchset, consider fixing it in this test.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"1fa5ae5be4983d4dae49ca469257ba939d117731","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_c0c72c11","line":284,"in_reply_to":"5a890539_a5ef92af","updated":"2014-11-11 06:06:24.000000000","message":"As far as I know neutron uses testtools, not unittest. You can see a reference in their method definition and its docstring.\nhttps://github.com/testing-cabal/testtools/blob/master/testtools/testcase.py#L340","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a29a3fd16e642cf3701375e5c7e742890295be99","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_aab84de6","line":284,"in_reply_to":"5a890539_a5ef92af","updated":"2014-11-19 04:27:03.000000000","message":"You should also notice it in the traceback when there is a mismatch as well.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ce10efb7cedea24ea773c6cb37af3557f8ef1269","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_e1ff85ff","line":284,"in_reply_to":"5a890539_aab84de6","updated":"2014-11-21 05:30:36.000000000","message":"I think it should be switched but I wouldn\u0027t fuss to much over this.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"69b37dfe9dea91d8df5117bbd98c8a3b7047d41b","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_a5ef92af","line":284,"in_reply_to":"5a890539_fe369fe6","updated":"2014-11-11 03:30:32.000000000","message":"Hi Elena,\n\nI read the python\u0027s document to verify about the sequence of (expected, observed), but I found nothing about that :-)\n\nhttps://docs.python.org/2/library/unittest.html#unittest.TestCase.assertEqual\n\nCan you give me some reference? Thanks!","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"2d8329dd7608ca2b64514ab3eacd8d532509f97b","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_5ed09353","line":284,"in_reply_to":"5a890539_fe369fe6","updated":"2014-11-10 11:12:23.000000000","message":"Thanks! I\u0027ll consider it if I have a new patch.","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d866925a34ddad98cd7188b592455655ca5b8da2","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":288,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_1f026a3e","line":285,"updated":"2014-11-11 14:08:42.000000000","message":"Question: If the assert fails on L284, will the port get deleted? If not, should addCleanup() be used? What about other tests, outside of the change set?","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"e07bd38838b857a9faf5c5fb4382d20d71c1c8e0","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":288,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_b7371afe","line":285,"in_reply_to":"5a890539_1f026a3e","updated":"2014-11-17 16:18:26.000000000","message":"I have same question... discuss at mail list?","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"50573f5def2394851e53a8163eccd7f8bdcb9047","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":288,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_0aea250f","line":285,"in_reply_to":"5a890539_660c8b43","updated":"2015-01-22 02:53:31.000000000","message":"yes, I have asked in mail list, clean will be done automaticly","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"ce10efb7cedea24ea773c6cb37af3557f8ef1269","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":283,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":284,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":285,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":288,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_660c8b43","line":285,"in_reply_to":"5a890539_b7371afe","updated":"2014-11-21 05:30:36.000000000","message":"I don\u0027t know how worried we need to be about this.  It\u0027ll all get cleaned up in the end, won\u0027t it?","commit_id":"940feaac7003119f8ceac3dc74100de9e524b69c"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"803d7d97789dffbdd8ea0132e558904d8fd03ae4","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                                              addr_pair.ADDRESS_PAIRS,),"},{"line_number":121,"context_line":"                                    port_security_enabled\u003dTrue,"},{"line_number":122,"context_line":"                                    allowed_address_pairs\u003daddress_pairs)"},{"line_number":123,"context_line":"            port \u003d self.deserialize(self.fmt, res)"},{"line_number":124,"context_line":"            self.assertEqual(port[\u0027port\u0027][psec.PORTSECURITY], True)"},{"line_number":125,"context_line":"            self.assertEqual(port[\u0027port\u0027][addr_pair.ADDRESS_PAIRS],"},{"line_number":126,"context_line":"                             address_pairs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_ebe2c89e","line":123,"updated":"2015-01-26 13:27:38.000000000","message":"and this","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"803d7d97789dffbdd8ea0132e558904d8fd03ae4","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                              addr_pair.ADDRESS_PAIRS,),"},{"line_number":139,"context_line":"                                    port_security_enabled\u003dFalse,"},{"line_number":140,"context_line":"                                    allowed_address_pairs\u003daddress_pairs)"},{"line_number":141,"context_line":"            self.deserialize(self.fmt, res)"},{"line_number":142,"context_line":"            self.assertEqual(res.status_int, 409)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_create_port_bad_mac(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_0be0f494","line":141,"updated":"2015-01-26 13:27:38.000000000","message":"and this","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"803d7d97789dffbdd8ea0132e558904d8fd03ae4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                        arg_list\u003d(addr_pair.ADDRESS_PAIRS,"},{"line_number":196,"context_line":"                                        \u0027fixed_ips\u0027),"},{"line_number":197,"context_line":"                                        allowed_address_pairs\u003daddress_pairs,"},{"line_number":198,"context_line":"                                        fixed_ips\u003dfixed_ips)"},{"line_number":199,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":200,"context_line":"                port \u003d self.deserialize(self.fmt, res)"},{"line_number":201,"context_line":"                self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_eb7488ff","line":198,"updated":"2015-01-26 13:27:38.000000000","message":"so this is not correct, right?","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e41c790c32fac00a2e29b5966e6d1de83765ffad","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                                        arg_list\u003d(addr_pair.ADDRESS_PAIRS,"},{"line_number":196,"context_line":"                                        \u0027fixed_ips\u0027),"},{"line_number":197,"context_line":"                                        allowed_address_pairs\u003daddress_pairs,"},{"line_number":198,"context_line":"                                        fixed_ips\u003dfixed_ips)"},{"line_number":199,"context_line":"                self.assertEqual(res.status_int, 201)"},{"line_number":200,"context_line":"                port \u003d self.deserialize(self.fmt, res)"},{"line_number":201,"context_line":"                self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_3e06cc1d","line":198,"in_reply_to":"1a930d6b_eb7488ff","updated":"2015-01-26 13:36:46.000000000","message":"Yes","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"db3861122d385a2aa3d42970b6a35e7aa1ba4e4e","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_efaf94e1","line":282,"updated":"2015-01-22 14:48:54.000000000","message":"nit: the correct order is self.assertEqual(expected, observed)","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"a75d0f00960094e5f716e4ad89a9e00d852d9be8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_65b2fd4d","line":282,"in_reply_to":"1a930d6b_0008ddd8","updated":"2015-05-31 10:50:50.000000000","message":"Done","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"cc5726b71812bd53849fc308c203c81ab626d51f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_0008ddd8","line":282,"in_reply_to":"1a930d6b_297258e5","updated":"2015-01-26 07:28:06.000000000","message":"This order is correct:\nassertEqual(expected, actual)\n\nIn this test case:\n\n  expected: 400 \n  actual: res.status_int","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"a75d0f00960094e5f716e4ad89a9e00d852d9be8","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_85a6190d","line":282,"in_reply_to":"1a930d6b_efaf94e1","updated":"2015-05-31 10:50:50.000000000","message":"Done","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"986a35750282e23547f00e189fe26ec00773ccba","unresolved":false,"context_lines":[{"line_number":279,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, update_port,"},{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a930d6b_297258e5","line":282,"in_reply_to":"1a930d6b_efaf94e1","updated":"2015-01-23 10:50:41.000000000","message":"it shouldn\u0027t be considered as nit comment. I feel we should follow everywhere possible.","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"05f744d42b46ae16cd9238558fa1d8ab5e648803","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":286,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9b358b_25d55fb8","line":283,"updated":"2015-04-01 08:47:32.000000000","message":"don\u0027t delete the port at the end, it\u0027s not part of the test","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"a75d0f00960094e5f716e4ad89a9e00d852d9be8","unresolved":false,"context_lines":[{"line_number":280,"context_line":"                                          port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":281,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":282,"context_line":"            self.assertEqual(res.status_int, 400)"},{"line_number":283,"context_line":"            self._delete(\u0027ports\u0027, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def test_create_port_remove_allowed_address_pairs(self):"},{"line_number":286,"context_line":"        with self.network() as net:"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a016987_45adc1e7","line":283,"in_reply_to":"da9b358b_25d55fb8","updated":"2015-05-31 10:50:50.000000000","message":"Done","commit_id":"f67e7e0e335035cf86f32a2398d088716c499c95"}]}
