)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6876,"name":"stephen-ma","email":"stephenbma43@gmail.com","username":"stephen-ma"},"change_message_id":"4defb9790c75f2dc3a3cec0b3aa80fc278611eba","unresolved":false,"context_lines":[{"line_number":10,"context_line":"used to keep track of FIPs for DVR routers."},{"line_number":11,"context_line":"This variable is not re-initialized correctly on"},{"line_number":12,"context_line":"agent restart and can get stale from other errors"},{"line_number":13,"context_line":"which cause proplems with namespace and port cleanup."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch will initialize the ri.dist_fip_count"},{"line_number":16,"context_line":"once in process_router for dvr routers only.  This"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"3a961159_97514edb","line":13,"updated":"2015-01-15 22:03:06.000000000","message":"proplems --\u003e problems","commit_id":"b31b39d6df7407453d63a1a33e57eb2c2b660644"}],"neutron/agent/l3/agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"621104468c434a82d329e34e65ead300b347c1f6","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                                     namespace\u003dri.ns_name)"},{"line_number":357,"context_line":"            existing_cidrs \u003d [addr[\u0027cidr\u0027] for addr in device.addr.list()]"},{"line_number":358,"context_line":"            fip_cidrs \u003d [c for c in existing_cidrs if c.endswith("},{"line_number":359,"context_line":"                FLOATING_IP_CIDR_SUFFIX)]"},{"line_number":360,"context_line":"            ri.dist_fip_count \u003d len(fip_cidrs)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _router_added(self, router_id, router):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_bdd5de44","line":359,"updated":"2015-01-21 23:05:49.000000000","message":"There is another change merging now to remove this constant.\n\nhttps://review.openstack.org/#/c/147972/","commit_id":"f745672005cebbaf860358788fcf5a4532fa1a71"},{"author":{"_account_id":10971,"name":"Michael Smith","email":"michael.smith6@hp.com","username":"mrsmith"},"change_message_id":"c8138707c187d7cc98fef8535784908cd60943bf","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                                     namespace\u003dri.ns_name)"},{"line_number":357,"context_line":"            existing_cidrs \u003d [addr[\u0027cidr\u0027] for addr in device.addr.list()]"},{"line_number":358,"context_line":"            fip_cidrs \u003d [c for c in existing_cidrs if c.endswith("},{"line_number":359,"context_line":"                FLOATING_IP_CIDR_SUFFIX)]"},{"line_number":360,"context_line":"            ri.dist_fip_count \u003d len(fip_cidrs)"},{"line_number":361,"context_line":""},{"line_number":362,"context_line":"    def _router_added(self, router_id, router):"}],"source_content_type":"text/x-python","patch_set":11,"id":"1a930d6b_dd838aca","line":359,"in_reply_to":"1a930d6b_bdd5de44","updated":"2015-01-21 23:24:39.000000000","message":"good - it made it hard to put this in the right place due to import issues.  I\u0027ll rebase with that and move this to dvr.py","commit_id":"f745672005cebbaf860358788fcf5a4532fa1a71"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1d81199001303462cefb7d7360c62f4ece8ef715","unresolved":false,"context_lines":[{"line_number":581,"context_line":"        # TODO(mrsmith) - we shouldn\u0027t need to check here"},{"line_number":582,"context_line":"        if \u0027distributed\u0027 not in ri.router:"},{"line_number":583,"context_line":"            ri.router[\u0027distributed\u0027] \u003d False"},{"line_number":584,"context_line":"        self.scan_fip_ports(ri)"},{"line_number":585,"context_line":"        self._process_internal_ports(ri)"},{"line_number":586,"context_line":"        self._process_external(ri)"},{"line_number":587,"context_line":"        # Process static routes for router"}],"source_content_type":"text/x-python","patch_set":12,"id":"1a930d6b_21741a67","line":584,"updated":"2015-01-23 19:58:26.000000000","message":"(no action needed)\n\nI\u0027d rather do:\n\nif \u0027distributed\u0027 not in ri.router:\n  ..\nelse:\n  self.scan_fip_ports(ri)\n\nand then skip the return in the scan_fip_ports","commit_id":"ee4bae211309e0f1fcee5565ddd2379997e1de13"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"3bdb60562ae41cbeb63b5e2fe896e6c25944e16c","unresolved":false,"context_lines":[{"line_number":1680,"context_line":"        for d in ns_ip.get_devices(exclude_loopback\u003dTrue):"},{"line_number":1681,"context_line":"            if d.name.startswith(ROUTER_2_FIP_DEV_PREFIX):"},{"line_number":1682,"context_line":"                return True"},{"line_number":1683,"context_line":"        return False"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"    def floating_forward_rules(self, floating_ip, fixed_ip):"},{"line_number":1686,"context_line":"        return [(\u0027PREROUTING\u0027, \u0027-d %s -j DNAT --to %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_41209c49","line":1683,"updated":"2014-09-30 09:58:54.000000000","message":"not needed - None returned by default will work too.","commit_id":"52b3c1ee52b56e9eb57c7443b1677d3e4cfa429a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"67b2927987c34325d0e0b5b3988ab82d087e4521","unresolved":false,"context_lines":[{"line_number":1071,"context_line":"                                            [\u0027floating_network_id\u0027])"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"        if self.agent_gateway_port and floating_ips:"},{"line_number":1074,"context_line":"                fip_net_id \u003d floating_ips[0][\u0027floating_network_id\u0027]"},{"line_number":1075,"context_line":"                self.create_rtr_2_fip_link(ri, fip_net_id)"},{"line_number":1076,"context_line":""},{"line_number":1077,"context_line":"    def _get_external_device_interface_name(self, ri, ex_gw_port):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a961159_46d2c100","line":1074,"updated":"2015-01-08 08:53:39.000000000","message":"too much indentation here","commit_id":"df8ed5a92ae0cbc86e767c9ecc373e6733f79564"}]}