)]}'
{"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c8a487b89482036309e0cea55beb1aed8341adb9","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                )"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":618,"context_line":"                for cidr in v4_subnets - set([subnet.cidr]):"},{"line_number":619,"context_line":"                    host_routes.append(\"%s,0.0.0.0\" % (cidr))"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"                if host_routes:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_585178d7","line":618,"updated":"2014-10-10 09:35:07.000000000","message":"Maybe this is a matter of taste...\ncreation of set and \u0027-\u0027 operation isn\u0027t necessary. something like\nhost_routers.extend(\"%s,0.0.0.0\" % subnet.cidr for subnet in ... if ip_version \u003d\u003d 4 and cidr !\u003d subnet.cidr)","commit_id":"6932c22e4bf12ec6ddf31a2dcec9a86c712c96e7"},{"author":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"change_message_id":"dbf5e16570b3f9942e3b1a186e017dc0e0d819cb","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                )"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":618,"context_line":"                for cidr in v4_subnets - set([subnet.cidr]):"},{"line_number":619,"context_line":"                    host_routes.append(\"%s,0.0.0.0\" % (cidr))"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"                if host_routes:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_351f560b","line":618,"in_reply_to":"baa201ad_585178d7","updated":"2014-10-10 13:14:39.000000000","message":"Well, I personally try to avoid such constructions (matter of taste).  However, this seems to be faster (one loop less, no need to create sets) and, most important part, preserves subnet order.","commit_id":"6932c22e4bf12ec6ddf31a2dcec9a86c712c96e7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"eeaf2a0e4392ba0483c17cd41623e0b605feec81","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                )"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":635,"context_line":"                host_routes.extend([\"%s,0.0.0.0\" % (s.cidr) for s in"},{"line_number":636,"context_line":"                                    self.network.subnets"},{"line_number":637,"context_line":"                                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":638,"context_line":"                                        s.cidr !\u003d subnet.cidr)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_135b6b23","line":635,"updated":"2015-01-19 16:38:41.000000000","message":"Why is it ipv4 only? Shouldn\u0027t we also set RTPREFIX option for ipv6?","commit_id":"d3a38d9b44c20a5dad906b22e31db632b05e83a9"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"81afdd22484c118193bc3cf3ae50aea702deb03e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                )"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":635,"context_line":"                host_routes.extend([\"%s,0.0.0.0\" % (s.cidr) for s in"},{"line_number":636,"context_line":"                                    self.network.subnets"},{"line_number":637,"context_line":"                                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":638,"context_line":"                                        s.cidr !\u003d subnet.cidr)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_b89eee53","line":635,"in_reply_to":"3a961159_135b6b23","updated":"2015-01-19 17:21:29.000000000","message":"Because the patch title says IPv4? :)\n\nIhar, are you OK with v6 being done in a follow-up patch?","commit_id":"d3a38d9b44c20a5dad906b22e31db632b05e83a9"},{"author":{"_account_id":11061,"name":"Alexey I. Froloff","email":"raorn@raorn.name","username":"raorn"},"change_message_id":"c214f14c56b168eb08f0f4f735776572f3f0696c","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                )"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":635,"context_line":"                host_routes.extend([\"%s,0.0.0.0\" % (s.cidr) for s in"},{"line_number":636,"context_line":"                                    self.network.subnets"},{"line_number":637,"context_line":"                                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":638,"context_line":"                                        s.cidr !\u003d subnet.cidr)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_f77dcb6e","line":635,"in_reply_to":"3a961159_6d4be386","updated":"2015-01-20 10:55:35.000000000","message":"Actually, I wasn\u0027t aware about this option before today.  As far as I googled, there is no RFC for this yet and even IETF draft is expired (correct me if I\u0027m wrong).\nOur clients (Ubuntu, RHEL5) doesn\u0027t seem to support this option.  I wouldn\u0027t implement a feature that I can\u0027t test, so I\u0027ll stick to IPv4 for this patch for now.","commit_id":"d3a38d9b44c20a5dad906b22e31db632b05e83a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9836f6420b1340eab45ee422f825ae9146dd2e3f","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                )"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":635,"context_line":"                host_routes.extend([\"%s,0.0.0.0\" % (s.cidr) for s in"},{"line_number":636,"context_line":"                                    self.network.subnets"},{"line_number":637,"context_line":"                                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":638,"context_line":"                                        s.cidr !\u003d subnet.cidr)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_6d4be386","line":635,"in_reply_to":"3a961159_b89eee53","updated":"2015-01-19 21:04:58.000000000","message":"Yeah, that\u0027s good hypothesis. I would like to hear from Alexey on whether it was omitted by intent, and whether he is going to propose another patch for ipv6 (if not, I can endevour there myself).","commit_id":"d3a38d9b44c20a5dad906b22e31db632b05e83a9"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"605008086bde32c49afca9497bc829fb68d02894","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                )"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"            if subnet.ip_version \u003d\u003d 4:"},{"line_number":635,"context_line":"                host_routes.extend([\"%s,0.0.0.0\" % (s.cidr) for s in"},{"line_number":636,"context_line":"                                    self.network.subnets"},{"line_number":637,"context_line":"                                    if (s.ip_version \u003d\u003d 4 and"},{"line_number":638,"context_line":"                                        s.cidr !\u003d subnet.cidr)])"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_daa1d6f8","line":635,"in_reply_to":"3a961159_f77dcb6e","updated":"2015-01-20 11:26:11.000000000","message":"Yeah, indeed, RT_PREFIX seems to be expired.","commit_id":"d3a38d9b44c20a5dad906b22e31db632b05e83a9"}],"neutron/tests/unit/test_linux_dhcp.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"22143381c4d3d4436f71776962aeb79911f31f14","unresolved":false,"context_lines":[{"line_number":913,"context_line":"        expected \u003d ("},{"line_number":914,"context_line":"            \u0027tag:tag0,option:dns-server,8.8.8.8\\n\u0027"},{"line_number":915,"context_line":"            \u0027tag:tag0,option:classless-static-route,20.0.0.1/24,20.0.0.1,\u0027"},{"line_number":916,"context_line":"            \u0027192.168.1.0/24,0.0.0.0,0.0.0.0/0,192.168.0.1\\n\u0027"},{"line_number":917,"context_line":"            \u0027tag:tag0,249,20.0.0.1/24,20.0.0.1,192.168.1.0/24,0.0.0.0,\u0027"},{"line_number":918,"context_line":"            \u00270.0.0.0/0,192.168.0.1\\n\u0027"},{"line_number":919,"context_line":"            \u0027tag:tag0,option:router,192.168.0.1\u0027).lstrip()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_1715683f","line":916,"updated":"2014-10-06 23:34:24.000000000","message":"these test changes are not additional coverage; please consider adding a test that targets your change.","commit_id":"86b52cf902fd3e59017f0330ec973c5b4c5aee05"}]}