)]}'
{"neutron/plugins/vmware/plugins/base.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cfe190d016f9e9bfddde06fea524c57ce5af4233","unresolved":false,"context_lines":[{"line_number":820,"context_line":""},{"line_number":821,"context_line":"    def _handle_lswitch_selection(self, context, cluster, network):"},{"line_number":822,"context_line":"        # NOTE(salv-orlando): This method used to select a NSX logical switch"},{"line_number":823,"context_line":"        # with an available porti, and create a new logical switch if"},{"line_number":824,"context_line":"        # necessary. As there is no more need to perform switch chaining in"},{"line_number":825,"context_line":"        # NSX, this method now just returns the first logical switch mapped"},{"line_number":826,"context_line":"        # to a Neutron network."}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e0a93291","line":823,"updated":"2014-10-03 12:40:22.000000000","message":"porti -\u003e port","commit_id":"533099bc7b4f2818dd64e2fc4e4a4774ac514ff3"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"999cac78fc97b83ef88e81594e4c594f0d421767","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        # the deployment and the code needs to find the first one with"},{"line_number":836,"context_line":"        # an avaialble slot for a port"},{"line_number":837,"context_line":"        lswitches \u003d nsx_utils.fetch_nsx_switches("},{"line_number":838,"context_line":"            context.session, cluster, network[\u0027id\u0027])"},{"line_number":839,"context_line":"        try:"},{"line_number":840,"context_line":"            return [ls for ls in lswitches"},{"line_number":841,"context_line":"                    if (ls[\u0027_relations\u0027][\u0027LogicalSwitchStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_8313605b","line":838,"updated":"2014-10-21 03:00:19.000000000","message":"why network.id was changed to network[\u0027id\u0027] ?","commit_id":"e30508d26c9dcd32e0d4a02d00776c0afd9603b6"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"9cc611033571e88d3a41453b7c88049c07f6d2fa","unresolved":false,"context_lines":[{"line_number":835,"context_line":"        # the deployment and the code needs to find the first one with"},{"line_number":836,"context_line":"        # an avaialble slot for a port"},{"line_number":837,"context_line":"        lswitches \u003d nsx_utils.fetch_nsx_switches("},{"line_number":838,"context_line":"            context.session, cluster, network[\u0027id\u0027])"},{"line_number":839,"context_line":"        try:"},{"line_number":840,"context_line":"            return [ls for ls in lswitches"},{"line_number":841,"context_line":"                    if (ls[\u0027_relations\u0027][\u0027LogicalSwitchStatus\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6f568008","line":838,"in_reply_to":"9aa7fdbe_8313605b","updated":"2014-11-18 21:47:16.000000000","message":"because I felt like it was not ok to rely on the fact that network was a sqlalchemy model class","commit_id":"e30508d26c9dcd32e0d4a02d00776c0afd9603b6"}],"neutron/tests/unit/vmware/test_nsx_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"cfe190d016f9e9bfddde06fea524c57ce5af4233","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                    pnet.SEGMENTATION_ID)) as net:"},{"line_number":139,"context_line":"            with self.subnet(network\u003dnet) as sub:"},{"line_number":140,"context_line":"                with self.port(subnet\u003dsub):"},{"line_number":141,"context_line":"                    # creating another port should see an exception"},{"line_number":142,"context_line":"                    self._create_port(\u0027json\u0027, net[\u0027network\u0027][\u0027id\u0027], 400)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_exhaust_ports_overlay_network(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_c080aec2","line":141,"updated":"2014-10-03 12:40:22.000000000","message":"_test_exhaust_ports() is relying of an exception to do the test. A subtle distinction, but this will be reported as a test \"error\", rather than a test \"failure\".  Would be better to do:\n    try:\n        self._create_port(...)\n    except Exception:\n        fail(\"Some descriptive message\")","commit_id":"533099bc7b4f2818dd64e2fc4e4a4774ac514ff3"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1ade1a003938bd0f81b1212dc62b59019c608cfc","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                    pnet.SEGMENTATION_ID)) as net:"},{"line_number":139,"context_line":"            with self.subnet(network\u003dnet) as sub:"},{"line_number":140,"context_line":"                with self.port(subnet\u003dsub):"},{"line_number":141,"context_line":"                    # creating another port should see an exception"},{"line_number":142,"context_line":"                    self._create_port(\u0027json\u0027, net[\u0027network\u0027][\u0027id\u0027], 400)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_exhaust_ports_overlay_network(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_39201d9b","line":141,"in_reply_to":"baa201ad_0743a56c","updated":"2014-11-19 22:13:35.000000000","message":"No, sorry. The \"should see an exception\" in the comment threw me off (and I thought I traced back _create_port, but I must have looked in the wrong place). Looks fine.","commit_id":"533099bc7b4f2818dd64e2fc4e4a4774ac514ff3"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"10920ea2505cbf0332c175e2003bda6e6d1f2504","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                                    pnet.SEGMENTATION_ID)) as net:"},{"line_number":139,"context_line":"            with self.subnet(network\u003dnet) as sub:"},{"line_number":140,"context_line":"                with self.port(subnet\u003dsub):"},{"line_number":141,"context_line":"                    # creating another port should see an exception"},{"line_number":142,"context_line":"                    self._create_port(\u0027json\u0027, net[\u0027network\u0027][\u0027id\u0027], 400)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_exhaust_ports_overlay_network(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_0743a56c","line":141,"in_reply_to":"baa201ad_c080aec2","updated":"2014-10-03 17:29:26.000000000","message":"self._create_port just verifies that the response code if a 400 -\u003ehttps://github.com/openstack/neutron/blob/master/neutron/tests/unit/test_db_plugin.py#L366\n\nTo the best of my knowledge there is not exception thrown - well maybe in the plugin - but then again this test exercises the API router, so the exception is handed and what the get here is a 400 status code.\n\nOr maybe you\u0027re seeing something I can\u0027t see?","commit_id":"533099bc7b4f2818dd64e2fc4e4a4774ac514ff3"}]}