)]}'
{"quantum/db/l3_db.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b3d20d806094148e9d05d034f9ae8f8c350851ff","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from sqlalchemy import orm"},{"line_number":26,"context_line":"from sqlalchemy.orm import exc"},{"line_number":27,"context_line":"import webob.exc as w_exc"},{"line_number":28,"context_line":"import netaddr"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.api.v2 import attributes"},{"line_number":31,"context_line":"from quantum.common import exceptions as q_exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fe3A%3D","line":28,"updated":"2012-09-07 07:59:39.000000000","message":"imports should be alphabetical, so netaddr should be above sqlalchemy","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"},{"author":{"_account_id":553,"name":"Hisaharu Ishii","email":"ishii.hisaharu@lab.ntt.co.jp","username":"ishii-hisaharu"},"change_message_id":"482f2eac96eef32de5cfb5b8952a5c5fca10b767","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from sqlalchemy import orm"},{"line_number":26,"context_line":"from sqlalchemy.orm import exc"},{"line_number":27,"context_line":"import webob.exc as w_exc"},{"line_number":28,"context_line":"import netaddr"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.api.v2 import attributes"},{"line_number":31,"context_line":"from quantum.common import exceptions as q_exc"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fd%2B0%3D","line":28,"in_reply_to":"AAAALH%2F%2Fe3A%3D","updated":"2012-09-08 04:23:08.000000000","message":"Done","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b3d20d806094148e9d05d034f9ae8f8c350851ff","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                    match \u003d netaddr.all_matching_cidrs(new_ipnet, [cidr])"},{"line_number":232,"context_line":"                    if match:"},{"line_number":233,"context_line":"                        msg \u003d ((\"Subnet %s is overlapped with subnet %s \""},{"line_number":234,"context_line":"                               + \"on router\") % (new_cidr, cidr))"},{"line_number":235,"context_line":"                        raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":236,"context_line":"        except exc.NoResultFound:"},{"line_number":237,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fe24%3D","line":234,"updated":"2012-09-07 07:59:39.000000000","message":"(suggestion) would be nice if the error message actually provided the subnet-ids as well as just the overlapping cidrs.","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"},{"author":{"_account_id":553,"name":"Hisaharu Ishii","email":"ishii.hisaharu@lab.ntt.co.jp","username":"ishii-hisaharu"},"change_message_id":"482f2eac96eef32de5cfb5b8952a5c5fca10b767","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                    match \u003d netaddr.all_matching_cidrs(new_ipnet, [cidr])"},{"line_number":232,"context_line":"                    if match:"},{"line_number":233,"context_line":"                        msg \u003d ((\"Subnet %s is overlapped with subnet %s \""},{"line_number":234,"context_line":"                               + \"on router\") % (new_cidr, cidr))"},{"line_number":235,"context_line":"                        raise q_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":236,"context_line":"        except exc.NoResultFound:"},{"line_number":237,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fd%2Bw%3D","line":234,"in_reply_to":"AAAALH%2F%2Fe24%3D","updated":"2012-09-08 04:23:08.000000000","message":"Done","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"}],"quantum/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"b3d20d806094148e9d05d034f9ae8f8c350851ff","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    def test_router_add_interface_overlapped_cidr(self):"},{"line_number":433,"context_line":"        with self.router() as r:"},{"line_number":434,"context_line":"            with self.subnet(cidr\u003d\u002710.0.0.0/24\u0027) as s1:"},{"line_number":435,"context_line":"                with self.subnet(cidr\u003d\u002710.0.0.0/24\u0027) as s2:"},{"line_number":436,"context_line":"                    self._router_interface_action(\u0027add\u0027,"},{"line_number":437,"context_line":"                                                  r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":438,"context_line":"                                                  s1[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fe2s%3D","line":435,"updated":"2012-09-07 07:59:39.000000000","message":"(suggestion) since this test is meant to confirm that we detect any overlapping cidr, not just exactly duplicate cidr, it might be nice to have the two subnets not be exactly the same here.   That way the test more clearly documents expected behavior and would catch any changes the implementation that  might incorrectly only detect exact match.","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"},{"author":{"_account_id":553,"name":"Hisaharu Ishii","email":"ishii.hisaharu@lab.ntt.co.jp","username":"ishii-hisaharu"},"change_message_id":"482f2eac96eef32de5cfb5b8952a5c5fca10b767","unresolved":false,"context_lines":[{"line_number":432,"context_line":"    def test_router_add_interface_overlapped_cidr(self):"},{"line_number":433,"context_line":"        with self.router() as r:"},{"line_number":434,"context_line":"            with self.subnet(cidr\u003d\u002710.0.0.0/24\u0027) as s1:"},{"line_number":435,"context_line":"                with self.subnet(cidr\u003d\u002710.0.0.0/24\u0027) as s2:"},{"line_number":436,"context_line":"                    self._router_interface_action(\u0027add\u0027,"},{"line_number":437,"context_line":"                                                  r[\u0027router\u0027][\u0027id\u0027],"},{"line_number":438,"context_line":"                                                  s1[\u0027subnet\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fd%2Bs%3D","line":435,"in_reply_to":"AAAALH%2F%2Fe2s%3D","updated":"2012-09-08 04:23:08.000000000","message":"Done","commit_id":"9323fbb30cf3814b42f5ad5e72e46f2f6309d1ba"}]}