)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8282ddeb3baaa0ba91f68735275ce06c8cac8f9b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In unit tests for several ML2 mechanism drivers (listed below)"},{"line_number":10,"context_line":"the NeutronDbPluginV2TestCase class is used instead of Ml2PluginV2TestCase"},{"line_number":11,"context_line":"which is derived to be used."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Unit tests for ML2 mechanism drivers in neutron/tests/unit/ml2:"},{"line_number":14,"context_line":"   drivers/cisco/nexus/test_cisco_mech.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baa201ad_5db6958b","line":11,"updated":"2014-10-13 15:27:43.000000000","message":"derived -\u003e desired?","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"93165e8b064c1a8141363706956e8d474bde9c7e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   test_mechanism_odl.py"},{"line_number":19,"context_line":"   test_l2population.py"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-bug: #1373153"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9524cafb39975b1384954a2eefcbf754231d2198"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa7fdbe_912aef2a","line":21,"updated":"2014-10-29 09:56:48.000000000","message":"Closes?","commit_id":"11405dc96827b40e4f30a8bdbf33c8a752c0c274"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"9fa59fcd44bab92623f44485ec75e54028ed61c8","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   test_mechanism_odl.py"},{"line_number":19,"context_line":"   test_l2population.py"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-bug: #1373153"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9524cafb39975b1384954a2eefcbf754231d2198"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa7fdbe_d159d75c","line":21,"in_reply_to":"9aa7fdbe_512fa7f6","updated":"2014-10-29 10:18:49.000000000","message":"Partial-Bug then","commit_id":"11405dc96827b40e4f30a8bdbf33c8a752c0c274"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"f3e018cded762572370a7738e4cf6998705cc443","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   test_mechanism_odl.py"},{"line_number":19,"context_line":"   test_l2population.py"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-bug: #1373153"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9524cafb39975b1384954a2eefcbf754231d2198"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa7fdbe_512fa7f6","line":21,"in_reply_to":"9aa7fdbe_912aef2a","updated":"2014-10-29 10:04:24.000000000","message":"Not really closed, as in bug description mentioned some other refactor, so I mentioned it as related.","commit_id":"11405dc96827b40e4f30a8bdbf33c8a752c0c274"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"46375dd8ddddb623f70a20c28eb9767cff40070d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"   test_mechanism_odl.py"},{"line_number":19,"context_line":"   test_l2population.py"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Related-bug: #1373153"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Change-Id: I9524cafb39975b1384954a2eefcbf754231d2198"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9aa7fdbe_ec21a2fd","line":21,"in_reply_to":"9aa7fdbe_d159d75c","updated":"2014-10-29 10:49:52.000000000","message":"ok","commit_id":"11405dc96827b40e4f30a8bdbf33c8a752c0c274"}],"neutron/tests/unit/ml2/drivers/brocade/test_brocade_mechanism_driver.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8282ddeb3baaa0ba91f68735275ce06c8cac8f9b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def mocked_brocade_init(self):"},{"line_number":48,"context_line":"            self._driver \u003d mock.MagicMock()"},{"line_number":49,"context_line":"            self._physical_networks \u003d [\u0027physnet1\u0027, \u0027physnet2\u0027]"},{"line_number":50,"context_line":"            self._switch \u003d {"},{"line_number":51,"context_line":"                \u0027address\u0027: \u002710.24.84.38\u0027,"},{"line_number":52,"context_line":"                \u0027username\u0027: \u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_c00d3c37","line":49,"updated":"2014-10-13 15:27:43.000000000","message":"Is this part of the change?","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"97bd0b64fc8894cc3f55b1360d55e54ee9505ac4","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def mocked_brocade_init(self):"},{"line_number":48,"context_line":"            self._driver \u003d mock.MagicMock()"},{"line_number":49,"context_line":"            self._physical_networks \u003d [\u0027physnet1\u0027, \u0027physnet2\u0027]"},{"line_number":50,"context_line":"            self._switch \u003d {"},{"line_number":51,"context_line":"                \u0027address\u0027: \u002710.24.84.38\u0027,"},{"line_number":52,"context_line":"                \u0027username\u0027: \u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_5e803946","line":49,"in_reply_to":"baa201ad_c00d3c37","updated":"2014-10-14 06:08:43.000000000","message":"Yes, this changes are needed. In fact in the way it was before actual brocade driver was not running at all, so now when it is used it is needed to set this.","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"43047bda8fb3793c2cfe5189f6939d49d72a9438","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def mocked_brocade_init(self):"},{"line_number":48,"context_line":"            self._driver \u003d mock.MagicMock()"},{"line_number":49,"context_line":"            self._physical_networks \u003d [\u0027physnet1\u0027, \u0027physnet2\u0027]"},{"line_number":50,"context_line":"            self._switch \u003d {"},{"line_number":51,"context_line":"                \u0027address\u0027: \u002710.24.84.38\u0027,"},{"line_number":52,"context_line":"                \u0027username\u0027: \u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_3640f155","line":49,"updated":"2014-11-06 15:50:49.000000000","message":"This code is not related to the bug fix. I don\u0027t even know why this is needed. if the switch calls are mocked.\nI tested brocade unit test without this code and they pass.","commit_id":"b40e0afb5c3327fe08fc0b394b26ad99806ff21e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"230f0cf949440ccf48a467ac3a4b27947d580a18","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        def mocked_brocade_init(self):"},{"line_number":48,"context_line":"            self._driver \u003d mock.MagicMock()"},{"line_number":49,"context_line":"            self._physical_networks \u003d [\u0027physnet1\u0027, \u0027physnet2\u0027]"},{"line_number":50,"context_line":"            self._switch \u003d {"},{"line_number":51,"context_line":"                \u0027address\u0027: \u002710.24.84.38\u0027,"},{"line_number":52,"context_line":"                \u0027username\u0027: \u0027admin\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8c0949_f8b1f7e1","line":49,"in_reply_to":"7a8c0949_3640f155","updated":"2014-11-06 16:01:06.000000000","message":"Strange, it fails before without it. Will remove this in next patch set, thanks.","commit_id":"b40e0afb5c3327fe08fc0b394b26ad99806ff21e"}],"neutron/tests/unit/ml2/drivers/freescale/test_mechanism_fslsdn.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8282ddeb3baaa0ba91f68735275ce06c8cac8f9b","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TestFslSdnMechanismDriver(base.BaseTestCase):"},{"line_number":61,"context_line":"    \"\"\"Testing FSL SDN Mechanism driver.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(TestFslSdnMechanismDriver, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_fd7bc9bb","line":61,"updated":"2014-10-13 15:27:43.000000000","message":"Nit: The blank line is correct for PEP8/PEP257 docstring for a class.","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"97bd0b64fc8894cc3f55b1360d55e54ee9505ac4","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"class TestFslSdnMechanismDriver(base.BaseTestCase):"},{"line_number":61,"context_line":"    \"\"\"Testing FSL SDN Mechanism driver.\"\"\""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def setUp(self):"},{"line_number":64,"context_line":"        super(TestFslSdnMechanismDriver, self).setUp()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_7eddfd6f","line":61,"in_reply_to":"baa201ad_fd7bc9bb","updated":"2014-10-14 06:08:43.000000000","message":"done","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"}],"neutron/tests/unit/ml2/test_mechanism_odl.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8282ddeb3baaa0ba91f68735275ce06c8cac8f9b","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    _mechanism_drivers \u003d [\u0027logger\u0027, \u0027opendaylight\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        # Set URL/user/pass so init doesn\u0027t throw a cfg required error."},{"line_number":37,"context_line":"        # They are not used in these tests since sendjson is overwritten."},{"line_number":38,"context_line":"        config.cfg.CONF.set_override(\u0027url\u0027, \u0027http://127.0.0.1:9999\u0027, \u0027ml2_odl\u0027)"},{"line_number":39,"context_line":"        config.cfg.CONF.set_override(\u0027username\u0027, \u0027someuser\u0027, \u0027ml2_odl\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_fd29099c","line":36,"updated":"2014-10-13 15:27:43.000000000","message":"Is the removal of the config override part of this change?","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"97bd0b64fc8894cc3f55b1360d55e54ee9505ac4","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    _mechanism_drivers \u003d [\u0027logger\u0027, \u0027opendaylight\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"},{"line_number":36,"context_line":"        # Set URL/user/pass so init doesn\u0027t throw a cfg required error."},{"line_number":37,"context_line":"        # They are not used in these tests since sendjson is overwritten."},{"line_number":38,"context_line":"        config.cfg.CONF.set_override(\u0027url\u0027, \u0027http://127.0.0.1:9999\u0027, \u0027ml2_odl\u0027)"},{"line_number":39,"context_line":"        config.cfg.CONF.set_override(\u0027username\u0027, \u0027someuser\u0027, \u0027ml2_odl\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa201ad_5ef759f5","line":36,"in_reply_to":"baa201ad_fd29099c","updated":"2014-10-14 06:08:43.000000000","message":"This is just set in another way in _mechanism_drivers variable as now it should use  Ml2PluginV2TestCase, but it seems that I accidentally do not change this. Will correct in nexr patch set.","commit_id":"a385a7a0d8a1436318afd76d15e244f59d4b4966"}]}