)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ab3f37f89d4240b83ad2c5e2a4bc3adc9f0a0ab5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Keepalived python script now notifies agent via domain socket"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To-Do:"},{"line_number":10,"context_line":"* Figure out why workers \u003e 0 fails the functional test but works"},{"line_number":11,"context_line":"  outside of testing."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"baa201ad_0b34d9dc","line":9,"updated":"2014-10-12 17:05:41.000000000","message":"We actually don\u0027t want to use workers... It forks the l3-agent itself and that\u0027s definitely something we don\u0027t want.","commit_id":"b09420860b267ea7c2afc95756c24bab2de29e7e"}],"neutron/agent/l3_ha_agent.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"278006c88c3eaa46d587390892d00d7feed54470","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        eventlet.spawn(self._start_keepalived_notifications_server)"},{"line_number":156,"context_line":"        super(AgentMixin, self).__init__(host)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":159,"context_line":"        msg \u003d \u0027Router %(router_id)s transitioned to %(state)s\u0027"},{"line_number":160,"context_line":"        placeholders \u003d {\u0027router_id\u0027: router_id,"},{"line_number":161,"context_line":"                        \u0027state\u0027: state}"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_07c2b658","line":158,"updated":"2014-10-05 14:42:11.000000000","message":"This doesn\u0027t seem to do anything except print something to the log. Either there is something missing or this doesn\u0027t enqueue anything and the name should change.","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"930bb3a4c08d4c71be4922e18eeac08bc552971c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        eventlet.spawn(self._start_keepalived_notifications_server)"},{"line_number":156,"context_line":"        super(AgentMixin, self).__init__(host)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    def enqueue_state_change(self, router_id, state):"},{"line_number":159,"context_line":"        msg \u003d \u0027Router %(router_id)s transitioned to %(state)s\u0027"},{"line_number":160,"context_line":"        placeholders \u003d {\u0027router_id\u0027: router_id,"},{"line_number":161,"context_line":"                        \u0027state\u0027: state}"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_6704624a","line":158,"in_reply_to":"baa201ad_07c2b658","updated":"2014-10-05 16:08:16.000000000","message":"It will in the next patches. I don\u0027t see a reason to rename this now, and then again in the next patch.","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"57acfdf1f8ecface1242778a1cabaf63f8bb4f50","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                          \u0027UNIX domain socket\u0027)),"},{"line_number":121,"context_line":"        cfg.IntOpt(\u0027backlog\u0027,"},{"line_number":122,"context_line":"                   default\u003d4096,"},{"line_number":123,"context_line":"                   help\u003d_(\u0027Number of backlog requests to configure the \u0027"},{"line_number":124,"context_line":"                          \u0027keepalived state change server socket with\u0027))"},{"line_number":125,"context_line":"    ]"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9aa7fdbe_84bb4fe4","line":123,"updated":"2014-10-21 20:19:54.000000000","message":"I imagine this was taken from the metadata object cfg definition, but would it be more readable to say \"Maximum number of queued requests for keepalived state change server\"?\n\nSame in the l3_agent.ini file.","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e3513334264e70d1db7519612884dc82ebda33b9","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                          \u0027UNIX domain socket\u0027)),"},{"line_number":121,"context_line":"        cfg.IntOpt(\u0027backlog\u0027,"},{"line_number":122,"context_line":"                   default\u003d4096,"},{"line_number":123,"context_line":"                   help\u003d_(\u0027Number of backlog requests to configure the \u0027"},{"line_number":124,"context_line":"                          \u0027keepalived state change server socket with\u0027))"},{"line_number":125,"context_line":"    ]"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_8914c3e9","line":123,"in_reply_to":"9aa7fdbe_84bb4fe4","updated":"2014-11-17 15:42:01.000000000","message":"Sounds good.","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"930a1e54390b0ba23e5991f642590340506009c1","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        cfg.StrOpt(\u0027socket\u0027,"},{"line_number":118,"context_line":"                   default\u003d\u0027$state_path/keepalived_state_change\u0027,"},{"line_number":119,"context_line":"                   help\u003d_(\u0027Location for keepalived state change \u0027"},{"line_number":120,"context_line":"                          \u0027UNIX domain socket\u0027)),"},{"line_number":121,"context_line":"        cfg.IntOpt(\u0027backlog\u0027,"},{"line_number":122,"context_line":"                   default\u003d4096,"},{"line_number":123,"context_line":"                   help\u003d_(\u0027Maximum number of queued requests for keepalived \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a890539_b8579001","line":120,"updated":"2014-11-20 13:54:14.000000000","message":"Nit: missing period here and L124 for help messages.","commit_id":"e9096955477d54bf11085a124cf1281bef4e9807"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"99014bae2b7cc8f9b94a1c4fe214c66d37c413dc","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        cfg.StrOpt(\u0027socket\u0027,"},{"line_number":118,"context_line":"                   default\u003d\u0027$state_path/keepalived_state_change\u0027,"},{"line_number":119,"context_line":"                   help\u003d_(\u0027Location for keepalived state change \u0027"},{"line_number":120,"context_line":"                          \u0027UNIX domain socket\u0027)),"},{"line_number":121,"context_line":"        cfg.IntOpt(\u0027backlog\u0027,"},{"line_number":122,"context_line":"                   default\u003d4096,"},{"line_number":123,"context_line":"                   help\u003d_(\u0027Maximum number of queued requests for keepalived \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a961159_666dd204","line":120,"in_reply_to":"5a890539_b8579001","updated":"2014-12-07 14:27:09.000000000","message":"Done","commit_id":"e9096955477d54bf11085a124cf1281bef4e9807"}],"neutron/cmd/keepalived_state_change.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"278006c88c3eaa46d587390892d00d7feed54470","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.agent.common import config as agent_config"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_47e11efd","line":20,"updated":"2014-10-05 14:42:11.000000000","message":"There is a code someplace which runs \u0027httplib2.RETIRES \u003d 1\u0027. How does that affect this code?","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"930bb3a4c08d4c71be4922e18eeac08bc552971c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import eventlet"},{"line_number":20,"context_line":"import httplib2"},{"line_number":21,"context_line":"from oslo.config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.agent.common import config as agent_config"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_a7faca40","line":20,"in_reply_to":"baa201ad_47e11efd","updated":"2014-10-05 16:08:16.000000000","message":"It doesn\u0027t as far as I can tell.","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"278006c88c3eaa46d587390892d00d7feed54470","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.agent.common import config as agent_config"},{"line_number":24,"context_line":"from neutron.agent import l3_agent"},{"line_number":25,"context_line":"from neutron.agent.metadata import namespace_proxy"},{"line_number":26,"context_line":"from neutron.common import config"},{"line_number":27,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_472afe2c","line":25,"updated":"2014-10-05 14:42:11.000000000","message":"Since UnixDomainHTTPConnection is a generic class and now shared to both metadata and keepalived, I suggest moving it outside to a more common path (neutron/agent/linux/?)\n\nAlso refactoring it a bit might be a good idea: UnixDomainHTTPConnection should receive self.socket_path as a parameter to __init__. If it makes problems in L65, then use partial to not break API with httplib2:\n\n functools.partial(KeepalivedUnixDomainConnection, \"my_socket_path\")","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"930bb3a4c08d4c71be4922e18eeac08bc552971c","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.agent.common import config as agent_config"},{"line_number":24,"context_line":"from neutron.agent import l3_agent"},{"line_number":25,"context_line":"from neutron.agent.metadata import namespace_proxy"},{"line_number":26,"context_line":"from neutron.common import config"},{"line_number":27,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c7f7ce57","line":25,"in_reply_to":"baa201ad_472afe2c","updated":"2014-10-05 16:08:16.000000000","message":"I\u0027ll have to think about this.","commit_id":"d7fa7b3f465c6fb787b7177dd85830e23b2c8487"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"57acfdf1f8ecface1242778a1cabaf63f8bb4f50","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _notify(self):"},{"line_number":63,"context_line":"        resp, content \u003d httplib2.Http().request("},{"line_number":64,"context_line":"            \u0027http://127.0.0.0.1/\u0027,"},{"line_number":65,"context_line":"            headers\u003d{\u0027X-Neutron-Router-Id\u0027: self.router_id,"},{"line_number":66,"context_line":"                     \u0027X-Neutron-State\u0027: self.state},"},{"line_number":67,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9aa7fdbe_e486db12","line":64,"updated":"2014-10-21 20:19:54.000000000","message":"127.0.0.1?","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e3513334264e70d1db7519612884dc82ebda33b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _notify(self):"},{"line_number":63,"context_line":"        resp, content \u003d httplib2.Http().request("},{"line_number":64,"context_line":"            \u0027http://127.0.0.0.1/\u0027,"},{"line_number":65,"context_line":"            headers\u003d{\u0027X-Neutron-Router-Id\u0027: self.router_id,"},{"line_number":66,"context_line":"                     \u0027X-Neutron-State\u0027: self.state},"},{"line_number":67,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_6c6165d2","line":64,"in_reply_to":"9aa7fdbe_e486db12","updated":"2014-11-17 15:42:01.000000000","message":"You caught me :)\nBecause we\u0027re using a Unix domain socket here and not TCP or UDP, the URL doesn\u0027t actually matter. IIRC there\u0027s a comment about this in the metadata proxy. That being said, 127.0.0.0.1 is just weird :)","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"57acfdf1f8ecface1242778a1cabaf63f8bb4f50","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                     \u0027X-Neutron-State\u0027: self.state},"},{"line_number":67,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if resp.status !\u003d 200:"},{"line_number":70,"context_line":"            raise Exception(_(\u0027Unexpected response code: %s\u0027) % resp.status)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9aa7fdbe_c4b1d7e2","line":69,"updated":"2014-10-21 20:19:54.000000000","message":"Use requests.codes.ok vs magic #","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e3513334264e70d1db7519612884dc82ebda33b9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                     \u0027X-Neutron-State\u0027: self.state},"},{"line_number":67,"context_line":"            connection_type\u003dKeepalivedUnixDomainConnection)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        if resp.status !\u003d 200:"},{"line_number":70,"context_line":"            raise Exception(_(\u0027Unexpected response code: %s\u0027) % resp.status)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a890539_2ceafdda","line":69,"in_reply_to":"9aa7fdbe_c4b1d7e2","updated":"2014-11-17 15:42:01.000000000","message":"I couldn\u0027t find something in httplib2 that represents error codes so I used requests.","commit_id":"e424781140735b1c6a6c925f70f485ac44e3cbf0"}]}
