)]}'
{"quantum/plugins/openvswitch/agent/ovs_quantum_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":214,"context_line":"        LOG.debug(\"tunnel_update received\")"},{"line_number":215,"context_line":"        if not self.enable_tunneling:"},{"line_number":216,"context_line":"            return"},{"line_number":217,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":218,"context_line":"        tunnel_id \u003d kwargs.get(\u0027tunnel_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNo%3D","line":215,"updated":"2012-09-10 05:35:44.000000000","message":"I think that you should do a log here. It may help identify problems.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"daf6356bd5227efd5fd25f022828763f3ed27461","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":214,"context_line":"        LOG.debug(\"tunnel_update received\")"},{"line_number":215,"context_line":"        if not self.enable_tunneling:"},{"line_number":216,"context_line":"            return"},{"line_number":217,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":218,"context_line":"        tunnel_id \u003d kwargs.get(\u0027tunnel_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdEw%3D","line":215,"in_reply_to":"AAAALH%2F%2FdIg%3D","updated":"2012-09-10 14:13:23.000000000","message":"I think the above is sufficient. Receiving tunnel_update broadcasts does not indicate any problem if there are other nodes that do support tunneling. Attempts to bring up GRE networks when tunneling is disabled are logged as errors elsewhere.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":214,"context_line":"        LOG.debug(\"tunnel_update received\")"},{"line_number":215,"context_line":"        if not self.enable_tunneling:"},{"line_number":216,"context_line":"            return"},{"line_number":217,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":218,"context_line":"        tunnel_id \u003d kwargs.get(\u0027tunnel_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdIg%3D","line":215,"in_reply_to":"AAAALH%2F%2FdJA%3D","updated":"2012-09-10 10:45:25.000000000","message":"ok, it may be useful to know that the service has tunnelling enabled and the agent does not. Yes again this may be an overkill.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"daf6356bd5227efd5fd25f022828763f3ed27461","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def tunnel_update(self, context, **kwargs):"},{"line_number":214,"context_line":"        LOG.debug(\"tunnel_update received\")"},{"line_number":215,"context_line":"        if not self.enable_tunneling:"},{"line_number":216,"context_line":"            return"},{"line_number":217,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":218,"context_line":"        tunnel_id \u003d kwargs.get(\u0027tunnel_id\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdJA%3D","line":215,"in_reply_to":"AAAALH%2F%2FdNo%3D","updated":"2012-09-10 10:29:12.000000000","message":"There is a log statement on line 214.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            else:"},{"line_number":282,"context_line":"                LOG.error(\"Cannot provision flat network for net-id\u003d%s \""},{"line_number":283,"context_line":"                          \"- no bridge for physical_network %s\" %"},{"line_number":284,"context_line":"                          (net_uuid, physical_network))"},{"line_number":285,"context_line":"        elif network_type \u003d\u003d constants.TYPE_VLAN:"},{"line_number":286,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":287,"context_line":"                # outbound"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNk%3D","line":284,"updated":"2012-09-10 05:35:44.000000000","message":"why not use locals? or for a log message you can use , between parameters","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":281,"context_line":"            else:"},{"line_number":282,"context_line":"                LOG.error(\"Cannot provision flat network for net-id\u003d%s \""},{"line_number":283,"context_line":"                          \"- no bridge for physical_network %s\" %"},{"line_number":284,"context_line":"                          (net_uuid, physical_network))"},{"line_number":285,"context_line":"        elif network_type \u003d\u003d constants.TYPE_VLAN:"},{"line_number":286,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":287,"context_line":"                # outbound"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdIc%3D","line":284,"in_reply_to":"AAAALH%2F%2FdI8%3D","updated":"2012-09-10 10:45:25.000000000","message":"For example:\nLOG.error(\"Cannot provision flat network for net-id\u003d%s \"\n                  \"- no bridge for physical_network %s\",\n                  net_uuid, physical_network)","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"daf6356bd5227efd5fd25f022828763f3ed27461","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            else:"},{"line_number":282,"context_line":"                LOG.error(\"Cannot provision flat network for net-id\u003d%s \""},{"line_number":283,"context_line":"                          \"- no bridge for physical_network %s\" %"},{"line_number":284,"context_line":"                          (net_uuid, physical_network))"},{"line_number":285,"context_line":"        elif network_type \u003d\u003d constants.TYPE_VLAN:"},{"line_number":286,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":287,"context_line":"                # outbound"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdFI%3D","line":284,"in_reply_to":"AAAALH%2F%2FdIc%3D","updated":"2012-09-10 14:13:23.000000000","message":"I agree LOG.debug() should use the style you recommend so that the string substitution is skipped when the level is disabled. But these are LOG.error() statements, which should never be disabled. \n\nIt probably makes sense to use the style you recommend consistently. Maybe another patch should clean this up as part of fixing https://bugs.launchpad.net/quantum/+bug/1045592.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"daf6356bd5227efd5fd25f022828763f3ed27461","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            else:"},{"line_number":282,"context_line":"                LOG.error(\"Cannot provision flat network for net-id\u003d%s \""},{"line_number":283,"context_line":"                          \"- no bridge for physical_network %s\" %"},{"line_number":284,"context_line":"                          (net_uuid, physical_network))"},{"line_number":285,"context_line":"        elif network_type \u003d\u003d constants.TYPE_VLAN:"},{"line_number":286,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":287,"context_line":"                # outbound"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdI8%3D","line":284,"in_reply_to":"AAAALH%2F%2FdNk%3D","updated":"2012-09-10 10:29:12.000000000","message":"I\u0027m not sure what you mean?","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            else:"},{"line_number":300,"context_line":"                LOG.error(\"Cannot provision VLAN network for net-id\u003d%s \""},{"line_number":301,"context_line":"                          \"- no bridge for physical_network %s\" %"},{"line_number":302,"context_line":"                          (net_uuid, physical_network))"},{"line_number":303,"context_line":"        elif network_type \u003d\u003d constants.TYPE_LOCAL:"},{"line_number":304,"context_line":"            # no flows needed for local networks"},{"line_number":305,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNg%3D","line":302,"updated":"2012-09-10 05:35:44.000000000","message":"ditto","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":305,"context_line":"            pass"},{"line_number":306,"context_line":"        else:"},{"line_number":307,"context_line":"            LOG.error(\"Cannot provision unknown network type %s for \""},{"line_number":308,"context_line":"                      \"net-id\u003d%s\" % (network_type, net_uuid))"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def reclaim_local_vlan(self, net_uuid, lvm):"},{"line_number":311,"context_line":"        \u0027\u0027\u0027Reclaim a local VLAN."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNc%3D","line":308,"updated":"2012-09-10 05:35:44.000000000","message":"ditto","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            # no flows needed for local networks"},{"line_number":347,"context_line":"            pass"},{"line_number":348,"context_line":"        else:"},{"line_number":349,"context_line":"            LOG.error(\"Reclaiming unknown network type %s for net-id\u003d%s\" %"},{"line_number":350,"context_line":"                      (lvm.network_type, net_uuid))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        del self.local_vlan_map[net_uuid]"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNY%3D","line":349,"updated":"2012-09-10 05:35:44.000000000","message":"Ditto","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"70615e472f2cdaa6ce471894153724c9d250d02b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.enable_tunneling \u003d enable_tunneling"},{"line_number":163,"context_line":"        self.local_ip \u003d local_ip"},{"line_number":164,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":165,"context_line":"        if self.enable_tunneling:"},{"line_number":166,"context_line":"            self.setup_tunnel_br(tun_br)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.rpc \u003d rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FceU%3D","line":165,"updated":"2012-09-11 01:27:48.000000000","message":"by now, it seems the self.tunnel_count is not used at all, can we use tunnel range defined to decide if we enabled the GRE?","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":162,"context_line":"        self.enable_tunneling \u003d enable_tunneling"},{"line_number":163,"context_line":"        self.local_ip \u003d local_ip"},{"line_number":164,"context_line":"        self.tunnel_count \u003d 0"},{"line_number":165,"context_line":"        if self.enable_tunneling:"},{"line_number":166,"context_line":"            self.setup_tunnel_br(tun_br)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        self.rpc \u003d rpc"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fcbk%3D","line":165,"in_reply_to":"AAAALH%2F%2FceU%3D","updated":"2012-09-11 02:35:02.000000000","message":"The tunnel_count is still used in in DB mode by manage_tunnels() to build the tunnel port\u0027s name.\n\nThe use of tenant_network_type seems to do the job, and allows values such as \"local\" and \"none\" that could not be inferred from other existing configuration variables. We could consider changing tenant_network_type to an ordered list for Grizzly.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":374,"context_line":"        lvm.vif_ports[port.vif_id] \u003d port"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        if network_type \u003d\u003d constants.TYPE_GRE:"},{"line_number":377,"context_line":"            if self.enable_tunneling:"},{"line_number":378,"context_line":"                # inbound unicast"},{"line_number":379,"context_line":"                self.tun_br.add_flow(priority\u003d3, tun_id\u003dsegmentation_id,"},{"line_number":380,"context_line":"                                     dl_dst\u003dport.vif_mac,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FcfA%3D","line":377,"updated":"2012-09-11 01:27:31.000000000","message":"(minor) is it possible to reach this point in the code with network_type \u003d\u003d GRE and enable_tunneling \u003d False given the above check in provision_local_vlan?   If so, we should probably log an error if tunneling isn\u0027t enabled.  If not, this check is probably not needed.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":374,"context_line":"        lvm.vif_ports[port.vif_id] \u003d port"},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"        if network_type \u003d\u003d constants.TYPE_GRE:"},{"line_number":377,"context_line":"            if self.enable_tunneling:"},{"line_number":378,"context_line":"                # inbound unicast"},{"line_number":379,"context_line":"                self.tun_br.add_flow(priority\u003d3, tun_id\u003dsegmentation_id,"},{"line_number":380,"context_line":"                                     dl_dst\u003dport.vif_mac,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fcc4%3D","line":377,"in_reply_to":"AAAALH%2F%2FcfA%3D","updated":"2012-09-11 02:09:53.000000000","message":"It is possible to reach this code. The test in provision_local_vlan() will take care of logging an error when the network is first created. But it doesn\u0027t change the flow of control after provision_local_vlan() returns. When the error occurs, the network basically operates like a local network, so it has an entryin loval_vlan_map. \n\nThis code in port_bound will be reached for every port associated with the network, and needs the check to prevent it from trying to set flows. I thought about logging an error here, but figured logging the error when the network was first created was sufficient. Let me know if you really think an error should be logged here as well for each port.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":403,"context_line":"            return"},{"line_number":404,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":405,"context_line":"        if lvm.network_type \u003d\u003d \u0027gre\u0027:"},{"line_number":406,"context_line":"            # remove inbound unicast flow"},{"line_number":407,"context_line":"            self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":408,"context_line":"                                     dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fce0%3D","line":406,"updated":"2012-09-11 01:27:31.000000000","message":"Does this need a similar update?  Seems tunnel related and seems to be the inverse of the above add_flow.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":403,"context_line":"            return"},{"line_number":404,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":405,"context_line":"        if lvm.network_type \u003d\u003d \u0027gre\u0027:"},{"line_number":406,"context_line":"            # remove inbound unicast flow"},{"line_number":407,"context_line":"            self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":408,"context_line":"                                     dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FcbY%3D","line":406,"in_reply_to":"AAAALH%2F%2Fcc0%3D","updated":"2012-09-11 02:35:02.000000000","message":"Done","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":403,"context_line":"            return"},{"line_number":404,"context_line":"        lvm \u003d self.local_vlan_map[net_uuid]"},{"line_number":405,"context_line":"        if lvm.network_type \u003d\u003d \u0027gre\u0027:"},{"line_number":406,"context_line":"            # remove inbound unicast flow"},{"line_number":407,"context_line":"            self.tun_br.delete_flows(tun_id\u003dlvm.segmentation_id,"},{"line_number":408,"context_line":"                                     dl_dst\u003dlvm.vif_ports[vif_id].vif_mac)"},{"line_number":409,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fcc0%3D","line":406,"in_reply_to":"AAAALH%2F%2Fce0%3D","updated":"2012-09-11 02:09:53.000000000","message":"Looks like I missed this one. I\u0027ll add the condition. Good catch!","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"70615e472f2cdaa6ce471894153724c9d250d02b","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            del lvm.vif_ports[vif_id]"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            LOG.info(\u0027port_unbound: vid_id %s not in local_vlan_map\u0027,"},{"line_number":414,"context_line":"                     port.vif_id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        if not lvm.vif_ports:"},{"line_number":417,"context_line":"            self.reclaim_local_vlan(net_uuid, lvm)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fces%3D","line":414,"updated":"2012-09-11 01:27:48.000000000","message":"can u help to fix the \u0027port.\u0027 problem since it is not available too?","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":411,"context_line":"            del lvm.vif_ports[vif_id]"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            LOG.info(\u0027port_unbound: vid_id %s not in local_vlan_map\u0027,"},{"line_number":414,"context_line":"                     port.vif_id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        if not lvm.vif_ports:"},{"line_number":417,"context_line":"            self.reclaim_local_vlan(net_uuid, lvm)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FcbQ%3D","line":414,"in_reply_to":"AAAALH%2F%2Fcco%3D","updated":"2012-09-11 02:35:02.000000000","message":"Done","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":411,"context_line":"            del lvm.vif_ports[vif_id]"},{"line_number":412,"context_line":"        else:"},{"line_number":413,"context_line":"            LOG.info(\u0027port_unbound: vid_id %s not in local_vlan_map\u0027,"},{"line_number":414,"context_line":"                     port.vif_id)"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"        if not lvm.vif_ports:"},{"line_number":417,"context_line":"            self.reclaim_local_vlan(net_uuid, lvm)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fcco%3D","line":414,"in_reply_to":"AAAALH%2F%2Fces%3D","updated":"2012-09-11 02:09:53.000000000","message":"I had not noticed that the port variable is not defined. Looks like I should just change port.vif_id to vif_id.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                           \"patch-tun\")"},{"line_number":452,"context_line":"        if int(self.patch_tun_ofport) \u003c 0 or int(self.patch_int_ofport) \u003c 0:"},{"line_number":453,"context_line":"            LOG.error(\"Failed to create OVS patch port\")"},{"line_number":454,"context_line":"            exit(1)"},{"line_number":455,"context_line":"        self.tun_br.remove_all_flows()"},{"line_number":456,"context_line":"        self.tun_br.add_flow(priority\u003d1, actions\u003d\"drop\")"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FceM%3D","line":454,"updated":"2012-09-11 01:27:31.000000000","message":"Is this the error that the user would see if they run OVS on a version that does not support tunnels?  If so, could we add something that points more to the actual cause of the problem, given that the user is unlikely to know what a patch port is?  Perhaps \"Cannot have tunneling enabled on this agent, since this version of OVS does not support tunnels or patch ports\".","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                           \"patch-tun\")"},{"line_number":452,"context_line":"        if int(self.patch_tun_ofport) \u003c 0 or int(self.patch_int_ofport) \u003c 0:"},{"line_number":453,"context_line":"            LOG.error(\"Failed to create OVS patch port\")"},{"line_number":454,"context_line":"            exit(1)"},{"line_number":455,"context_line":"        self.tun_br.remove_all_flows()"},{"line_number":456,"context_line":"        self.tun_br.add_flow(priority\u003d1, actions\u003d\"drop\")"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2FcbM%3D","line":454,"in_reply_to":"AAAALH%2F%2Fcck%3D","updated":"2012-09-11 02:35:02.000000000","message":"Done","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                                           \"patch-tun\")"},{"line_number":452,"context_line":"        if int(self.patch_tun_ofport) \u003c 0 or int(self.patch_int_ofport) \u003c 0:"},{"line_number":453,"context_line":"            LOG.error(\"Failed to create OVS patch port\")"},{"line_number":454,"context_line":"            exit(1)"},{"line_number":455,"context_line":"        self.tun_br.remove_all_flows()"},{"line_number":456,"context_line":"        self.tun_br.add_flow(priority\u003d1, actions\u003d\"drop\")"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAALH%2F%2Fcck%3D","line":454,"in_reply_to":"AAAALH%2F%2FceM%3D","updated":"2012-09-11 02:09:53.000000000","message":"Sounds reasonable.","commit_id":"39ec5c220a70bd803db4122d90dd6c5af8703cf1"}],"quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9733233e2ce9ef644497bb1745c6a343a9f136dc","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s\" %"},{"line_number":204,"context_line":"                      self.tenant_network_type)"},{"line_number":205,"context_line":"            sys.exit(1)"},{"line_number":206,"context_line":"        self.enable_tunneling \u003d cfg.CONF.OVS.enable_tunneling"},{"line_number":207,"context_line":"        self.tunnel_id_ranges \u003d []"},{"line_number":208,"context_line":"        if self.enable_tunneling:"},{"line_number":209,"context_line":"            self._parse_tunnel_id_ranges()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdNM%3D","line":206,"updated":"2012-09-10 05:35:44.000000000","message":"Does this means that all nodes have to work with non tunnelling mode? Is there no way of running combinations? This may be a hard limitation.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"daf6356bd5227efd5fd25f022828763f3ed27461","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            LOG.error(\"Invalid tenant_network_type: %s\" %"},{"line_number":204,"context_line":"                      self.tenant_network_type)"},{"line_number":205,"context_line":"            sys.exit(1)"},{"line_number":206,"context_line":"        self.enable_tunneling \u003d cfg.CONF.OVS.enable_tunneling"},{"line_number":207,"context_line":"        self.tunnel_id_ranges \u003d []"},{"line_number":208,"context_line":"        if self.enable_tunneling:"},{"line_number":209,"context_line":"            self._parse_tunnel_id_ranges()"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FdI4%3D","line":206,"in_reply_to":"AAAALH%2F%2FdNM%3D","updated":"2012-09-10 10:29:12.000000000","message":"It would be possible to have tunneling enabled in the server, but disabled in some but not all nodes. The nodes with tunneling disabled would log errors if they tried to bring up a GRE network. This might be useful in non-OpenStack Quantum deployments, or with an eventual connectivity-aware Nova scheduler plugin.","commit_id":"627524624767d95a89c1c0c152795e61d8344e98"}]}