)]}'
{"quantum/agent/l3_agent.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"5904f4f046d93009e278bd2d137444b0db3882b9","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                continue"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"            ex_net_id \u003d (r[\u0027external_gateway_info\u0027] and"},{"line_number":206,"context_line":"                         r[\u0027external_gateway_info\u0027].get(\u0027network_id\u0027))"},{"line_number":207,"context_line":"            if not ex_net_id and not self.conf.handle_internal_only_routers:"},{"line_number":208,"context_line":"                continue"},{"line_number":209,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fczw%3D","line":206,"updated":"2012-09-10 18:13:47.000000000","message":"Good catch.  The original intention was that external_gateway_info would be {} if it was not set, but latest code sets it to None, so this is definitely needed.","commit_id":"cb38773cc70e7977be7dd9fc44815f2c13defa9d"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"change_message_id":"5904f4f046d93009e278bd2d137444b0db3882b9","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                                root_helper\u003dself.conf.root_helper,"},{"line_number":384,"context_line":"                                namespace\u003dri.ns_name()):"},{"line_number":385,"context_line":"            self.driver.unplug(interface_name,"},{"line_number":386,"context_line":"                               bridge\u003dself.conf.external_network_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        ex_gw_ip \u003d ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":389,"context_line":"        for c, r in self.external_gateway_filter_rules():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fczc%3D","line":386,"updated":"2012-09-10 18:13:47.000000000","message":"don\u0027t we need to pass in the namespace here as well?","commit_id":"cb38773cc70e7977be7dd9fc44815f2c13defa9d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":383,"context_line":"                                root_helper\u003dself.conf.root_helper,"},{"line_number":384,"context_line":"                                namespace\u003dri.ns_name()):"},{"line_number":385,"context_line":"            self.driver.unplug(interface_name,"},{"line_number":386,"context_line":"                               bridge\u003dself.conf.external_network_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        ex_gw_ip \u003d ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":389,"context_line":"        for c, r in self.external_gateway_filter_rules():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2Fcew%3D","line":386,"in_reply_to":"AAAALH%2F%2FcgM%3D","updated":"2012-09-11 01:24:23.000000000","message":"In case of OVS interface driver, a port can be removed. But I am afraid it is required for LB interface driver, where a network interface named with \u0027device_name\u0027 exists in the namespace. Can\u0027t we find the network interface to be removed without namespace?\n\ndhcp-agent calls unplug() with namespace.  \n\nAnyway, it needs to be tested. If it does not work without namespace parameter, let\u0027s fix in another patch.","commit_id":"cb38773cc70e7977be7dd9fc44815f2c13defa9d"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":383,"context_line":"                                root_helper\u003dself.conf.root_helper,"},{"line_number":384,"context_line":"                                namespace\u003dri.ns_name()):"},{"line_number":385,"context_line":"            self.driver.unplug(interface_name,"},{"line_number":386,"context_line":"                               bridge\u003dself.conf.external_network_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        ex_gw_ip \u003d ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":389,"context_line":"        for c, r in self.external_gateway_filter_rules():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FcgM%3D","line":386,"in_reply_to":"AAAALH%2F%2FclI%3D","updated":"2012-09-11 01:02:52.000000000","message":"I don\u0027t think it is strictly required, but it may leave a stale device in the namespace, I\u0027m not sure.  Eitherway, gary\u0027s patch adds: https://review.openstack.org/#/c/12691/, so I think we can approve this patch.","commit_id":"cb38773cc70e7977be7dd9fc44815f2c13defa9d"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"74c8f9020861f65706f6fb695f875af6a35561e2","unresolved":false,"context_lines":[{"line_number":383,"context_line":"                                root_helper\u003dself.conf.root_helper,"},{"line_number":384,"context_line":"                                namespace\u003dri.ns_name()):"},{"line_number":385,"context_line":"            self.driver.unplug(interface_name,"},{"line_number":386,"context_line":"                               bridge\u003dself.conf.external_network_bridge)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        ex_gw_ip \u003d ex_gw_port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":389,"context_line":"        for c, r in self.external_gateway_filter_rules():"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAALH%2F%2FclI%3D","line":386,"in_reply_to":"AAAALH%2F%2Fczc%3D","updated":"2012-09-10 23:09:21.000000000","message":"I see all of the unplug does not pass in namespace.","commit_id":"cb38773cc70e7977be7dd9fc44815f2c13defa9d"}]}