)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e64e2170e2ff7005bc70e0177286a09f7d5ea1f9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gordon chung \u003cgord@live.ca\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 14:17:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"graduate to oslo.serialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_293630e8","line":7,"updated":"2014-10-10 05:27:28.000000000","message":"Just say \u0027swith to using jsonutils from oslo.serialization\u0027... This headline is not very clear.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2d2c2ca87ef5f73df1d92eef3a1ff33897c5a94c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gordon chung \u003cgord@live.ca\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 14:17:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"graduate to oslo.serialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_ef8181fc","line":7,"in_reply_to":"baa201ad_293630e8","updated":"2014-10-10 11:58:56.000000000","message":"this title is pretty consistent with other patches:\n\nhttps://review.openstack.org/#/q/owner:julien%2540danjou.info+status:merged,n,z\nhttps://review.openstack.org/#/c/127257/\n...etc","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f70143faf7d95e1d48024bd12c9552d7b04cb443","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gordon chung \u003cgord@live.ca\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 14:17:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"graduate to oslo.serialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_9b9bd371","line":7,"in_reply_to":"baa201ad_40241ac6","updated":"2014-10-10 14:26:26.000000000","message":"Done","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4248e75e7ac162d4bbe663efbbe406a0640bc35d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gordon chung \u003cgord@live.ca\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 14:17:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"graduate to oslo.serialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_40241ac6","line":7,"in_reply_to":"baa201ad_ef8181fc","updated":"2014-10-10 14:12:53.000000000","message":"Though it\u0027s maybe consistent with previous patches, the title still sounds unusual. Graduation is a process of moving code from oslo-incubator to a separate library. And projects \u0027switch\u0027 to using those libraries.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b8dbe5cad16436159e79c30d9ead8f4733e19daa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     gordon chung \u003cgord@live.ca\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-10-09 14:17:43 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"graduate to oslo.serialization"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_e61606a7","line":7,"in_reply_to":"baa201ad_ef8181fc","updated":"2014-10-10 15:01:32.000000000","message":"then maybe the other ones should be changed too :)\n\nThe reason why I suggested this is that if I look at the simple git log, graduate to oslo.graduation is not intuitive for  what the patch does at all!","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e64e2170e2ff7005bc70e0177286a09f7d5ea1f9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"},{"line_number":11,"context_line":"the new library. openstack.common.jsonutils will be removed in"},{"line_number":12,"context_line":"subsequent patches as there are some existing references to it in"},{"line_number":13,"context_line":"common code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2898c4040abb2f208959049708e7bc093cfbaba7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_894c7c78","line":13,"updated":"2014-10-10 05:27:28.000000000","message":"IMO this should be tracked with a bug report. That said I\u0027m not sure I understand why this needs to be done in two steps","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4248e75e7ac162d4bbe663efbbe406a0640bc35d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"},{"line_number":11,"context_line":"the new library. openstack.common.jsonutils will be removed in"},{"line_number":12,"context_line":"subsequent patches as there are some existing references to it in"},{"line_number":13,"context_line":"common code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2898c4040abb2f208959049708e7bc093cfbaba7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_e04eee95","line":13,"in_reply_to":"baa201ad_6f759131","updated":"2014-10-10 14:12:53.000000000","message":"Armando, jsonutils are still used in:\n\nneutron/openstack/common/policy.py\nneutron/openstack/common/log.py\n\nSince those files belong to oslo-incubator, we should not modify them in neutron. Instead, they should be dropped once those modules are graduated to separate libraries, and we switch to using them.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2d2c2ca87ef5f73df1d92eef3a1ff33897c5a94c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"},{"line_number":11,"context_line":"the new library. openstack.common.jsonutils will be removed in"},{"line_number":12,"context_line":"subsequent patches as there are some existing references to it in"},{"line_number":13,"context_line":"common code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2898c4040abb2f208959049708e7bc093cfbaba7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_6f759131","line":13,"in_reply_to":"baa201ad_894c7c78","updated":"2014-10-10 11:58:56.000000000","message":"in openstack we generally don\u0027t create bugs for graduating/syncing oslo code.\n\nthe reason i did it in two steps is because graduating oslo.serialization is a requirement of pulling in versionutils but they are distinct","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b8dbe5cad16436159e79c30d9ead8f4733e19daa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"},{"line_number":11,"context_line":"the new library. openstack.common.jsonutils will be removed in"},{"line_number":12,"context_line":"subsequent patches as there are some existing references to it in"},{"line_number":13,"context_line":"common code."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2898c4040abb2f208959049708e7bc093cfbaba7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baa201ad_86761a05","line":13,"in_reply_to":"baa201ad_e04eee95","updated":"2014-10-10 15:01:32.000000000","message":"Ihar, thanks for clearing this up, much appreciated! So why don\u0027t we say that in the commit message? That avoids people wonder!","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"83dffa24d747f31a406ee845fea026c38ea53e71","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"jsonutils has been moved to the oslo.serialization library. in this"},{"line_number":10,"context_line":"patch we bring in oslo.serialization and switch all references to"},{"line_number":11,"context_line":"the new library."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2898c4040abb2f208959049708e7bc093cfbaba7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"5a890539_a1c4ab92","line":11,"updated":"2014-11-12 22:13:23.000000000","message":"What is blueprint or bug # associated with this change?","commit_id":"9f95ae18b42ee1b1778f48520a8043db77588ef5"}],"neutron/plugins/cisco/n1kv/n1kv_client.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4248e75e7ac162d4bbe663efbbe406a0640bc35d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import base64"},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from oslo.serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_400b3a2b","line":16,"updated":"2014-10-10 14:12:53.000000000","message":"eventlet is actually third-party, so you should move it below.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f70143faf7d95e1d48024bd12c9552d7b04cb443","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import base64"},{"line_number":16,"context_line":"import eventlet"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import netaddr"},{"line_number":19,"context_line":"from oslo.serialization import jsonutils"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_7bf0efc9","line":16,"in_reply_to":"baa201ad_400b3a2b","updated":"2014-10-10 14:26:26.000000000","message":"Done","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"}],"neutron/plugins/vmware/api_client/eventlet_request.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4248e75e7ac162d4bbe663efbbe406a0640bc35d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import httplib"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.serialization import jsonutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":24,"context_line":"from neutron.plugins.vmware.api_client import request"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_bb25f7af","line":21,"updated":"2014-10-10 14:12:53.000000000","message":"All modules above are third-party. So please join the sections.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c85623a4e5b6794c1e896a7dc8ab160ba7f48ffd","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import httplib"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.serialization import jsonutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":24,"context_line":"from neutron.plugins.vmware.api_client import request"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_e6860665","line":21,"in_reply_to":"baa201ad_3be66717","updated":"2014-10-10 14:42:44.000000000","message":"Yeah, sorry.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f70143faf7d95e1d48024bd12c9552d7b04cb443","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import httplib"},{"line_number":19,"context_line":"import urllib"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from oslo.serialization import jsonutils"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.openstack.common import log as logging"},{"line_number":24,"context_line":"from neutron.plugins.vmware.api_client import request"}],"source_content_type":"text/x-python","patch_set":1,"id":"baa201ad_3be66717","line":21,"in_reply_to":"baa201ad_bb25f7af","updated":"2014-10-10 14:26:26.000000000","message":"i\u0027ll bring down eventlet as i think httplib/urllib should remain separate","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"}],"requirements.txt":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4248e75e7ac162d4bbe663efbbe406a0640bc35d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"oslo.db\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":30,"context_line":"oslo.messaging\u003e\u003d1.4.0"},{"line_number":31,"context_line":"oslo.rootwrap\u003e\u003d1.3.0"},{"line_number":32,"context_line":"oslo.serialization\u003e\u003d1.0.0               # Apache-2.0"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"python-novaclient\u003e\u003d2.18.0"}],"source_content_type":"text/plain","patch_set":1,"id":"baa201ad_fba4df09","line":32,"updated":"2014-10-10 14:12:53.000000000","message":"I don\u0027t know why we have indentation \u0027fixed\u0027 for all other entries. Should we follow the example?","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"86111c03d5a6f11e03991ff90fa4b8f5bb9f483d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"oslo.db\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":30,"context_line":"oslo.messaging\u003e\u003d1.4.0"},{"line_number":31,"context_line":"oslo.rootwrap\u003e\u003d1.3.0"},{"line_number":32,"context_line":"oslo.serialization\u003e\u003d1.0.0               # Apache-2.0"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"python-novaclient\u003e\u003d2.18.0"}],"source_content_type":"text/plain","patch_set":1,"id":"baa201ad_463992d7","line":32,"in_reply_to":"baa201ad_5b1c0b14","updated":"2014-10-10 14:40:35.000000000","message":"Are you sure? It hasn\u0027t reformed lines above the last time it synced requirements.","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f70143faf7d95e1d48024bd12c9552d7b04cb443","unresolved":false,"context_lines":[{"line_number":29,"context_line":"oslo.db\u003e\u003d1.0.0  # Apache-2.0"},{"line_number":30,"context_line":"oslo.messaging\u003e\u003d1.4.0"},{"line_number":31,"context_line":"oslo.rootwrap\u003e\u003d1.3.0"},{"line_number":32,"context_line":"oslo.serialization\u003e\u003d1.0.0               # Apache-2.0"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"python-novaclient\u003e\u003d2.18.0"}],"source_content_type":"text/plain","patch_set":1,"id":"baa201ad_5b1c0b14","line":32,"in_reply_to":"baa201ad_fba4df09","updated":"2014-10-10 14:26:26.000000000","message":"i don\u0027t know why either. but the automated sync will just reformat it to how it is in global-requirements (which is what i have now)","commit_id":"8f85c898348a6a4516ca59f2dee0f04b4984c1c3"}]}