)]}'
{"neutron/api/rpc/handlers/dhcp_rpc.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"b7bf9055f3336bf4d3b70cf3b723568363cf9bb2","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def update_dhcp_port(self, context, **kwargs):"},{"line_number":283,"context_line":"        \"\"\"Update the dhcp port.\"\"\""},{"line_number":284,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":285,"context_line":"        port \u003d kwargs.get(\u0027port\u0027, {\u0027port\u0027: {}})"},{"line_number":286,"context_line":"        port[\u0027id\u0027] \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":287,"context_line":"        LOG.debug(_(\u0027Update dhcp port %(port)s \u0027"},{"line_number":288,"context_line":"                    \u0027from %(host)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_481af16f","line":285,"updated":"2014-10-16 11:28:34.000000000","message":"Why would any caller call update_dhcp_port without any port information ?","commit_id":"640444d5430e21095c16cc56ef4388d12a409259"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"51c7300f2d93d3609380e4c16865e2d501c81921","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def update_dhcp_port(self, context, **kwargs):"},{"line_number":283,"context_line":"        \"\"\"Update the dhcp port.\"\"\""},{"line_number":284,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":285,"context_line":"        port \u003d kwargs.get(\u0027port\u0027, {\u0027port\u0027: {}})"},{"line_number":286,"context_line":"        port[\u0027id\u0027] \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":287,"context_line":"        LOG.debug(_(\u0027Update dhcp port %(port)s \u0027"},{"line_number":288,"context_line":"                    \u0027from %(host)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_48d8311e","line":285,"in_reply_to":"baa201ad_481af16f","updated":"2014-10-16 11:46:57.000000000","message":"I don\u0027t know. The kwargs imply that it might not be there. If not, I should just convert these to regular arguments and don\u0027t allow them to the be unspecified.","commit_id":"640444d5430e21095c16cc56ef4388d12a409259"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"bb8a3d5cea41702cda6c3f697a9d0d560f333ff0","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def update_dhcp_port(self, context, **kwargs):"},{"line_number":283,"context_line":"        \"\"\"Update the dhcp port.\"\"\""},{"line_number":284,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":285,"context_line":"        port \u003d kwargs.get(\u0027port\u0027, {\u0027port\u0027: {}})"},{"line_number":286,"context_line":"        port[\u0027id\u0027] \u003d kwargs.get(\u0027port_id\u0027)"},{"line_number":287,"context_line":"        LOG.debug(_(\u0027Update dhcp port %(port)s \u0027"},{"line_number":288,"context_line":"                    \u0027from %(host)s.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa201ad_c8418164","line":285,"in_reply_to":"baa201ad_48d8311e","updated":"2014-10-16 12:03:15.000000000","message":"Ok","commit_id":"640444d5430e21095c16cc56ef4388d12a409259"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"736de251b28bcf2aa7b344eff645be945181b352","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        plugin \u003d manager.NeutronManager.get_plugin()"},{"line_number":280,"context_line":"        return self._port_action(plugin, context, port, \u0027create_port\u0027)"},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    def update_dhcp_port(self, context, **kwargs):"},{"line_number":283,"context_line":"        \"\"\"Update the dhcp port.\"\"\""},{"line_number":284,"context_line":"        host \u003d kwargs.get(\u0027host\u0027)"},{"line_number":285,"context_line":"        port \u003d kwargs.get(\u0027port\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_03c5de5a","side":"PARENT","line":282,"updated":"2014-10-18 08:06:41.000000000","message":"We do this in multiple places if I recall correctly, and certainly so in this file. I don\u0027t see any particular reason why this would be useful just for this method. The code looks fine as is, even though I agree that the use of kwargs is not so polite.","commit_id":"695cabc44c13a7e85d58b56d35068a05163a4b92"}]}