)]}'
{"neutron/services/firewall/agents/l3reference/firewall_l3_agent.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"0bdd3a634eff71eec5c8e7e30132e8efcb45c199","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            for router in routers"},{"line_number":98,"context_line":"            if router[\u0027tenant_id\u0027] \u003d\u003d tenant_id]"},{"line_number":99,"context_line":"        local_ns_list \u003d root_ip.get_namespaces("},{"line_number":100,"context_line":"            self.root_helper) if self.conf.use_namespaces else []"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        router_info_list \u003d []"},{"line_number":103,"context_line":"        # Pick up namespaces for Tenant Routers"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_5e4950cf","line":100,"updated":"2014-10-20 22:55:36.000000000","message":"The py26 failure is because I\u0027ve set self.conf.use_namespaces to True and this now runs.  I\u0027ll mock this call.","commit_id":"5e0e41d4c90474d3f74101250e10abbd1cce4da0"}],"neutron/tests/unit/services/firewall/agents/l3reference/test_firewall_l3_agent.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2156c9751cf8afe010cddd3040f0b2850f5ea130","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                ctx,"},{"line_number":334,"context_line":"                fake_firewall_list[0][\u0027id\u0027])"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def _prepare_router_data(self, use_namespaces):"},{"line_number":337,"context_line":"        router \u003d {\u0027id\u0027: str(uuid.uuid4()), \u0027tenant_id\u0027: str(uuid.uuid4())}"},{"line_number":338,"context_line":"        ns \u003d \"ns-\" + router[\u0027id\u0027]"},{"line_number":339,"context_line":"        return l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_1d50ad31","line":336,"range":{"start_line":336,"start_character":35,"end_line":336,"end_character":49},"updated":"2014-10-21 01:24:37.000000000","message":"better to remove use_namesapces argument.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8decf685caf8e37d7858f4e4220e7ca641c96115","unresolved":false,"context_lines":[{"line_number":333,"context_line":"                ctx,"},{"line_number":334,"context_line":"                fake_firewall_list[0][\u0027id\u0027])"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def _prepare_router_data(self, use_namespaces):"},{"line_number":337,"context_line":"        router \u003d {\u0027id\u0027: str(uuid.uuid4()), \u0027tenant_id\u0027: str(uuid.uuid4())}"},{"line_number":338,"context_line":"        ns \u003d \"ns-\" + router[\u0027id\u0027]"},{"line_number":339,"context_line":"        return l3_agent.RouterInfo(router[\u0027id\u0027], self.conf.root_helper,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_2069caf9","line":336,"in_reply_to":"9aa7fdbe_1d50ad31","updated":"2014-10-21 17:04:20.000000000","message":"You\u0027re right, this should be cleaned up.  Will do.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"2156c9751cf8afe010cddd3040f0b2850f5ea130","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_router_info_list_without_namespace_helper(self,"},{"line_number":360,"context_line":"                                                       router_use_namespaces):"},{"line_number":361,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, router_use_namespaces)"},{"line_number":362,"context_line":"        ri \u003d self._prepare_router_data("},{"line_number":363,"context_line":"            use_namespaces\u003drouter_use_namespaces)"},{"line_number":364,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_fd31290c","line":361,"updated":"2014-10-21 01:24:37.000000000","message":"this change seems weird.\nit\u0027s better to remove router_user_namespaces argument and thus reduce test cases.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"1e6be32994e570394246ad58a1a67b8011408803","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_router_info_list_without_namespace_helper(self,"},{"line_number":360,"context_line":"                                                       router_use_namespaces):"},{"line_number":361,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, router_use_namespaces)"},{"line_number":362,"context_line":"        ri \u003d self._prepare_router_data("},{"line_number":363,"context_line":"            use_namespaces\u003drouter_use_namespaces)"},{"line_number":364,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_b435b3f8","line":361,"in_reply_to":"9aa7fdbe_10a0829e","updated":"2014-10-23 03:04:03.000000000","message":"callers of _get_router_info_list_with_namespace_helper and _get_router_info_list_without_namespace_helper seem trying\nto test all combinations of conf.use_namespace and ri.use_namespace.\nas you removed ri.use_namespace, you can (IMO should) now reduce\nthe number of tests.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"f13feb768411e6852a292c91699dbe9df2461513","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_router_info_list_without_namespace_helper(self,"},{"line_number":360,"context_line":"                                                       router_use_namespaces):"},{"line_number":361,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, router_use_namespaces)"},{"line_number":362,"context_line":"        ri \u003d self._prepare_router_data("},{"line_number":363,"context_line":"            use_namespaces\u003drouter_use_namespaces)"},{"line_number":364,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_7a979b48","line":361,"in_reply_to":"9aa7fdbe_b435b3f8","updated":"2014-10-23 19:16:36.000000000","message":"Ok, thanks for the more detailed explanation.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"8decf685caf8e37d7858f4e4220e7ca641c96115","unresolved":false,"context_lines":[{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def _get_router_info_list_without_namespace_helper(self,"},{"line_number":360,"context_line":"                                                       router_use_namespaces):"},{"line_number":361,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, router_use_namespaces)"},{"line_number":362,"context_line":"        ri \u003d self._prepare_router_data("},{"line_number":363,"context_line":"            use_namespaces\u003drouter_use_namespaces)"},{"line_number":364,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_10a0829e","line":361,"in_reply_to":"9aa7fdbe_fd31290c","updated":"2014-10-21 17:04:20.000000000","message":"There are still two code paths being tested.  I don\u0027t think it is appropriate to reduce the test cases in this case.  What I\u0027ve done here is to modify the test to manipulate self.conf.use_namespaces instead of setting it on the router.  This corresponds to the change in neutron/services/firewall/agents/l3reference/firewall_l3_agent.py.","commit_id":"b087867d0dcfb6399cf6eeb2898b53ad381f34d4"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a92a10e7fedd9e65276def4872088c073fcd20c2","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                   router\u003drouter, ns_name\u003dns)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _get_router_info_list_with_namespace_helper(self,"},{"line_number":343,"context_line":"                                                    router_use_namespaces):"},{"line_number":344,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, True)"},{"line_number":345,"context_line":"        ri \u003d self._prepare_router_data()"},{"line_number":346,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_4eaeabe7","line":343,"updated":"2014-10-23 11:52:17.000000000","message":"The argument, router_use_namespace,  isn\u0027t used any more.","commit_id":"1d8918ed154faa396fb7981b5e0cb9c7b196c199"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"36b1eb1f5c3f07b6aad4631c7a30dbc41564b7dc","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                                   router\u003drouter, ns_name\u003dns)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"    def _get_router_info_list_with_namespace_helper(self,"},{"line_number":343,"context_line":"                                                    router_use_namespaces):"},{"line_number":344,"context_line":"        self.conf.set_override(\u0027use_namespaces\u0027, True)"},{"line_number":345,"context_line":"        ri \u003d self._prepare_router_data()"},{"line_number":346,"context_line":"        routers \u003d [ri.router]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aa7fdbe_fab8ebc9","line":343,"in_reply_to":"9aa7fdbe_4eaeabe7","updated":"2014-10-23 19:25:21.000000000","message":"Done","commit_id":"1d8918ed154faa396fb7981b5e0cb9c7b196c199"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"b48b147e8ca9c4262d18f628ad86b0c303e05028","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                routers,"},{"line_number":352,"context_line":"                ri.router[\u0027tenant_id\u0027])"},{"line_number":353,"context_line":"        if use_namespaces:"},{"line_number":354,"context_line":"            self.assertFalse(router_info_list)"},{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            self.assertEqual([ri], router_info_list)"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_3ddb4851","line":354,"updated":"2014-10-24 01:53:37.000000000","message":"can you keep mock_get_namespaces.assert_called_once_with assertion?","commit_id":"4e32f12ef6e2b21a2c7fcebb83ce74561a81dec1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d190624c76b81cc24430cdc2b41a1301c3662ea6","unresolved":false,"context_lines":[{"line_number":351,"context_line":"                routers,"},{"line_number":352,"context_line":"                ri.router[\u0027tenant_id\u0027])"},{"line_number":353,"context_line":"        if use_namespaces:"},{"line_number":354,"context_line":"            self.assertFalse(router_info_list)"},{"line_number":355,"context_line":"        else:"},{"line_number":356,"context_line":"            self.assertEqual([ri], router_info_list)"},{"line_number":357,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_493e7c8d","line":354,"in_reply_to":"9aa7fdbe_3ddb4851","updated":"2014-10-24 18:36:29.000000000","message":"Sure, I can do that.","commit_id":"4e32f12ef6e2b21a2c7fcebb83ce74561a81dec1"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c18f224757e4d9461610ac778d3ca221bc8b41f6","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def test_get_router_info_list_for_tenant_for_namespaces_disabled(self):"},{"line_number":359,"context_line":"        self._get_router_info_list_helper(use_namespaces\u003dFalse)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def test_get_router_info_list_tenant_without_namespace_router_with(self):"},{"line_number":362,"context_line":"        self._get_router_info_list_helper(use_namespaces\u003dTrue)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _get_router_info_list_router_without_router_info_helper(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_9dfb54c0","line":361,"range":{"start_line":361,"start_character":8,"end_line":361,"end_character":70},"updated":"2014-10-24 01:52:45.000000000","message":"the name of this method now looks weird.","commit_id":"4e32f12ef6e2b21a2c7fcebb83ce74561a81dec1"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"d190624c76b81cc24430cdc2b41a1301c3662ea6","unresolved":false,"context_lines":[{"line_number":358,"context_line":"    def test_get_router_info_list_for_tenant_for_namespaces_disabled(self):"},{"line_number":359,"context_line":"        self._get_router_info_list_helper(use_namespaces\u003dFalse)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"    def test_get_router_info_list_tenant_without_namespace_router_with(self):"},{"line_number":362,"context_line":"        self._get_router_info_list_helper(use_namespaces\u003dTrue)"},{"line_number":363,"context_line":""},{"line_number":364,"context_line":"    def _get_router_info_list_router_without_router_info_helper(self,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9aa7fdbe_e98d707d","line":361,"in_reply_to":"9aa7fdbe_9dfb54c0","updated":"2014-10-24 18:36:29.000000000","message":"It looked weird before.  :)","commit_id":"4e32f12ef6e2b21a2c7fcebb83ce74561a81dec1"}]}
