)]}'
{"neutron/plugins/ml2/db.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d071ddae93c869a0f4573430e7ea9c77b7493c10","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        binding \u003d (session.query(models.PortBinding)."},{"line_number":161,"context_line":"                   enable_eagerloads(False)."},{"line_number":162,"context_line":"                   filter_by(port_id\u003dport_id)."},{"line_number":163,"context_line":"                   one())"},{"line_number":164,"context_line":"        return binding"},{"line_number":165,"context_line":"    except exc.NoResultFound:"},{"line_number":166,"context_line":"        return None, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_819013ee","line":163,"updated":"2015-01-08 09:49:31.000000000","message":"If you query .first() here instead of one(), it will return None on NoResultFound so you don\u0027t have to catch that error and convert it yourself.","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"cee351abb08955fe69e488e689bb13c90084976a","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        binding \u003d (session.query(models.PortBinding)."},{"line_number":161,"context_line":"                   enable_eagerloads(False)."},{"line_number":162,"context_line":"                   filter_by(port_id\u003dport_id)."},{"line_number":163,"context_line":"                   one())"},{"line_number":164,"context_line":"        return binding"},{"line_number":165,"context_line":"    except exc.NoResultFound:"},{"line_number":166,"context_line":"        return None, None"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_381a2d6f","line":163,"in_reply_to":"3a961159_819013ee","updated":"2015-01-08 12:17:52.000000000","message":"Changes in this file not necessary anymore, so removing this from next patchset.","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"}],"neutron/plugins/openvswitch/agent/ovs_dvr_neutron_agent.py":[{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"9f2272160aea91e20fbc289de6e593a2216fc013","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.patch_tun_ofport \u003d patch_tun_ofport"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def setup_dvr_flows_on_integ_tun_br(self):"},{"line_number":145,"context_line":"        \u0027\u0027\u0027Setup up initial dvr flows into br-int and br-tun\u0027\u0027\u0027"},{"line_number":146,"context_line":"        if not self.enable_distributed_routing:"},{"line_number":147,"context_line":"            return"},{"line_number":148,"context_line":"        LOG.debug(\"L2 Agent operating in DVR Mode\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_3d0590c2","line":145,"updated":"2014-12-08 03:43:42.000000000","message":"this line should be changed to reflect VLAN support.","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"69e45727a7feff68bd5271d3980f78956677086f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.patch_tun_ofport \u003d patch_tun_ofport"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def setup_dvr_flows_on_integ_tun_br(self):"},{"line_number":145,"context_line":"        \u0027\u0027\u0027Setup up initial dvr flows into br-int and br-tun\u0027\u0027\u0027"},{"line_number":146,"context_line":"        if not self.enable_distributed_routing:"},{"line_number":147,"context_line":"            return"},{"line_number":148,"context_line":"        LOG.debug(\"L2 Agent operating in DVR Mode\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_7b6f5928","line":145,"in_reply_to":"3a961159_3d0590c2","updated":"2015-01-08 12:12:48.000000000","message":"Done","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":7183,"name":"Xu Han Peng","email":"xuhanp@linux.vnet.ibm.com","username":"xuhanp"},"change_message_id":"9f2272160aea91e20fbc289de6e593a2216fc013","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                             priority\u003d1,"},{"line_number":189,"context_line":"                             actions\u003d\"normal\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":192,"context_line":"            self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":193,"context_line":"                                 priority\u003d2,"},{"line_number":194,"context_line":"                                 in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1d73744e","line":191,"updated":"2014-12-08 03:43:42.000000000","message":"Is self.bridge_mappings the only way to decide if VLAN flows should be enabled? What if bridge_mappings is specified in conf file but tenant_network_type doesn\u0027t include vlan?","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"93206c879f2ef67988bddc00f1e9afe43d34d97f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                             priority\u003d1,"},{"line_number":189,"context_line":"                             actions\u003d\"normal\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":192,"context_line":"            self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":193,"context_line":"                                 priority\u003d2,"},{"line_number":194,"context_line":"                                 in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_fdebee75","line":191,"updated":"2014-11-27 21:30:08.000000000","message":"if \u0027bridge\u0027 isn\u0027t needed, just use \u0027for physical_network in self.bridge_mappings\u0027","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"69e45727a7feff68bd5271d3980f78956677086f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                             priority\u003d1,"},{"line_number":189,"context_line":"                             actions\u003d\"normal\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":192,"context_line":"            self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":193,"context_line":"                                 priority\u003d2,"},{"line_number":194,"context_line":"                                 in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a961159_1bdc95e3","line":191,"in_reply_to":"3a961159_1d73744e","updated":"2015-01-08 12:12:48.000000000","message":"Regardless of the value in tenant_network_types, operator can create provider networks with VLAN as the underlay.  In order to support such use-case only haven\u0027t additionally checked for tenant_network_type value.\n\nThe same case is possible other way, wherein the tenant_network_type will be VLAN but the tenant can create provider networks with VXLAN.","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"d8319ef5cd4e6bbfa7dfe2a71a9e7b2099d88604","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                             priority\u003d1,"},{"line_number":189,"context_line":"                             actions\u003d\"normal\")"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":192,"context_line":"            self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":193,"context_line":"                                 priority\u003d2,"},{"line_number":194,"context_line":"                                 in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_98decb0f","line":191,"in_reply_to":"5a890539_fdebee75","updated":"2014-12-04 03:24:25.000000000","message":"will do.","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"93206c879f2ef67988bddc00f1e9afe43d34d97f","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            LOG.debug(\"Removed DVR MAC flow for %s\", oldmac)"},{"line_number":312,"context_line":"            self.registered_dvr_macs.remove(oldmac)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        for newmac in dvr_macs_added:"},{"line_number":315,"context_line":"            for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":316,"context_line":"                self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":317,"context_line":"                    in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_1d00ba34","line":314,"updated":"2014-11-27 21:30:08.000000000","message":"before each these iterations to add rules, can you put an inline comment that explains what the purpose of the rules being added is?","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"d8319ef5cd4e6bbfa7dfe2a71a9e7b2099d88604","unresolved":false,"context_lines":[{"line_number":311,"context_line":"            LOG.debug(\"Removed DVR MAC flow for %s\", oldmac)"},{"line_number":312,"context_line":"            self.registered_dvr_macs.remove(oldmac)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"        for newmac in dvr_macs_added:"},{"line_number":315,"context_line":"            for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":316,"context_line":"                self.int_br.add_flow(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":317,"context_line":"                    in_port\u003dself.int_ofports[physical_network],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_b8e1c7d1","line":314,"in_reply_to":"5a890539_1d00ba34","updated":"2014-12-04 03:24:25.000000000","message":"Yes, will do.","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"93206c879f2ef67988bddc00f1e9afe43d34d97f","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        if network_type in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":467,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"},{"line_number":468,"context_line":"                             priority\u003d3,"},{"line_number":469,"context_line":"                             dl_vlan\u003dlocal_vlan,"},{"line_number":470,"context_line":"                             proto\u003d\u0027arp\u0027,"},{"line_number":471,"context_line":"                             nw_dst\u003dsubnet_info[\u0027gateway_ip\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_3dfd763c","line":468,"updated":"2014-11-27 21:30:08.000000000","message":"nit: shift these args over as well so they match with the open parens","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"d8319ef5cd4e6bbfa7dfe2a71a9e7b2099d88604","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        if network_type in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":467,"context_line":"            self.tun_br.add_flow(table\u003dconstants.DVR_PROCESS,"},{"line_number":468,"context_line":"                             priority\u003d3,"},{"line_number":469,"context_line":"                             dl_vlan\u003dlocal_vlan,"},{"line_number":470,"context_line":"                             proto\u003d\u0027arp\u0027,"},{"line_number":471,"context_line":"                             nw_dst\u003dsubnet_info[\u0027gateway_ip\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a890539_9805eb7b","line":468,"in_reply_to":"5a890539_3dfd763c","updated":"2014-12-04 03:24:25.000000000","message":"Will do.","commit_id":"8e11979c73c71005c8b4d2b4ec5d15e1ea6c03ec"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d071ddae93c869a0f4573430e7ea9c77b7493c10","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def setup_dvr_flows_on_tun_br(self):"},{"line_number":264,"context_line":"        \u0027\u0027\u0027Setup up initial dvr flows into br-tun\u0027\u0027\u0027"},{"line_number":265,"context_line":"        if not self.enable_tunneling:"},{"line_number":266,"context_line":"            return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        if not self.in_distributed_mode():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_a18b4fbe","line":265,"updated":"2015-01-08 09:49:31.000000000","message":"if not self.enable_tunneling or not self.in_distributed_mode():","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"cee351abb08955fe69e488e689bb13c90084976a","unresolved":false,"context_lines":[{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def setup_dvr_flows_on_tun_br(self):"},{"line_number":264,"context_line":"        \u0027\u0027\u0027Setup up initial dvr flows into br-tun\u0027\u0027\u0027"},{"line_number":265,"context_line":"        if not self.enable_tunneling:"},{"line_number":266,"context_line":"            return"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"        if not self.in_distributed_mode():"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_12138f65","line":265,"in_reply_to":"3a961159_a18b4fbe","updated":"2015-01-08 12:17:52.000000000","message":"Done","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d071ddae93c869a0f4573430e7ea9c77b7493c10","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        for oldmac in dvr_macs_removed:"},{"line_number":358,"context_line":"            for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":359,"context_line":"                    self.int_br.delete_flows(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":360,"context_line":"                        in_port\u003dself.int_ofports[physical_network],"},{"line_number":361,"context_line":"                        dl_src\u003doldmac)"},{"line_number":362,"context_line":"                    self.phys_brs[physical_network].delete_flows("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_c1bdbb69","line":359,"updated":"2015-01-08 09:49:31.000000000","message":"overindented","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"cee351abb08955fe69e488e689bb13c90084976a","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":"        for oldmac in dvr_macs_removed:"},{"line_number":358,"context_line":"            for physical_network, bridge in self.bridge_mappings.iteritems():"},{"line_number":359,"context_line":"                    self.int_br.delete_flows(table\u003dconstants.LOCAL_SWITCHING,"},{"line_number":360,"context_line":"                        in_port\u003dself.int_ofports[physical_network],"},{"line_number":361,"context_line":"                        dl_src\u003doldmac)"},{"line_number":362,"context_line":"                    self.phys_brs[physical_network].delete_flows("}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_320deb3e","line":359,"in_reply_to":"3a961159_c1bdbb69","updated":"2015-01-08 12:17:52.000000000","message":"Done","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"d071ddae93c869a0f4573430e7ea9c77b7493c10","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        if not self.in_distributed_mode():"},{"line_number":647,"context_line":"            return"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if local_vlan_map.network_type not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":650,"context_line":"            if local_vlan_map.network_type !\u003d p_const.TYPE_VLAN:"},{"line_number":651,"context_line":"                LOG.debug(\"DVR: Port %s is with network_type %s not supported\""},{"line_number":652,"context_line":"                          \" for dvr plumbing\" % (port.vif_id, local_vlan_map.network_type))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_e1c0f7e1","line":649,"updated":"2015-01-08 09:49:31.000000000","message":"if local_vlan_map.network_type not in (constants.TUNNEL_NETWORK_TYPES  \n                                       + [p_const.TYPE_VLAN])):","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"cee351abb08955fe69e488e689bb13c90084976a","unresolved":false,"context_lines":[{"line_number":646,"context_line":"        if not self.in_distributed_mode():"},{"line_number":647,"context_line":"            return"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"        if local_vlan_map.network_type not in constants.TUNNEL_NETWORK_TYPES:"},{"line_number":650,"context_line":"            if local_vlan_map.network_type !\u003d p_const.TYPE_VLAN:"},{"line_number":651,"context_line":"                LOG.debug(\"DVR: Port %s is with network_type %s not supported\""},{"line_number":652,"context_line":"                          \" for dvr plumbing\" % (port.vif_id, local_vlan_map.network_type))"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a961159_92fe9f04","line":649,"in_reply_to":"3a961159_e1c0f7e1","updated":"2015-01-08 12:17:52.000000000","message":"Done","commit_id":"baa9768340ad6efa10fe0606b2f61fe8ef2ad186"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"e94ca5acf9042f201f7bee009ba3b438e971cfe5","unresolved":false,"context_lines":[{"line_number":401,"context_line":"                             \"resubmit(,%s)\" %"},{"line_number":402,"context_line":"                             (lvid, table_id))"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def _bind_distributed_router_interface_port(self, port, lvm,"},{"line_number":405,"context_line":"                                                fixed_ips, device_owner):"},{"line_number":406,"context_line":"        # since router port must have only one fixed IP, directly"},{"line_number":407,"context_line":"        # use fixed_ips[0]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_41a979dc","line":404,"updated":"2015-01-12 14:52:46.000000000","message":"This function\u0027s length implies that it may be worth trying to refactor this a bit going forward. I don\u0027t think we should hold this patch up due to this, but perhaps a follow-on patch could do the refactor.","commit_id":"ed2b00e41fa2206281ade045cf415d2921d32280"}],"neutron/plugins/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4ce6b3d8d210c8a8fa85ddf18d1545046d389231","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        elif network_type \u003d\u003d p_const.TYPE_VLAN:"},{"line_number":544,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":545,"context_line":"                # outbound"},{"line_number":546,"context_line":"                br \u003d self.phys_brs[physical_network]"},{"line_number":547,"context_line":"                if self.enable_distributed_routing:"},{"line_number":548,"context_line":"                    br.add_flow(table\u003dconstants.LOCAL_VLAN_TRANSLATION,"},{"line_number":549,"context_line":"                            priority\u003d4,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_8a016308","line":546,"updated":"2015-01-23 22:10:21.000000000","message":"I\u0027d rather build the kwargs like so:\n\n  kwargs \u003d {\n    \u0027priority\u0027: 4,\n    \u0027in_port\u0027: self.phys_ofports[physical_network],\n    \u0027dl_vlan\u0027: lvid,\n    \u0027actions\u0027: \"mod_vlan_vid:%s,normal\" % segmentation_id\n  }\n  if self.enable_distributed_routing:\n    kwargs[\u0027table\u0027] \u003d constants.LOCAL_VLAN_TRANSLATION\n\n  br.add_flow(**kwargs)","commit_id":"cd7b6b923fb517f0deb7131f8113639a28d06117"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"d45b9d4760f75d52d1b5948b72e8e9ec8a2b517f","unresolved":false,"context_lines":[{"line_number":543,"context_line":"        elif network_type \u003d\u003d p_const.TYPE_VLAN:"},{"line_number":544,"context_line":"            if physical_network in self.phys_brs:"},{"line_number":545,"context_line":"                # outbound"},{"line_number":546,"context_line":"                br \u003d self.phys_brs[physical_network]"},{"line_number":547,"context_line":"                if self.enable_distributed_routing:"},{"line_number":548,"context_line":"                    br.add_flow(table\u003dconstants.LOCAL_VLAN_TRANSLATION,"},{"line_number":549,"context_line":"                            priority\u003d4,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_d0323a5e","line":546,"in_reply_to":"1a930d6b_8a016308","updated":"2015-01-23 22:54:27.000000000","message":"Yes , will change.","commit_id":"cd7b6b923fb517f0deb7131f8113639a28d06117"}],"neutron/tests/unit/openvswitch/test_ovs_neutron_agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4ce6b3d8d210c8a8fa85ddf18d1545046d389231","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        cfgmap \u003d ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":89,"context_line":"        self.assertEqual(cfgmap[\u0027enable_distributed_routing\u0027], True)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class TestOvsNeutronAgent(base.BaseTestCase):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_2a8b0fc4","line":91,"updated":"2015-01-23 22:10:21.000000000","message":"can you follow up with a patch that breaks out the DVR logic out of this test case (e.g. by contributing this to a test_ovs_dvr_neutron_agent)?","commit_id":"cd7b6b923fb517f0deb7131f8113639a28d06117"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"d45b9d4760f75d52d1b5948b72e8e9ec8a2b517f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        cfgmap \u003d ovs_neutron_agent.create_agent_config_map(cfg.CONF)"},{"line_number":89,"context_line":"        self.assertEqual(cfgmap[\u0027enable_distributed_routing\u0027], True)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"class TestOvsNeutronAgent(base.BaseTestCase):"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_f0fc9674","line":91,"in_reply_to":"1a930d6b_2a8b0fc4","updated":"2015-01-23 22:54:27.000000000","message":"Agreed.  I will break out DVR test cases to a separate file test_ovs_dvr_neutron_agent.","commit_id":"cd7b6b923fb517f0deb7131f8113639a28d06117"}]}