)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"c10f781623d4083283707dea01cd145cd3712fdc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"retried that many times. \u0027retry\u0027 means it happened"},{"line_number":11,"context_line":"once before. In the current code, if DB_MAX_RETRIES"},{"line_number":12,"context_line":"is set to 1, the query won\u0027t be retried at all."},{"line_number":13,"context_line":"If it\u0027s set to 0, the query won\u0027t even be run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the logic by adding another iteration"},{"line_number":16,"context_line":"to the loop to cover the first attempt."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_3b9e1e57","line":13,"updated":"2014-10-22 16:36:40.000000000","message":"As Armando points out, the value for DB_MAX_RETRIES is a hard-coded to 10. Who is going to set it to something else, and how?","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3f5a29655da331021e56f293d41e6e55d92e4350","unresolved":false,"context_lines":[{"line_number":10,"context_line":"retried that many times. \u0027retry\u0027 means it happened"},{"line_number":11,"context_line":"once before. In the current code, if DB_MAX_RETRIES"},{"line_number":12,"context_line":"is set to 1, the query won\u0027t be retried at all."},{"line_number":13,"context_line":"If it\u0027s set to 0, the query won\u0027t even be run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the logic by adding another iteration"},{"line_number":16,"context_line":"to the loop to cover the first attempt."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_4a694524","line":13,"in_reply_to":"9aa7fdbe_0a5d7de9","updated":"2014-10-23 00:14:06.000000000","message":"No-one in the right mind will set RETRIES to 0 or 1, come on! \n\nThat said, this is correct to me:\n\nDB_MAX_RETRIES \u003d 0 \u003d\u003d\u003e I should not run and it\u0027s consistent!\nDB_MAX_RETRIES \u003d 1 \u003d\u003d\u003e I retry only one, and I shoot myself in the foot!\n\nI really don\u0027t see the problem here, but it could be just me.","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e150c10c37894502089edd2e434293090d02ad71","unresolved":false,"context_lines":[{"line_number":10,"context_line":"retried that many times. \u0027retry\u0027 means it happened"},{"line_number":11,"context_line":"once before. In the current code, if DB_MAX_RETRIES"},{"line_number":12,"context_line":"is set to 1, the query won\u0027t be retried at all."},{"line_number":13,"context_line":"If it\u0027s set to 0, the query won\u0027t even be run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch fixes the logic by adding another iteration"},{"line_number":16,"context_line":"to the loop to cover the first attempt."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9aa7fdbe_0a5d7de9","line":13,"in_reply_to":"9aa7fdbe_3b9e1e57","updated":"2014-10-22 23:41:46.000000000","message":"A developer with a text editor! My point is that the variable has an incorrect name in it\u0027s current usage.","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":11825,"name":"Sudhakar Babu Gariganti","email":"sudhakar.gariganti@gmail.com","username":"sudhakar-gariganti"},"change_message_id":"031b1d61f68a85ef8d0b3903c7f59095c727943b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"is set to 1, the query won\u0027t be retried at all."},{"line_number":13,"context_line":"If it\u0027s set to 0, the query won\u0027t even be run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This constant should actually be called DB_MAX_TRIES"},{"line_number":16,"context_line":"to indicate that the variable includes the first try."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I13f088ffa38c40db7fd297173e892b4ad5c7fadd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aa7fdbe_44d44c47","line":15,"updated":"2014-10-29 06:47:26.000000000","message":"Missed to update with the new nice name here :P","commit_id":"bdced9581fe482a4a86afd88fe4b6097a175bb9c"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f62df4bbd760a18c69f3baa16e1ca46c7b43867b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"is set to 1, the query won\u0027t be retried at all."},{"line_number":13,"context_line":"If it\u0027s set to 0, the query won\u0027t even be run."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This constant should actually be called DB_MAX_TRIES"},{"line_number":16,"context_line":"to indicate that the variable includes the first try."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I13f088ffa38c40db7fd297173e892b4ad5c7fadd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9aa7fdbe_04c08429","line":15,"in_reply_to":"9aa7fdbe_44d44c47","updated":"2014-10-29 07:12:11.000000000","message":"Whoops.","commit_id":"bdced9581fe482a4a86afd88fe4b6097a175bb9c"}],"neutron/plugins/ml2/drivers/helpers.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3f5a29655da331021e56f293d41e6e55d92e4350","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                      filter_by(allocated\u003dFalse, **filters))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Selected segment can be allocated before update by someone else,"},{"line_number":110,"context_line":"            # We retry until update success or DB_MAX_RETRIES retries"},{"line_number":111,"context_line":"            for attempt in range(1, DB_MAX_RETRIES + 2):"},{"line_number":112,"context_line":"                alloc \u003d select.first()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_4ad785bf","line":110,"updated":"2014-10-23 00:14:06.000000000","message":"now this is DB_MAX_RETRIES + 1 :P","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8554235bb327a75894621434536954d57dd82137","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Selected segment can be allocated before update by someone else,"},{"line_number":110,"context_line":"            # We retry until update success or DB_MAX_RETRIES retries"},{"line_number":111,"context_line":"            for attempt in range(1, DB_MAX_RETRIES + 2):"},{"line_number":112,"context_line":"                alloc \u003d select.first()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"                if not alloc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_6f21c8b3","line":111,"updated":"2014-10-22 14:55:32.000000000","message":"This value is hard-coded in the source! It sounds like we\u0027re solving the wrong problem here...just saying...","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e150c10c37894502089edd2e434293090d02ad71","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Selected segment can be allocated before update by someone else,"},{"line_number":110,"context_line":"            # We retry until update success or DB_MAX_RETRIES retries"},{"line_number":111,"context_line":"            for attempt in range(1, DB_MAX_RETRIES + 2):"},{"line_number":112,"context_line":"                alloc \u003d select.first()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"                if not alloc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_8aba4d08","line":111,"in_reply_to":"9aa7fdbe_6f21c8b3","updated":"2014-10-22 23:41:46.000000000","message":"Well if the variable doesn\u0027t represent what it means, why don\u0027t we just name it MYVAR? :-)","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3f5a29655da331021e56f293d41e6e55d92e4350","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Selected segment can be allocated before update by someone else,"},{"line_number":110,"context_line":"            # We retry until update success or DB_MAX_RETRIES retries"},{"line_number":111,"context_line":"            for attempt in range(1, DB_MAX_RETRIES + 2):"},{"line_number":112,"context_line":"                alloc \u003d select.first()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"                if not alloc:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_aaef1186","line":111,"in_reply_to":"9aa7fdbe_8aba4d08","updated":"2014-10-23 00:14:06.000000000","message":"would RETRIES work any better?","commit_id":"13ac0dc97c823d6ca0c0ea7c069d304490041800"},{"author":{"_account_id":11279,"name":"Angus Lees","email":"gus@inodes.org","username":"gus"},"change_message_id":"70f6fc2281ca41c197586271c82d284fbadf883c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                      filter_by(allocated\u003dFalse, **filters))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"            # Selected segment can be allocated before update by someone else,"},{"line_number":110,"context_line":"            # We retry until update success or DB_MAX_TRIES attemps"},{"line_number":111,"context_line":"            for attempt in range(1, DB_MAX_TRIES + 1):"},{"line_number":112,"context_line":"                alloc \u003d select.first()"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa7fdbe_9ec8ce23","line":110,"updated":"2014-10-23 00:52:49.000000000","message":"attemps -\u003e attempts","commit_id":"f90c9cf0043e5c5330e6b89e43cefcc364af05e7"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f779ea33d27a643f1e0df96cc31ffe80cc742dba","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Number of attempts to find a valid segment candidate and allocate it"},{"line_number":24,"context_line":"DB_MAX_TRIES \u003d 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_e9499961","line":24,"updated":"2014-10-29 05:34:33.000000000","message":"I call out Armando to defend MAX_TRIES! :-) This was his idea after a conversation about this critical patch and its impact on Neutron\u0027s future.\n\nI was concerned about confusion with the datastructure (trie), but that alone wasn\u0027t worth a change. However, in light of this recent revelation from Salvatore, I\u0027m losing confidence in this name! Neutron has already suffered through a painful rename, I wouldn\u0027t want to bring on litigation from rugby assosiations...","commit_id":"52637bb25e030678370dbb0aefa8499fd47ce933"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"5954dfc39980e0d4490e0d67550cd02bdf17b272","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Number of attempts to find a valid segment candidate and allocate it"},{"line_number":24,"context_line":"DB_MAX_TRIES \u003d 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_ab1fc9b5","line":24,"updated":"2014-10-27 07:47:58.000000000","message":"this is really confusing. As you know a \"try\" is the preferred way of scoring points in a rugby match (http://en.wikipedia.org/wiki/Try).\n\nNow I understand that DB is a rugby player who can score at most 10 tries. This can lead the reader to think this code is for a rugby videogame.","commit_id":"52637bb25e030678370dbb0aefa8499fd47ce933"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7ba5a89e95f0495bf7b5359a74036c1958c3c8d8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Number of attempts to find a valid segment candidate and allocate it"},{"line_number":24,"context_line":"DB_MAX_TRIES \u003d 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_0078af8e","line":24,"in_reply_to":"9aa7fdbe_66619804","updated":"2014-10-27 10:38:22.000000000","message":"I share Akihiro proposal for consistency","commit_id":"52637bb25e030678370dbb0aefa8499fd47ce933"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"65c53cf5e9fd0fefe75afe49512941f9cc45d355","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# Number of attempts to find a valid segment candidate and allocate it"},{"line_number":24,"context_line":"DB_MAX_TRIES \u003d 10"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aa7fdbe_66619804","line":24,"in_reply_to":"9aa7fdbe_ab1fc9b5","updated":"2014-10-27 09:07:56.000000000","message":":-)\n\nApart from the joke, DB_MAX_ATTEMPTS looks more clear to me. The comment says \"number of attempts\".","commit_id":"52637bb25e030678370dbb0aefa8499fd47ce933"}]}