)]}'
{"neutron/tests/unit/ml2/db/test_ml2_db.py":[{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                               security_group_id\u003dsg_id))"},{"line_number":75,"context_line":"            self.ctx.session.add(sg_portbinding)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_add_network_segment_for_provider_network(self):"},{"line_number":78,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":79,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":80,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_61dcd819","line":77,"updated":"2014-10-29 13:17:23.000000000","message":"Shall I remove this test case?","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"382e39540673d932aac5134562291495d245e244","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_add_network_segment_is_dynamic_true(self):"},{"line_number":88,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_19380fd2","line":85,"updated":"2014-10-28 03:35:50.000000000","message":"While this at least exercises some code paths, we aren\u0027t really testing much by only checking that an info log was called. Isn\u0027t there something better we can do to make sure the segment type and ID made it to the place it was supposed to go?\n\nThe same applies to all of these tests that are only asserting that log_info was called.","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"0d442cdb8e02152c75493e88801e27088b900fb6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_add_network_segment_is_dynamic_true(self):"},{"line_number":88,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_1c38fdd1","line":85,"in_reply_to":"9aa7fdbe_19380fd2","updated":"2014-10-28 04:44:28.000000000","message":"Hi Kevin,\n\nThanks for the review, But I am not sure how I would do that?\nSince _add_network_segment is not returning anything. \nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/db.py#L55. \n\nNeed your help :)\n\nAt the same time if you look at test_get_network_segments() if have asserted all the expected and actual values.","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b561e72f1a6f456408b6b3ab8e7c30b234e1310d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_add_network_segment_is_dynamic_true(self):"},{"line_number":88,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_8e402508","line":85,"in_reply_to":"9aa7fdbe_1c38fdd1","updated":"2014-10-28 15:36:48.000000000","message":"Asserting that a log trace was called is just consequential that the code executed without errors. If someone removes/changes the trace the test breaks, even though the method itself continues to behave the way it\u0027s expected; that\u0027s not nice!\n\nI think what you want to do here is to ensure that the data stored in the db is as you expect it so in this case you should query it directly and check that  the resultset matches what you passed in to add_network_segment","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"4088607aab9178b04390e6f007db801b4e16fa5b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_add_network_segment_is_dynamic_true(self):"},{"line_number":88,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_ce794dc9","line":85,"in_reply_to":"9aa7fdbe_8e402508","updated":"2014-10-28 15:56:40.000000000","message":"Thanks Armando,\n\nI think we are doing the same in test_get_network_segments() so I feel we don\u0027t need to do it in test_add_network_segment.\n\n@Armando,\n\nDid you get a chance to review the entire code. It would be great if you could review it and share your comments :) .","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def test_add_network_segment_is_dynamic_true(self):"},{"line_number":88,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":89,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":90,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_81e1bcd2","line":87,"updated":"2014-10-29 13:17:23.000000000","message":"ditto","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                                       segment, is_dynamic\u003dTrue)"},{"line_number":96,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    def test_add_network_segment_for_multiprovider_network(self):"},{"line_number":99,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":100,"context_line":"        segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":101,"context_line":"                    api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_c1ebc4ae","line":98,"updated":"2014-10-29 13:17:23.000000000","message":"ditto","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                          segment, segment_index)"},{"line_number":111,"context_line":"                self.assertTrue(log_info.called)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_get_network_segments_for_provider_network(self):"},{"line_number":114,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":115,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":116,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_419b5472","line":113,"updated":"2014-10-29 13:17:23.000000000","message":"One thing I could propose is I will remove\n   \"def test_add_network_segment_for_provider_network(self) \" and test both add_network_segment() and get_network_segments() within this test case.\n\nAlso, I will rename def test_get_network_segments_for_provider_network(self): ---\u003e\n  def test_network_segments_for_provider_network(self):\n\n@Kevin, Armando:\n  What is your opinion ?","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3e63e2a4c5e409da2c602199dba37c43a836061d","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                                          segment, segment_index)"},{"line_number":111,"context_line":"                self.assertTrue(log_info.called)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def test_get_network_segments_for_provider_network(self):"},{"line_number":114,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":115,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":116,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8c0949_ccbaeee0","line":113,"in_reply_to":"9aa7fdbe_419b5472","updated":"2014-11-03 11:24:38.000000000","message":"Kindly, share your opinion :)","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":116,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"},{"line_number":117,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":118,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":119,"context_line":"        ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_a18160fd","line":118,"updated":"2014-10-29 13:17:23.000000000","message":"I will add it here:\n\n   with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":117,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":118,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":119,"context_line":"        ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"},{"line_number":122,"context_line":"                                                   network_id)"},{"line_number":123,"context_line":"        net_segment \u003d net_segments[0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_c1866413","line":120,"updated":"2014-10-29 13:17:23.000000000","message":"I will add it here: \n      self.assertTrue(log_info.called)","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":126,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":127,"context_line":"                             net_segment.get(element))"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def test_get_network_segments_filter_dynamic_none(self):"},{"line_number":130,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":131,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":132,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_c102e46e","line":129,"updated":"2014-10-29 13:17:23.000000000","message":"ditto","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"3cf453aae545b66d66f4eb83efcf6aa4573b851b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":144,"context_line":"                             net_segment.get(element))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def test_get_network_segments_for_multiprovider_network(self):"},{"line_number":147,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":148,"context_line":"        segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":149,"context_line":"                    api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aa7fdbe_e1f60890","line":146,"updated":"2014-10-29 13:17:23.000000000","message":"ditto","commit_id":"c80240436cb756e30fe9e506f0828170834b6efb"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7b1e36fc7f26af82196b1ee5f588bd0ae43bd4a6","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                 net_segment.get(element))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_get_segment_by_id_result_not_found(self):"},{"line_number":155,"context_line":"        segment_id \u003d uuidutils.generate_uuid()"},{"line_number":156,"context_line":"        net_segment \u003d ml2_db.get_segment_by_id(self.ctx.session, segment_id)"},{"line_number":157,"context_line":"        self.assertIsNone(net_segment)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_065f3e73","line":155,"updated":"2014-11-13 14:06:31.000000000","message":"i do not think that a segment id is a UUID. https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/models.py#L41","commit_id":"43732f0e6ec8ef1cffab8b6c0a19c34a5db65c4b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89801bc31865dcaaa4fb7f1adc8dba41fce15a14","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                                 net_segment.get(element))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_get_segment_by_id_result_not_found(self):"},{"line_number":155,"context_line":"        segment_id \u003d uuidutils.generate_uuid()"},{"line_number":156,"context_line":"        net_segment \u003d ml2_db.get_segment_by_id(self.ctx.session, segment_id)"},{"line_number":157,"context_line":"        self.assertIsNone(net_segment)"},{"line_number":158,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6c1e2165","line":155,"in_reply_to":"5a890539_065f3e73","updated":"2014-11-13 14:34:37.000000000","message":"Hi Gary,\n\nI respectfully disagree :)\n\n :param segment_id: UUID of the dynamic network segment.\n\n    def release_dynamic_segment(self, session, segment_id):\n        \"\"\"Delete a dynamic segment.\"\"\"\n        segment \u003d db.get_segment_by_id(session, segment_id)\n\nKindly, find the link below for reference:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/driver_api.py#L349","commit_id":"43732f0e6ec8ef1cffab8b6c0a19c34a5db65c4b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7b1e36fc7f26af82196b1ee5f588bd0ae43bd4a6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":209,"context_line":"        self._setup_neutron_portbinding(port_id_two, vif_type, host)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":212,"context_line":"            port_host \u003d ml2_db.get_port_binding_host(port_id)"},{"line_number":213,"context_line":"            self.assertIsNone(port_host)"},{"line_number":214,"context_line":"            self.assertTrue(log_error.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_06a49e55","line":211,"updated":"2014-11-13 14:06:31.000000000","message":"why do we need to test logging here?","commit_id":"43732f0e6ec8ef1cffab8b6c0a19c34a5db65c4b"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89801bc31865dcaaa4fb7f1adc8dba41fce15a14","unresolved":false,"context_lines":[{"line_number":208,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":209,"context_line":"        self._setup_neutron_portbinding(port_id_two, vif_type, host)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":212,"context_line":"            port_host \u003d ml2_db.get_port_binding_host(port_id)"},{"line_number":213,"context_line":"            self.assertIsNone(port_host)"},{"line_number":214,"context_line":"            self.assertTrue(log_error.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_8cb50d33","line":211,"in_reply_to":"5a890539_06a49e55","updated":"2014-11-13 14:34:37.000000000","message":"I feel it\u0027s good to cover log message also in UT\u0027s. By doing this we will be having full coverage for a method.","commit_id":"43732f0e6ec8ef1cffab8b6c0a19c34a5db65c4b"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"7b1e36fc7f26af82196b1ee5f588bd0ae43bd4a6","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        self._setup_neutron_port(network_id, port_id_one)"},{"line_number":239,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":242,"context_line":"            port \u003d ml2_db.get_port(self.ctx.session, port_id)"},{"line_number":243,"context_line":"            self.assertIsNone(port)"},{"line_number":244,"context_line":"            self.assertTrue(log_error.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_4685c6ab","line":241,"updated":"2014-11-13 14:06:31.000000000","message":"ditto","commit_id":"43732f0e6ec8ef1cffab8b6c0a19c34a5db65c4b"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"aba39fa90c63113ed320d33bfe193fccc67bb496","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.manager \u003d mock.patch.object(manager, \u0027NeutronManager\u0027).start()"},{"line_number":37,"context_line":"        self.plugin \u003d self.manager.get_plugin()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _setup_neutron_network(self, network_id):"},{"line_number":40,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":41,"context_line":"            self.ctx.session.add(models_v2.Network(id\u003dnetwork_id))"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_46f7788b","line":39,"updated":"2014-11-13 19:43:14.000000000","message":"any special reason why you preferred to add these helper methods instead of using the plugin ones? instead of calling self._setup_neutron_network one could simply do self.plugin.create_network. Just curious about the reason. Not sure if it\u0027s worth adding an helper method if we can use an already existing method","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89005926378109b0df830aed92de36f331bdb432","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        self.manager \u003d mock.patch.object(manager, \u0027NeutronManager\u0027).start()"},{"line_number":37,"context_line":"        self.plugin \u003d self.manager.get_plugin()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def _setup_neutron_network(self, network_id):"},{"line_number":40,"context_line":"        with self.ctx.session.begin(subtransactions\u003dTrue):"},{"line_number":41,"context_line":"            self.ctx.session.add(models_v2.Network(id\u003dnetwork_id))"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_fa1f076a","line":39,"in_reply_to":"5a890539_46f7788b","updated":"2014-11-14 09:15:29.000000000","message":"I think we shouldn\u0027t call create_network here. if we call create_network here itself then what we would test?\n\ncreate_network calls ml2_db.add_network_segment() internally.\n\nAnd, create_network UT\u0027s are already covered in test_ml2_plugin.py","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"aba39fa90c63113ed320d33bfe193fccc67bb496","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"},{"line_number":88,"context_line":"                                                   network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e656a4cd","line":85,"updated":"2014-11-13 19:43:14.000000000","message":"this assert doesn\u0027t add much to the test now that you are checking the results in the DB","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89005926378109b0df830aed92de36f331bdb432","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":83,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":84,"context_line":"            ml2_db.add_network_segment(self.ctx.session, network_id, segment)"},{"line_number":85,"context_line":"            self.assertTrue(log_info.called)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"},{"line_number":88,"context_line":"                                                   network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_da65eb1e","line":85,"in_reply_to":"5a890539_e656a4cd","updated":"2014-11-14 09:15:29.000000000","message":"I understand that, but it doesn\u0027t have any side-effect. And, its good to cover them in UT\u0027s.","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"aba39fa90c63113ed320d33bfe193fccc67bb496","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                             net_segment.get(element))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_network_segments_for_multiprovider_network(self):"},{"line_number":115,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":116,"context_line":"        segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":117,"context_line":"                    api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"},{"line_number":118,"context_line":"                    api.SEGMENTATION_ID: 1},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_e63f8485","line":115,"updated":"2014-11-13 19:43:14.000000000","message":"why don\u0027t you create an helper method that can be used by all the test methods? Something like (sorry for the weird indentation, don\u0027t know why but Gerrit formats my comment in the wrong way :/ ):\n\n\ndef _create_segments(self, segments, is_seg_dynamic\u003dFalse):\n    network_id \u003d \u0027foo-network-id\u0027\n    self._setup_neutron_network(network_id)\n    with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:\n         for segment_index, segment in enumerate(segments):\n\t\tml2_db.add_network_segment(self.ctx.session, network_id,\n\t\t\t                                         segment, segment_index,\n                                                                 is_dynamic\u003d is_seg_dynamic) \n\n    net_segments \u003d ml2_db.get_network_segments(self.ctx.session,\n\t\t\t                                                        network_id)\n    for segment_index, segment in enumerate(segments):\n        for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,\n\t\t\tapi.SEGMENTATION_ID]:\n\t    self.assertEqual(segment.get(element),\n\t\t\t              net_segments[segment_index][element])\n\nThis method would then be:\n\n\ndef test_network_segments_for_multiprovider_network(self):\n    segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,\n                          api.PHYSICAL_NETWORK: \u0027physnet1\u0027,\n\t\t\t  api.SEGMENTATION_ID: 1},\n\t\t\t  {api.NETWORK_TYPE: \u0027vlan\u0027,\n\t\t\t  api.PHYSICAL_NETWORK: \u0027physnet1\u0027, \n\t\t\t  api.SEGMENTATION_ID: 2}]\n    self._create_segments(segments)\n\n\nYou can refactor the other methods accordingly","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"89005926378109b0df830aed92de36f331bdb432","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                             net_segment.get(element))"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    def test_network_segments_for_multiprovider_network(self):"},{"line_number":115,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":116,"context_line":"        segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":117,"context_line":"                    api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"},{"line_number":118,"context_line":"                    api.SEGMENTATION_ID: 1},"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a890539_65437842","line":115,"in_reply_to":"5a890539_e63f8485","updated":"2014-11-14 09:15:29.000000000","message":"Sure, I will refactor it.","commit_id":"8ec8f4008efae76d1daa11234910480e32f5ddca"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"b8871ac587dfaa7f6b5bed16712f49bf8affaf75","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        net_segment \u003d self._add_and_get_network_segment(segment)[0]"},{"line_number":70,"context_line":"        for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":71,"context_line":"                        api.SEGMENTATION_ID]:"},{"line_number":72,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":73,"context_line":"                             net_segment.get(element))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_8da23849","line":70,"updated":"2014-11-14 18:06:21.000000000","message":"Thanks for adding the method _add_and_get_network_segment ,  now the code looks better but there\u0027s still some repetition see lines 69-73 and 86-92 etc. .  Why didn\u0027t you follow what I was suggesting in the previous patch? Can you help me understand the reason? In order to avoid the repetition and if you want to keep _add_and_get_network_segment  I guess you can create an helper method to take care of the assert, basically copy from line 111 to line 115 in the helper method and refactor accordingly. Anyway I think one method is better than having two.","commit_id":"d7871e21add574cd98941b62ca61bcc608af6968"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"e4710bf93588fc675dc5fe0961206ce2d516da4d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        net_segment \u003d self._add_and_get_network_segment(segment)[0]"},{"line_number":70,"context_line":"        for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":71,"context_line":"                        api.SEGMENTATION_ID]:"},{"line_number":72,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":73,"context_line":"                             net_segment.get(element))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_0ecce260","line":70,"in_reply_to":"5a890539_26b568cd","updated":"2014-11-20 11:21:28.000000000","message":"Done","commit_id":"d7871e21add574cd98941b62ca61bcc608af6968"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"60e4a0e90c76bd25c45c00c269a6523ca4bde126","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        net_segment \u003d self._add_and_get_network_segment(segment)[0]"},{"line_number":70,"context_line":"        for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":71,"context_line":"                        api.SEGMENTATION_ID]:"},{"line_number":72,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":73,"context_line":"                             net_segment.get(element))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_26b568cd","line":70,"in_reply_to":"5a890539_403e578d","updated":"2014-11-19 15:21:14.000000000","message":"Sorry, let me correct my suggestion. I tested it and this is working:\n\n    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):\n        network_id \u003d \u0027foo-network-id\u0027\n        self._setup_neutron_network(network_id)\n        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:\n            for segment in segments:\n                ml2_db.add_network_segment(self.ctx.session, network_id,\n                                   segment,\n                                   is_dynamic\u003dis_seg_dynamic)\n\n        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,\n                                                   network_id,\n                                                   filter_dynamic\u003dis_seg_dynamic)\n        for segment_index, segment in enumerate(segments):\n            for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,\n                            api.SEGMENTATION_ID]:\n                self.assertEqual(segment.get(element),\n                                 net_segments[segment_index][element])\n\n\nand can be called like this:\n\n    def test_network_segments_for_provider_network(self):\n        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,\n                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,\n                   api.SEGMENTATION_ID: 1}\n        self._create_segments([segment])\n\n    def test_network_segments_is_dynamic_true(self):\n        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,\n                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,\n                   api.SEGMENTATION_ID: 1}\n        self._create_segments([segment], is_seg_dynamic\u003dTrue)\n\n    def test_network_segments_for_multiprovider_network(self):\n        network_id \u003d \u0027foo-network-id\u0027\n        segments \u003d [{api.NETWORK_TYPE: \u0027vlan\u0027,\n                    api.PHYSICAL_NETWORK: \u0027physnet1\u0027,\n                    api.SEGMENTATION_ID: 1},\n                    {api.NETWORK_TYPE: \u0027vlan\u0027,\n                     api.PHYSICAL_NETWORK: \u0027physnet1\u0027,\n                     api.SEGMENTATION_ID: 2}]\n        self._create_segments(segments)","commit_id":"d7871e21add574cd98941b62ca61bcc608af6968"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"28d6cb63a1d654e525dcdecc7434e6dcd5439593","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"        net_segment \u003d self._add_and_get_network_segment(segment)[0]"},{"line_number":70,"context_line":"        for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":71,"context_line":"                        api.SEGMENTATION_ID]:"},{"line_number":72,"context_line":"            self.assertEqual(segment.get(element),"},{"line_number":73,"context_line":"                             net_segment.get(element))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a890539_403e578d","line":70,"in_reply_to":"5a890539_8da23849","updated":"2014-11-14 18:39:58.000000000","message":"What you suggested in previous patch-set will not work seamlessly for \n  1. test_network_segments_for_provider_network\n  2. test_network_segments_is_dynamic_true\n  3. test_network_segments_for_multiprovider_network\n\nFor provider network:\n   ml2_db.add_network_segment(self.ctx.session, network_id, segment)\n   ml2_db.get_network_segments(self.ctx.session, network_id)\n\nFor dynamic network:\n   ml2_db.add_network_segment(self.ctx.session, network_id, segment, is_dynamic\u003dTrue)\n   ml2_db.get_network_segments(self.ctx.session, network_id, None)\n\nFor multi provider network:\n    for segment_index, segment in enumerate(segments):\n         ml2_db.add_network_segment(self.ctx.session, network_id, segment, segment_index)\t\n     \n     ml2_db.get_network_segments(self.ctx.session,network_id)\n\nSo, we can\u0027t have common helper_method which will work for all three above.\n\nThat\u0027s the reason I have added def _add_and_get_network_segment(segment) which is used in many test_cases like:\n\n   def test_network_segments_for_provider_network(self):\n   def test_get_segment_by_id(self):\n   def test_delete_network_segment(self):\n\n\nAnd, regarding L69-73, L86-92 and L111-115.\n I don\u0027t see them as repetition we are asserting values for a given test case and for that also we can\u0027t have common helper_method.\n\nPlease tell me know if you need more clarification :)","commit_id":"d7871e21add574cd98941b62ca61bcc608af6968"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c4c92daa8dfc331c8ae202167c5af6a307fe79e3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment(self.ctx.session, network_id,"},{"line_number":61,"context_line":"                                   segment, is_dynamic\u003dis_seg_dynamic)"},{"line_number":62,"context_line":"                self.assertTrue(log_info.called)"},{"line_number":63,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"},{"line_number":64,"context_line":"                                   network_id, filter_dynamic\u003dis_seg_dynamic)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_648f4724","line":61,"updated":"2014-11-20 12:24:29.000000000","message":"nit: indentation.\nimo it\u0027s better to put all arguments on the new line:\n ml2_db.add_network_segment(\n     self.ctx.session, network_id, segment, is_dynamic\u003dis_seg_dynamic)\n\nsame on line 63","commit_id":"b4482e1a4344b0657a56de31280bd8a9553b6ee2"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"48f775066d047235b57e1b06f459dd662e647363","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment(self.ctx.session, network_id,"},{"line_number":61,"context_line":"                                   segment, is_dynamic\u003dis_seg_dynamic)"},{"line_number":62,"context_line":"                self.assertTrue(log_info.called)"},{"line_number":63,"context_line":"        net_segments \u003d ml2_db.get_network_segments(self.ctx.session,"},{"line_number":64,"context_line":"                                   network_id, filter_dynamic\u003dis_seg_dynamic)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_47188d75","line":61,"in_reply_to":"5a890539_648f4724","updated":"2014-11-20 12:35:11.000000000","message":"Done","commit_id":"b4482e1a4344b0657a56de31280bd8a9553b6ee2"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"c4c92daa8dfc331c8ae202167c5af6a307fe79e3","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        net_segment \u003d self._create_segments([segment])[0]"},{"line_number":118,"context_line":"        segment_uuid \u003d net_segment[api.ID]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertIsNone(ml2_db.delete_network_segment(self.ctx.session,"},{"line_number":121,"context_line":"                                                        segment_uuid))"},{"line_number":122,"context_line":"        # Get segment and verify its empty"},{"line_number":123,"context_line":"        net_segment \u003d ml2_db.get_segment_by_id(self.ctx.session, segment_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_24ad3f89","line":120,"updated":"2014-11-20 12:24:29.000000000","message":"Is there a point to check return value of this method?","commit_id":"b4482e1a4344b0657a56de31280bd8a9553b6ee2"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"48f775066d047235b57e1b06f459dd662e647363","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        net_segment \u003d self._create_segments([segment])[0]"},{"line_number":118,"context_line":"        segment_uuid \u003d net_segment[api.ID]"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        self.assertIsNone(ml2_db.delete_network_segment(self.ctx.session,"},{"line_number":121,"context_line":"                                                        segment_uuid))"},{"line_number":122,"context_line":"        # Get segment and verify its empty"},{"line_number":123,"context_line":"        net_segment \u003d ml2_db.get_segment_by_id(self.ctx.session, segment_uuid)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a890539_87027507","line":120,"in_reply_to":"5a890539_24ad3f89","updated":"2014-11-20 12:35:11.000000000","message":"Not required :)\n\nI will remove the self.assertIsNone().","commit_id":"b4482e1a4344b0657a56de31280bd8a9553b6ee2"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62a435da784a7ee359ba705e1981792da74b170c","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):"},{"line_number":56,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":57,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_cb49df61","line":57,"updated":"2015-01-01 06:59:07.000000000","message":"Please don\u0027t mock and then assert logging. This is the epitome of asserting implementation and not behavior. add_network_segment could easily remove its logging and no unit test should ever fail because of that.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"6f7e076ade82758afefb3c6d86b34da1e883d8ba","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):"},{"line_number":56,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":57,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_60062c23","line":57,"in_reply_to":"3a961159_4cb8a2c7","updated":"2015-01-05 09:10:29.000000000","message":"For sure asserting mocked logging doesn\u0027t increase code coverage itself, it\u0027s just a check. Running method with certain input increases code coverage, but you need to verify that somehow (either by mocking or by using real methods - whatever is simpler)\n\nlogger mock is just an indicator of certain code path. If it was used in several code paths, then we could not use it, but for this case it suits the need imo.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0531945f7e9a67f9353b3ed4b7d0471218f47963","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):"},{"line_number":56,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":57,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_4cb8a2c7","line":57,"in_reply_to":"3a961159_9137014d","updated":"2015-01-02 13:50:41.000000000","message":"Mocking and then asserting logging behavior doesn\u0027t increase your coverage.\n\nAlso, why would you want your tests to assert logging behavior?\n\nYou\u0027re testing that a certain DB method returns expected output, why would you care if it logs this or that?","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"4631bb961c204593498c52545f67428de35ce999","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):"},{"line_number":56,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":57,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_6bd38bd5","line":57,"in_reply_to":"3a961159_cb49df61","updated":"2015-01-01 10:09:31.000000000","message":"Done","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"8f42be7936fc94baaab3d9210721cad6c60d6266","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def _create_segments(self, segments, is_seg_dynamic\u003dFalse):"},{"line_number":56,"context_line":"        network_id \u003d \u0027foo-network-id\u0027"},{"line_number":57,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":58,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027info\u0027) as log_info:"},{"line_number":59,"context_line":"            for segment in segments:"},{"line_number":60,"context_line":"                ml2_db.add_network_segment("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_9137014d","line":57,"in_reply_to":"3a961159_cb49df61","updated":"2015-01-02 11:59:47.000000000","message":"For unit tests it makes sense to assert implementation.\nIt\u0027s white box testing, and for code coverage purposes it makes sense to use whatever helps to make sure that certain code path is checked.\n\nYes, the test will need to be modified in case the implementation changes - that\u0027s not just ok for unit tests, that\u0027s how they\u0027re supposed to behave.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62a435da784a7ee359ba705e1981792da74b170c","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        net_segments \u003d ml2_db.get_network_segments("},{"line_number":66,"context_line":"                           self.ctx.session, network_id,"},{"line_number":67,"context_line":"                           filter_dynamic\u003dis_seg_dynamic)"},{"line_number":68,"context_line":"        for segment_index, segment in enumerate(segments):"},{"line_number":69,"context_line":"            for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":70,"context_line":"                            api.SEGMENTATION_ID]:"},{"line_number":71,"context_line":"                self.assertEqual(segment.get(element),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_6b70eba4","line":68,"updated":"2015-01-01 06:59:07.000000000","message":"You could probably add a helper that compared two segments.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"4631bb961c204593498c52545f67428de35ce999","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        net_segments \u003d ml2_db.get_network_segments("},{"line_number":66,"context_line":"                           self.ctx.session, network_id,"},{"line_number":67,"context_line":"                           filter_dynamic\u003dis_seg_dynamic)"},{"line_number":68,"context_line":"        for segment_index, segment in enumerate(segments):"},{"line_number":69,"context_line":"            for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":70,"context_line":"                            api.SEGMENTATION_ID]:"},{"line_number":71,"context_line":"                self.assertEqual(segment.get(element),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_8bd997f6","line":68,"in_reply_to":"3a961159_6b70eba4","updated":"2015-01-01 10:09:31.000000000","message":"Done","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"5cca073cf9e07a95ef748d597fafb557d798822d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        net_segments \u003d ml2_db.get_network_segments("},{"line_number":66,"context_line":"                           self.ctx.session, network_id,"},{"line_number":67,"context_line":"                           filter_dynamic\u003dis_seg_dynamic)"},{"line_number":68,"context_line":"        for segment_index, segment in enumerate(segments):"},{"line_number":69,"context_line":"            for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":70,"context_line":"                            api.SEGMENTATION_ID]:"},{"line_number":71,"context_line":"                self.assertEqual(segment.get(element),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_ab7013db","line":68,"in_reply_to":"3a961159_8bd997f6","updated":"2015-01-01 10:42:20.000000000","message":"This didn\u0027t work out?","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c037cba2b32501b3081e4893021877fe7b4e6156","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        net_segments \u003d ml2_db.get_network_segments("},{"line_number":66,"context_line":"                           self.ctx.session, network_id,"},{"line_number":67,"context_line":"                           filter_dynamic\u003dis_seg_dynamic)"},{"line_number":68,"context_line":"        for segment_index, segment in enumerate(segments):"},{"line_number":69,"context_line":"            for element in [api.NETWORK_TYPE, api.PHYSICAL_NETWORK,"},{"line_number":70,"context_line":"                            api.SEGMENTATION_ID]:"},{"line_number":71,"context_line":"                self.assertEqual(segment.get(element),"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_eb285b99","line":68,"in_reply_to":"3a961159_ab7013db","updated":"2015-01-01 10:52:44.000000000","message":"Yeah, I have not done this because I couldn\u0027t able to figure out any significance :)\n\nwhy we should have too many helper methods if we could do it in a single helper method?\n\nIf you still insist me I won\u0027t mind to make a new helper method.\n\nPlease suggests.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62a435da784a7ee359ba705e1981792da74b170c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self._setup_neutron_portbinding(port_id_one, vif_type, host)"},{"line_number":160,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":161,"context_line":"        self._setup_neutron_portbinding(port_id_two, vif_type, host)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":164,"context_line":"            port_host \u003d ml2_db.get_port_binding_host(port_id)"},{"line_number":165,"context_line":"            self.assertIsNone(port_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_eb44db48","line":162,"updated":"2015-01-01 06:59:07.000000000","message":"Same comment about asserting logging.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"4631bb961c204593498c52545f67428de35ce999","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        self._setup_neutron_portbinding(port_id_one, vif_type, host)"},{"line_number":160,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":161,"context_line":"        self._setup_neutron_portbinding(port_id_two, vif_type, host)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":164,"context_line":"            port_host \u003d ml2_db.get_port_binding_host(port_id)"},{"line_number":165,"context_line":"            self.assertIsNone(port_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_abd493bb","line":162,"in_reply_to":"3a961159_eb44db48","updated":"2015-01-01 10:09:31.000000000","message":"Done","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62a435da784a7ee359ba705e1981792da74b170c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            self.assertTrue(log_error.called)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def test_get_port_binding_host_result_not_found(self):"},{"line_number":169,"context_line":"        port_id \u003d uuidutils.generate_uuid()"},{"line_number":170,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027debug\u0027) as log_debug:"},{"line_number":171,"context_line":"            port_host \u003d ml2_db.get_port_binding_host(port_id)"},{"line_number":172,"context_line":"            self.assertIsNone(port_host)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_0b73e7b4","line":169,"updated":"2015-01-01 06:59:07.000000000","message":"Ditto.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"62a435da784a7ee359ba705e1981792da74b170c","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        self._setup_neutron_network(network_id)"},{"line_number":190,"context_line":"        self._setup_neutron_port(network_id, port_id_one)"},{"line_number":191,"context_line":"        self._setup_neutron_port(network_id, port_id_two)"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        with mock.patch.object(ml2_db.LOG, \u0027error\u0027) as log_error:"},{"line_number":194,"context_line":"            port \u003d ml2_db.get_port(self.ctx.session, port_id)"},{"line_number":195,"context_line":"            self.assertIsNone(port)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a961159_2b76e3a3","line":192,"updated":"2015-01-01 06:59:07.000000000","message":"Ditto.","commit_id":"8f4430e40f7a8c70865fc36c2a5e0a320fa936bd"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ce854fa7aae1c102e0e4eef756df8936c5b39ab4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":94,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"},{"line_number":95,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        net_segment \u003d self._create_segments([segment])[0]"},{"line_number":98,"context_line":"        segment_uuid \u003d net_segment[api.ID]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_5da3f2b0","line":96,"updated":"2015-01-01 13:43:54.000000000","message":"I would remove the segment variable above and in-line into this call. Then you rename \u0027net_segment\u0027 to \u0027expected\u0027, and in line 100 rename \u0027net_segment\u0027 to \u0027result\u0027, then change lines 101 to 104 with:\n\nself.assertEqual(expected, result)\n\nThat should shave off 6 lines of code, and more importantly the element by element comparison, which is unneeded as you can just compare dicts.","commit_id":"0407e5b7526e19cf005c1c3266db5690e1c7f17a"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"c9ba326a05a272082b0300b7e3044d866eb102b3","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        segment \u003d {api.NETWORK_TYPE: \u0027vlan\u0027,"},{"line_number":94,"context_line":"                   api.PHYSICAL_NETWORK: \u0027physnet1\u0027,"},{"line_number":95,"context_line":"                   api.SEGMENTATION_ID: 1}"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        net_segment \u003d self._create_segments([segment])[0]"},{"line_number":98,"context_line":"        segment_uuid \u003d net_segment[api.ID]"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3a961159_001ca169","line":96,"in_reply_to":"3a961159_5da3f2b0","updated":"2015-01-01 17:57:53.000000000","message":"I have removed the element by element comparison from both the places L101-L102 and L65-66. \n\nAlso, I don\u0027t think we should remove the segment variable above and in-line into this call. \n\nSince helper method _create_segments is used for creating multi-segment network also. I agree in most of the places we are passing single segment but in one of the places we are creating multi-segment network. \n\nI feel the code should be simple to understand, I really don\u0027t want to make it complex just to shave off few lines.\n\nBut if there are any logical error or functionality issue I am open for the comments and suggestions.","commit_id":"0407e5b7526e19cf005c1c3266db5690e1c7f17a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4309eb38666a710deb6f0660d7d84d006e9e33ab","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self._setup_neutron_port(network_id, port_id)"},{"line_number":207,"context_line":"        self._setup_neutron_portbinding(port_id, vif_type, host)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        port, binding \u003d ml2_db.get_locked_port_and_binding(self.ctx.session,"},{"line_number":210,"context_line":"                                                           port_id)"},{"line_number":211,"context_line":"        self.assertEqual(port_id, port.id)"},{"line_number":212,"context_line":"        self.assertEqual(port_id, binding.port_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_23127562","line":209,"updated":"2015-01-04 22:07:07.000000000","message":"This call implies a lockmode in db, the test should unlock the db after L212","commit_id":"e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"4409ecf8e115d50aa0490628ebcc594f317e9f9d","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self._setup_neutron_port(network_id, port_id)"},{"line_number":207,"context_line":"        self._setup_neutron_portbinding(port_id, vif_type, host)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        port, binding \u003d ml2_db.get_locked_port_and_binding(self.ctx.session,"},{"line_number":210,"context_line":"                                                           port_id)"},{"line_number":211,"context_line":"        self.assertEqual(port_id, port.id)"},{"line_number":212,"context_line":"        self.assertEqual(port_id, binding.port_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_a0df34d5","line":209,"in_reply_to":"3a961159_23127562","updated":"2015-01-05 08:56:32.000000000","message":"Hi Cedric,\n\nDo we really need to do that?\n\nI feel every unit test is atomic in nature and will clear the tables after completion.\n\nclass SqlTestCase(base.BaseTestCase):\n\n    # flag to indicate that the models have been loaded\n    _TABLES_ESTABLISHED \u003d False\n\n    def setUp(self):\n        super(SqlTestCase, self).setUp()\n        # Register all data models\n        engine \u003d db_api.get_engine()\n        if not SqlTestCase._TABLES_ESTABLISHED:\n            model_base.BASEV2.metadata.create_all(engine)\n            SqlTestCase._TABLES_ESTABLISHED \u003d True\n\n        def clear_tables():\n            with engine.begin() as conn:\n                for table in reversed(\n                        model_base.BASEV2.metadata.sorted_tables):\n                    conn.execute(table.delete())\n\n        self.addCleanup(clear_tables)\n\nAlso, please share some reference code to unlock the DB.\n\nThanks in advance :)","commit_id":"e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"25cfdcac394cbe32cbc2e82fa1e518c9ef5c3207","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        self._setup_neutron_port(network_id, port_id)"},{"line_number":207,"context_line":"        self._setup_neutron_portbinding(port_id, vif_type, host)"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        port, binding \u003d ml2_db.get_locked_port_and_binding(self.ctx.session,"},{"line_number":210,"context_line":"                                                           port_id)"},{"line_number":211,"context_line":"        self.assertEqual(port_id, port.id)"},{"line_number":212,"context_line":"        self.assertEqual(port_id, binding.port_id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_630d5635","line":209,"in_reply_to":"3a961159_a0df34d5","updated":"2015-01-05 09:12:18.000000000","message":"That\u0027s correct argument. We don\u0027t need to care about \u0027locking cleanup\u0027 in each test.","commit_id":"e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4309eb38666a710deb6f0660d7d84d006e9e33ab","unresolved":false,"context_lines":[{"line_number":214,"context_line":"    def test_get_locked_port_and_binding_result_not_found(self):"},{"line_number":215,"context_line":"        port_id \u003d uuidutils.generate_uuid()"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        port, binding \u003d ml2_db.get_locked_port_and_binding(self.ctx.session,"},{"line_number":218,"context_line":"                                                           port_id)"},{"line_number":219,"context_line":"        self.assertIsNone(port)"},{"line_number":220,"context_line":"        self.assertIsNone(binding)"}],"source_content_type":"text/x-python","patch_set":9,"id":"3a961159_4315c147","line":217,"updated":"2015-01-04 22:07:07.000000000","message":"itto","commit_id":"e3383f9ac573863c49bf02ff65ea1f8ac1f2b5ee"}]}
